liz/rawTherapee
liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11,299 Commits 1 Branch 0 Tags
Commit Graph

30 Commits

Author SHA1 Message Date
Lawrence Lee
40678f67b0 Refactor tool name code 2021-12-11 21:21:54 -08:00
Flössie
64382928c1 Fix -Wodr in GCC LTO builds 
I've tested GCC 10 and 11, which exhibit the problem, and 8, which
doesn't.
 2021-07-05 13:06:33 +02:00
Lawrence Lee
c13cc02768 Un-highlight spot removal spots after deletion 2021-06-12 11:46:54 -07:00
Lawrence Lee
a2c5fd0f91 Fix drag position after alternate button press 
When a button is released and the edit state is not "dragging", reset
the drag delta to zero.

There was a problem with the spot removal spots being dragged. If a spot
is deleted while being dragged, dragging another spot will cause a jump.
 2021-06-12 11:37:38 -07:00
Flössie
9d052e267d Fix "unused variable" warning on release builds 2021-06-07 15:12:09 +02:00
Lawrence Lee
3c7e20b689 Refactor rtgui/spot.cc 2021-05-30 12:05:51 -07:00
Lawrence Lee
5f88cf240e Use enums for on-preview geometry 2021-05-30 11:51:49 -07:00
Lawrence Lee
3441854a19 Prevent making spot removal spots outside image 2021-05-23 22:01:01 -07:00
Lawrence Lee
051d69331f Fix control line and spot removal spot highlight 
Return the geometry color to normal (white) when exiting edit mode.
 2021-05-23 12:10:40 -07:00
Lawrence Lee
a5de8920fb Fix crash when resetting spot removal with drag 
Do not attempt to update non-existent spots immediately after resetting
the spot removal tool.
 2021-05-22 17:51:54 -07:00
Lawrence Lee
76706ac276 Leave spot removal widgets in good state on commit 
Set the correct geometry states if edit mode is toggled off while a spot
is being dragged.
 2021-05-22 17:35:22 -07:00
Lawrence Lee
21020f18c2 Fix spot removal link line visual bug 
The link was showing upon creating a new spot where the source and
target inner circles overlap.
 2021-05-17 22:14:51 -07:00
Thanatomanic
bb623d3a02 Fix instance of deprecated HBox 2021-05-13 12:34:27 +02:00
Lawrence Lee
f958074d9b Fix crash when deleting spot removal spot 
Deleting a spot while hovering over one of the circles for adjusting the
radius or feathering could trigger a crash. This is because immediately
after deleting a geometry object, EditSubscriber::getCursor is given an
object ID based on old data, causing the spot tool to attempt to get
information about the deleted geometry object.

This commit fixes the issue by returning the default cursor if the
active spot is -1. It works because the active spot is set to -1 when
deleting a spot, and there is no need to use a special cursor when there
is no active spot.

A better long-term solution would be updating the geometry data before
calling EditSubscriber::getCursor.
 2021-03-07 11:58:36 -08:00
Lawrence Lee
10b5f65b30 Fix spot removal enable/disable history message 
The history panel was showing "HISTORY_MSG_1049".
 2021-03-06 21:29:56 -08:00
Hombre57
8b60ea4794 Bugfix in SpotRemoval tool GUI (Batch Editor) + Partial Paste handling 2019-12-17 21:46:18 +01:00
Hombre
1935820884 Fix crash in Spot Removal tool when deleting a Spot entry 2019-09-14 23:03:19 +02:00
Hombre
82e7caa635 Spot removal : differentiating source/dest, betted cursor handling 
+ some code cleanup from floessie (see issue #2239)
 2019-09-01 02:08:48 +02:00
Hombre
0d19cd40a6 Adding documentation of Spot Removal in a tooltip 
(see issue #2239)
 2019-08-16 02:46:55 +02:00
Hombre
68e26fb648 More bugfix for issue #2239 2019-08-15 20:23:29 +02:00
Hombre
a46b85f226 Fix crash reported in #2239 + suppress warning from header files 
Crash reported here
https://github.com/Beep6581/RawTherapee/issues/2239#issuecomment-521585237
 2019-08-15 19:01:30 +02:00
Hombre
4d4f54cbc2 Spot-Removal (#2239): Adding recusivity and border handling 
Warning: Debug builds will be slow due to the amount of debug output (no problem for Release builds). Code cleanup will be done when after testing phase.
 2019-08-14 15:52:22 +02:00
Hombre
0db64d49a2 Introducing TweakOperator, for better tool's special mode handling 2019-08-06 02:04:48 +02:00
Hombre
7d310e688c Adding a new spot adjust editing mode in rtengine / preview window 2019-08-04 16:07:35 +02:00
Hombre
5b136d664d Merge branch 'dev' into spot-removal-tool 2019-03-25 22:35:17 +01:00
Hombre
e0c04955e3 Fix build crash (see #5232), but this branch is still not usable 2019-03-19 22:29:10 +01:00
Hombre
698492e21c Merge branch 'dev' into spot-removal-tool 2019-03-18 22:35:11 +01:00
Hombre57
81932ba2d6 Some files 'astylized' + slight cleanup 2017-08-22 00:15:56 +02:00
Hombre
3eeeb151ec Merge branch 'master' into spot-removal-tool 2016-12-28 01:57:46 +01:00
Hombre
56dafcf8c1 Spot Removal tool 
It is not working yet, but the GUI is (almost) done.
See issue #2239.
 2016-04-23 00:46:01 +02:00