7744 Commits

Author SHA1 Message Date
rom9
a3004bb2b8 Added SSE2 optimization in film negative thumbnail processing. 2019-06-27 22:03:59 +02:00
heckflosse
9ea964f5d9 camconst.json: some raw crops and white levels 2019-06-27 15:32:28 +02:00
heckflosse
a652752c2f raw crops for FUJIFILM X-T30 and Sony DSC-HX99 2019-06-26 22:12:38 +02:00
heckflosse
e76d98fb9f raw crop for Sony DSC-RX0M2 2019-06-26 20:49:07 +02:00
rom9
63a6e1b79c Changed GUI behaviour so that the first slider sets the reference exponent (green channel), and the other two sliders set the ratio of the red/blue exponent to the reference one. This should be more intuitive, and less confusing when clicking on the reset-to-default slider button. Now the first slider sets the general contrast, while the other two affect the color.
Lowered exponent slider max value from 6 to 4 (it was too large to be useful). New sliders are log-scale.
2019-06-26 02:00:34 +02:00
rom9
157d83d169 Partially reverting my last commit. When using large exponents, huge raw values could cause segfaults in ImProcFunctions:rgbProc (specifically in shadowToneCurve), and in Amaze demosaic.
Re-added the clipping check on raw values, but with a higher threshold. This way, raw clipping is less frequent in highlight areas (so those can be used as spots for exponents calculation), but the threshold is low enough to avoid the segfaults.
Not a very clean solution, need to find a better one...
2019-06-26 00:14:03 +02:00
rom9
22f6297a5b Removed clipping check for values above 65535 (reverts commit 9156572). It was just a defensive check to avoid hitting corner cases like this: 1e4f9ac , that is already fixed elsewhere.
The check is now causing problems with the dual-spot feature, because after clipping, the formula cannot be undone to get back the original raw values.
Since there are no known issues caused by raw values >65k, i'm removing the check until there will be a good reason to re-introduce it.
2019-06-24 21:48:06 +02:00
heckflosse
66c9cd6177 Don't scan for darframes/flatfields/cluts if folder is not set, #2238 2019-06-24 19:52:17 +02:00
heckflosse
d3fb58a19c clang error on badpixels.cc variable-sized object initializations, fixes #5358 2019-06-24 19:43:43 +02:00
Beep6581
981970b508
Merge pull request #5352 from Benitoite/patch-17
Notarization, Entitlements for macOS 10.15 Catalina
2019-06-24 13:51:15 +02:00
rom9
7040378dec Merge remote-tracking branch 'origin/dev' into filmnegative 2019-06-23 23:40:56 +02:00
rom9
2fde6e562a The "dual-spot" exponents calculation feature now honors the master (green) exponent set by the user, and adjusts red and blue based on the ratios between the new, "guessed" exponents.
This way, if the user has chosen a different master exponent than the default, using the feature just alters the color characteristic of the conversion, while keeping the same contrast level.
2019-06-23 22:21:24 +02:00
Ingo Weyrich
c6cdaf37eb
Merge pull request #5350 from Beep6581/badpixels-compunit
Move badpixel code to own compilation unit
2019-06-22 18:00:13 +02:00
rom9
8c6458daff Removed "lock channels" CheckButton, it wasn't very useful. Keeping the "(lead)" note on the green channel label, to give a hint that this slider controls the other two as well. 2019-06-21 20:51:50 +02:00
rom9
880a6e125e Added film negative processing in thumbnails, with correct white balance. Calculated channel averages to restore the same initial conditions as RawImageSource, where get_colorsCoeff is called with forceAutoWB = true. Code still needs refinement and cleanup. 2019-06-21 07:12:42 +02:00
Eric Jiang
789edc5bd3 Apply code-cleanup patch from @Floessie
See https://github.com/Beep6581/RawTherapee/pull/5325
2019-06-18 13:02:10 -07:00
rom9
03dc855fc7 Merged cleanup patch proposed by heckflosse, moves exponents negation to a single place. Now it's much easier to read. 2019-06-18 21:08:18 +02:00
rom9
c9c834dc63 Very honored to add myself to AUTHORS.txt, as suggested by heckflosse:
https://github.com/Beep6581/RawTherapee/pull/5349#pullrequestreview-247409279
2019-06-18 21:02:53 +02:00
rom9
7c0275ca1a Updated copyright notice in new source files 2019-06-18 13:52:58 +02:00
Flössie
ca387e0379 Use terser C++11 resets in ProcParams::setDefaults() 2019-06-18 09:22:45 +02:00
rom9
8de581ac39 Removed old debugging stuff from rtgui/filmnegative.cc 2019-06-17 21:46:50 +02:00
rom9
ad72e0f57b Merge branch 'Beep6581-filmnegative-cleanup' into filmnegative 2019-06-17 20:39:56 +02:00
Flössie
b687ca2643 Merge branch 'rom9-filmnegative' into filmnegative-cleanup 2019-06-17 08:57:14 +02:00
Flössie
20fdba77e8 Merge branch 'filmnegative' of https://github.com/rom9/RawTherapee into rom9-filmnegative 2019-06-17 08:07:32 +02:00
Flössie
54cc02eea9 Filmenegative core cleanup 2019-06-17 08:03:46 +02:00
Benitoite
daedba584a
Mac: simplify exec. loader interpreter 2019-06-16 03:08:35 -07:00
Benitoite
1d04026e9c
Mac: update an absolute path 2019-06-15 23:24:38 -07:00
Benitoite
f77eb3e4d2
Mac: Use codesigning sandbox, entitlements
Allows file system access in MacOS 10.15 *Catalina*
2019-06-15 23:14:52 -07:00
Benitoite
1ad9444259
Mac: cleanup executable loader script 2019-06-15 23:12:31 -07:00
Benitoite
8a8536702e
Mac: point to directories from a nested app 2019-06-15 23:11:29 -07:00
Benitoite
2ed66677b8
Mac: Property lists for nested app bundle 2019-06-15 23:09:00 -07:00
rom9
d01f78864c Locked red and blue exponents by default in the GUI, added CheckButton to unlock them. 2019-06-14 22:14:24 +02:00
Flössie
80f2b6a002 Replace raw arrays with std::array<> 2019-06-14 08:58:04 +02:00
Benitoite
1141f5fc65
Fix a typo in macosx_bundle.sh 2019-06-13 06:44:33 -07:00
Benitoite
7ee7be1833
macOS: Copy some libraries into the bundle
for libexpat and libz
2019-06-13 02:14:37 -07:00
Benitoite
6095f86467
macOS: Import notarization credentials
Imports apple notarization credentials (Apple ID and App-specific password) given to cmake as `-DNOTARY:STRING="-u woz@apple.com -p abcd-efgh-ijkl-mnop"`
2019-06-13 02:03:00 -07:00
Benitoite
0de04eea93
macOS: optionally notarize app and dmg
For macOS 10.15 *Catalina* compatibility: will notarize app and dmg with credentials provided thru cmake command.
2019-06-13 01:57:37 -07:00
Flössie
015cffc73a Peripheral cleanups and a fix
- Whitespace, braces, sorting
- Fixed missing filmnegative in `ProcParams::operator ==(ProcParams)`
2019-06-13 09:52:13 +02:00
rom9
c819cb63a2 Speed boost in the median vectors fill via loop unrolling 2019-06-12 22:11:34 +02:00
Morgan Hardwood
a686a94a62 Merge branch 'filmnegative' of https://github.com/rom9/RawTherapee into rom9-filmnegative 2019-06-12 09:19:49 +02:00
rom9
8d0755eddc Raised default master exponent from 1.0 to 2.0, to get a reasonable contrast right from the start. 2019-06-11 22:50:36 +02:00
rom9
5ddc4a3e0e Added missing checkbox for film negative feature in partial apply / partial paste dialogs. 2019-06-11 22:13:16 +02:00
rom9
8fa30d496d Now that medians are known *before* processing, moved multiplication step inside the same loop as exponentiation for further optimization. Patch kindly provided by @heckflosse ;-) 2019-06-11 21:02:16 +02:00
rom9
2bbf8bd864 Changed events action from ALL to FIRST , this way the histogram is updated after enabling/disabling or moving the adjusters. 2019-06-11 20:26:13 +02:00
rom9
e1c9197ed5 Moved median calculation block before exponentiation. This way findMinMaxPercentile() can be used again because it works on the original raw file values (which are in a much more reasonable range). Patch kindly provided by @heckflosse ;-) 2019-06-11 20:08:46 +02:00
rom9
223ae8abce Bugfix: exponent adjusters were not following the master (green) slider after exponents auto-calc via dual spot picking; updated redRatio/blueRatio after calculation. 2019-06-11 00:19:18 +02:00
heckflosse
156f3009d5 badpixels code: further cleanups 2019-06-10 22:15:16 +02:00
rom9
b95bdb1aea Linked red and blue exponent adjuster to the green adjuster, in order to maintain the ratio between exponents if the user moves the green adjuster (master).
Switched back to vector sort for median calculations: the results of the histogram search function diverge more and more from the simple median calculation as the exponents increase.
At 2.0 the test picture is already impossible to WB as the multipliers are too far off (2.78226e+08 histo vs 9.7927e+11 sort), and the normal WB sliders can't compensate for those huge factors.
2019-06-10 22:05:54 +02:00
heckflosse
fe16bf7917 Move badpixel code to own compilation unit 2019-06-10 16:40:44 +02:00
rom9
91565728e5 Clamped output values to a max of 65535.f after applying multipliers, to avoid trouble further down the processing pipeline. 2019-06-09 19:25:15 +02:00