28 Commits

Author SHA1 Message Date
Stephen Shkardoon
23f2a2fc9f Use _WIN32 instead of WIN32 to detect Windows
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here.
http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
2023-08-13 17:09:49 +12:00
Lawrence Lee
a626bdae3e
Fix external editor on macOS
Avoid using Gio::AppInfo.
2023-07-31 22:57:57 -07:00
Lawrence Lee
19f12f3182
Allow native commands as external editors
If an editor is marked as a native command, it is launched using the
older method (native for Windows or Glib otherwise). Non-native commands
are launched with Gio. When reading preferences containing the old style
external editor settings, all commands are marked as native to avoid
breaking them.

Fix bug where the send to editor button shows the wrong editor. The bug
happens when the other editor option is selected while the user edits
the external editors in preferences. When saved, the button shows the
first option is selected instead of the other editor option (the last
entry).
2023-04-08 18:16:23 -07:00
Lawrence Lee
5468e74e57
Fall back to custom external editor launcher 2023-01-08 17:20:42 -08:00
Lawrence Lee
c4a8554db3 Catch exceptions when launching external editor
Catch all Glib::Errors and print the error code and message to stderr.
2021-07-11 22:13:27 -07:00
Lawrence Lee
72fe8d6049 Merge dev into multi-external-editor 2021-06-28 22:03:14 -07:00
Desmis
eb8f121709
Add ability to export to an external editor within the same folder as the original file - issue 6195 (#6232)
* import and change the art code -thanks to Alberto

* Possible fixed for white space in folder

* Added verbose when white-space

* Replace WS only if windows and Gimp

* Fixed Windows and Gimp bug for external editor - thanks to Lawrence37

* Fix LGTM alert for reused variable name

Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
2021-05-13 12:41:22 +02:00
Lawrence Lee
349ceb9336 Add function for opening images with Gio::AppInfo 2021-04-12 21:53:04 -07:00
Ingo Weyrich
04b08741ee Further cleanups 2019-11-27 18:55:20 +01:00
Ingo Weyrich
79431ffa1d Some changes suggested by @Floessie 2019-11-26 19:42:48 +01:00
Ingo Weyrich
2a4891827d Some cleanups 2019-11-26 15:25:11 +01:00
Ingo Weyrich
6935faa258 Further cleanup of include dependencies 2019-10-30 22:12:06 +01:00
Ingo Weyrich
068847eb5a Further cleanup of include dependencies 2019-10-29 21:06:27 +01:00
scx
ca42b7b726 Fix launch of custom editor
Fixes Beep6581/RawTherapee#5472
2019-09-26 04:21:28 +02:00
Flössie
5b72cc0dd3 Quote parameters correctly for Linux when spawning (#5463) 2019-09-24 09:59:31 +02:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
Morgan Hardwood
408fc858e1 Support opening filenames with spaces in external editor in Windows, fixes #3883 2017-05-25 12:02:11 +02:00
heckflosse
6171db443f Fix warning in extprog.cc 2017-04-01 20:16:01 +02:00
Morgan Hardwood
7a8cd68f30 External editor polished and implements ShellExecute, closes #3522 2017-01-18 14:17:55 +01:00
Flössie
0731975ff0 Apply modernize-use-nullptr
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
heckflosse
566d4c9822 Cppcheck: Fixed most issued in rtgui/* 2016-10-04 23:28:19 +02:00
Morgan Hardwood
0608ad8f49 Simplified OS X GIMP and Photoshop calling code. 2016-07-15 01:16:12 +02:00
Adam Reichold
1297f4b2ec Move the UTF-8 string conversion helper to their respective places of use. 2016-02-21 10:20:21 +01:00
Adam Reichold
e853629854 Move the external command helper into the external program store singleton. 2016-02-21 10:12:56 +01:00
Adam Reichold
9ec0557edf Simplify the DCLP singleton instances found by searching for methods named 'getInstance'. 2015-11-28 14:53:27 +01:00
DrSlony
0e0cfb9b25 Formatted all .cc and .h code in rtengine, rtexif and rtgui using astyle 2015-08-11 11:55:03 +02:00
DrSlony
effb46c3e1 Line endings 2015-08-11 11:53:44 +02:00
torger
d5ca351c20 Issue 2134: removed obsolete raw highlight preservation setting from GUI (still left in procparams for backwards compatilibility) 2015-07-10 12:00:36 +02:00