12224 Commits

Author SHA1 Message Date
Thanatomanic
d52e032af8
Merge pull request #6305 from 10110111/dev
Fix size of TIFFTAG_EXIFIFD as passed to TIFFSetField
2021-07-22 07:04:46 +02:00
Ruslan Kabatsayev
9988fa1fdc Fix size of TIFFTAG_EXIFIFD as passed to TIFFSetField
Starting with libtiff 4.0.0, TIFFTAG_EXIFIFD has size of 64 bits, so it
must be set as a 64-bit value. Otherwise, since TIFFSetField is a
variadic function, there's no conversion, and the function reads garbage
into the higher dword.

This patch implements the fix and thus closes #5141.
2021-07-15 12:43:33 +03:00
Lawrence Lee
c4a8554db3 Catch exceptions when launching external editor
Catch all Glib::Errors and print the error code and message to stderr.
2021-07-11 22:13:27 -07:00
Lawrence Lee
02e3e01294 Use correct GIMP and Photoshop icons for Windows
Icon names in Windows are typically the executable path followed by the
string ",0".
2021-07-11 21:45:39 -07:00
Lawrence Lee
c625975453 Surround Windows commands in quotes
When external editors are launched in Windows OS, the command is
surrounded by quotes. This commit fixes the translation of commands for
use by the multiple custom external editors feature so that the
translated commands are also surrounded by quotes.
2021-07-11 21:38:52 -07:00
Lawrence Lee
5a49ea7b8c Get locallab spot name from one source
Fixes #6298.
2021-07-10 09:52:18 -07:00
Lawrence Lee
d7f9e1f51c Add history message for LA delta E C-H balance 2021-07-05 15:25:42 -07:00
Lawrence Lee
4044f67c0f Align External Editor > Output directory to top
Prevents the frame from expanding vertically.
2021-07-05 11:01:51 -07:00
Flössie
64382928c1 Fix -Wodr in GCC LTO builds
I've tested GCC 10 and 11, which exhibit the problem, and 8, which
doesn't.
2021-07-05 13:06:33 +02:00
Desmis
33ea50e2dd Abstrcat profile - fixed crash when BxBy aligned with RxRY GxGy 2021-07-04 14:27:44 +02:00
Desmis
7d8c876fd3 Abstract profile fixed crash when by=0.5 and all sliders to minimum 2021-07-04 13:17:08 +02:00
Flössie
b6449bfd5f Escape HTML chars in camera/lens name in quick info box (fixes #6294) 2021-06-30 09:18:06 +02:00
Lawrence Lee
72fe8d6049 Merge dev into multi-external-editor 2021-06-28 22:03:14 -07:00
Ingo Weyrich
4ab54c9fda Crash when moving crop window using SHIFT+Mouse, fixes #6290 2021-06-24 12:01:18 +02:00
Desmis
3cf3562505 LA small change GUI vibrance 2021-06-23 13:49:53 +02:00
Thanatomanic
4d17114126
Remove errant comma. Should fix #6289 2021-06-22 05:35:31 +02:00
Pandagrapher
491b57bee7
Improves RT window position management, fixes #6233 (#6239)
* Improves RT window events detection and RT window position computation

* Fixes some limitations in specific cases for Windows and MacOS

* Fixes RT window not restoring saved position at startup

- When maximized at startup, RT window position wasn't restored from
options file. So when unmaximazing RT, position was set to up left
corner instead of restored one
- Other fix: Removed some uses of deprecated Gtk functions

* Improves RT window management for independant edit window mode

Other fixes:
- Monitor ID wasn't correctly computed
- Removes some other deprecated functions uses
- Removes debug printf

* Fixes editor window aspects not restored in MEOW mode on Linux

Other fixes:
- Removes some Gtk warnings when adding a new editor panel in MEOW mode
- Adds robustness to avoid RT windows outside screen at startup loading
corrupted options file with negative position values

* Fixes incorrect max position saturation in dual screen configurations
2021-06-21 21:22:14 +02:00
Thanatomanic
7e36240f3a Fix the incorrect rendering of Leica M8 DNGs by removing white level in camconst 2021-06-21 08:02:42 +02:00
Desmis
31e178a4dd Change loop limit for cp.mulC ipwavlet.cc 2021-06-19 18:36:20 +02:00
Desmis
a6a8ee0e40 Others fix bad behavior Dynamic range and exposure 2021-06-19 10:36:30 +02:00
Desmis
b35e0d8269 Fixed bad behavior GUI in inverse Dynamic Range 2021-06-18 08:45:29 +02:00
Thanatomanic
c937e09e63 Fix raw crop for Canon EOS R5 2021-06-16 19:26:30 +02:00
Lawrence37
166538dbcb
Merge pull request #6278 from Beep6581/preview-widget-fixes
More preview widget fixes
2021-06-13 11:49:47 -07:00
Thanatomanic
869ac54242
Minor update to the parametric curve fix 2021-06-12 21:11:45 +02:00
Jonathan Bieler
3248e6b003
Reduce artifacts in parametric curve calculation (#6219) 2021-06-12 21:07:44 +02:00
Lawrence Lee
c13cc02768 Un-highlight spot removal spots after deletion 2021-06-12 11:46:54 -07:00
Lawrence Lee
a2c5fd0f91 Fix drag position after alternate button press
When a button is released and the edit state is not "dragging", reset
the drag delta to zero.

There was a problem with the spot removal spots being dragged. If a spot
is deleted while being dragged, dragging another spot will cause a jump.
2021-06-12 11:37:38 -07:00
Desmis
d02ed52e00
Local adjustments - improve exposure - issue 6274 (#6277)
* Various change to improve LA exposure

* Removed pow_Fr - clean code

* Remove unused code
2021-06-08 07:38:47 +02:00
Flössie
9d052e267d Fix "unused variable" warning on release builds 2021-06-07 15:12:09 +02:00
Bezierr
d86888e93f
Add resizing options "long edge" and "short edge" (#6263)
Introduces "long edge" and "short edge" options to resize an image. The GUI is made such that the relevant spinboxes only appear for the selected option. Unrelated values (e.g. for box-mode) are not updated.
2021-06-05 07:37:09 +02:00
Lawrence37
38ff2b5695
Merge pull request #6268 from Beep6581/perspective-ux
Perspective tool: Improve control lines user experience
2021-06-03 21:37:30 -07:00
Morgan Hardwood
3f58095b60 Updated generatePngIcons
The script is now compatible with Inkscape 1.0
2021-06-04 01:36:06 +02:00
rom9
73c505cf44 Merge remote-tracking branch 'upstream/dev' into dev 2021-06-03 20:16:58 +02:00
rom9
726f1c1f26 FilmNeg tool: used a single luminance reference when sampling white balance spot several times in sequence, to avoid luminance drift.
Fixes #6257
2021-06-03 19:57:28 +02:00
Lawrence Lee
f17eb2b504 Merge branch 'dev' into perspective-ux 2021-05-31 11:53:50 -07:00
Lawrence37
2e6e52f335
Merge pull request #6253 from Beep6581/preview-widget-fixes
On-preview widget fixes
2021-05-31 11:30:00 -07:00
Lawrence37
22f5a90cb1
Merge pull request #6222 from Beep6581/inspector-window-fixes
Inspector window fixes
2021-05-31 11:27:26 -07:00
Lawrence Lee
e7e6dd1cb5 Clean up rtgui perspective.* and controllines.*
Change size_t to std::size_t, remove void from function parameters, use
constants to represent the minimum required number of control lines, and
change const auto & to const auto.
2021-05-31 11:20:01 -07:00
Lawrence Lee
2c1e6a8ca1 Make control lines buttons react to line counts
Set the "apply" and "delete all" button sensitivity based on the number
of control lines. Add extra tooltip text to the apply button when
editing and there is not enough lines. The text explains there must be
enough vertical or horizontal control lines.
2021-05-30 18:02:29 -07:00
Lawrence Lee
3c7e20b689 Refactor rtgui/spot.cc 2021-05-30 12:05:51 -07:00
Lawrence Lee
5f88cf240e Use enums for on-preview geometry 2021-05-30 11:51:49 -07:00
Desmis
ef49d9eefd Disable masks when tool is disable 2021-05-30 07:53:19 +02:00
Desmis
c01166441c
Wavelet levels - and denoise - crash in some cases - issue 6264 (#6265)
* Change order levwav for denoise

* Intialize to zero multipliers contrast if not used

* Forgotten commit

* Clean code
2021-05-29 11:39:06 +02:00
Desmis
6e68cab5d9 Change range primaries ICC profile creator 2021-05-25 09:05:04 +02:00
Thanatomanic
6189a0e816 Prevent crash when opening Canon RP files with different crop factor. Fixes #6255 2021-05-24 08:00:09 +02:00
Lawrence Lee
3441854a19 Prevent making spot removal spots outside image 2021-05-23 22:01:01 -07:00
Lawrence Lee
56e634da81 Improve control lines dragging behavior
Fix control line not updating when dragging and allow dragging when
starting with the mouse cursor outside the preview image area.
2021-05-23 21:45:23 -07:00
Lawrence Lee
051d69331f Fix control line and spot removal spot highlight
Return the geometry color to normal (white) when exiting edit mode.
2021-05-23 12:10:40 -07:00
Lawrence Lee
4bc69dc30c Leave gradient widget in good state on commit
Stop highlighting the hovered or dragged geometry when disabling the
widget.
2021-05-23 12:00:30 -07:00
Ingo Weyrich
2f2720b763 Perspective tool: Strange amplification interaction with Local Adjustments, fixes #6252 2021-05-23 14:37:26 +02:00