12224 Commits

Author SHA1 Message Date
Richard E Barber
d6f102100b
Rename findATOMIC.cmake to FindATOMIC.cmake 2023-08-28 10:06:59 -07:00
Richard E Barber
7a5931135e
handle libatomic in cmake module
cmake/modules/findATOMIC.cmake detects libatomic flags. see #6821
2023-08-28 09:43:09 -07:00
Richard E Barber
ea33323d18
Call findATOMIC.cmake
libatomic is required in some builds. see #6821
2023-08-28 09:37:08 -07:00
Richard E Barber
f0b282a695
Create findATOMIC.cmake
Provided by @Floessie  https://github.com/Beep6581/RawTherapee/issues/6821#issuecomment-1678626624
2023-08-28 09:32:43 -07:00
Pandagrapher
d8c0b521ab Modify icons color
- Update icon from color "2a7fff" to "cccccc"
- Update .svg files with last Inkscape version
2023-08-28 17:10:23 +02:00
Lawrence Lee
e6a2654241
Show "unchanged" in batch profiled lens correction 2023-08-27 16:32:30 -07:00
Pandagrapher
e32ad15fe5 Review of rtdata files tree for icons/images 2023-08-27 18:35:13 +02:00
Pandagrapher
b57d1026a3 Merge with 'Beep6581/dev' 2023-08-24 13:48:07 +02:00
Pandagrapher
ce5f77ffc2 Removes debug printf 2023-08-23 13:48:39 +02:00
Pandagrapher
bf988ad274 Updates font management for hidpi
Improvements:
- Cleanup of default options files to use OS font by default
- Comments updates
- Simplify font size management as Pango/Gtk directly manage pt/px conversions

Bug fix:
- If Preference panel is closed by "cancel", font size was not reinitialized to previously saved one
- Font size was specified in "RawTherapee.css" theme and so user choice could be ignored
2023-08-23 13:43:07 +02:00
Dániel Battyányi
75541d6281
Changes to get the full spot width where needed 2023-08-20 13:59:42 +02:00
Dániel Battyányi
6b6200314f
Member functions changed to const
The following member functions and methods of SpotPicker changed to const:
- get_active()
- get_spot_half_width()
- selecterSetup()
- spotButtonTemplate().
2023-08-20 13:38:24 +02:00
Dániel Battyányi
af22f4195d
Removed empty destructor 2023-08-20 13:29:49 +02:00
Battyányi Dániel
6715e89696
Merge branch 'dev' into film_negative_pick_size 2023-08-19 19:44:29 +02:00
Lawrence37
a56c11570f
Merge pull request #6814 from Lawrence37/multi-editor-tabs-external-editor-bugfix
External editor button: synchronize in multiple editors layout
2023-08-18 21:03:18 -07:00
Dániel Battyányi
3d5810f088
Applied requested changes from review comments 2023-08-19 00:17:10 +02:00
Pandagrapher
58b7d41694 Cleanup of theme selection
For hidpi support, Gtk min version has been increased to 3.24.3. Theme logics based on Gtk version is so now useless
2023-08-16 19:07:39 +02:00
Lawrence37
ac48cc55d8
Better use of cache with inpaint opposed highight reconstruction (#6822)
* Speed up preview when inpaint opposed enabled

Only reprocess from raw if the white balance is changed. Otherwise, a
cache from later in the pipeline can be used.

* Remove unused code

* Fix refresh map bit positions

* Make WB & inpaint opposed refresh less brittle

Co-authored-by: Hombre57 <natureh.510@gmail.com>

---------

Co-authored-by: Hombre57 <natureh.510@gmail.com>
2023-08-15 07:52:38 -07:00
Stephen Shkardoon
23f2a2fc9f Use _WIN32 instead of WIN32 to detect Windows
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here.
http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
2023-08-13 17:09:49 +12:00
Lawrence37
9ae8c79c3a
Merge pull request #6755 from Lawrence37/lensfun-db-preferences
Edit Lensfun database directory from preferences
2023-08-12 17:43:50 -07:00
Jean-Christophe
e10ec281f1
Merge pull request #6820 from Beep6581/treeview-editable-cells
Fix for Treeview's editable entries incorrectly displayed
2023-08-13 01:37:49 +02:00
Hombre57
83263a3504 Fix for Treeview's editable entries incorrectly displayed 2023-08-13 01:01:18 +02:00
Lawrence37
75741eeabd
Merge pull request #5889 from Beep6581/metadata-exiv2
Adopt Exiv2 for metadata handling
2023-08-12 15:58:35 -07:00
Lawrence Lee
db4bfd8695
Add tooltips for LCP & Lensfun dir in preferences 2023-08-12 15:39:59 -07:00
Lawrence Lee
1f7d2d4ebc
Remove metadata-exiv2 from pre-dev publishing 2023-08-12 15:10:44 -07:00
Lawrence Lee
7eb7fb210f
Merge branch 'dev' into metadata-exiv2 2023-08-12 15:08:42 -07:00
Pandagrapher
bb258e4024 Delete now obsolete "pseudo-hidpi" preference 2023-08-12 18:30:03 +02:00
Pandagrapher
5b2dc59fbf Fix incorrect icon names
- Some icon names still had file extension indicated in their names
- This commit also enable icon name debug messages on console
2023-08-12 18:20:27 +02:00
Pandagrapher
d0743ef359 Merge with 'Beep6581/dev' 2023-08-12 18:03:41 +02:00
Lawrence37
bd94fbd6b6
Merge pull request #6808 from Lawrence37/places-ux
Show favorite places at the top of the list
2023-08-08 19:17:29 -07:00
Beep6581
aa4af96296
Merge pull request #6816 from Benitoite/dev-1
Mac: change -cli ad hoc signature to certified
2023-08-08 23:43:44 +02:00
Richard E Barber
12e60dd6c3
Mac: fix macos_bundle output formatting
Updates message formatting in the bundle script to escaped formatting, eliminating output terminal errors.
2023-08-07 07:06:51 -07:00
U-PCSPECIALIST01\jdesm
269e426cc6 Another change to blendmask 2023-08-07 08:48:08 +02:00
Richard E Barber
6720fa90e7
Mac: change -cli ad hoc signature to certified
*Ventura* no longer supports a distribution ad hoc signatory.  Changes codesign command for the -cli to use developer certificate.
2023-08-07 12:53:33 +07:00
U-PCSPECIALIST01\jdesm
8d437fec38 Change range blmask in iplocallab - thanks to hombre 2023-08-07 07:06:55 +02:00
Lawrence Lee
548907da34
Fix external editor button updates
Make sure the pop-up button is updated in both multiple editors modes.
2023-08-06 16:44:54 -07:00
Lawrence37
0052f08e94
Merge pull request #6794 from Lawrence37/auto-dcp-locale-fix
Fix for Auto-matched camera profile detection when using the English (US) language
2023-08-06 14:52:08 -07:00
Lawrence37
ec24613f3b
Merge pull request #6778 from Lawrence37/eos-7d-markii-raw-crop
Improved raw crop for Canon EOS 7D Mark II
2023-08-06 14:48:35 -07:00
Lawrence37
a596de2f44
Merge pull request #6789 from Lawrence37/lang-names
Language names
2023-08-06 14:47:37 -07:00
Lawrence37
ccf8f5a66c
Correct the Czech language name 2023-08-06 14:43:58 -07:00
Lawrence37
7e0f0b6636
Merge pull request #6807 from Lawrence37/ilce-7rm2-pdaf-pattern
Fix PDAF lines pattern for Sony ILCE-7RM2
2023-08-06 12:30:10 -07:00
Lawrence Lee
4faea6df7b
Merge branch 'dev' into eos-7d-markii-raw-crop 2023-08-06 11:58:30 -07:00
Lawrence37
b7816ff882
Merge pull request #6809 from Lawrence37/external-editor-macos-fix
Fix external editor on macOS
2023-08-06 11:54:52 -07:00
Lawrence Lee
c5a0067eee
Merge branch 'dev' into metadata-exiv2 2023-08-06 10:25:49 -07:00
Desmis
8d0333120e
Research and development - WB auto -temperature correlation - tests - finding the optimum settings (#6643)
* Change estimchrom estim hue final

* Itcw observer checkbox

* 8 spectral colors

* 11 spectral colors

* 6 spectral colors

* Small change to correction green

* Fixed various bad behavior - settings itcwb_deltaspec

* 4 spectral colors green

* 3 green spectral colors

* 3 spectral colors green

* 5 spectral colors red green

* 3 spectral colors red green

* 3 spectral colrs green red

* Chnage slider choice deltaE - to size color patch

* display more info in console

* Display more info in console - comment code

* Clean - comment code

* 8 spectral colors green red

* 8 spectral colors blue

* 8 spectral colors blue

* 3 spectral colors

* 6 spectral colors

* 4 spectal colors

* 2 spectral colors

* Eliminate high Y - increse temp iteration - recenter selection inside patch

* compatibility 5.9

* Modify dislay and place selected dats in patch

* Dispaly in console hue chroma image selection

* First optimization

* optimization code - clean unused variables

* Remove sorted in chroma order - some others changes

* 5.9 compatibility

* Clean and optimize code

* Clean code - more display info in console

* More info in console - set itcwb_minsize in option

* Display patch chroma in GUI

* Change some default settings

* Minsize patch GUI

* Display GUI patch size

* Chroma patch variations

* Display in GUI min and max dats found in patch

* Some adjustments

* Remove too low datas in patch

* Various improvment - ponderate

* Clean code colortemp comment spectral datas

* Comment code - correc gren

* Comment and refine code

* Fixed bug in improcoordinator

* fixes a malfunction of AWB bias in improcoordinator

* Various improvments - clean code

* 2 improvments green and find patch

* Allows parametrind ponder and Ypurple in options

* Update autowb - filter on magenta purple

* Clean and optimize code

* Read colors in GUI

* Denoise median 5x5 image datas before Itcwb

* Change to GUI

* Replace median5x5 by 2 median3x3 - clean GUI code

* Work around to recalculate wbauto

* Remove work around - change params->wb related change

* Disabled low_sampling 5.9

* First try for compatibility Low sampling 5.9

* Re-enable WB autogrey

* Change reference image to autogrey if camera settings probably out

* Clean code aand adjust settings camera out

* Format astylert rawimagesource.cc - various small adjustments

* Small correction

* Small green correction

* Change default settings - correction to autowb bias in improccoordinator

* Save provisory work

* Save provisory work 2

* Try to find good tempitc with iterate when temptitc very different 5000K

* Change 2 default settings

* Work around awb temp bias

* Limit work around bias - small other changes

* 3 spectral colors deep blue

* 4 spectral color deep blue

* 4 color spectral yellow

* 5 spectral colors neutral red-magenta

* 5 spectral color neutral red magenta

* Change threshold tempitc

* 5.9 compatibility

* Work around bad claculation Planck's formula

* Fixed bad behavior when using blackbody spectal

* 6 spectral color - checkbutton remove 2 passes

* Fixed various bugs

* Format rawimagesource.cc

* Various improvment before to find the good selection

* First new optimization (perhaps?)

* Display GUI patc deltaE

* Various optimzation and tooltip

* Default observer 2°- Simplify GUI - improve display GUI - remove too low numbers datas

* 4 spectral colors - change 2 settings

* Change calculation threshold 2 passes

* 6 spectral colors magenta

* 13 spectral colors

* Improvment GUI display

* remove checkbutton no_purple

* 2 spectral colors - remove in GUI low sampling 5.9

* Change default setting display in console

* Change behavior when temp near stdA

* 4 spectral colors - settings Itcwb_tempstdA

* Gamut control on image histogram

* Clean code and format rawimagesource.cc

* Comment and format colortemp.cc

* Remove unused fileds from GUI - change tooltips

* Add tooltips

* Various changes

* Change settings when camera temperature is out

* improvment extra and tooltip

* Small change when using auto grey as start reference

* Remove itcwb_fgreen from GUI

* Various change - and 'unsatisfactory' test to take into account Custom

* Change second temp when < 4000 - replace automatic by automatic and refinement

* Neutralize 'Use custom tempertaure and green'

* Green refinement

* Clean code - small changes

* Other clean code

* Added forgotten itcw_green in procparams.cc

* Fixed a bug dispaly deltaE

* Change threshold settings - change code for Custom

* various change in case of using camera settings

* Change way to estimate range green

* clean code and message in console

* Clean and optimize

* Disable 2 passes if custom

* Improve GUI 2 passes

* Increase sampling and number of temperature above 9400K

* Hide AWB temperature bais and green refinement when Custom temerature ans green

* marks out the code with past time markers

* Improve time processing with spectral colors temp calculations

* Replace in console msec by nsec

* Scan temp 5.9

* Change max temp and behavior if temp > 15000k

* Refine temp near 14000K

* Increase sampling temperature 132 to 167

* Increase sampling temperature

* Set in preference choice for itcwb_custom

* White point calculated  with observer instead of table

* More on whitepoint calculation - informations

* Clean and format code with astyle colortemp.cc rawimagesource.cc improccoordinator.cc

* Small change tooltip

* Improve update auto-wb

* Remove 'use custom temperature and tin' - simplify sampling to 2 choice

* Small change to rand AWB bias - green refinement - tooltips

* slightly modify the parameters upstream of the algo - do not use camera in some cases

* Mixed initial green

* Refine init green and temp when no camera

* Refine temp and green in do not use camera settings

* Change tint threshold and various improvments (tooltips, wrong values..)

* Refinment and clean code

* Improve mode No use camera settings

* Init nocam

* Refine use no camera  settings

* Small change

* 5.9 compatibility - and format

* Refine sampling temperature  around 7000 - 8000K

* Format astylert rawimagesource colortemp

* 5.9 settings

* 5.9 settings 2

* Various change - 5.9 - format

* Improve pre and post algorithm

* Fixed correction temp > 8000K

* Fixed bad behavior Tppat.minchroma

* Change sampling choices and tooltip

* Change name wp wp2 wip to wb wb2 iwb to avoid misunderstood

* Small Change settings - limit display studgood to 0.0001

* Improvment display GUI temp

* Change default sampling

* Change ACESP0 to JDCmax

* Improve GUI abstract profile

* Allows dispaly in console xy values thanks to Reffort

* Remove bruce rgb in wp and abstract

* Change wp abstract and save itcwb with dispaly cellxy

* Change prim = 13 improccoordinator iplab2rgb

* remove display datas in console - fixed wrong display Y xyY

* Fixed ifferences in GUI maxhist minhist

* Change limits x y in function sampling

* fixed a dizziness

* Change  after algorithm rule when temp > 6000K

* Harmonize limx limy for oldsampling 5.9

* Added Cam xyz matrix to sampling - thanks to Reffort

* Display in console xyz matrix

* Forgotten instruction when mix camera and autowb grey

* Change rgbloc with Camera matrix Dcraw when no input profile

* Change rep to repref in rgbxyz

* Remove message in console

* 5.9 compat

* 5.9 compat 2

* 5.9 compat 3

* 5.9 compat 4

* 5.9 compat 5 format

* 5.9 compta 6

* Improve code

* Diasble itcwb_sampling in GUI

* Comment code

* Clean and comment code

* 5 spectral colors

* 9 spectral colors

* 2 spectral colors

* Various improvments

* 5 spectral colors

* 5 spectral colors

* First changes review lawrence37

* Second changes review Lawrence37

* 3rd changes review Lawrence37

* 4th changes review Lawrence37

* Change windows and appimage yml

* Re-enable Rtv4_Bruce in procparams.cc

* test for 5.9 compatibility

* Try to fixed crash

* Slightly improve the management of 5.9

* test for 5.9 compatibility by passing parameters via the GUI

* Forgotten parameter

* Change ref_spec limit and remove pac_start for itcwb_sampling

* Puts back the old Planck formula - the same as in dev

* Revert "test for 5.9 compatibility by passing parameters via the GUI"

This reverts commit d6b5a8feda31b93a5574cee6ebf4d3e9d58bbcfb.

* Switch to new ITCWB only when changing WB method

Prevents sudden changing of the white balance if ITCWB is selected and
the image is reopened.

* Fix spelling in comment

* Suggested change from Lawrence37 to whitebalance - small change to improcoordinator

* tempbias Set_sentive(false) if itcwb_smapling - clean whitebalance

* Another clean whitebalance.cc

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2023-08-06 13:44:48 +02:00
Jean-Christophe
00fff386c7
Merge pull request #6722 from hfiguiere/crop-leak-6721
Issue #6721 - Fix memory leak in Crop
2023-08-06 12:57:43 +02:00
Jean-Christophe
8764da1ca9
Merge pull request #6800 from jaschob/issue6005-heap-not-stack
Allocate on Heap, Not Stack, in `gaussVertical` and Friends
2023-08-06 12:46:13 +02:00
Beep6581
f4dab3c46c
Merge pull request #6796 from Benitoite/patch-23
macOS: fixes -cli
2023-08-06 12:45:25 +02:00
Beep6581
e1a6e74ab8
Merge branch 'dev' into patch-23 2023-08-06 12:45:18 +02:00
Beep6581
ea5cfc8814
Merge pull request #6812 from Benitoite/patch-26
Mac bundle: handle harfbuzz update
2023-08-06 12:44:38 +02:00