4079 Commits

Author SHA1 Message Date
Simone Gotti
c2a57359fe options: fix BrowseRecursiveFollowLinks reading
PR #6769 added the boolean BrowseRecursiveFollowLinks options, but while
it's saved as a boolean, it's read as an integer causing this error:

```
Options::readFromFile / Error code 5 while reading values from "/home/sgotti/.config/RawTherapee/options":
Key file contains key “BrowseRecursiveFollowLinks” in group “File Browser” which has a value that cannot be interpreted.
```
2024-03-25 11:02:03 +01:00
Lawrence37
3bab4657d7
Merge pull request #6962 from sgotti/read_raw_embedded_dcp
Read embedded dcp profile from raw files
2024-03-24 12:19:04 -07:00
Lawrence37
bf8f385eb5
Merge pull request #6769 from Lawrence37/browse-subfolder
Recursive image browsing
2024-03-24 12:02:21 -07:00
Lawrence Lee
82dce5fd47
Adapt to real hi-DPI update
Change recursive folder browsing button icon color and size.
2024-03-09 12:47:52 -08:00
Lawrence Lee
3e8ebfef2c
Merge branch 'dev' into browse-subfolder 2024-03-09 12:19:30 -08:00
Lawrence37
fb74a9fb11
Merge pull request #6977 from sgotti/denoise_gui_set_luminance_detail_adjuster_default_as_procparams_default
denoise gui: set luminance detail adjuster default as procparams default
2024-03-09 11:23:41 -08:00
Desmis
96a48c6334
Local adjustments - set method Avoid Gamut to Munsell - better processing of highlights and gamut (#6965)
* Avoidgamumethod set to Munsell-only

* Set appimage.yml and windows.yml to la_gamutmunsell

* Remove procparams conversion XYZ absolute tu Munsell only

* Neutralize appimage.yml and windows.yml
2024-03-09 07:36:46 +01:00
Simone Gotti
8de0519204 denoise gui: set luminance detail adjuster default as procparams default
The rtgui denoise luminance detail adjuster widget default value is
set to 50, but the procparams default is 0 causing some confusing
behavior: when enabling the denoise tool in the gui the luminance detail
value is set to the proc params default value (0), when resetting the
adjuster the values is set to 50.

This patch sets the adjuster default value to the procparams default
value like the other adjusters.
2024-03-08 10:46:26 +01:00
Simone Gotti
3e26976403 Read embedded dcp profile from raw files
raw files, usually dng files, can provide a dcp profile by providing the
related tags.

This patch will make the "Use embedded" options in the color management
panel selectable if the source raw file embeds a dcp profile.
In this case the DCP panel will be enabled like when reading an external
dcp profile.

Additional changes:

* Rename "Use embedded, if possible" to just "Use embedded" since the
option is already disabled when no embedded profile is found.
* Update the "Use embedded" options tooltip as it's now not related to
  only non raw images.
2024-03-07 10:37:54 +01:00
Pandagrapher
7e63892628 Merge with 'Beep6581/dev' 2024-03-06 19:10:49 +01:00
Lawrence37
f687bda276
Merge pull request #6872 from 0v3rt1r3d/0v3rt1r3d/max-zoom-preference
Implement maximal zoom feature
2024-03-02 16:40:15 -08:00
Lawrence37
8495ba7502
Merge pull request #6837 from Lawrence37/lensfun-match-saved-name
Fix for some Lensfun corrections not available
2024-03-02 15:45:59 -08:00
Lawrence37
c3402b18d5
Merge pull request #6951 from sgilbertson/issue-4765-queue-template-time-and-date
Issue 4765 queue template time and date
2024-03-01 21:46:29 -08:00
Scott Gilbertson
cd64ced60f Address comments in pull request:
- use "const" where possible
 - add spaces after commas
 - use dateTimeFormatExamples by reference (don't copy)
 - fix incorrect cast to unsigned int (declare variable as gunichar)
2024-02-28 13:22:57 -05:00
Scott Gilbertson
1db8b0d643 Indent example path the same amount as other indented items in the queue template help 2024-02-25 17:49:00 -05:00
Scott Gilbertson
50f27c099c Make indentation consistent in queue template help 2024-02-25 17:38:42 -05:00
Scott Gilbertson
fbeaace607 Change literal to G_FILE_ATTRIBUTE_TIME_MODIFIED, change line spacing in template help 2024-02-25 10:14:10 -05:00
Scott Gilbertson
7c67739b9d Eliminated dateTimeIsValid, instead null-checking dateTime -- non-null means it's valid. 2024-02-19 11:43:04 -05:00
Scott Gilbertson
b39ab15659 Eliminated use of stat() instead using Gio::FileInfo to get file modification date 2024-02-19 11:35:46 -05:00
Scott Gilbertson
547ac41ad4 Make brace placement consistent 2024-02-18 12:28:00 -05:00
Scott Gilbertson
703a81ae0c Removed FIXME comment 2024-02-18 12:22:36 -05:00
Scott Gilbertson
94cd3d4626 Apply time/date format for %t output template specifier 2024-02-18 11:30:43 -05:00
Lawrence Lee
7945f93e8f
Merge branch 'releases' into dev 2024-02-15 23:15:50 -08:00
Scott Gilbertson
dbd0829e61 Obtain the export, shooting or save time, per letter after %t output template specifier
Print the result (not yet processing a time formatting string)
2024-02-12 18:35:01 -05:00
Scott Gilbertson
79134ecc9f Instead of time now, in help examples use 2001-02-03T04:05:06.123456 local time 2024-02-12 17:06:08 -05:00
Scott Gilbertson
5d7586bab4 Simplify path help, add '%f' to generated examples 2024-02-11 15:28:39 -05:00
Scott Gilbertson
ccc667e390 Added specific tooltip for the location template "?" help toggle button 2024-02-11 15:10:02 -05:00
Scott Gilbertson
bc054ea506 Added help for time/date template specifiers 2024-02-11 15:07:50 -05:00
Scott Gilbertson
353a4d472a Added help sections for %r and %s tags, and for common examples 2024-02-11 14:28:03 -05:00
Scott Gilbertson
2690e27dea Generate help examples (Windows or Linux, as appropriate) for %d, %p and %P specifiers.
Also make the help pane half the overall width when first shown (and it's resizeable).
2024-02-11 14:03:58 -05:00
Scott Gilbertson
ed5792bb9f Make populateTemplateHelpBuffer a private member of class BatchQueuePanel 2024-02-10 13:49:19 -05:00
Scott Gilbertson
3fb7296cd1 Create template help Pango markdown programmatically (partial).
Do that the first time the text is shown, rather than at startup.
2024-02-10 13:44:12 -05:00
Desmis
8ad4ebf482
Change default behavior Local Adjustments settings Avoid Color Shift to XYZ Absolute (#6948)
* Change default settings avoidcolorshift to XYZ absolute

* Same change in controlspotpanel.cc
2024-02-08 21:53:07 -08:00
Lawrence37
e438e0e604
Some more cherry-picking for 5.10 (#6937)
* Local adjustments - Show additional settings - link with complexity  (#6899)

* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds

* Update camconst.json white levels for 1DxII

* Fix warnings: conversion to double/float, unused variables, register keyword

* Fix crash when opening image in editor

Do not access uninitialized raw image data. The raw data is requested
when the demosaic mode is set to None and the cursor is moved over the
image in the editor. It can occur before the raw data is loaded.

* Fix sRGB working profile crash

The sRGB working profile cannot be found under some conditions because
the profile name is stored as a Glib::ustring and the same strings may
not be equal when using different locales. Use std::string whenever
comparing profile names.

---------

Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: CarVac <airplaniac2002@gmail.com>
Co-authored-by: Alexander Gruzintsev <0v3rt1r3d@gmail.com>
2024-02-04 15:43:33 -08:00
Lawrence37
0d0834cbe7
Dynamic Range Compression Improvement (5.10) (#6943)
* Improve Dynamic Range Compression - for some images with very high DR

* Clean code

* Improve TM fattal with saturation control in LA

* Saturation control fattal in LA

* Re-order paramsedit

* Change history_msg_tmo_satur with saturation

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-04 15:38:04 -08:00
Scott Gilbertson
c7500becb8 Make template help initially hidden 2024-02-03 19:24:07 -05:00
Scott Gilbertson
e332446627 Added "?" toggle button to show/hide template help.
I haven't figured out how to make it initially hidden.
2024-02-03 15:28:46 -05:00
Scott Gilbertson
7632d0df7c Got template help show/hide working (I had been hiding the wrong widget) 2024-02-03 13:13:25 -05:00
Scott Gilbertson
bfcfaca0ba First try at adding expandable queue template help, using a Gtx::Paned.
Hiding doesn't work right yet. Click a thumbnail and the text disappears,
but the border between widgets doesn't move to the left side.
I tried using a Gtk::Expander, but couldn't get it to expand horizontally.
2024-02-03 13:02:02 -05:00
Desmis
5349f7a860
Improve Dynamic Range Compression - for some images with very high DR - Main and LA (#6931)
* Improve Dynamic Range Compression - for some images with very high DR

* Clean code

* Improve TM fattal with saturation control in LA

* Saturation control fattal in LA

* Re-order paramsedit

* Change history_msg_tmo_satur with saturation
2024-02-02 07:42:34 +01:00
Lawrence37
f06e756c20
AWB non-raw file fixes (for 5.10) (#6940)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-01 22:41:56 -08:00
Desmis
e4087e2fa2
White balance auto temperature correlation - improve behavior with non raw files (#6903)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2024-02-01 07:48:07 +01:00
Lawrence37
ba065dc13f
Merge pull request #6920 from sgilbertson/issue-6915-queue-template-improvements
Queue template improvements
2024-01-28 11:43:07 -08:00
Lawrence37
4dd7517a55
Merge pull request #6873 from 0v3rt1r3d/0v3rt1r3d/fix-a-couple-of-warnings
Fix a couple of warnings
2024-01-27 21:46:14 -08:00
Lawrence37
5ffa0632f2
Merge pull request #6885 from Lawrence37/asan-mem-leak
Fixes for memory leaks and memcpy overlap found by AddressSanitizer
2024-01-25 21:02:50 -08:00
Scott Gilbertson
11a0a0b697 Fixes per pull request comments: fix %p-1 missing slash, use static_cast, fix int/unsigned mismatches 2024-01-16 07:54:12 -05:00
Scott Gilbertson
6cbc448f63 Handle Samba-style UNC prefix '//' in %p and %P queue output template specifiers 2024-01-15 17:13:40 -05:00
Scott Gilbertson
1df9b4869e Make %p and %P queue output template specifiers limit invalid range rather than treating that as an error.
For example in a 4-element path "first 5 elements" and "last 5 elements" now return all four elements.
2024-01-15 16:39:38 -05:00
Scott Gilbertson
a39e6779e4 Fix: If %p or %P queue template term includes start of file path, prepend the leading /, \ or \\ from the file path 2024-01-15 15:27:09 -05:00
Scott Gilbertson
343b5ecc68 Left-justify the queue destination preview label and allow it to scroll horizontally 2024-01-15 14:40:56 -05:00