* Gui improvments
* Several improvments GUI Jz algo
* Change function La for lightess Jz
* SH jzazbz first
* enable Jz SH
* Clean code
* Disabled Munsell correction when Jz
* Change tooltip and Cam16 Munsell
* GUI for CzHz and HzHz curves
* Enable curves Hz(Hz) Cz(Hz)
* Improve Cz chroma
* Jz100 reference refine
* Change limit Jz100
* Refine link between jz100 and peak adaptation
* Improve GUI
* Various improvment PQ PU gamut
* Change defaults settings
* forgotten PL in gamutjz
* Small changes and comment
* Change gamujz parameter
* disabled gamut Jz too slow
* Jzazbz curve Jz(Hz)
* reenable gamutjz
* small changes
* Change tooltip
* Change labels tooltips
* Jzazbz only on advanced mode
* GUI improvments
* Change tooltip
* Change default values and tooltip
* Added tooltip Jz
* Disabled Jz gamut
* Change gamma color and light - remove exposure
* Gamma for exposure and DR
* gamma Sharp
* Gamma vibrance
* gamma optimizations
* Change tooltips
* Optimization PQ
* LA GUI for tone curve Ciecam
* LA ciecam Enable curve lightness - brightness
* LA ciecam GUI color curve
* LA ciecam enable color curve
* Change tooltip and default values
* Enable Jz curve
* Enable Cz(Cz) curve
* Enable Cz(Jz) curve
* Added Log encoding to ciecam
* Improvment algorithm remapping
* Reenable forgotten listener logencodchanged
* Change Jz tooltips
* Reenable dynamic range and exposure
* First change GUI auto ciecam
* 2nd fixed ciecam auto
* Improve GUI maskbackground curves
* Enable activspot for la ciecam
* set sensitive sliders La ciecam when auto scene conditions
* Change internal calculations see comments
* Checcbox ForceJz to 1
* Change tool position - change order CAM model
* Expander for Jzczhz
* Remove unused code
* GUI changes
* Change labels CAM16 Jzazbz
* Change slider brightness parameters
* improvment SH jz
* Some changes to brightness Jz
* Fixed scene conditions auto
* Renable forgotten change
* Prepare calculation Zcam
* Prepare Iz for zcam
* First GUI Zcam
* Improve GUI Zcam
* Calculate Qz white - brightness of the reference white
* Prepare for PQ - eventually
* Init LUT ZCAMBrightCurveJz and ZCAMBrightCurveQz
* prepare zcam achromatic variables
* First zcam
* Change algo step 5 zcam
* Another change original algo
* Another change to original algo
* first colorfullness
* Fixed bad behavior threshold and change c c2 surround parameters
* added saturation Zcam
* Change parameters surround
* Enable chroma zcam
* change chroma and lightness formula
* disable OMP for 2nd process Zcam
* Improvment zcam for some high-light images
* Change parameters overflow zcam
* Change parmeters high datas
* another change to retrieve...
* Simplify code matrix conversion xyz-jzazbz
* Adjust internam parameters zcam
* Change some parameters - clean code
* Enable PQCam16
* Enable PQ Cam16 - disable ZCAM
* remove warning compilation message
* Change GUI jzczhz
* Fixed bad behavior remaping jz
* Remove forgotten parameter - hide Jz100 - PU adaptation- chnage tooltips
* Another change to chroma parameter
* Small changes
* If verbose display in console Cam16 informations
* If verbose display in console source saturation colorfullness
* Change to La calculation for ciecam
* Change GUI cam16 - jzczhz - remove cam16 and jzczhz
* Disable exposure compensation to calculate La for all Ciecam and Log encoding
* Change label Cam16 and jzczhz
* Improve GUI Jz
* Other improvment GUI Jz Cam16
* verify nan Jz and ciecam matrix to avoid crash
* Enable La manual for Jz to change PU-adaptation
* Improve calculation to avoid crash Jz and Cam16 matrix
* Fixed crash with local contrast in cam16
* Clean code loccont
* First step GUI Cie mask
* GUI part 2 - Cie
* Build cieMask
* Gui part 3 cie
* Valid llcieMask
* Valid llcieMask
* Pass GUI curves parameters to iplocallab.cc
* 2nd pass parameters from GUI to iplocallab.cc
* Init first functions modifications
* Add expander to cam16 adjustments
* First test mask cie
* Various improvment GUI - tooltips - process
* Take into account Yb cam16 for Jz - reenable warm-cool
* Surround source Cam16 before Jz
* Improve GUI and process
* Fixed bug and bad behavior last commit
* Fixed bug chroma mask - improve GUI - Relative luminance for Jz
* Increase sensitivity mask chroma
* Improve Jz with saturation Z - improve GUI Jzczhz
* Small code improvment
* Another change mask C and enable mask for Cam16 and Jz
* Some changes
* Enable denoise chroma mask
* Small change LIM01 normchromar
* Enable Zcam matrix
* Improve chroma curves...mask and boudaries
* take into account recursive slider in settings
* Change tooltip - improvment to C curve (denoise C - best value in curves - etc.) - remove Zcam button
* Change tooltips
* First part GUI - local contrast wavelet Jz
* Passed parameters GUI local contrast wav jz to rtengine
* save config wavelet jz
* first try wavelet local contrast Jz
* Add tooltips
* Simplify code wavelet local contrast
* take into account edge wavelet performance in Wavelet Jz
* Fixed overflow jz when usig botth contradt and wavelt local jz contrast
* Adapt size winGdiHandles in filepanel to avoid crash in Windows multieditor
* First GUI part Clarity wavelet Jz
* First try wavelet Jz Cz clarity
* Added tooltips
* Small change to enable wavelet jz
* Disabled (commented) all Zcam code
* Improve behavior when SH local-contrast and Clarity are use both
* Change limit PQremap jz
* Clean and optimize code
* Reenable mjjz
* Change settings guidedfilter wavelet Jz
* Fixed crash when revory based on lum mask negative
* Change tooltip
* Fixed ad behavior auto mean and absolute luminance
* Remove warning in console
* Fixed bad behavior auto Log encoding - bad behavior curves L(H) Jz
* Fixed another bad behavior - reenable curves color and light L(H) C(H)
* first transposition Lab Jz for curves H
* Change mask boundary for Jz
* Various improvment to H curves Jz
* Add amountchrom to Hcurve Color and Light
* Improve gray boundary curves behavior
* reenable Jz curve H(H) - soft radius
* Improve guidefilter Jz H curve
* Threshold chroma Jz(Hz)
* Enable guidedfilter chroma curve H
* improve GUI curves Hz
* Checkbutton chroma for curve Jz(Hz)
* Change event selectspot
* Clean and small optimization code
* Another clean code
* Change calculation Hz references for curves Hz
* Clean code
* Various changes to GF and GUI
* Another change to Chroma for Jz(H)
* Change GUI sensitive Jz100 adapdjzcie
* Improve code for Jz100
* Change default value skin-protection to 0 instead of 50
* Clean code
* Remove BENCHFUN for ciecam
* small correction to huejz_to_huehsv2 conversion
* Added missing plum parameter for jch2xyz_ciecam02float
* another small change to huejz_to_huehsv2
* Improvment to huelab_to_huehsv2 and some double functions
* Fixed warning hide parameters in lgtm-com
* Fixed ? Missing retuen statement in lgtm-com
* Change behavior Log encoding whith PQ Cam16
* Small improvment to Jz PU adaptation
* Added forgoten to_one for Cz slider
* Replace 0.707... by RT_SQRT1_2 - change some settings chroma
* Improvment to getAutoLogloc
* Fixed crash with array in getAutoLogloc
* First try Jz Log encoding
* Forgotten Cz
* Various improvment GUI setlogscale - Jz log encoding
* Change labels tooltips Jz log
* Change wrong clipcz value
* Change tooltip auto scene conditions
* Fixed bad behavior blackevjz whiteevjz
* Small improvment to LA Log encoding std
* Avoid bad behavior Jz log when enable Relative luminance
* Change sourcegray jz calculation
* Revert last change
* Clean and comment code
* Review tooltips thanks to Wayne - harmonize response La log encoding and Jz Log encoding
* Always force Dynamic Range evaluation in full frame mode for Jz log encoding
* Remove unused code
* Small optimizations sigmoid Cam16 and Jz
* Comment code
* Change parameters deltaE for HDR
* Various improvment to Jz - La - sigmoid - log encoding
* Basic support for Sony ILCE-7M4 in camconst.json
* German translation Spot Removal (#6388)
* Filmnegative German translation (#6389)
* (Temporarily) disable `ftree-loop-vectorize` for GCC 11 because of #6384
* Added BlacEv WhiteEv to sigmoidJz
* Improve GUI for BlackEv WhiteEv
* Change location SigmoidJz in Iplocallab
* Improvment GUI and sensitivity sliders strength sigmoid
* Change labels
Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
Co-authored-by: Anna <simonanna@gmx.net>
When perspective control line editing is active and the history entry is
changed such that edit mode is automatically disabled, there is a crash.
The history change triggers a processing parameters update and disables
editing. When editing is disabled, the perspective tool also tries to
update the processing parameters, causing a double mutex lock attempt.
This commit avoids updating parameters from the perspective tool and
uses the tweak operator (introduced with the spot removal tool) to achieve
the same effect.
Closes#6251.
* Change TRC in the process
* Improve GUI slope
* Add tooltip output profile
* Various change to enable and tooltip
* Chnage rtthumbnail
* Small change tooltip trc
* Another small change tooltip
* Improve GUI - change default TRC BT709 - change tooltip
* Other GUI improvment
* Small changes to BT709 values
* Various change to TRC - add illuminant working profile
* Change labels tooltip TRC illuminant
* Display wp in console if wp provided
* Change tooltip
* Change max wlope
* Init trc + illum + primaries
* Add black point compensation
* Change location abstract
* Fixed bug with rtthumbnail...
* Added tooltip
* Logscale for wslope
* Change tooltip abstract
* Change labels tooltips abstract profile
* Added 6 sliders custom primaries X and Y
* Change GUI custom primaries
* Use custom primaries abstract profiles
* Tooltip with primaries red green blue
* Fixed warning gtk
* Change one tooltip
* Change range custom primaries
* Change GUI default Primaries
* Change one tooltip
* Speedup for trc
* Rendering intent for abstract profile
* Hide intent abstract
* Preserve neutral tones
* Chnage settings preserves neutral tones
* Improve GUI
* Improvment to preserv
* Clean code - speedup TRC when illuminant and primaries default
* Change label
* Change bad default value Blux
* Add forgoten illuminant when selecting primaries
* clean code
* Change labels
* improve workingtrc for LA
* Change default primaries when select default
* Added others working profile to primaries
* Change labels and GUI
* Change tooltip
* CIExy diagram displaying the primaries (interactive) and the white point (#6207)
* Ciexy diagram
* Change to Ciexy graph
* Change graph and defaut coordonates
* Various changes to graph - params
* Disable setListener(ToolPanelListener)
* Add some graduation to graph
* Clean comment code graph
* Change radius 0
* Enable sensitive graph Ciexy
* update Ciexy graph with primaries
* Remove reset button graph
* Change labels and behavior
* First step third spot green
* Second step 3rd spot green
* First try 3 primaries graph Ciexy
* Fixed bad behavior in lab grid
* Fixed another bad behavior graph
* Clean and comment code
* Change default gamma
* More accurate graph Cie xy
* Added white point to Ciexy graph
* Added tooltip Cie xy diagram
* Improvment when illuminant change
* Refine diagram CIE xy - added WP 2000K
* White point D120 + tooltip
* Change label
* Change labels
* Change tooltips
* Improve diagram CIE xy with parabolic
* Other parabolic to improve Cie xy diagram
* Small change GUI
* Added Label CIE xy - change labels
* Change behavior when none - change labels
* Improve gUI and trys to fix LGTM alerts
* CIE xy change set sensitive
* Improve tooltip primaries sliders
* Adapt tooltip to new labels
* Fixed crash and some bad behavior
* First fix bad behavior with some primaries
* Second fixed bad behavior primaries
* Third fixed bad behavior primaries
* Change white point BestRGB
* Change order rgb in history msg Ciexy
* Change tooltip
* Change tooltip
* Improve GUI primaries
* Illuminant 1500K - display in console matrix XYZ-RGB
* Improve GUI illuminant
* Change a tooltip
* Somme changes to GUI and verbose
* Test code for wprim in read
* clean code for wprims
* further cleanups, not tested
* Some cleanups and bugfixes, #5949
* Simplify `std::unique_ptr<>` dereferencing
Also some minor cleanups.
* Some changes suggested by Floessie
* Others change suggested
* Others changes suggested by Floessie
* Forgotten change in procparams.cc
* Added black and white for use with the primaries channel mixer
* Small change behavior GUI - illuminant
* Change pragma omp in iplab2rgb
* Add enums and clean up
* Remove unused code icmpanel.cc
* Fix LGTM alert, #5949
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Flössie <floessie.mail@gmail.com>
Replaces the following deprecated Gtk classes throughout the codebase by their non-deprecated counterparts. Style, HBox, VBox, HPaned, VPaned, HScrollbar, VScrollbar, VSeparator, HSeparator, Stock, Table, VScale and HScale.
Collection of CSS and GUI improvements, cleanup of main CSS theme, introduction of highlight for enabled module.
Primary change is the modification of the module titles to better distinguish modules that are on or off. The text of a disabled module is now less bright, the corresponding icon is a slightly smaller version of the power icon. When activating the module, the text turns brighter and the icon slightly bigger and also brighter. Thanks to @TechXavAL for the icon work.
Secondary changes are related to the margins around several GUI elements, padding within elements and some accompanying borders. These changes hopefully make it easier to distinguish the various (sometimes crowded) GUI elements of modules. The panels have gotten a slightly 'outset' look.
Nested panels have a changed look where deeper nesting increases the background brightness slightly, instead of darkening it (old behaviour). This is done without a strong decrease in contrast.
The old theme is available as a legacy option. Due to hardcoded GUI changes needed for the new theme, the legacy version is not a 100% exact replicate. The @TooWaBoo theme's may also be slightly affected.
* Added support for non-raw files to the film negative tool. The tool is now under the "Color" tab. Moved the entire filmneg code downstream, right after input profile conversion.
Usage changes a bit: White Balance must be set to the _backlight_ color temperature. Added two more sliders to color-balance the picture after negative inversion. Legacy inversion method kept for compatibility with processing profiles saved by RT v5.7 or 5.8 (only if Film Negative was enabled). Should be removed in a future version.
There is still an issue with DCP profiles that need the look table to be active to work properly. Using a simple matrix input profile (or just camera standard) is recommended for now.
* The user can now choose to perform inversion before or after input colorspace conversion.
Seamless backwards compatibility with previous processing profiles; upgrading from a previous version now gives an (almost) identical output as before.
Generalised the concept of film base values: the processing profile now contains a pair of RGB triplets, "reference input" and "reference output", which makes it much more straightforward to compute the output multipliers.
* Added support for `RGB` data type to putToKeyFile, removed the now unused `RGB::toVector()` method. Some cleanup.
* Spot balance picker now stays active indefinitely. Can be disabled by right-clicking, too.
* Removed film negative from `filterRawRefresh` condition, since the new version does not require raw rendering anymore.
* The Output Level slider is now exponential, so it should feel more familiar to use (similar to the exposure compensation slider).
* Removed old `RedBase`, `GreenBase`, `BlueBase` keys from the PP3 file after params upgrade. Keys are only kept if the file only undergoes batch edit (hence no params upgrade was done).
* Made the balance sliders exponential and centered at zero. Now they should be a bit smoother and possibly more user-friendly.
* Changed adjusters' step to more useful values, they were too fine-grained and hard to adjust using the +/- spinbutton.
Increased max ratio value from 3 to 5, as i found an old negative needing a very high blue channel exponent.
* Added an initial processing profile for film negative inversion, to be provided as a bundled profile.
* Removed Output Level and balance sliders when in batch mode: since the effect of these sliders is dependent on the reference input values, those values needed to be copied as well. And, touching any of the sliders needed to flag all three as dirty. All this felt more confusing than useful.
It should be sufficient (and clearer) to copy/paste the params, and then fine-tune the balance on individual pictures when needed.
* Set bayer demosaic method to RCD in the bundled "Film Negative" processing profile. RCD seems to play a bit better with Capture Sharpening in the presence of film grain, compared to Amaze.
This will favor new users starting with all-defaults settings, hence having Capture Sharpening enabled by default.
* Removed incorrect "contrast" term from the "Reference exponent" label. This parameter adjusts the image _gamma_, not its contrast.
- Modified some Locallab tool default parameters
- Updates some labels
- Expanders visibility state is now kept when using history
- New added tool has now its visibily state resetted to default one
- Code cleanup
* Added new feature to calculate channel multipliers from crop area. This also saves the crop area channel medians to the processing profiles, in order to get a more consistent color balance when batch-applying the same profile to multiple pictures from the same film roll.
* Fixed wrong initialization of array, and missing check for the result of `getFilmNegativeMedians()`.
Moved `ImProcCoordinator::translateCoord()` from private member to anonymous namespace.
Fixed some whitespace and formatting issues.
* Fixed some formatting issues
* Passed `ipf` parameter as const in `translateCoord`.
Narrowed `using namespace` to single class `Coord2D`.
* Added `scaleGain` entry to thumbnail metadata file, to make `scale_mul` multipliers available in thumbnail processing phase. This simplifies multiplier calculations, so that "faking" thumbnail multipliers in the main image processing is not necessary anymore. This way, output values are immune to slight variations of multipliers between successive shots taken with in-camera AWB turned on.
Shifted multipliers so that the output channel medians are balanced when "Camera WB" is selected. This way, just computing multipliers from crop and setting "Camera WB" (which is the default) gives a pretty well balanced image as a starting point.
* New channel scaling method, based on a film base color sample instead of crop area channel medians. Channels are scaled so that the converted film base values are equal to 1/512th of the output range (65k). This giver better black levels in the output, and more consistency when batch-processing multiple negatives.
The output is now compensated for a known fixed WB value, so that the film base will appear grey when WB is set to 3500K, Green=1.
Added PPVERSION 347 to preserve backwards compatibility: when a processing profile saved by RT 5.7 is loaded (PPVERSION=346), the new fields are initialized to the special value -1, which will instruct the main processing to follow the old channel scaling behaviour. The old channel scaling multipliers will then be converted to the new film base values so that the resulting image is the same, and the fields will be overwritten as soon as the PP is saved again. This will transparently upgrade the processing profile.
When the new behaviour is used, but the film base values are still unset, they are estimated based on channel medians, excluding a 20% border around the image. This should give a better result out-of-the-box for pictures containing a large film holder.
* Code cleanup from review
* Run astyle on film neg source files
* Fixed automated build failure caused by incompatible libraries on my dev PC.
* Simplified `Thumbnail::processFilmNegative` method signature. There is no need to pass in `rmi`,`gmi`,`bmi` multipliers from the caller, i can do the same with my own internal multipliers.
* Added `FilmNegListener` class to pass estimeted film base values to the GUI after first processing. Removed old `filmBaseValues` instance variable from RawImageSource.
* Code cleanup
* Forgot to set baseValues flag in `PartialPasteDlg::applyPaste`
Fixed `filmBaseValuesLabel` not updating when reading zero baseValues. Normally not needed (the label is updated later by the listener), but when the user is browsing through pictures the listener won't fire, so the label must be updated to show values are unset.
* Overwritten channel scaling multipliers by calling `get_colorsCoeff` with `forceAutoWB=false`.
Initially, in `RawImageSource::load`, channels are auto-balanced by averaging the whole picture when computing multipliers.
This can give different multipliers for multiple shots of the same camera, which will lead to inconsistent conversions when batch-processing multiple negatives.
This commit re-sets `scale_mul`, `ref_pre_mul`, etc., in order to "undo" the auto-WB and use the normal camera multipliers.
* Found an easier way to get stable overall multipliers, removed the (horrible) on-the-fly mutation of scaling instance variables.
If the focal length and/or crop factor for the camera-based perspective
correction tool are not edited, they will be set using the focal length
information found in the image metadata. This only applies to the editor
(batch editor and CLI still default to 24 for the focal length and 1 for
the crop factor).
I had to remove the `isVisible` check in `MyExpander::set_expanded()`
because it would trigger in Wavelet and Retinex for unknown reasons.
One inner expander in CIECAM isn't covered by the tool states, and the
way they are distributed to Wavelet and Retinex won't allow for further
tool states in those tools. We should consider to move the tool states
for sub-tools (like Wavelet, Retinex, and CIECAM) to seperate keys in
the `options` file.
