Commit Graph

91 Commits

Author SHA1 Message Date
Lawrence Lee
1e6cc85fe2 Add missing includes
Thanks to Benitoite
(https://github.com/Beep6581/RawTherapee/pull/5889#issuecomment-1475033091)
2023-03-18 18:15:38 -07:00
Lawrence Lee
20e78068cd Merge branch 'dev' into metadata-exiv2 2023-03-17 22:16:17 -07:00
Flössie
e2311cc3da Some minor improvements to ImageIO::saveTIFF() 2023-03-03 09:17:12 +01:00
Flössie
8587fe068d Don't perform EXIF hack on BigTIFF 2023-03-03 08:57:08 +01:00
Flössie
a07c38f405 Support for saving TIFFs as BigTIFF (#6690) 2023-03-01 12:47:55 +01:00
Lawrence Lee
e590429786 Remove outdated comment
Issue #5787 in the Exiv2 branch is handled by commit 522f6f4.
2023-02-11 17:51:43 -08:00
Alberto Griggio
522f6f4473 metadata: make sure to include XResolution and YResolution when writing TIFFs
This is mandatory (according to http://dpfmanager.org), and in fact needed for
Photoshop compatibility

(cherry picked from commit 5d281810cc7a7f7dc563dde030cf90c78dbf55d0)
2022-12-10 10:46:29 -08:00
Alberto Griggio
322e709bcb metadata: do not accidentally remove exif tags when embedding the arp sidecar in XMP
Fixes #127

(cherry picked from commit 49cbe9bd19db558a4be36221472cbb5e78aa95a2)
2022-12-10 10:01:15 -08:00
Alberto Griggio
6cec805774 metadata: try to be more robust when saving
Tentative fix for #89

(cherry picked from commit a8b53fef753c7a1146013feeb66be87c688b8631)
2022-12-10 09:51:16 -08:00
Alberto Griggio
ea3cf2fe8f imageio: do not fail in saving an image if no metadata is available
(cherry picked from commit 86d48be88b6f9fe36e5e25185ec4fda7696efc25)
2022-12-05 21:34:20 -08:00
Alberto Griggio
e90ffe979b metadata: catch std::exception instead of Exiv2::AnyError for better robustness
(cherry picked from commit 0e2d9332f633b060bd4d5cbcd9d47009bab0c46c)
2022-12-05 21:19:21 -08:00
Alberto Griggio
1a771fa211 more work on synchronizing metadata with xmp sidecars
(cherry picked from commit 81bbff6e6ae87bd35e8050a1cc621297ca24939b)
2022-12-04 15:55:09 -08:00
Lawrence Lee
4223f114cb Clean up merge 2022-12-03 21:24:17 -08:00
Ruslan Kabatsayev
9988fa1fdc Fix size of TIFFTAG_EXIFIFD as passed to TIFFSetField
Starting with libtiff 4.0.0, TIFFTAG_EXIFIFD has size of 64 bits, so it
must be set as a 64-bit value. Otherwise, since TIFFSetField is a
variadic function, there's no conversion, and the function reads garbage
into the higher dword.

This patch implements the fix and thus closes #5141.
2021-07-15 12:43:33 +03:00
Thanatomanic
ae754b2492 Merge branch 'dev' into metadata-exiv2 2021-04-27 09:59:52 +02:00
Adam Reichold
fae40a137a A few more minor fixes geared towards lgtm.com alerts (#6127)
* Remove unfilled formatting placeholders in KLT parser.
* Fix presumably unintentionally missing reference on PlanatPtr and ChunkyPtr call operators.
* Fix catching pointer and make use-after-free of workimg easier to spot.
Make sure all of our thrown exceptions derive from std::exception and then catch
by reference instead of by pointer.
* Fix mismatch between array form new and non-array form delete.
* Simplify memory management of embedded color profiles by unifying allocation to use operator new.
2021-03-17 08:37:19 +01:00
Ingo Weyrich
24df5166f2 assume SAMPLEFORMAT_UINT for tiff files when SAMPLEFORMAT_VOID is set 2021-02-21 13:32:16 +01:00
Ingo Weyrich
80c5816084 Improve error logging and memory handling when reading tiff files 2020-11-18 13:52:07 +01:00
Thanatomanic
d9799ec5de Fix dcp.cc with some help from the implementation in ART 2020-10-16 12:39:17 +02:00
Thanatomanic
8b4389ade9 Resolve exiv2 merge conflicts and merge with 2020-10-16 11:45:26 +02:00
Flössie
d033dbc810 Add 300dpi resolution to exported TIFFs (fixes #5787) 2020-06-16 10:52:56 +02:00
Ingo Weyrich
d731e172c2 Further reduction of include dependencies 2019-11-01 16:15:59 +01:00
Ingo Weyrich
cac2eb53ef Further reduction of include dependencies 2019-10-31 20:41:08 +01:00
Ingo Weyrich
6935faa258 Further cleanup of include dependencies 2019-10-30 22:12:06 +01:00
Flössie
28f0bc14da Merge branch 'dev' into metadata-exiv2
- Rating (#5325) not yet implemented
2019-09-24 14:30:54 +02:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
Ingo Weyrich
17f343f682 add -Wcast-qual switch and fix all related warnings 2019-07-25 17:45:43 +02:00
Flössie
21a97980b6 Merge branch 'dev' into metadata-exiv2 2019-07-09 13:34:19 +02:00
Ingo Weyrich
0f09559413 Windows build crashes when trying to load a corrupted jpg, fixes #5366 2019-07-06 12:58:53 +02:00
Flössie
ba4de904cc Cleanups and a few fixes 2019-05-10 21:24:22 +02:00
Alberto Griggio
c360fd7e2c Use exiv2 for metadata handling 2019-05-06 09:27:44 +02:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
heckflosse
bfe8465563 Review of image classes interfaces 2018-11-18 15:43:15 +01:00
Roel Baars
f179eb8333 Add safeguards for setjmp calls when compiling with clang 2018-11-11 14:48:44 +01:00
Hombre
c5ad03c9cc Better support of TIFF's SubFileType tag and alpha channel
Fix issue #4868
2018-10-15 22:48:37 +02:00
heckflosse
6969303878 Compressed 16-bit TIFF output broken, fixes #4792 2018-09-11 17:11:38 +02:00
Hombre
b356c74813 RT now generates valid 16-bit float TIFF output image (see #2357)
...however the "reader" of those files is broken and make RT crash.

Thanks to @heckflosse for the "writer" patch.
2018-05-10 22:13:06 +02:00
Hombre
3044cd80c9 Merge branch 'dev' into 32b-tiff-output-cli 2018-05-07 09:59:25 +02:00
Hombre
30efa5930d 16-bit floating-point support for TIFF output image (see #2357) 2018-05-07 09:57:53 +02:00
Hombre
5ac11ef1b9 Enable saving 32 bits floating point TIFF image with rt-cli (see #2357) 2018-05-06 18:50:42 +02:00
Hombre
ec2181f7ff Fix #4532, Fix #4533 : Pentax HDR/PEF and 16/24 bits float support 2018-05-06 17:14:44 +02:00
heckflosse
59ebf99f63 Add support for embedded single channel previews, fixes #4419 2018-03-20 22:20:25 +01:00
Hombre
abec60d099 Bugfix: wrong length written to file 2018-03-02 01:03:00 +01:00
Hombre
0b8eb41896 The EXIFIfd data type produced by libtiff is updated to 0x0004
which make the Exifs understandable by Windows. (see #4393)
2018-03-02 00:12:02 +01:00
luz.paz
c3c3ceac79 Misc. typos
Found via `codespell` 
+ removed rtengine/dcraw.patch per discussion in https://github.com/Beep6581/RawTherapee/pull/4395
2018-02-14 14:07:18 -05:00
Hombre
d7f7c06f10 Whean read, 32 bits tiff image data are not scaled anymore
So the highlights above the 1.0 upper limit will be clipped but colors
will be preserved. Fix #4379
2018-02-09 22:25:40 +01:00
Morgan Hardwood
09c4572402 Fix corrupt 32-bit compressed TIFF
Match endianness of pixel data with endianness of Exif metadata when
saving compressed 32-bit float TIFF.
Fixes #4377
2018-02-07 17:10:57 +01:00
heckflosse
d6f1b3e6f6 Fix resource leak reported by Coverity (CID 186465) 2018-01-12 16:12:11 +01:00
Hombre
91e494a709 Fix issue #4291 : "Bug when edit current image in external editor"
Is also add metadata to the "ICC Reference image" (ICM tool).
2018-01-10 18:22:50 +01:00
Alberto Griggio
e29e9ca0d8 Fixed segfault when saving reference image (due to metadata in TIFF not present)
Fixes #4289
2018-01-10 17:38:18 +01:00