142 Commits

Author SHA1 Message Date
Stephen Shkardoon
23f2a2fc9f Use _WIN32 instead of WIN32 to detect Windows
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here.
http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
2023-08-13 17:09:49 +12:00
Lawrence Lee
8accebe416
Fix incorrect sampled L*a*b* values
Use LCMS to convert values back into L*a*b*. The pipette buffer has the
output or working profile applied with LCMS. Performing the inverse
operation fixes the incorrect values shown in the navigator, histogram
indicator bars, and lockable color pickers.
2023-05-28 18:15:27 -07:00
Ingo Weyrich
8bd9bddfc7
New crop guide: square center, closes #6342 (#6345)
* New crop guide: square center, closes #6342

* Turn `CropParams::guide` into an `enum`

This saves recurring string comparisons.

Co-authored-by: Flössie <floessie.mail@gmail.com>
2021-08-25 15:25:59 +02:00
Lawrence Lee
a2c5fd0f91 Fix drag position after alternate button press
When a button is released and the edit state is not "dragging", reset
the drag delta to zero.

There was a problem with the spot removal spots being dragged. If a spot
is deleted while being dragged, dragging another spot will cause a jump.
2021-06-12 11:37:38 -07:00
Lawrence Lee
56e634da81 Improve control lines dragging behavior
Fix control line not updating when dragging and allow dragging when
starting with the mouse cursor outside the preview image area.
2021-05-23 21:45:23 -07:00
Ingo Weyrich
f1f147a826 On-Preview Editing Widgets: Crashes, #6244 2021-05-20 22:15:46 +02:00
Ingo Weyrich
19e3833e66 Merge branch 'dev' into spot-removal-tool 2020-11-24 17:16:41 +01:00
Lawrence37
eb01f99bf2
Merge pull request #5814 from Lawrence37/perspective-lines
GUI improvements for perspective correction
2020-10-08 09:55:37 -07:00
Flössie
79278875da Use snprintf() instead of sprintf() (#5907) 2020-09-15 14:56:57 +02:00
Lawrence Lee
1e73135d51 Add perspective edit button to toolbar
The perspective control lines edit mode no longer piggybacks on the hand
tool button on the toolbar.
2020-07-31 21:58:00 -07:00
Lawrence Lee
6b7c1871b9 Implement basic perspective control lines (WIP) 2020-06-08 18:21:12 -07:00
Hombre
f42548b018 Merge branch 'dev' into spot-removal-tool 2020-05-18 14:54:30 +02:00
Ingo Weyrich
30317f4133 use std::fabs, hopefully fixes #5651 2020-02-12 23:38:07 +01:00
Ingo Weyrich
f0b5ca02e7 More double promote fixes 2020-02-10 16:22:42 +01:00
Ingo Weyrich
bf301b7e40 reduce include depenencies 2020-01-18 23:46:48 +01:00
luz.paz
765499bf55 Fix doxygen typo and other various typos 2019-12-19 20:46:35 -05:00
Hombre57
c23f976302 Merge branch 'dev' into spot-removal-tool 2019-12-08 00:37:54 +01:00
Ingo Weyrich
04b08741ee Further cleanups 2019-11-27 18:55:20 +01:00
Ingo Weyrich
2a4891827d Some cleanups 2019-11-26 15:25:11 +01:00
Ingo Weyrich
b3b1008270 Further reduction of include dependencies 2019-11-02 17:29:26 +01:00
Ingo Weyrich
e682b364b5 Further reduction of include dependencies 2019-11-01 14:51:33 +01:00
Hombre
1cf62a2a65 Merge branch 'dev' into spot-removal-tool 2019-09-14 23:31:02 +02:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
Hombre
82e7caa635 Spot removal : differentiating source/dest, betted cursor handling
+ some code cleanup from floessie (see issue #2239)
2019-09-01 02:08:48 +02:00
Andy Dodd
1a6d1b038f rtgui/cropwindow: Improve behavior with smooth scrolling devices
Accumulate/coalesce GDK_SCROLL_SMOOTH events until we equal or exceed +/-1.0

This avoids having one zoom adjustment for every single event which makes touchpad zooming unusable due to frequent
small deltas

This makes trackpad zooming usable while having no effect on mice that emit GDK_SMOOTH_SCROLL with values of +/-1.0 instead
of GDK_SCROLL_UP and GDK_SCROLL_DOWN

If any mice exist that have scroll wheel detents but emit smaller values per detent, this may have the negative effect of
requiring multiple detents per zoom level.  It remains to be seen whether any mice behave like this.  The discrete step
implementation of zoomSteps requires us to coalesce events instead of smoothly zooming in and out.
2019-08-30 16:55:35 -04:00
Hombre
878c429b3c Merge branch 'dev' into spot-removal-tool 2019-08-19 00:10:36 +02:00
Hombre
5b320c9e35 Merge remote-tracking branch 'origin/objectprecedence' into dev 2019-08-19 00:06:41 +02:00
Hombre
6b12f299e6 On preview widgets for main crop window is now clipped
to avoid drawing on the whole window. Fix issue #5418
2019-08-18 18:20:32 +02:00
Hombre
8bb88073fa Fixing object precedence in getCursor as well
+ resize of the "catching spot" of the Gradient widget (30 -> 12)
2019-08-18 17:12:37 +02:00
Hombre
f5a18f6248 Hovered edit object wasn't dragged if inside a red crop's rectangle
Fix issue #5415
2019-08-18 01:54:31 +02:00
Hombre
883e73454d Merge branch 'dev' into spot-removal-tool 2019-08-16 22:58:17 +02:00
Ingo Weyrich
4fedfb2b26 cppcheck: further fixes 2019-08-06 22:10:38 +02:00
Hombre
0db64d49a2 Introducing TweakOperator, for better tool's special mode handling 2019-08-06 02:04:48 +02:00
Ingo Weyrich
5f8799d48e Store buttonset tooltips in static memory, saves about 700 byte per thumbnail 2019-07-18 11:18:45 +02:00
Hombre
f60711b65b Code cleanup of editcallbacks.h/.cc for more safety 2019-03-24 01:40:25 +01:00
Hombre
108b69ae22 "edit.h/.cc" splitted to limit rebuilding dependencies 2019-03-22 00:09:37 +01:00
Hombre
52dcd08b97 Merge branch 'dev' into hidpi-icons 2019-03-13 01:00:14 +01:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
Hombre
bd175ec8d1 Merge branch 'dev' into hidpi-icons 2019-02-25 22:37:00 +01:00
heckflosse
9802feee86 Fix crash in cropwindow.cc, fixes #5169 2019-02-09 14:34:56 +01:00
Flössie
37027e46bd Fix non-OpenMP build 2019-02-06 06:54:31 +01:00
Hombre
434e121f99 Merge branch 'dev' into hidpi-icons 2018-11-29 00:15:57 +01:00
heckflosse
b5a20fd6df Fix bug in calculation of diagonal, #5032, thanks to @Konyicsiva 2018-11-28 16:28:43 +01:00
heckflosse
ae4cfaa992 Using mouse wheel to zoom in sometimes zooms out, fixes #5036 2018-11-26 21:00:48 +01:00
luz.paz
e0ccb7da7d Misc. comment typo fixes
Found via `codespell`
2018-11-23 07:07:38 -05:00
Hombre
785a0e6a46 Merge branch 'dev' into hidpi-icons 2018-10-25 20:43:41 +02:00
Hombre
4eb8a8f70c Adding HiDPI support (WIP) 2018-10-25 20:22:33 +02:00
Hombre
0d61f14bae Added support for GDK_SCROLL_SMOOTH in some widgets
see #4781, #4786
2018-09-15 21:14:48 +02:00
Roel Baars
a7b7f20b83
Fix for #4743: flashing background 2018-09-02 17:53:52 +02:00
Beep6581
c4791f6bc5
Merge pull request #4754 from Beep6581/navcursor
Improvements to mouse cursor and icons
2018-08-31 10:36:19 +02:00