Alberto Griggio
7b9252be33
fattal: correctly crop the image to the dimensions required for distortion correction
...
Fix for #4187
2017-11-17 21:02:19 +01:00
Alberto Griggio
6212d6e0c6
better (local) caching of fattal results in dcrop
...
Use new M_HDR todo code instead of using M_RGBCURVE for fattal
(ported from Hombre's commit a9d02a7dca0b5dcd31f642046d94e1663b17c9ff)
2017-11-17 17:46:13 +01:00
Alberto Griggio
1467b858c5
fixed missing memory deallocation
2017-11-17 15:34:48 +01:00
Alberto Griggio
b25bac8c53
improved performance of Fattal in dcrop
...
Now only Fattal works on the full image, the rest of the pipeline (including denoising) always operates only on the visible crop
2017-11-17 15:27:56 +01:00
Alberto Griggio
619b3e9c63
fixed off-by-one error leading to segfault
2017-11-16 17:35:21 +01:00
Alberto Griggio
2cdc5fc69a
move Fattal before transform
2017-11-11 16:18:38 +01:00
Alberto Griggio
4d010f8dec
do use a temporary image for Fattal in dcrop when it is needed
...
Because, sometimes it is needed indeed...
2017-11-07 10:31:03 +01:00
Alberto Griggio
6e17e38136
no need to use a temporary image for Fattal in dcrop
2017-11-06 23:00:52 +01:00
Alberto Griggio
f6faccc759
moved Fattal earlier in the pipeline (before rgbProc, right after distortion/perspective/ca)
2017-11-04 18:16:51 +01:00
Alberto Griggio
d418b9d01d
various fixes to Fattal, and moved it later in the pipeline
2017-11-03 14:58:27 +01:00
heckflosse
d5ceb850f3
Make compilation unit rtengine/rawimagesource.cc -Wextra clean, #4155
2017-10-22 13:43:28 +02:00
heckflosse
04cdcca26c
Make compilation unit rtengine/improcfun.cc -Wextra clean, #4155
2017-10-21 21:26:07 +02:00
heckflosse
06f07820bd
Make compilation unit rtengine/ipwavelet.cc -Wextra clean, #4155
2017-10-21 19:52:41 +02:00
heckflosse
9e812bb25b
Make compilation unit rtengine/FTblockDN.cc -Wextra clean
2017-10-21 17:43:02 +02:00
heckflosse
818200522a
Fix some inconsistencies in Profiled Lens Correction gui
2017-09-15 20:11:49 +02:00
Alberto Griggio
c2960caab5
some (minor) code cleanup
2017-09-13 15:06:47 +02:00
Alberto Griggio
dde94bc6d3
added basic integration of lensfun
...
so far only distortion correction, and no GUI yet
2017-09-07 00:53:03 +02:00
Alberto Griggio
b4d3caf9c6
changed signature of ImProcFunctions::transform to take as input an ImageMetaData pointer
2017-09-06 00:15:41 +02:00
Desmis
0bb824e2c1
Other changes for Elle
2017-08-14 08:21:35 +02:00
Desmis
be82e1bde2
Some changes requested by Elle
2017-08-13 13:07:39 +02:00
Desmis
49d61d5209
Small changes + mode double
2017-08-11 08:21:38 +02:00
Desmis
0ffbc5251e
Add CAT02 viewing conditions
2017-08-10 14:20:00 +02:00
Hombre57
c6b16bc031
Making the preview more accurate with "Use CIECam for EPD" ( #2233 )
2017-07-23 18:47:32 +02:00
Hombre57
36fe0f800f
Ehnance preview accuracy of Tone Mapping (EPD) tool (issue #2233 )
2017-07-19 02:14:40 +02:00
Alberto Griggio
0ecb02afdd
Merge pull request #3916 from Beep6581/lcp-distortion-alt-match
...
Lcp distortion alt match
2017-06-26 23:37:14 +02:00
Alberto Griggio
b39529f7c0
LCP: new experimental logic for finding the correct distortion coefficients
2017-06-05 14:21:52 +02:00
Flössie
051670160b
Some fixes as hinted by Coverity ( #3558 )
2017-06-05 10:58:14 +02:00
Alberto Griggio
3464c0ec92
fixed glitch in handling crop windows at the edges of the image when LCP distortion correction is enabled
2017-04-08 19:58:32 +02:00
Alberto Griggio
73e14702dd
fix out-of-bounds access to crop when lcp distortion correction is enabled
2017-04-08 10:13:53 +02:00
heckflosse
86ccc4b968
rtengine/dcrop.cc
2017-03-31 19:50:27 +02:00
Alberto Griggio
dc4b62e253
fix bug in preview when LCP distortion correction is on and the image is flipped
...
Candidate fix for #3778
2017-03-26 19:20:36 +02:00
Alberto Griggio
4bf70b72e8
fixed zooming and rendering of the preview window when a LCP profile with distortion correction is active
...
fixes #3765
2017-03-18 17:14:45 +01:00
Flössie
e9b5f42a9f
Sanitize ImageDimensions
base class
...
- Make `width` and `height` private
- Drop `getW()` and `getH()`
- Clean `PreviewProps`
2017-02-14 21:23:54 +01:00
Flössie
5202f45137
Protect all Crop
accesses with cropMutex
( fixes #3306 )
2017-02-10 20:06:35 +01:00
heckflosse
3cc8438cf9
CbDL before black and white no preview when changing exposure, fixes #3539
2016-12-14 14:39:20 +01:00
heckflosse
053b305d89
Tone curve histogram ignores DCP tone curve, fixes #3512
2016-11-23 17:23:25 +01:00
heckflosse
fca99676b6
Fix a bug I introduced some commits ago. Fixes #3476
2016-10-22 18:29:53 +02:00
heckflosse
8cad2f8863
CbDL badly interacts with Graduated and Vignetting Filter if CbDL is set to 'before Black-and-White', fixes #3473
2016-10-21 00:41:27 +02:00
Flössie
0bbc84b2af
Merge branch 'master' into clang-tidy
2016-10-18 17:48:50 +02:00
heckflosse
ed42b1239c
Merge cppckeck2 branch into master
2016-10-16 22:13:13 +02:00
Hombre
50165dab20
Merge branch 'master' into softproofing
2016-10-16 01:45:52 +02:00
heckflosse
3625643392
Cppcheck: Fixed bug from last commit. Also added some new fixes
2016-10-13 17:37:08 +02:00
Flössie
0731975ff0
Apply modernize-use-nullptr
...
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
Hombre
23011fbd63
Merge branch 'master' into softproofing
2016-10-04 00:04:57 +02:00
heckflosse
01048ee513
Cppcheck: Fixed all issues in rtengine/ alignedbuffer.h, colortemp.cc, dcrop.cc, simpleprocess.cc
2016-10-03 21:17:27 +02:00
heckflosse
f9f593d343
Cppcheck: Fix issues related to rtengine/FTblockDN.cc
2016-10-02 15:09:26 +02:00
heckflosse
ef83e6b591
Removed StopWatches and corrected some bugs from latest commit
2016-09-07 23:34:06 +02:00
heckflosse
0f21a0de6c
Speedups for denoise, fixes #3418
2016-09-07 16:44:16 +02:00
Hombre
a1981dbd4d
Merge branch 'master' into softproofing
2016-08-27 23:52:53 +02:00
Hombre
5affa18341
Introducting soft-proofing and Black Point Compensation, simplify the
...
CMM at the end of the pipeline + sparse code refactoring
A new BPC checkbutton has been created in 'Preferences/Color Management'
and in the ICM tool. Better hanbling of widget sensitivity of the output
profile / gamma part of the ICM tool.
2016-08-24 22:32:06 +02:00