Commit Graph

4734 Commits

Author SHA1 Message Date
Desmis
3ad786745c LA - Move colortoning labgrid from rgb to lab - issue #6132 (#6173)
* Move colortoning labgrid from rgb to lab

* Remove unnecessary variables
2021-03-23 16:59:54 +01:00
Thanatomanic
ca5a9a26de Initial support for Fujifilm X-E4 in camconst.json 2021-03-22 13:26:25 +01:00
Desmis
d90f663f83 Second forgotten nlmeans size Rt-spot 2021-03-21 20:55:35 +01:00
Desmis
88a7a7ecc7 LA nlmeans remove limitation spot size - issue 6087 2021-03-21 10:03:27 +01:00
Desmis
7224412b69 Local adjustments - Nlmeans - Fixed smears image borders issue 6171 (#6172)
* Fixed ? smears image borders issue 6171

* Increase effect for borders

* Fixed smears image border nlmeans - thanks to Lawrence37
2021-03-19 08:45:56 +01:00
Desmis
c0e67b64c8 Fixed crash wavelet edge sharpness in some cases 2021-03-18 09:40:34 +01:00
Adam Reichold
fae40a137a A few more minor fixes geared towards lgtm.com alerts (#6127)
* Remove unfilled formatting placeholders in KLT parser.
* Fix presumably unintentionally missing reference on PlanatPtr and ChunkyPtr call operators.
* Fix catching pointer and make use-after-free of workimg easier to spot.
Make sure all of our thrown exceptions derive from std::exception and then catch
by reference instead of by pointer.
* Fix mismatch between array form new and non-array form delete.
* Simplify memory management of embedded color profiles by unifying allocation to use operator new.
2021-03-17 08:37:19 +01:00
Desmis
537fa73d3f Local adjustments - Log encoding - Ciecam16 ContrastJ - contrastQ - contrast threshold (#6169)
* Added contrast threshold Log encoding

* Improve contrast threshold

* Chanhe tooltip

* Change sign threshold when contrast negative

* Another change threshold with contrast Q and J
2021-03-15 07:57:25 +01:00
Desmis
227ae487d4 LA and Shadows-Highlight main - change location shadows-highlight in Lab issue 6163 (#6164)
* Change location shadows-highlight in Lab

* Suppress unused variable

* Small change in improccoordinator.cc
2021-03-13 07:17:42 +01:00
Desmis
0170305906 Local contrast - Try to solve bug issue #6132 (#6134)
* Try to solve bug issue 6132

* Refine placement localcontrast in pipeline
2021-03-08 08:29:57 +01:00
Lawrence Lee
7e436a44d6 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into spot-removal-tool 2021-03-06 16:41:40 -08:00
Desmis
0bf7c4e56c Local adjustments - Added Guidedfilter to avoid color shift (#6149)
* Added Guidedfilter to avoid color shift

* Various improvment to avoid color shift

* Small change to mint maxt

* local adjustments avoid color shift: reduce memory usage by width * height * 8 byte if Soft Radius > 0

* Remove StopWatch

* local adjustments avoid color shift: speedup for last loop

* cleanups

* one more cleanup

* Added checkbox Munsell correction only - uniform perceptual lab

* Refine some settings

* Clean-up - other small refinement

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-03-03 18:49:55 +01:00
Ingo Weyrich
2366cb4935 raw crop for Leica SL2-S 2021-03-01 18:30:40 +01:00
Stefan Wunsch
68a6e02369 Fix some cmake build system issues (#6147)
* [cmake] Switch to find_package for TIFF
- Included in cmake 3.5 and later
- Provides better configuration messages
* Add missing TIFF library to rtgui and rtexif
* Removed unnecessary quotes so that cmake sees the list as a list
* Add OpenMP to rtengine if OpenMP is enabled
2021-03-01 16:40:54 +01:00
Ingo Weyrich
cf21bd87d5 Merge pull request #6145 from Beep6581/issue_6143
speedup for a loop in wavelet code, fixes #6143
2021-03-01 16:28:29 +01:00
Ingo Weyrich
045bc1cd9a Cleanup and removed stopwatch, #6143 2021-02-28 14:16:20 +01:00
Desmis
d8515da4dd LA - Disable default avoid color shift - change needHH to true 2021-02-28 13:38:20 +01:00
Ingo Weyrich
1f9a8b69a2 Clarify expression by adding parentheses, #6143 2021-02-28 11:14:56 +01:00
Ingo Weyrich
966cbfe276 speedup for a loop in wavelet code , #6143 2021-02-28 10:40:59 +01:00
Ingo Weyrich
7a4ad241a2 Merge pull request #6138 from Beep6581/issue_6137
Speedup for wavelets/final touchup/local contrast
2021-02-27 17:18:52 +01:00
Desmis
b58f643d59 Local adjustments - Grain - various improvment - see issue #2460 (#6120)
* Fixed bad behavior saturation issue 6117

* Reenable scalegr for grain

* some changes to grain

* Init lagrain

* Various improvment GUI - gamma

* Change basic - normal grain
2021-02-27 08:13:44 +01:00
Thanatomanic
8d32d59b33 Basic color support for Canon EOS 2000D in camconst.json
Fixes #5495, but improvement possible
2021-02-27 07:49:57 +01:00
Ingo Weyrich
84d463fbb9 Segfault in wavelet/denoise, fixes #6140 2021-02-26 17:18:45 +01:00
Ingo Weyrich
4f880b346a add a cppcheck-suppress 2021-02-26 14:19:52 +01:00
Ingo Weyrich
fb72b6c626 Keep original code, Optimizer will catch that 2021-02-26 13:47:08 +01:00
Ingo Weyrich
d3c536b0d8 Fix clang build 2021-02-26 13:01:02 +01:00
Ingo Weyrich
d7327e8b05 left original code in comments 2021-02-26 12:41:23 +01:00
Ingo Weyrich
10e0ab4eaa Speedup final touchup local contrast 2021-02-25 23:10:37 +01:00
Ingo Weyrich
9ba266c21f added some stopwatches 2021-02-25 22:44:50 +01:00
luz paz
fe795b419c Fix various source comment typos
Found via `codespell -q 3 -S ./rtdata/languages -L ba,bord,childs,hist,fo,reall,bloc,alph,dof,inout,thre,makro,chang,currentry,preserv,portugues,struc,trough,vektor,`
2021-02-25 09:49:27 -05:00
Ingo Weyrich
f727477710 Make some more files cppcheck clean (#6133)
* Make some more files cppcheck clean

* revert change of dcrop.cc from last commit

* Replace calculation: y = pow(x, 1/ (2.f * 2.f)) by y = sqrt(sqrt(x))

* Revert "Replace calculation: y = pow(x, 1/ (2.f * 2.f)) by y = sqrt(sqrt(x))"

This reverts commit d639c67249f1723fa9f9e55e0442afcb862eba91.
2021-02-24 22:39:23 +01:00
Ingo Weyrich
7a2463a81a make improcfun.cc cppcheck and -Wextra clean (#6128)
* make improcfun.cc cppcheck clean

* improcfun.cc: add -Wdouble-promotion to stay clean about this warning in future, because we are clean about it atm

* improcfun.cc: some cleanups, now this file is -Wextra clean. Let's keep it clean...

* improcfun.cc : Fix LGTM alert
2021-02-23 23:06:51 +01:00
Adam Reichold
fc23c0fbfa Fix GCC warning about comparing signed and unsigned integers. 2021-02-22 18:40:38 +01:00
Ingo Weyrich
c5a6c9fb3d make iplocallab.cc cppcheck and also -Wdouble-promotion clean #6119 (#6122)
* iplocallab.cc: some cppcheck fixes, also some cleanups and speedups, #6119

* iplocallab.cc: fix remainig cppcheck issues. Now this file is cppcheck clean, #6119

* make iplocallab.cc -Wdouble-promotion clean, #6119

* Fix compilatio issue

* Fix compilation issue
2021-02-22 12:03:53 +01:00
Ingo Weyrich
24df5166f2 assume SAMPLEFORMAT_UINT for tiff files when SAMPLEFORMAT_VOID is set 2021-02-21 13:32:16 +01:00
Desmis
9e159deb01 Local adjustments - Blur and noise radius > 1.5 increase saturation issue #6117 (#6118)
* Fixed bad behavior saturation issue 6117

* Reenable scalegr for grain

* Add forgotten brackets
2021-02-19 13:06:34 +01:00
Thanatomanic
de15da1d59 Fix new color propagation method (#6109)
* Fixed artifacts thanks to Alberto

* Added blur to Color propagation

* Clean format code - small improvments

* color propagation: Enable old mode at blur = 0

* Improve GUI

* color propagation: smooth progress bar for blur > 0

* change label

* Some cleanups

* color propagation: small speedup for blur > 0

* color propagation: speedup for blur > 0 when region with clipped highlights is small

* Speed-up for blur=1 - clean GUI code

* color propagation: cleanups

* Harmonize events in tonecurve.cc

* tonecurve.cc : cleanup

* Highlight reconstruction: small changes to gui

* Use Gtk::Box instead of Gtk::VBox

* Change maximum number of blur levels to 4

* Suppress BENCHFUN

* Suppress bad commit locallabtools

Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-18 13:36:54 +01:00
Ingo Weyrich
c3df0b1d86 LUT.h : fix cppcheck warnings 2021-02-14 17:48:10 +01:00
Ingo Weyrich
6454737d0c Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into dev 2021-02-09 12:39:07 +01:00
Ingo Weyrich
b7b5d48d2f Automatic distortion correction crashes on particular image, fixes #6104 2021-02-09 12:38:39 +01:00
Desmis
9b0bbdd276 Local adjustments - Neutralize process after LA when when the user uses preview deltaE (#6099)
* Add others methods RGB process - to preview dE

* added others process to neutralize preview dE

* Added others process to neutralize preview dE

* Change scope placement for all tools
2021-02-09 07:31:54 +01:00
Ingo Weyrich
e586f1b53e Fix broken PENTAX *ist D decoding 2021-02-08 14:37:50 +01:00
Desmis
d369efb045 Local adjustments - Placement of LA in the processing order - issue #6069 (#6080)
* LA change location in pipeline

* Improvment to events

* Second improvment events

* Another change events

* Change all events TRANSFORM to HDR

* Change in Log encoding for exposure now after

* Small change in Log encoding for calculation Black Ev and White Ev

* Change events for log encoding

* Add M_INIT | M_LINDENOISE | M_HDR to dcrop.cc

* Avoid unnecessary convertion from rgb to lab and back if local adjustments are not used, #6069

* Tooltip preview dE - disabled when BW

* Fixed issue 6092 - preview dE when BW is enabled

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-07 07:47:30 +01:00
Desmis
6ad419f189 Local adjustments - Denoise - improvments with Non Local means issue #6087 (#6091)
* Improvment to denoise

* Initialize nlmeans - thanks to Alberto and Ingo

* Added 2 sliders max_patch and max_radius

* Added Frame Non-local means

* Improve GUI and tooltips - french

* Change dfault detail - and comment code

* Change label

* Adapt English tooltip

* Change GUI for NLmeans

* Change order GUI denoise

* Some changes to enable DCT - labels and tooltips

* French labels tooltip

* Change order combobox mode denoise - labels - tooltips

* Change tooltip Denoise based on luminance mask

* Change a tooltip

* Removes unnecessary code

* Nlmeans add gamma to preserve structure or reinforce denoise

* Change gamma tooltip

* Change tooltip Recovery denoise

* Disabled nlmeans if skip > 5

* Change tooltip - size limit spot Nlmeans 150-150

* Change gamma Nlmeans

* Supress display console

* Speedup for gammalog and igammalog, #6087

* SSE code for (i)gammalog, #6087

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-05 16:24:43 +01:00
Ingo Weyrich
cce2f5053e Colour propagation: reduce memory usage 2021-02-02 17:53:27 +01:00
Ingo Weyrich
7a0d2dddc9 Fix flat field correction for multiframe raw files 2021-01-31 14:09:41 +01:00
Desmis
6b1e5d6181 Ciecam - Take into account issue #6022 choice between classic - symmetric - mixed - for cat02/16 (#6079)
* Change mode cat02-16 auto

* Change tooltip
2021-01-30 07:35:07 +01:00
Desmis
727c9557b4 Local adjustments - Mask - Change behavior Laplacian (#6075)
* Change Laplacian action in mask

* Change tooltip Laplace
2021-01-28 07:32:07 +01:00
Desmis
a5280fddf5 Local adjustments - Enable Disable spot with Denoise 2021-01-26 08:10:19 +01:00
Ingo Weyrich
84cfedd2a2 rcd: fix border issue 2021-01-24 11:26:04 +01:00