Commit Graph

3986 Commits

Author SHA1 Message Date
Lawrence Lee
80944d6c9b Change look of favorites preferences
Set column widths based on DPI and font size in pseudo-HiDPI mode. Move
favorites buttons to left side of list.
2021-12-10 22:24:18 -08:00
Lawrence Lee
f8a1deb371 Add option to clone favorite tools
If cloning is enabled, favorite tools will appear in the favorites panel
and in the original location.
2021-12-09 21:27:39 -08:00
Lawrence Lee
acda4da226 Fix favorites panel not being added
Favorites panel would not show after adding tools to the favorites panel
if the program started with no favorites.
2021-12-05 18:07:10 -08:00
Lawrence Lee
778b26d5bd Make tool locations dynamic
Update tool locations after changing favorite tools preferences.
2021-12-05 17:21:46 -08:00
Lawrence Lee
8bd7712cce Add error handling to tool location preferences 2021-11-26 21:34:19 -08:00
Lawrence Lee
9a67dd726e Comment code for tool location preferences 2021-11-26 21:01:37 -08:00
Lawrence Lee
16a9e3932f Fix compilation error
Add hasher to unordered_map with an enum class key.
2021-11-26 16:39:50 -08:00
Lawrence Lee
4fe39a82a5 Add buttons for reordering favorites 2021-11-26 15:46:24 -08:00
Lawrence Lee
fde15eaebb Improve look of favorites preferences
Set a fixed width for the lists, embed the preferences in a
horizontally-scrollable window, and open the preferences window on the
general tab.
2021-11-25 15:35:02 -08:00
Lawrence Lee
c6a45ae765 Move helper functions into anonymous namespace
Move some functions in toollocationpref.cc.
2021-11-25 14:58:42 -08:00
Flössie
ac19ea4507 Fix enum class key in hashed containers 2021-11-24 15:32:04 +01:00
Lawrence Lee
23214ae5cd Clean up code
Fix compile warning, remove GTK functions not present in version 3.16,
and make code more concise.
2021-11-22 21:38:14 -08:00
Lawrence Lee
0f894656a0 Add favorites customizer to preferences UI 2021-11-21 17:47:41 -08:00
Desmis
a1bbede061 Fixed missing entries history msg wavelet issue 6381 2021-11-12 17:24:28 +01:00
Ingo Weyrich
e4ee63850d Add an average filter for pixel shift to process the moving parts, closes #6376 (#6380) 2021-11-10 17:54:57 +01:00
Lawrence Lee
732316dcaf Fix initial generation of external editor icons
In Windows, escape backslashes and quotes in the serialized GVariants of
the icons.
2021-10-05 21:49:42 -07:00
Ingo Weyrich
d053f02450 Do not explicit enable white balance when switching method, fixes #6365 2021-09-19 12:29:09 +02:00
Lawrence37
5268b94cfd Merge pull request #6302 from Beep6581/spot-rename
Update spot name in history after rename
2021-09-04 12:00:12 -07:00
Desmis
9b26424c3a Set default to brightness in some cases 2021-09-03 10:34:31 +02:00
Desmis
0991b0a380 Ciecam - re enable - curve brightness (#6350)
* Re enable curve ciecam brighness

* Change default tone curve2 to Brightness
2021-09-03 07:51:31 +02:00
Lawrence Lee
0db17f99dd Fix crash while updating RGB parade and waveform
Closes #6349.
2021-09-02 21:52:59 -07:00
Desmis
ba2985a44c Enable checkbutton preferences - ciecam artifacts (#6347) 2021-08-29 07:39:01 +02:00
Lawrence Lee
d897116507 Change Locallab tool members from pointers to obj.
Ensures the LocallabTools are destructed when Locallab is.
2021-08-27 22:17:41 -07:00
Ingo Weyrich
8bd9bddfc7 New crop guide: square center, closes #6342 (#6345)
* New crop guide: square center, closes #6342

* Turn `CropParams::guide` into an `enum`

This saves recurring string comparisons.

Co-authored-by: Flössie <floessie.mail@gmail.com>
2021-08-25 15:25:59 +02:00
Desmis
b528d67910 Disabled in advanced mode tonecurves brightness 2021-08-23 10:51:53 +02:00
Lawrence Lee
8cb89688a7 Fix CIECAM scene temperature changing unexpectedly
The temperature was unexpectedly changing to 5003 when changing other
settings such as wavelets.

Closes #6326.
2021-08-22 17:07:52 -07:00
Lawrence Lee
d3b67c1e22 Fix empty dialog messages
Escape ampersands and angle brackets in some Gtk::MessageDialogs.
Closes #6306.
2021-08-15 12:23:29 -07:00
Lawrence Lee
672d6302f3 Fix storage of external editor icons
De-serialize and serialize icons instead of using their names.
2021-08-14 17:11:07 -07:00
Lawrence Lee
d3e524a491 Fix crash when adding an external editor
On some platforms, the app chooser dialog causes a crash after selecting
an application. The application information returned by the dialog may
also trigger crashes when accessed. See
https://gitlab.gnome.org/GNOME/glib/-/issues/1104 and
https://gitlab.gnome.org/GNOME/glibmm/-/issues/94. This commit overrides
gtkmm's app chooser dialog to work around these bugs.
2021-08-14 16:05:11 -07:00
Lawrence Lee
9423ebc97c Fix crash when changing external editors
Initialize a pointer to nullptr.
2021-08-14 11:32:25 -07:00
luzpaz
22f89bc752 Fix various typos (#6332)
* Fix various typos

Found via `codespell -q 3 -S ./rtdata/languages -L ba,bord,childs,hist,fo,reall,bloc,alph,dof,inout,thre,makro,chang,currentry,preserv,portugues,struc,trough,vektor`

* Fix source typo

* Added requested revisions
2021-08-13 14:37:29 +02:00
Benitoite
b1e7860a23 mac: update of macosx_bundle.sh (#5786)
Various changes to improve compilation of RT on macOS thanks to @Benitoite and @Pandagrapher 
* mac: use sed -i.bak, add X's to mktemp template in macosx_bundle.sh
* mac: test lensfun version in macosx_bundle.sh to select correct lensfun database version (version_1 for 3.2 and version_2 for 3.95)
* mac: remove DYLD_FALLBACK_LIBRARY_PATH from main Info.plist
* mac: removes some -cli codesigning commands
* mac: remove erroneous newlines in macosx_bundle.sh and suppress superfluous codesigning of Contents/Frameworks/*dylib
* mac: Apple arm64/homebrew compatibility update
* mac: CMakeLists.txt arm64 homebrew compatibility
* mac: add Apple arm64 CPU native flag
* mac: fix pixbuf query syntax
* mac: adapt. of Pandagrapher's patch
* mac: additional instructions for the -cli exec.
* mac: revert target 10
* mac: remove legacy environment variable Per https://github.com/Beep6581/RawTherapee/pull/5786#issuecomment-792276656
* mac: fix destination of credits/license
* mac: copy {LOCAL_PREFIX}/share/locale to bundle
* mac: fixes a path for the License
* mac: fix of UpdateInfo command structure
* mac: remove redundant copying
* mac: use cmake to configure Info.plist values
* mac: configurator for Info.plist version values
* mac: fix locale detection / language
* mac: remove an outdated key from Info.plist
* mac: fix path usage for gtk.immodules / locale dir
* mac: revert a change merged elsewhere
* mac: follow more symlinks for 'brew builds
* mac: link to CoreFoundation for locale detection
* mac: link CoreFoundation for locale / C
* mac: detect locale with CoreFoundation per https://github.com/Beep6581/RawTherapee/pull/5786#issuecomment-798926898
* mac: remove outdated lines
* Update multilangmgr.cc
* mac: Info.plist language fixes (Pandagrapher) https://github.com/Beep6581/RawTherapee/pull/5786#issuecomment-813004475
* Mac: also package libpng12 for homebrew compatibility.
* macOS packaging and language updates
2021-08-09 07:11:09 +02:00
Thanatomanic
6be177d4de Merge pull request #6317 from Bezierr/ha-profileload-dev
Resize tool values not computed when profile is loaded
2021-08-08 21:00:46 +02:00
rom9
94b5f7232f Ignored ParamsEdited information when doing a partial profile save.
The user-selected params will get saved, overriding any ParamsEdited
filtering.
Fixes #6303
2021-07-27 21:18:08 +02:00
Bezierr
61dcb5113c Merge branch 'ha-profileload-5.8' into ha-profileload-dev 2021-07-27 16:39:33 +02:00
Bezierr
7d02d77fc1 Update resize.cc
Fixes the issue that values in Resize-GUI are not recomputed when loading profile.
E.g. loaded from profile are Specify: width, value for width, value for height => loaded value for height was displayed even if  not corresponding to width for this picture's dimensions.
2021-07-27 14:10:18 +02:00
Lawrence Lee
db7d56c253 Synchronize send to external editor buttons
Keep all buttons updated when using a multiple editor tabs mode.
2021-07-25 17:45:20 -07:00
Lawrence Lee
a0711ebc8c Fix tmp image reuse when exporting different image
If two images have identical processing parameters, then sending one to
an external editor followed by sending the other one will cause the
first temporary image to be reused. This commit associates the image in
the editor with the "cached" temporary image so that the temporary image
only gets used if the editor image matches.
2021-07-25 16:03:13 -07:00
Lawrence Lee
c4a8554db3 Catch exceptions when launching external editor
Catch all Glib::Errors and print the error code and message to stderr.
2021-07-11 22:13:27 -07:00
Lawrence Lee
02e3e01294 Use correct GIMP and Photoshop icons for Windows
Icon names in Windows are typically the executable path followed by the
string ",0".
2021-07-11 21:45:39 -07:00
Lawrence Lee
c625975453 Surround Windows commands in quotes
When external editors are launched in Windows OS, the command is
surrounded by quotes. This commit fixes the translation of commands for
use by the multiple custom external editors feature so that the
translated commands are also surrounded by quotes.
2021-07-11 21:38:52 -07:00
Lawrence Lee
5a49ea7b8c Get locallab spot name from one source
Fixes #6298.
2021-07-10 09:52:18 -07:00
Lawrence Lee
4044f67c0f Align External Editor > Output directory to top
Prevents the frame from expanding vertically.
2021-07-05 11:01:51 -07:00
Flössie
64382928c1 Fix -Wodr in GCC LTO builds
I've tested GCC 10 and 11, which exhibit the problem, and 8, which
doesn't.
2021-07-05 13:06:33 +02:00
Desmis
7d8c876fd3 Abstract profile fixed crash when by=0.5 and all sliders to minimum 2021-07-04 13:17:08 +02:00
Flössie
b6449bfd5f Escape HTML chars in camera/lens name in quick info box (fixes #6294) 2021-06-30 09:18:06 +02:00
Lawrence Lee
72fe8d6049 Merge dev into multi-external-editor 2021-06-28 22:03:14 -07:00
Ingo Weyrich
4ab54c9fda Crash when moving crop window using SHIFT+Mouse, fixes #6290 2021-06-24 12:01:18 +02:00
Desmis
3cf3562505 LA small change GUI vibrance 2021-06-23 13:49:53 +02:00
Pandagrapher
491b57bee7 Improves RT window position management, fixes #6233 (#6239)
* Improves RT window events detection and RT window position computation

* Fixes some limitations in specific cases for Windows and MacOS

* Fixes RT window not restoring saved position at startup

- When maximized at startup, RT window position wasn't restored from
options file. So when unmaximazing RT, position was set to up left
corner instead of restored one
- Other fix: Removed some uses of deprecated Gtk functions

* Improves RT window management for independant edit window mode

Other fixes:
- Monitor ID wasn't correctly computed
- Removes some other deprecated functions uses
- Removes debug printf

* Fixes editor window aspects not restored in MEOW mode on Linux

Other fixes:
- Removes some Gtk warnings when adding a new editor panel in MEOW mode
- Adds robustness to avoid RT windows outside screen at startup loading
corrupted options file with negative position values

* Fixes incorrect max position saturation in dual screen configurations
2021-06-21 21:22:14 +02:00