Commit Graph

11902 Commits

Author SHA1 Message Date
U-PCSPECIALIST01\jdesm
23408bfcb3 Local adjustments denoise - Removes the need to have luminance denoise curve activates to activate Nlmeans 2023-02-23 09:18:48 +01:00
Lawrence Lee
006a7d9975 Fix CodeQL alert 2023-02-18 18:16:12 -08:00
Lawrence Lee
1bacb8b5b0 Add Exiv2 to GitHub Actions workflows 2023-02-18 16:42:26 -08:00
Matei George-Daniel
887cf99665 make dpfa lines mark safer 2023-02-18 19:58:59 +02:00
Floessie
9533d8acbd Merge pull request #6686 from din99dany/georgem_6663_fix_before_and_after_crash
RT crush when using before/after + abstruct Profile #6663
2023-02-18 10:38:03 +01:00
Matei George-Daniel
01441ccb4b initialize pointer variable with null 2023-02-18 02:55:15 +02:00
U-PCSPECIALIST01\jdesm
d5aae723b8 Fixed the same Observer for general and Itcwb 2023-02-16 11:10:18 +01:00
Lawrence Lee
e3c7fd42e9 Merge branch 'dev' into metadata-exiv2 2023-02-15 22:28:18 -08:00
Lawrence Lee
8704c1dd86 Add bound check
Thanks to Floessie
(https://github.com/Beep6581/RawTherapee/pull/5889#discussion_r622755925)
2023-02-15 21:34:03 -08:00
Lawrence37
bfe6e0fb85 Merge pull request #6631 from Lawrence37/metadata-exiv2
Exiv2 updates
2023-02-14 21:38:58 -08:00
Lawrence Lee
a329e423ec Remove outdated comments about ratings 2023-02-12 18:19:28 -08:00
Lawrence Lee
cac76c18c0 Re-introduce UTF-8 validation for EXIF panel 2023-02-12 17:47:07 -08:00
Lawrence Lee
cf545abc87 Read serial number with Exiv2 2023-02-12 17:10:00 -08:00
Lawrence Lee
9c6dac5f25 Remove outdated comments
Validation of metadata is still needed for #5923.
2023-02-11 18:06:20 -08:00
Lawrence Lee
e590429786 Remove outdated comment
Issue #5787 in the Exiv2 branch is handled by commit 522f6f4.
2023-02-11 17:51:43 -08:00
U-PCSPECIALIST01\jdesm
8047aded3b remove BENCHFUN for inpaint-opposed color-propagation Itcwb 2023-02-09 16:15:42 +01:00
Desmis
e5d46032ff Add "Inpaint opposed" to Highlight reconstruction and improved Itcwb (#6635)
* Essai HL

* Try Inpaint opposed

* Code improvment

* Add file

* Improvment to process inpaint opposed  and color propagation

* Clean code

* Change Blend to Coloropp in Profile pp3

* Enable BENCHFUN hilite_recon

* Clean rtengine cmakelist

* Comment unused code

* Neutralise unused code

* Change bad Exposure in Pop2Lab.pp3

* Try to fix bug when Inpaint Opposed is used and White balance disabled

* Changes to refreshmap

* Change to improccoordinator M_RETINEX

* Clean unused commented code

* Force Inpaint-opposed in rawimagesouce if wb change

* Suppressed message in console

* Change events and limits to 1 the number of calls to inpaint-opposed

* Comment code

* Add gain theshold to inpaint opposed

* fixed typo in procparams.cc

* Change in option.cc itcwb_sort to true

* Change itcw sorted in options and rawimagesource.cc

* Change sampling read datas Itcwb

* Allow or not purple in WB itcwb

* Added option icwb.nopurple to bypass settings

* Added code comment Itcwb

* optimize Itcwb between green and student

* Formated code used by Itcwb with Astylert.bat

* Change color_match - thanks to Lawrence37

* Remove wrong text
2023-02-09 07:14:20 +01:00
Lawrence Lee
12ef477a6d Fix merge issues
Adapt tone equalizer to favorites tab changes.
2023-02-06 21:44:57 -08:00
U-PCSPECIALIST01\jdesm
a3adbce04b Support for Nikon Z9 2023-02-06 19:00:14 +01:00
Lawrence Lee
f236a7edb7 Merge branch 'dev' into tone-equalizer 2023-02-05 18:39:23 -08:00
Lawrence37
a4b44b8dfb Merge pull request #6383 from Beep6581/favorites-gui
Favorites preferences
2023-02-05 18:28:17 -08:00
Lawrence Lee
b8d25d542a Fix crash reading Pentax metadata 2023-02-05 17:46:13 -08:00
Alberto Griggio
0421a0acfa fixed bug in handling raw border
Fixes 189

(cherry picked from commit 10df3c06c37a4eb6f38aae2f4a711798af0c4884)
2023-02-05 17:41:08 -08:00
Lawrence Lee
3833c6e634 Merge branch 'dev' into metadata-exiv2 2023-02-05 12:29:58 -08:00
Lawrence Lee
2982f02328 Merge branch 'dev' into favorites-gui 2023-02-03 21:58:34 -08:00
Benitoite
ba11a9355a mac: fixes lensfun logic
Fixes use of the v1 lensfun interface for v0.3.3, v0.3.4-RC1, etc.
2023-01-31 23:42:36 -08:00
Desmis
9a245c1acb Avoid Color shift - Gamut and Munsell Review in RT - branch Munsellgamut (#6673)
* Fixed numerous problems with gamut and Munsell in Local adjustments

* change gamut-munsell in lab adjustmnts - gamut in ciecam

* Improve XYZ colorimetry and tooltip

* Change event - format code - change labels tooltips

* Removed avoid_ and avoidmun_

* Removed avoidcolorshift in labcurve

* Push change proposed by Lawrence37 - compatibility with old pp3
2023-01-31 12:32:31 +01:00
Lawrence37
ef7676826e Merge pull request #6661 from Beep6581/external-editor-fixes
External editor fixes for Windows
2023-01-26 21:37:14 -08:00
Lawrence37
b1490e24c7 Fix Windows build libsharpyuv-0.dll error (#6672) 2023-01-26 14:03:37 +01:00
Floessie
f49d10c603 Merge pull request #6670 from mattiaverga/gcc13
Add missing include for GCC13 compatibility
2023-01-26 08:33:17 +01:00
Mattia Verga
311f3422fd Add missing include for GCC13 compatibility
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
2023-01-25 14:16:19 +01:00
Desmis
7afdfc1e2b Abstract profile - Gamut improvment (#6665)
* Gamut control when the chosen primaries are different from working profile

* Gamut control abstract

* Gamut label and history

* Change to Wx Wz

* Fixed crash if y primaries are set to zero

* Fomated with Astylert ImProcFunctions::workingtrc and Color::primaries_to_xyz

* Fixed black becomes green wit gamt abstract profile

* Harmonize types in color.cc

* Try to fix Multiplication result converted to larger type
2023-01-24 14:29:50 +01:00
Lawrence Lee
48b1b6f9be Add OM-1 raw decoding and basic camconst entry 2023-01-17 22:06:58 -08:00
Lawrence Lee
22edf5f069 Add radio indicator to external editor selector
Make it easier to see that the selector is for changing the current
editor and not for immediately sending the image to the clicked-on
editor.
2023-01-15 15:10:54 -08:00
Lawrence Lee
194ef397a6 Fix external editor file chooser filter (Windows)
Look for files with the MIME type "application/x-msdownload", which are
Windows executable files. The Gio function for determining if a file is
executable does not work for Windows.
2023-01-08 22:17:21 -08:00
Lawrence Lee
5468e74e57 Fall back to custom external editor launcher 2023-01-08 17:20:42 -08:00
Desmis
21afbaf90b CIECAM - Changes such as symmetric works and temperature output makes sense - issue #6656 (#6658)
* changes such as symmetric works and temperature output makes sense

* Comment code

* other Comment code and small change

* Change tint in tooltip temperature

* Improve GUI for tempout and greenout
2023-01-06 06:43:21 +01:00
Desmis
95cede9a1a Color Appearance and lighting : Remove cat02preset and all dependencies issue 5664 (#6585)
* Remove cat02preset and all dependencies issue 5664

* Normalize cmakelist
2023-01-03 07:44:46 +01:00
Lawrence Lee
143e5c6783 Merge branch 'dev' into favorites-gui 2023-01-02 15:37:07 -08:00
Lawrence37
f449a726e8 Merge pull request #6299 from Beep6581/multi-external-editor
Multiple External Editors
2023-01-02 15:07:25 -08:00
Lawrence Lee
4d287b4cdf Merge branch 'dev' into multi-external-editor 2023-01-02 15:06:33 -08:00
Lawrence37
57c1822b2c Strict temporary image file permissions (#6358)
* Write temp images to private tmp directory (Linux)

The directory is in /tmp with 700 permissions.

* Reduce temp image file permissions in Linux

Set temporary image file permissions to read/write for the user only.

* Use private tmp directory for temp images in MacOS

* Use private tmp directory for temp images Windows

* Use GLib to create temporary directories

* Reuse temp directory if possible
2023-01-02 21:32:15 +01:00
Ingo Weyrich
8d29d361a8 Support dnggainmap (embedded correction) for Bayer files (#6382)
* dng gainmap support, #6379
* dng GainMap: control sensitivity of checkbox, #6379
* dng GainMap: partial paste
* dng GainMap: moved isGainMapSupported() from dcraw.h to dcraw.cc
* RawImageSource::applyDngGainMap: small speedup
* Change GUI to separate gainmap from other flat-field; also reorder checkbox

Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
2023-01-02 21:30:06 +01:00
Niklas Haas
2101b846c3 Implement file sorting in thumbnail view (#6449)
* Use mtime as fallback timestamp for files without EXIF data

As suggested in #6449, with date-based sorting it can be useful to have
at least *some* sort of time-relevant information for EXIF-less files,
to prevent them from falling back to getting sorted alphabetically all
the time.

This commit simply defaults the file timestamp to the file's mtime as
returned by g_stat. For annoying reasons, it doesn't suffice to merely
forward the timestamp to the FileData structs - we also need to keep
track of it inside FilesData to cover the case of a file with 0 frames
in it.

* Add DateTime to Thumbnail

Putting it here facilitate easier sorting without having to re-construct
the DateTime on every comparison.

To simplify things moving forwards, use the Glib::DateTime struct right
away. This struct also contains timezone information, but we don't
currently care about timezone - so just use the local timezone as the
best approximation. (Nothing currently depends on getting the timezone
right, anyway)

In addition to the above, this commit also changes the logic to allow
generating datetime strings even for files with missing EXIF (which
makes sense as a result of the previous commit allowing the use of mtime
instead).

* Implement file sorting in thumbnail view

For simplicity, I decided to only implement the attributes that I could
verily easily reach from the existing metadata exported by Thumbnail.
Ideally, I would also like to be able to sort by "last modified" but I'm
not sure of the best way to reach this from this place in the code.

It's worth pointing out that, with the current implementation, the list
will not dynamically re-sort itself until you re-select the sorting
method - even if you make changes to the files that would otherwise
affect the sorting (e.g. changing the rank while sorting by rank). One
might even call this a feature, not a bug, since it prevents thumbnails
from moving around while you're trying to re-label them. You can always
re-select "sort by ..." from the context menu to force a re-sort.

Fixes #3317

Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
2023-01-02 21:27:12 +01:00
Thanatomanic
3423a7ac55 Support for GX680 digital back including DCP (#6655)
* Initial support for GX680 digital back
With help from LibRaw for decoding support.
Estimates for color calibration are very rough...
* Small modification to black level, add DCP
2023-01-02 21:24:15 +01:00
Lawrence Lee
646065f643 Remove unused code
Remove the preferences code for selecting the external editor since it
is superseded by the multiple external editor preferences.
2023-01-01 21:22:47 -08:00
Thanatomanic
21a7c97ede Multiple crop support for ILCE-7S
Fixes #3960
2023-01-01 11:43:54 +01:00
Thanatomanic
a9b8ece335 Add raw crop for EOS R3
Fully fixes #6420
2023-01-01 11:01:48 +01:00
Lawrence37
d74524f2c5 Camconst support for multiple crops (#6473)
Adapted from ART 
Co-authored-by: Alberto Griggio <agriggio@users.noreply.github.com>

* camconst: support for multiple image sizes in raw_crop and masked_areas
* Clean up code after porting raw crop changes
* fixed raw crop for Canon R6 reduced-resolution raws
* Add Canon EOS R5 1.6 crop raw crop & masked areas
2023-01-01 10:50:11 +01:00
Nicolas Turlais
9fef79ede4 Add filter for Path to dynamic profiles (#6284)
* Path filter in dynamic profile panel
* Pass filename as a function argument
* Removed unused include
* Clearer translation
2022-12-31 10:51:59 +01:00