* Change TRC in the process
* Improve GUI slope
* Add tooltip output profile
* Various change to enable and tooltip
* Chnage rtthumbnail
* Small change tooltip trc
* Another small change tooltip
* Improve GUI - change default TRC BT709 - change tooltip
* Other GUI improvment
* Small changes to BT709 values
* Various change to TRC - add illuminant working profile
* Change labels tooltip TRC illuminant
* Display wp in console if wp provided
* Change tooltip
* Change max wlope
* Init trc + illum + primaries
* Add black point compensation
* Change location abstract
* Fixed bug with rtthumbnail...
* Added tooltip
* Logscale for wslope
* Change tooltip abstract
* Change labels tooltips abstract profile
* Added 6 sliders custom primaries X and Y
* Change GUI custom primaries
* Use custom primaries abstract profiles
* Tooltip with primaries red green blue
* Fixed warning gtk
* Change one tooltip
* Change range custom primaries
* Change GUI default Primaries
* Change one tooltip
* Speedup for trc
* Rendering intent for abstract profile
* Hide intent abstract
* Preserve neutral tones
* Chnage settings preserves neutral tones
* Improve GUI
* Improvment to preserv
* Clean code - speedup TRC when illuminant and primaries default
* Change label
* Change bad default value Blux
* Add forgoten illuminant when selecting primaries
* clean code
* Change labels
* improve workingtrc for LA
* Change default primaries when select default
* Added others working profile to primaries
* Change labels and GUI
* Change tooltip
* CIExy diagram displaying the primaries (interactive) and the white point (#6207)
* Ciexy diagram
* Change to Ciexy graph
* Change graph and defaut coordonates
* Various changes to graph - params
* Disable setListener(ToolPanelListener)
* Add some graduation to graph
* Clean comment code graph
* Change radius 0
* Enable sensitive graph Ciexy
* update Ciexy graph with primaries
* Remove reset button graph
* Change labels and behavior
* First step third spot green
* Second step 3rd spot green
* First try 3 primaries graph Ciexy
* Fixed bad behavior in lab grid
* Fixed another bad behavior graph
* Clean and comment code
* Change default gamma
* More accurate graph Cie xy
* Added white point to Ciexy graph
* Added tooltip Cie xy diagram
* Improvment when illuminant change
* Refine diagram CIE xy - added WP 2000K
* White point D120 + tooltip
* Change label
* Change labels
* Change tooltips
* Improve diagram CIE xy with parabolic
* Other parabolic to improve Cie xy diagram
* Small change GUI
* Added Label CIE xy - change labels
* Change behavior when none - change labels
* Improve gUI and trys to fix LGTM alerts
* CIE xy change set sensitive
* Improve tooltip primaries sliders
* Adapt tooltip to new labels
* Fixed crash and some bad behavior
* First fix bad behavior with some primaries
* Second fixed bad behavior primaries
* Third fixed bad behavior primaries
* Change white point BestRGB
* Change order rgb in history msg Ciexy
* Change tooltip
* Change tooltip
* Improve GUI primaries
* Illuminant 1500K - display in console matrix XYZ-RGB
* Improve GUI illuminant
* Change a tooltip
* Somme changes to GUI and verbose
* Test code for wprim in read
* clean code for wprims
* further cleanups, not tested
* Some cleanups and bugfixes, #5949
* Simplify `std::unique_ptr<>` dereferencing
Also some minor cleanups.
* Some changes suggested by Floessie
* Others change suggested
* Others changes suggested by Floessie
* Forgotten change in procparams.cc
* Added black and white for use with the primaries channel mixer
* Small change behavior GUI - illuminant
* Change pragma omp in iplab2rgb
* Add enums and clean up
* Remove unused code icmpanel.cc
* Fix LGTM alert, #5949
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Flössie <floessie.mail@gmail.com>
* Added support for non-raw files to the film negative tool. The tool is now under the "Color" tab. Moved the entire filmneg code downstream, right after input profile conversion.
Usage changes a bit: White Balance must be set to the _backlight_ color temperature. Added two more sliders to color-balance the picture after negative inversion. Legacy inversion method kept for compatibility with processing profiles saved by RT v5.7 or 5.8 (only if Film Negative was enabled). Should be removed in a future version.
There is still an issue with DCP profiles that need the look table to be active to work properly. Using a simple matrix input profile (or just camera standard) is recommended for now.
* The user can now choose to perform inversion before or after input colorspace conversion.
Seamless backwards compatibility with previous processing profiles; upgrading from a previous version now gives an (almost) identical output as before.
Generalised the concept of film base values: the processing profile now contains a pair of RGB triplets, "reference input" and "reference output", which makes it much more straightforward to compute the output multipliers.
* Added support for `RGB` data type to putToKeyFile, removed the now unused `RGB::toVector()` method. Some cleanup.
* Spot balance picker now stays active indefinitely. Can be disabled by right-clicking, too.
* Removed film negative from `filterRawRefresh` condition, since the new version does not require raw rendering anymore.
* The Output Level slider is now exponential, so it should feel more familiar to use (similar to the exposure compensation slider).
* Removed old `RedBase`, `GreenBase`, `BlueBase` keys from the PP3 file after params upgrade. Keys are only kept if the file only undergoes batch edit (hence no params upgrade was done).
* Made the balance sliders exponential and centered at zero. Now they should be a bit smoother and possibly more user-friendly.
* Changed adjusters' step to more useful values, they were too fine-grained and hard to adjust using the +/- spinbutton.
Increased max ratio value from 3 to 5, as i found an old negative needing a very high blue channel exponent.
* Added an initial processing profile for film negative inversion, to be provided as a bundled profile.
* Removed Output Level and balance sliders when in batch mode: since the effect of these sliders is dependent on the reference input values, those values needed to be copied as well. And, touching any of the sliders needed to flag all three as dirty. All this felt more confusing than useful.
It should be sufficient (and clearer) to copy/paste the params, and then fine-tune the balance on individual pictures when needed.
* Set bayer demosaic method to RCD in the bundled "Film Negative" processing profile. RCD seems to play a bit better with Capture Sharpening in the presence of film grain, compared to Amaze.
This will favor new users starting with all-defaults settings, hence having Capture Sharpening enabled by default.
* Removed incorrect "contrast" term from the "Reference exponent" label. This parameter adjusts the image _gamma_, not its contrast.
* Added new feature to calculate channel multipliers from crop area. This also saves the crop area channel medians to the processing profiles, in order to get a more consistent color balance when batch-applying the same profile to multiple pictures from the same film roll.
* Fixed wrong initialization of array, and missing check for the result of `getFilmNegativeMedians()`.
Moved `ImProcCoordinator::translateCoord()` from private member to anonymous namespace.
Fixed some whitespace and formatting issues.
* Fixed some formatting issues
* Passed `ipf` parameter as const in `translateCoord`.
Narrowed `using namespace` to single class `Coord2D`.
* Added `scaleGain` entry to thumbnail metadata file, to make `scale_mul` multipliers available in thumbnail processing phase. This simplifies multiplier calculations, so that "faking" thumbnail multipliers in the main image processing is not necessary anymore. This way, output values are immune to slight variations of multipliers between successive shots taken with in-camera AWB turned on.
Shifted multipliers so that the output channel medians are balanced when "Camera WB" is selected. This way, just computing multipliers from crop and setting "Camera WB" (which is the default) gives a pretty well balanced image as a starting point.
* New channel scaling method, based on a film base color sample instead of crop area channel medians. Channels are scaled so that the converted film base values are equal to 1/512th of the output range (65k). This giver better black levels in the output, and more consistency when batch-processing multiple negatives.
The output is now compensated for a known fixed WB value, so that the film base will appear grey when WB is set to 3500K, Green=1.
Added PPVERSION 347 to preserve backwards compatibility: when a processing profile saved by RT 5.7 is loaded (PPVERSION=346), the new fields are initialized to the special value -1, which will instruct the main processing to follow the old channel scaling behaviour. The old channel scaling multipliers will then be converted to the new film base values so that the resulting image is the same, and the fields will be overwritten as soon as the PP is saved again. This will transparently upgrade the processing profile.
When the new behaviour is used, but the film base values are still unset, they are estimated based on channel medians, excluding a 20% border around the image. This should give a better result out-of-the-box for pictures containing a large film holder.
* Code cleanup from review
* Run astyle on film neg source files
* Fixed automated build failure caused by incompatible libraries on my dev PC.
* Simplified `Thumbnail::processFilmNegative` method signature. There is no need to pass in `rmi`,`gmi`,`bmi` multipliers from the caller, i can do the same with my own internal multipliers.
* Added `FilmNegListener` class to pass estimeted film base values to the GUI after first processing. Removed old `filmBaseValues` instance variable from RawImageSource.
* Code cleanup
* Forgot to set baseValues flag in `PartialPasteDlg::applyPaste`
Fixed `filmBaseValuesLabel` not updating when reading zero baseValues. Normally not needed (the label is updated later by the listener), but when the user is browsing through pictures the listener won't fire, so the label must be updated to show values are unset.
* Overwritten channel scaling multipliers by calling `get_colorsCoeff` with `forceAutoWB=false`.
Initially, in `RawImageSource::load`, channels are auto-balanced by averaging the whole picture when computing multipliers.
This can give different multipliers for multiple shots of the same camera, which will lead to inconsistent conversions when batch-processing multiple negatives.
This commit re-sets `scale_mul`, `ref_pre_mul`, etc., in order to "undo" the auto-WB and use the normal camera multipliers.
* Found an easier way to get stable overall multipliers, removed the (horrible) on-the-fly mutation of scaling instance variables.
