Some lens profile methods provides a way to correct distortion and CA in
a single step.
When available, applying distortion and CA correction when both enabled
in a single pass is more precise (see lensfun
ApplySubpixelGeometryDistortion doc) since it's usually how the profile
is done. Instead applying the CA correction in a step after distortion
correction could lead to a bit different (also if not always visible)
correction.
This is also required for future lens correction methods (like DNG
WarpRectilinear or corrections based on vendor metadata) that provides
only merged distortion and CA correction in a single pass.
Doing profile based CA as the really first correction in a separate steps is
probably not useful.
Additionally many lens profile (lensfun) and future one provide
functions to do them in a single step with better precision while other
just provide a single step that does both (i.e. DNG WarpRectilinear).
For the above reasons this patch removes the additional pass for CA correction.
This will also improve the perfomance due to less work.
* ppversion 351 and keep valus scope for color and light shadow-highligt vibrance
* Change comment in ppversion.h
* Change procparams for colorscope pp<351
* Remove not used isset
Stream a C-string of the file name instead of the Glib::ustring. The
ustring can throw an exception with certain locale settings and file
name character combinations, such as with LANG=es_ES and the character
"ä".
Only print the message if verbose is true.
* First step LA globally
* fixed several GUI bad behavior
* better behavior shows additional settings
* Improve transition in main
* First step hide-show invers and scope
* Hide show invers and scope step2
* hide show others inverse and scope
* Try to improve
* Change windows.yml and appimage.yml
* In Preference set choice for default Spot Method
* Optimization call idle_register
* forgotten delete mainfp
* Re-enable sliders scope in colorlight - shadows - vibrance - move setting checkbox others settings
* Fixed bad behavior hide - show
* Optimize behavior
* Bad behavior scope when changing method
* Clean and comment code
* disable preview mask and modif for cbdl and retinex
* Fixed preview deltaE mask and modif log encode - exposure - new button preview color and light
* Button preview deltaE - exposure
* Button preview SH
* Button preview Vibrance
* Improce code using mask
* Fixed several bad behavior - preview TM and Contrast
* Preview log button
* Preview Ciecam button
* Preview common mask button
* Disable Preview button in settings when not used in tools
* Change call to controspotpanel in improcoordinator
* Change Local adjustments title to Selective Editing
* Change default value spotmethod in option
* Missing cddl in preview settings
* Change parameter setting spot type
* put selective editing tab just after exposure tab
* Disable preview ΔE button when another is enabled
Only one button should be active at any given time.
* Deactivate preview ΔE buttons when switching spots
* Change tooltip Spot method
* Change selective editing position
* Remove duplicate line in language default
* Remove appimage.yml windows.yml
---------
Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
