Commit Graph

3998 Commits

Author SHA1 Message Date
Lawrence Lee
7945f93e8f Merge branch 'releases' into dev 2024-02-15 23:15:50 -08:00
Desmis
8ad4ebf482 Change default behavior Local Adjustments settings Avoid Color Shift to XYZ Absolute (#6948)
* Change default settings avoidcolorshift to XYZ absolute

* Same change in controlspotpanel.cc
2024-02-08 21:53:07 -08:00
Lawrence37
e438e0e604 Some more cherry-picking for 5.10 (#6937)
* Local adjustments - Show additional settings - link with complexity  (#6899)

* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds

* Update camconst.json white levels for 1DxII

* Fix warnings: conversion to double/float, unused variables, register keyword

* Fix crash when opening image in editor

Do not access uninitialized raw image data. The raw data is requested
when the demosaic mode is set to None and the cursor is moved over the
image in the editor. It can occur before the raw data is loaded.

* Fix sRGB working profile crash

The sRGB working profile cannot be found under some conditions because
the profile name is stored as a Glib::ustring and the same strings may
not be equal when using different locales. Use std::string whenever
comparing profile names.

---------

Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: CarVac <airplaniac2002@gmail.com>
Co-authored-by: Alexander Gruzintsev <0v3rt1r3d@gmail.com>
2024-02-04 15:43:33 -08:00
Lawrence37
0d0834cbe7 Dynamic Range Compression Improvement (5.10) (#6943)
* Improve Dynamic Range Compression - for some images with very high DR

* Clean code

* Improve TM fattal with saturation control in LA

* Saturation control fattal in LA

* Re-order paramsedit

* Change history_msg_tmo_satur with saturation

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-04 15:38:04 -08:00
Desmis
5349f7a860 Improve Dynamic Range Compression - for some images with very high DR - Main and LA (#6931)
* Improve Dynamic Range Compression - for some images with very high DR

* Clean code

* Improve TM fattal with saturation control in LA

* Saturation control fattal in LA

* Re-order paramsedit

* Change history_msg_tmo_satur with saturation
2024-02-02 07:42:34 +01:00
Lawrence37
f06e756c20 AWB non-raw file fixes (for 5.10) (#6940)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-01 22:41:56 -08:00
Desmis
e4087e2fa2 White balance auto temperature correlation - improve behavior with non raw files (#6903)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2024-02-01 07:48:07 +01:00
Lawrence37
ba065dc13f Merge pull request #6920 from sgilbertson/issue-6915-queue-template-improvements
Queue template improvements
2024-01-28 11:43:07 -08:00
Lawrence37
4dd7517a55 Merge pull request #6873 from 0v3rt1r3d/0v3rt1r3d/fix-a-couple-of-warnings
Fix a couple of warnings
2024-01-27 21:46:14 -08:00
Lawrence37
5ffa0632f2 Merge pull request #6885 from Lawrence37/asan-mem-leak
Fixes for memory leaks and memcpy overlap found by AddressSanitizer
2024-01-25 21:02:50 -08:00
Scott Gilbertson
11a0a0b697 Fixes per pull request comments: fix %p-1 missing slash, use static_cast, fix int/unsigned mismatches 2024-01-16 07:54:12 -05:00
Scott Gilbertson
6cbc448f63 Handle Samba-style UNC prefix '//' in %p and %P queue output template specifiers 2024-01-15 17:13:40 -05:00
Scott Gilbertson
1df9b4869e Make %p and %P queue output template specifiers limit invalid range rather than treating that as an error.
For example in a 4-element path "first 5 elements" and "last 5 elements" now return all four elements.
2024-01-15 16:39:38 -05:00
Scott Gilbertson
a39e6779e4 Fix: If %p or %P queue template term includes start of file path, prepend the leading /, \ or \\ from the file path 2024-01-15 15:27:09 -05:00
Scott Gilbertson
343b5ecc68 Left-justify the queue destination preview label and allow it to scroll horizontally 2024-01-15 14:40:56 -05:00
Scott Gilbertson
b3bbaa6421 Code formatting: move ampersands next to types 2024-01-10 18:55:52 -05:00
Scott Gilbertson
9e310b7454 Minor changes per feedback in issue #6915 (mostly code formatting) 2024-01-10 18:47:14 -05:00
Scott Gilbertson
c918de3178 Reversed %p and %P processing cases for location templates, which were opposite to what the help says. 2024-01-07 11:49:19 -05:00
Scott Gilbertson
0127b68bdb Minor comment clarification 2024-01-07 11:14:52 -05:00
Scott Gilbertson
df41028468 On Windows, use backslashes in template-generated paths
(but continue to accept either / or \ in input strings, on any platform)
Also deleted an unused helper function.
2024-01-07 11:10:05 -05:00
Scott Gilbertson
f92e07e5cf Make destination path preview label selectable, so its contents can be copied to the clipboard 2024-01-07 10:52:01 -05:00
Scott Gilbertson
0f66d43272 Update destination preview whenever the save format changes. 2024-01-07 10:09:45 -05:00
Scott Gilbertson
21c53823ee Reimplemented %p template specifier to use new method, added %P specifier
The %P specifier includes directories from the start of the file path,
whereas the original %p specifier includes them from the end. In both
cases N is from the last directory in the path, and -N is from the
first directory in the path (N=1..9).
2024-01-06 18:21:59 -05:00
Scott Gilbertson
b8d3f90ca0 Reimplement template %dN specifier, making %d-N count from start of path, not end
Also made %pN selectively skip the next character only if it's a slash or backslash,
so for example %p2/a, %p2\a and %p2a produce the same result.
2024-01-06 18:01:56 -05:00
Scott Gilbertson
587e0c6782 Simplified BatchQueue::updateDestinationPathPreview after noticing that calcAutoFileNameBase handles all cases 2024-01-06 16:32:14 -05:00
Scott Gilbertson
380d964077 Add destination path preview label to batch queue panel.
Label initially says "Destination path for the first selected image appears here"
so the feature is discoverable. Select a file and it shows the destination path
that would be used if it is the first file to be processed and the file does
not already exist. Label is updated as the template is edited, so you can see the
effect of the edits. If "Save to folder" is selected, the previewed path uses
that folder.
2024-01-06 16:00:19 -05:00
Desmis
31bf942d92 Local adjustments - Show additional settings - link with complexity (#6899)
* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds
2023-12-17 08:37:20 +01:00
Lawrence37
1839db448d Merge pull request #6793 from Lawrence37/nr-gain
Option for disabling noise reduction gain
2023-12-16 11:11:24 -08:00
Lawrence Lee
badbb9fbe2 Add checkbox for disabling NR gain
Option to disable noise reduction automatic gain for consistency between
photographs.
Fix automatic gain not being recalculated after changing the white level
correction.
2023-12-16 11:10:11 -08:00
Desmis
886c7f5498 LA exposure hide show sliders when expcomp different from zero (#6892) 2023-12-12 22:15:11 -08:00
Lawrence Lee
7c619f87bc Fix WB method reset when not using English
Use the GUI label for "Camera" instead of hard-coding it.
2023-12-12 22:15:10 -08:00
Lawrence Lee
01e8af8c89 Fix color toning layers being hidden
Request resizing of tool widgets after being attached to the tool panel.
2023-12-12 22:15:04 -08:00
Desmis
32aca270ec LA exposure hide show sliders when expcomp different from zero (#6892) 2023-12-02 08:24:42 +01:00
Lawrence Lee
330f99832e Fix WB method reset when not using English
Use the GUI label for "Camera" instead of hard-coding it.
2023-11-26 16:25:06 -08:00
Lawrence37
33a2d1c767 Format code
Move `const` to the front.
2023-11-17 21:08:24 -08:00
Lawrence Lee
c5bb1f093e Fix issues found by AddressSanitizer
Fix memcpy overlap in TIFF reader.
Fix memory leaks of SpotRows in control spot panel.
Fix memory leaks of SpotRows in locallab.
Fix memory leak of Glib::ThreadPool in file browser entry.
Fix memory leak of Glib::ThreadPool in thumbnail image updater.
2023-11-11 16:56:34 -08:00
Alexander Gruzintsev
de82b9fc7a Fix warnings: conversion to double/float, unused variables, register keyword 2023-10-30 08:18:33 +01:00
Desmis
d276a56b10 Local adjustments - improvment Dehaze with black (#6860)
* Local Dehaze black

* Enable black

* Change threshold black - publish_pre_dev_labels ladehazeblack
2023-10-12 06:59:33 +02:00
Lawrence37
dac3dcf664 Merge pull request #6854 from Lawrence37/color-toning-layers-fix
Fix hidden layers in the Color Toning tool
2023-10-10 21:05:33 -07:00
Lawrence37
ab8de06c66 Merge branch 'dev' into nr-gain 2023-10-10 21:03:03 -07:00
Lawrence Lee
a35b320f1a Fix color toning layers being hidden
Request resizing of tool widgets after being attached to the tool panel.
2023-09-17 15:27:19 -07:00
Lawrence37
c75ff3260f Format code 2023-09-17 15:14:10 -07:00
Lawrence Lee
17b9e7c107 Fix startup crash in debug build
Do not throw error when trying to get mutex lock.
2023-09-17 15:14:09 -07:00
Lawrence37
7ebbac25ca Format code 2023-09-10 14:29:17 -07:00
Lawrence Lee
730704f3b2 Fix startup crash in debug build
Do not throw error when trying to get mutex lock.
2023-09-09 16:02:41 -07:00
Lawrence Lee
0fdac3797a Merge branch 'dev' into browser-preview-applied-pparams 2023-08-29 22:58:51 -07:00
Beep6581
e189a1a4ec Merge pull request #6817 from ss23/clang_windows_mingw_64bit_fix
Use `_WIN32` instead of `WIN32` to detect Windows
2023-08-29 00:47:13 +02:00
Morgan Hardwood
5f6ca0afab More visible curve crosshair cursor
Fixes #6741

The mouse cursor when hovering over a curve was sometimes impossible to
see on a high resolution screen due to the almost identical colors of
the cursor relative to the curve background.
2023-08-29 00:32:56 +02:00
Morgan Hardwood
322c124e6b Merge branch 'switched-rating-shortcuts' of github.com:Eemilp/RawTherapee into Eemilp-switched-rating-shortcuts 2023-08-29 00:01:50 +02:00
Beep6581
0a13b85d1d Merge pull request #6798 from LoKolbasz/film_negative_pick_size
Adjustable picker size in Film Negative tool
2023-08-28 21:58:55 +02:00