Commit Graph

3726 Commits

Author SHA1 Message Date
Desmis
35abd92209 Custom TRC Tone response curve and Illuminant - change Histogram - RGB and Lab values - for output (screen, TIF, JPG..) (#5949)
* Change TRC in the process

* Improve GUI slope

* Add tooltip output profile

* Various change to enable and tooltip

* Chnage rtthumbnail

* Small change tooltip trc

* Another small change tooltip

* Improve GUI - change default TRC BT709 - change tooltip

* Other GUI improvment

* Small changes to BT709 values

* Various change to TRC - add illuminant working profile

* Change labels tooltip TRC illuminant

* Display wp in console if wp provided

* Change tooltip

* Change max wlope

* Init trc + illum + primaries

* Add black point compensation

* Change location abstract

* Fixed bug with rtthumbnail...

* Added tooltip

* Logscale for wslope

* Change tooltip abstract

* Change labels tooltips abstract profile

* Added 6 sliders custom primaries X and Y

* Change GUI custom primaries

* Use custom primaries abstract profiles

* Tooltip with primaries red green blue

* Fixed warning gtk

* Change one tooltip

* Change range custom primaries

* Change GUI default Primaries

* Change one tooltip

* Speedup for trc

* Rendering intent for abstract profile

* Hide intent abstract

* Preserve neutral tones

* Chnage settings preserves neutral tones

* Improve GUI

* Improvment to preserv

* Clean code - speedup TRC when illuminant and primaries default

* Change label

* Change bad default value Blux

* Add forgoten illuminant when selecting primaries

* clean code

* Change labels

* improve workingtrc for LA

* Change default primaries when select default

* Added others working profile to primaries

* Change labels and GUI

* Change tooltip

* CIExy diagram displaying the primaries (interactive) and the white point (#6207)

* Ciexy diagram

* Change to Ciexy graph

* Change graph and defaut coordonates

* Various changes to graph - params

* Disable setListener(ToolPanelListener)

* Add some graduation to graph

* Clean comment code graph

* Change radius 0

* Enable sensitive graph Ciexy

* update Ciexy graph with primaries

* Remove reset button graph

* Change labels and behavior

* First step third spot green

* Second step 3rd spot green

* First try 3 primaries graph Ciexy

* Fixed bad behavior in lab grid

* Fixed another bad behavior graph

* Clean and comment code

* Change default gamma

* More accurate graph Cie xy

* Added white point to Ciexy graph

* Added tooltip Cie xy diagram

* Improvment when illuminant change

* Refine diagram CIE xy - added WP 2000K

* White point D120 + tooltip

* Change label

* Change labels

* Change tooltips

* Improve diagram CIE xy with parabolic

* Other parabolic to improve Cie xy diagram

* Small change GUI

* Added Label CIE xy - change labels

* Change behavior when none - change labels

* Improve gUI and trys to fix LGTM alerts

* CIE xy change set sensitive

* Improve tooltip primaries sliders

* Adapt tooltip to new labels

* Fixed crash and some bad behavior

* First fix bad behavior with some primaries

* Second fixed bad behavior primaries

* Third fixed bad behavior primaries

* Change white point BestRGB

* Change order rgb in history msg Ciexy

* Change tooltip

* Change tooltip

* Improve GUI primaries

* Illuminant 1500K - display in console matrix XYZ-RGB

* Improve GUI illuminant

* Change a tooltip

* Somme changes to GUI and verbose

* Test code for wprim in read

* clean code for wprims

* further cleanups, not tested

* Some cleanups and bugfixes, #5949

* Simplify `std::unique_ptr<>` dereferencing

Also some minor cleanups.

* Some changes suggested by Floessie

* Others change suggested

* Others changes suggested by Floessie

* Forgotten change in procparams.cc

* Added black and white for use with the primaries channel mixer

* Small change behavior GUI - illuminant

* Change pragma omp in iplab2rgb

* Add enums and clean up

* Remove unused code icmpanel.cc

* Fix LGTM alert, #5949

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Flössie <floessie.mail@gmail.com>
2021-05-16 06:18:25 +02:00
Lawrence Lee
1b7ddf2b31 Fix perspective and local adjustments cursor icons
Correctly override the getCursor virtual function.
2021-05-14 22:20:25 -07:00
Desmis
7040aed540 Some change issue6234 (#6238) 2021-05-15 06:40:39 +02:00
Thanatomanic
09621242f4 Fix forgotten HBox -> Box change in header 2021-05-13 13:01:41 +02:00
Desmis
eb8f121709 Add ability to export to an external editor within the same folder as the original file - issue 6195 (#6232)
* import and change the art code -thanks to Alberto

* Possible fixed for white space in folder

* Added verbose when white-space

* Replace WS only if windows and Gimp

* Fixed Windows and Gimp bug for external editor - thanks to Lawrence37

* Fix LGTM alert for reused variable name

Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
2021-05-13 12:41:22 +02:00
Thanatomanic
fa2776c732 Remove double include 2021-05-13 12:41:01 +02:00
Thanatomanic
bb623d3a02 Fix instance of deprecated HBox 2021-05-13 12:34:27 +02:00
Desmis
3cb6e88ea4 Harmonize GUI for Scope - Retinex and Dehaze 2021-05-11 13:27:04 +02:00
Lawrence Lee
77ea6d92cb Pin inspector whenever scrolling or zooming 2021-05-09 12:31:26 -07:00
Lawrence Lee
6535cb4a94 Make inspector never upscale in fit-to-window mode
When zoomed completely out, don't upscale images.
2021-05-09 12:18:06 -07:00
Lawrence Lee
9df34be6cb Hide inspector accelerator in film strip
Only show the accelerator key in the context menu when opening the menu
from the full file browser but not the film strip.
2021-05-08 12:15:58 -07:00
Lawrence Lee
36cb32b31b Make inspector window size consistent 2021-05-08 11:48:18 -07:00
Lawrence Lee
b2988ddbb3 Avoid reopening inspector window when being opened 2021-05-07 22:26:28 -07:00
Pandagrapher
1c9d1f522c Locallab - Fix bad syntax in LocallabParamsEdited vector resize 2021-05-07 18:47:14 +02:00
Lawrence Lee
9495c049c4 Fix inspector not opening full-screen at first 2021-05-06 21:39:01 -07:00
Desmis
980a16abb0 Improve ciecam16 Log encoding (#6228) 2021-05-04 13:54:12 +02:00
Desmis
f22482c204 Local adjustments - Strength control on Spot - tools - issue 6221 (#6223)
* Add strength to local contrast and wavelet

* Added strength to Color and Light

* Added strength to Denoise

* Added strength to shadows highlight Tone equalizer

* Added strength to Dynamic Range and exposure

* Added strength to Tone mapping

* Small improvment to Dynamic Range
2021-05-04 07:27:55 +02:00
Lawrence Lee
70d30a5050 Fix crash after pressing f key in file browser
Check that the inspector window exists before trying to close it.
2021-05-02 15:57:34 -07:00
Lawrence Lee
bce88478c4 Fix inspector window rendering with device scaling 2021-05-02 15:50:55 -07:00
Lawrence Lee
de9403f9fe Ignore key down repeat events in inspector window
Ignore key press events that happen when a key is held down.
2021-05-02 12:52:15 -07:00
Lawrence Lee
4811f92c39 Add missing return statement 2021-05-02 12:35:05 -07:00
Lawrence Lee
b99b9302cc Fix inspector window scaling with caps lock
When launched with the accelerator key, the inspector window initially
scales the image without respecting the state of the caps lock. This
commit fixes the bug.
2021-05-02 12:31:33 -07:00
Lawrence Lee
e25cb3fde0 Fix inspector window panning speed
Consistently use integers for mouse movement and compensate for image
scale.
2021-05-01 15:52:45 -07:00
Lawrence Lee
5decec5405 Fix inspector window zoom centering
Use floating point coordinates instead of integers to avoid rounding
errors.
2021-05-01 15:52:13 -07:00
Lawrence Lee
900af7aeb7 Remove drawn background in inspector window
Add "InspectorWindow" CSS ID so that the background color can be changed
through CSS.
2021-04-25 18:11:47 -07:00
Lawrence Lee
d4bceb5c06 Pin inspector window if opened with context menu 2021-04-25 17:27:57 -07:00
Lawrence Lee
67e18b5c53 Fix inspector window sometimes not hiding
When the f shortcut is quickly pressed, the inspector window will
sometimes open and remain open even though it should automatically
close. This commit ensures the window closes by capturing the f key
release event from the main window in addition to the inspector window.
2021-04-25 17:05:02 -07:00
Lawrence Lee
61aba8ad08 Set inspector window title from language files 2021-04-25 15:48:29 -07:00
Lawrence Lee
58995a052d Properly enable inspector window for film strip 2021-04-25 15:44:49 -07:00
Desmis
53bb6e41bb LA other bad behavior Duplicate spot when spot outside preview 2021-04-22 07:15:28 +02:00
Desmis
f47f23a4dc LA - Duplicate full image size whole image - issue 6200 2021-04-21 10:32:51 +02:00
Desmis
128de03aed Local adjustemnts - adapt various parameters to fit labels in right tool panel issue #6153 (#6160)
* Various change to fit label in left tool panel

* Increase size left panel from 460 to 465

* Various improvment to reduce size left panel

* Others changes to reduce left panel labels

* Increase default size right panel

* Set right panel ajustable to size font

* Others small changes to mask

* Others small modifications

* change a litlle GUI - curveeditorgroup.cc - suppress curves u=in mask and reduce size right panel

* Added : to various curves label

* Others : labels curves

* Some adjustments labels sizefonts

* Change 2 forgotten length labels in denoise

* Others improvments labels

* Others labels change for retinex

* Others change labels - thanks to Wayne Sutton

* French change label length

* Change labels Wavelet levels - LA retinex - LA color and lights - and others

* Other change to mask blur

* Change box - Flowbox - thanks to Beep6581

* Adapt size box basic..advanced with size font

* Restore curveditorgroup : - change some labels and tooltips

* Remove some ':' - change and adapt labels tooltip wavelet levels

* Change flowbox for complexity under label

* Restore right panel and options to default values

* Change a label in wavelet level denoise

* Change in mask curves L(L) by L C(C) by C

* Small change labels denoise to fit in width right panel

* Others changes to GUi and labels to fit in right panel

* First change tooltips and french

* Second change tooltips

* Change tooltip mask denoise
2021-04-02 07:36:42 +02:00
Desmis
717948cf09 Local adjustments - Normalize luminance - improvment Preview TM - Retinex - Remove D.Range (#6185)
* Enable dynamic range - settings normalize luminance

* Change range DR sigma offset

* improve normalize_mean_dt with mean std before

* Save work on normalize dynamic range

* Improve normalize for TM

* Added LA retinex to normalize_mean

* Clean and optimize code

* Disabled normalize DR - improve TM and Retinex

* Clean code - first part

* Clean code - part two

* Change 2 default values Retinex

* Change order TM and Retinex in process

* remove the order number in - add tool to current spot -

* Fixed bug in TM

* Some change Retinex - default...

* optimize mean sigma

* cleanup for mean_sig

* Fix some cppcheck issues

* convert one large loop into three loops to avoid performance penalty on machines with 4-way L1 cache

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-03-28 12:55:29 +02:00
Ingo Weyrich
871d35c228 Favorites Tab: rawBayerExposure in X-Trans, fixes #6182 2021-03-24 11:05:11 +01:00
Desmis
3ad786745c LA - Move colortoning labgrid from rgb to lab - issue #6132 (#6173)
* Move colortoning labgrid from rgb to lab

* Remove unnecessary variables
2021-03-23 16:59:54 +01:00
Desmis
170df03933 LA - Simplify GUI - Dynamic range 2021-03-19 16:58:49 +01:00
Desmis
537fa73d3f Local adjustments - Log encoding - Ciecam16 ContrastJ - contrastQ - contrast threshold (#6169)
* Added contrast threshold Log encoding

* Improve contrast threshold

* Chanhe tooltip

* Change sign threshold when contrast negative

* Another change threshold with contrast Q and J
2021-03-15 07:57:25 +01:00
Desmis
227ae487d4 LA and Shadows-Highlight main - change location shadows-highlight in Lab issue 6163 (#6164)
* Change location shadows-highlight in Lab

* Suppress unused variable

* Small change in improccoordinator.cc
2021-03-13 07:17:42 +01:00
Ingo Weyrich
bb08b6bed8 Raw black points: Green2 Does not change color when click button restore value to 0, fixes #6165 2021-03-09 13:11:51 +01:00
Desmis
0170305906 Local contrast - Try to solve bug issue #6132 (#6134)
* Try to solve bug issue 6132

* Refine placement localcontrast in pipeline
2021-03-08 08:29:57 +01:00
Desmis
9b2e955dc9 LA improve behavior full image issue 6161 2021-03-08 08:00:35 +01:00
Lawrence Lee
f958074d9b Fix crash when deleting spot removal spot
Deleting a spot while hovering over one of the circles for adjusting the
radius or feathering could trigger a crash. This is because immediately
after deleting a geometry object, EditSubscriber::getCursor is given an
object ID based on old data, causing the spot tool to attempt to get
information about the deleted geometry object.

This commit fixes the issue by returning the default cursor if the
active spot is -1. It works because the active spot is set to -1 when
deleting a spot, and there is no need to use a special cursor when there
is no active spot.

A better long-term solution would be updating the geometry data before
calling EditSubscriber::getCursor.
2021-03-07 11:58:36 -08:00
Lawrence Lee
10b5f65b30 Fix spot removal enable/disable history message
The history panel was showing "HISTORY_MSG_1049".
2021-03-06 21:29:56 -08:00
Lawrence Lee
7e436a44d6 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into spot-removal-tool 2021-03-06 16:41:40 -08:00
Desmis
df9f33e44e LA - Others improvments length labels 2021-03-06 08:22:50 +01:00
Desmis
0bf7c4e56c Local adjustments - Added Guidedfilter to avoid color shift (#6149)
* Added Guidedfilter to avoid color shift

* Various improvment to avoid color shift

* Small change to mint maxt

* local adjustments avoid color shift: reduce memory usage by width * height * 8 byte if Soft Radius > 0

* Remove StopWatch

* local adjustments avoid color shift: speedup for last loop

* cleanups

* one more cleanup

* Added checkbox Munsell correction only - uniform perceptual lab

* Refine some settings

* Clean-up - other small refinement

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-03-03 18:49:55 +01:00
Pandagrapher
84751ad26f Re-allow using RT shortcut while focused on adjuster 2021-03-01 21:38:35 +01:00
Pandagrapher
d92bbf59e1 Fixes #6148, allow using decimal key on numpad 2021-03-01 21:04:08 +01:00
Stefan Wunsch
68a6e02369 Fix some cmake build system issues (#6147)
* [cmake] Switch to find_package for TIFF
- Included in cmake 3.5 and later
- Provides better configuration messages
* Add missing TIFF library to rtgui and rtexif
* Removed unnecessary quotes so that cmake sees the list as a list
* Add OpenMP to rtengine if OpenMP is enabled
2021-03-01 16:40:54 +01:00
Ingo Weyrich
02a5040a60 Undocumented search feature in exif tab can be annoying, fixes #6142 2021-02-28 17:00:37 +01:00