George Hilliard
5081c85f26
Fix leak of heap-allocated mutexes
2018-11-02 03:07:07 -05:00
George Hilliard
77eccdf13d
Fix mismatched malloc/delete leak
...
From the Valgrind report:
```
Mismatched free() / delete / delete []
at 0x4838EAB: operator delete(void*) (vg_replace_malloc.c:576)
by 0xBC5C87: std::default_delete<cJSON>::operator()(cJSON*) const (unique_ptr.h:81)
by 0xBC4ACA: std::unique_ptr<cJSON, std::default_delete<cJSON> >::~unique_ptr() (unique_ptr.h:274)
by 0xBBB755: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
by 0x89743FF: GOMP_parallel_sections (sections.c:158)
by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
by 0x9CE10E: Options::load(bool) (options.cc:2358)
by 0x982CD6: main (main.cc:603)
Address 0xd62d700 is 0 bytes inside a block of size 64 alloc'd
at 0x483777F: malloc (vg_replace_malloc.c:299)
by 0xE97390: cJSON_New_Item (cJSON.c:205)
by 0xE98718: cJSON_ParseWithOpts (cJSON.c:1020)
by 0xE9886F: cJSON_Parse (cJSON.c:1083)
by 0xBBB4D3: (anonymous namespace)::getAliases(Glib::ustring const&) (dcp.cc:422)
by 0xBC1CCA: rtengine::DCPStore::init(Glib::ustring const&, bool) (dcp.cc:1846)
by 0xC3ED4F: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:81)
by 0x89743FF: GOMP_parallel_sections (sections.c:158)
by 0xC3E906: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) (init.cc:52)
by 0x9CE10E: Options::load(bool) (options.cc:2358)
by 0x982CD6: main (main.cc:603)
```
2018-11-02 03:06:59 -05:00
Alberto Griggio
5e30b5ac58
merged 'colortoning-labregions' into 'dev'
2018-11-01 15:18:11 +01:00
Alberto Griggio
e9f0b6ac60
L*a*b* regions: some code cleanups
2018-11-01 13:34:10 +01:00
heckflosse
72787cd990
Set Post-Resize Sharpening Contrast Threshold to 15, fixes #4909
2018-11-01 12:12:01 +01:00
Alberto Griggio
86b282fc68
procparams: call DehazeParams::operator== in ProcParams::operator==
2018-11-01 05:42:45 +01:00
Alberto Griggio
be03d1061a
L*a*b* regions: allow for a bit more latitude in corrections
2018-11-01 00:18:59 +01:00
Ingo Weyrich
0bb5d26ed0
Merge pull request #4908 from Beep6581/getridoffeahistogramcache
...
Get rid of aehistogram files in RT cache.
Merged to get more tests. Issue and pr stay open for a while
2018-10-31 21:56:00 +01:00
Alberto Griggio
fb97eeaa5a
guided filter: fixed bug due to overlapping input and output arrays
2018-10-31 17:53:47 +01:00
Alberto Griggio
7090730063
Merge pull request #4898 from Beep6581/dehaze
...
Dehaze
2018-10-31 13:26:08 -05:00
heckflosse
f6c864d477
Get rid of aehistogram files in RT cache, fixes #4904
2018-10-31 15:02:53 +01:00
Morgan Hardwood
cef5d12779
AllowUpscaling=false for old PP3s
...
PP3s from before the Allow Upscaling option's introduction to the Resize
tool should defaut to not allow upscaling.
Closes #4643
2018-10-30 21:18:21 +01:00
Alberto Griggio
74a467fb4e
labgrid: work on [0,1] values
2018-10-30 21:12:44 +01:00
heckflosse
1dcf92322d
RT crashes with wrong value in profile (curves), fixes #4398
2018-10-30 19:36:37 +01:00
heckflosse
894fb8d9b3
vng4 demosaic: another small speedup, #4633
2018-10-30 13:45:44 +01:00
heckflosse
13abcd0f6c
vng4 demosaic: another very small speedup, #4633
2018-10-28 20:37:34 +01:00
Alberto Griggio
50c623802a
set LabRegions as the default color toning method
2018-10-28 18:38:55 +01:00
Ingo Weyrich
b47884bf93
Merge pull request #4897 from Beep6581/vng4-speedup
...
Vng4 speedup
2018-10-27 18:46:25 +02:00
heckflosse
47cfcd51d4
vng4 demosaic: removed StopWatch, fixes #4897
2018-10-27 18:46:02 +02:00
Alberto Griggio
b651cdd40b
Merge pull request #4885 from Beep6581/softlight-later-pipeline
...
moved softlight later in the pipeline
2018-10-27 18:03:51 +02:00
Alberto Griggio
7fb90644d3
dehaze: tweak epsilon to avoid artifacts in corner cases
2018-10-27 15:25:38 +02:00
heckflosse
1b291aee9b
vng4 demosaic: minor speedup, #4633
2018-10-26 22:20:20 +02:00
heckflosse
3d61eca91f
vng4 demosaic: remove unreachable code, #4633
2018-10-26 20:23:27 +02:00
Alberto Griggio
91f9dfe110
labregions: properly scale the guide to [0,1] for the guidedFilter calls
2018-10-26 18:04:41 +02:00
Alberto Griggio
c4ee5e611d
guided filter: reuse buffer across boxblur invocations
2018-10-26 18:04:07 +02:00
heckflosse
c44b8ca6a3
vng4 demosaic: move red/blue interpolation inside main loop for better cache usage, #4633
2018-10-26 17:09:28 +02:00
heckflosse
d53e44d45b
vng4 demosaic: precalculate weight
2018-10-26 16:51:05 +02:00
heckflosse
b37d88fb22
Always use auto-contrast threshold when using Amaze+VNG4 as demosaicer for motion areas in pixelshift
2018-10-26 14:43:36 +02:00
Alberto Griggio
1a3fd9f157
Added new color toning method "L*a*b* regions"
...
Allows to specify various "regions" of the image with masks, and to correct
for hue, saturation and lightness.
Inspired by the existing L*a*b* grid (in turn taken from darktable)
2018-10-25 16:46:11 +02:00
heckflosse
5134040a5b
Merge branch 'dev' into show_flatfield_autoclip_in_gui
2018-10-24 15:40:21 +02:00
heckflosse
ac700502db
Flat field: Show auto calculated clip control value in ui
2018-10-24 00:49:51 +02:00
heckflosse
96acd92a7c
Changes suggested by code review, #4890
2018-10-23 21:10:01 +02:00
heckflosse
4d46e618bb
Calculate dual demosaic auto contrast threshold when saving file, #4866
2018-10-23 21:03:23 +02:00
heckflosse
392e00cd69
Dual demosaic auto contrast threshold: Use adjuster with auto button, #4866
2018-10-23 19:52:40 +02:00
heckflosse
2519db1bbf
Merge branch 'dev' into dual_demosaic_auto_threshold
2018-10-23 16:05:28 +02:00
heckflosse
8ed760c639
LG Mobile LG-H850 (LG G5) raw support, fixes #3655
2018-10-23 15:54:07 +02:00
heckflosse
b404268c7a
Better white level for DJI FC6310
2018-10-23 15:48:30 +02:00
heckflosse
ed3b54e4eb
DNG files from DJI FC6310 open extremely slow, fixes #4888
2018-10-23 15:43:24 +02:00
Roel Baars
f832d479e9
Fixes #4883
2018-10-22 20:32:55 +02:00
heckflosse
be987d8f32
dual demosaic auto contrast: fix segfault when falling back to zero, #4866
2018-10-22 17:24:36 +02:00
heckflosse
e2965cc6b4
dual demosaic: improved auto threshold detection and fall back to more detailed demosaicer if no flat region was found, #4866
2018-10-22 14:22:49 +02:00
heckflosse
459f64bac2
Disable demosaic timing code
2018-10-21 22:55:56 +02:00
heckflosse
e5f373d0e1
Merge branch 'dev' into dual_demosaic_auto_threshold
2018-10-21 21:54:24 +02:00
heckflosse
8b65900066
Dual demosaic: Add auto threshold checkbox and show used value in ui, #4866
2018-10-21 20:21:43 +02:00
Alberto Griggio
18f812d96a
added initial support for the Nikon Z7 to camconst.json (issue #4880 )
2018-10-19 22:26:33 +02:00
heckflosse
0da47b0da3
2-pass dual-demosaic-contrast-threshold detection if 1-pass does not find a flat area, #4866
2018-10-18 22:09:35 +02:00
Alberto Griggio
2026fe1d17
guided filter: added support for automatic computation of subsampling factor
2018-10-18 08:53:02 +02:00
Alberto Griggio
b50b8dea9f
merge with dev
2018-10-27 16:11:17 +02:00
Alberto Griggio
59339644de
dehaze: do not consider out-of-gamut pixels when estimating the ambient light
2018-10-17 15:38:35 +02:00
Beep6581
009c1082f7
Merge pull request #4857 from Beep6581/abstract-listeners
...
Turn Listeners into abstract interfaces
2018-10-17 14:22:11 +02:00