Commit Graph

4953 Commits

Author SHA1 Message Date
Lawrence Lee
6d2022b5d5 Fix compiler warnings 2024-02-08 22:08:44 -08:00
Desmis
8ad4ebf482 Change default behavior Local Adjustments settings Avoid Color Shift to XYZ Absolute (#6948)
* Change default settings avoidcolorshift to XYZ absolute

* Same change in controlspotpanel.cc
2024-02-08 21:53:07 -08:00
Lawrence37
f65e428e7f Merge pull request #6833 from LoKolbasz/segfault_with_fuji_cropped_raw_issue#6312
Segfault fixed when opening Fuji cropped raw. Fixes #6312
2024-02-04 15:47:28 -08:00
Lawrence37
e438e0e604 Some more cherry-picking for 5.10 (#6937)
* Local adjustments - Show additional settings - link with complexity  (#6899)

* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds

* Update camconst.json white levels for 1DxII

* Fix warnings: conversion to double/float, unused variables, register keyword

* Fix crash when opening image in editor

Do not access uninitialized raw image data. The raw data is requested
when the demosaic mode is set to None and the cursor is moved over the
image in the editor. It can occur before the raw data is loaded.

* Fix sRGB working profile crash

The sRGB working profile cannot be found under some conditions because
the profile name is stored as a Glib::ustring and the same strings may
not be equal when using different locales. Use std::string whenever
comparing profile names.

---------

Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: CarVac <airplaniac2002@gmail.com>
Co-authored-by: Alexander Gruzintsev <0v3rt1r3d@gmail.com>
2024-02-04 15:43:33 -08:00
Lawrence37
42817bffa4 Defringe tool banding & desaturation fix (#6934)
* Fix defringe banding & desaturation race condition

Use a copy of the image instead of the image itself for the source data.
Affects Defringe, Color Appearance & Lighting Hot/bad pixel filter, and
Contrast by Detail Levels Reduce artifacts.

* Fix CodeQL warning

Fix multiplication overflow.
2024-02-04 15:41:32 -08:00
Lawrence37
2f7c2e973c Fix rotation of images with odd number of rows (#6926)
* Fix line in middle of 180 degree rotated image

For images with an odd number of rows, a 180 degree rotation resulted in
one row of un-rotated pixels because it was effectively rotated twice.

* Replace verbose swap with std::swap
2024-02-04 15:40:38 -08:00
Lawrence37
0d0834cbe7 Dynamic Range Compression Improvement (5.10) (#6943)
* Improve Dynamic Range Compression - for some images with very high DR

* Clean code

* Improve TM fattal with saturation control in LA

* Saturation control fattal in LA

* Re-order paramsedit

* Change history_msg_tmo_satur with saturation

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-04 15:38:04 -08:00
Lawrence37
f06e756c20 AWB non-raw file fixes (for 5.10) (#6940)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-01 22:41:56 -08:00
Lawrence37
13bf7a1f0a Merge pull request #6857 from Lawrence37/camconst-from-art
Update camconst.json from ART
2024-01-27 15:52:54 -08:00
Lawrence37
7eb2aedbc1 Merge pull request #6927 from Lawrence37/panasonic-dc-g100-white-levels
Panasonic DC-G100 white levels
2024-01-25 21:04:19 -08:00
Lawrence37
5ffa0632f2 Merge pull request #6885 from Lawrence37/asan-mem-leak
Fixes for memory leaks and memcpy overlap found by AddressSanitizer
2024-01-25 21:02:50 -08:00
Lawrence37
ddcaa7a81c Merge pull request #6881 from Lawrence37/lensfun-vignette-fix
Fix focus distance from metadata
2024-01-25 21:01:17 -08:00
Lawrence Lee
2bc7cea5a1 Add white levels for Panasonic DC-G100
Reduce white levels for ISOs 1600-4000 due to noise with LENR on.
2024-01-14 12:58:05 -08:00
Lawrence37
d0e36ee509 Merge pull request #6904 from Lawrence37/fix-odd-raw-crop-raw-ca
Fix for wrong colors when the demosaic border is odd
2023-12-23 11:14:37 -08:00
Lawrence37
85746a8093 Fix bad colors when demosaic border is odd
Colors are incorrect if the demosaic border is odd and raw chromatic
aberration is enabled.
2023-12-21 22:09:32 -08:00
Lawrence Lee
badbb9fbe2 Add checkbox for disabling NR gain
Option to disable noise reduction automatic gain for consistency between
photographs.
Fix automatic gain not being recalculated after changing the white level
correction.
2023-12-16 11:10:11 -08:00
U-PCSPECIALIST01\jdesm
339fdd9f04 Ftblockdn - remove unwanted messages in console 2023-12-12 22:15:09 -08:00
Desmis
f6aa9b86cb White Balance - temperature correlation in batch mode - issue #6867 (#6877)
* Change Itcwb in simpleprocess

* Change for auto RGBgrey

* remove unnecessary code
2023-12-12 22:15:08 -08:00
Lawrence Lee
d5ba3cf232 Fix crash in noise reduction
Fix upper bound for array access while building histogram of absolute
values in mean absolute deviation (MAD) calculation.

Fixes #6871.
2023-12-12 22:15:07 -08:00
Lawrence Lee
c5bb1f093e Fix issues found by AddressSanitizer
Fix memcpy overlap in TIFF reader.
Fix memory leaks of SpotRows in control spot panel.
Fix memory leaks of SpotRows in locallab.
Fix memory leak of Glib::ThreadPool in file browser entry.
Fix memory leak of Glib::ThreadPool in thumbnail image updater.
2023-11-11 16:56:34 -08:00
Lawrence Lee
f25659307c Calculate focus distance for Nikon Z cameras 2023-11-11 14:57:24 -08:00
Alberto Griggio
e5d389e271 metadata: fixed focus distance computation
A wrong focus distance calculation was affecting lensfun vignetting correction
2023-11-09 21:22:37 -08:00
Lawrence Lee
1ecbd73a4a Update camconst.json from ART
Add color matrix for Canon EOS Rebel SL3 (250D / Kiss X10).
Add masked areas for Canon EOS M6 Mark II and 90D.
Include Canon PowerShot G9 X for values for G5 X and G7 X Mark II.
Add black level for LEICA D-LUX 7.
Include PANASONIC DC-GX880 for values for DC-GF10.
2023-09-24 16:37:29 -07:00
Flössie
dcbc0327a1 Fix UB in ProcParams::load() and the resulting Clang 15+ miscompilation
Fixes #6847.
2023-09-17 15:14:11 -07:00
Lawrence Lee
dab9a3f57e Fix automatic distortion correction crash
Closes #6840.
2023-09-17 15:14:03 -07:00
Battyányi Dániel
d0b34a3234 Fixed crop mode checking
Me make dumb mistake in prev. commit sry.
2023-09-12 18:19:51 +02:00
Battyányi Dániel
1a0b7f4562 Replaced casting with != 2023-09-12 14:01:35 +02:00
Battyányi Dániel
b4daf36349 CropMode changed from "plain enum" to "enum class" 2023-09-12 10:39:50 +02:00
Battyányi Dániel
0fe4c18752 Semantic changes 2023-09-12 10:33:04 +02:00
Battyányi Dániel
f09612453a Metadata no longer overwrites camconsts
Added suggested changes to camconst and removed the camconst.json overwriting part as per the review comment
2023-09-12 00:07:43 +02:00
Battyányi Dániel
ab6d5b190c Tags in numerical order inside parse_fuji()
As suggested by review comment
2023-09-11 23:18:57 +02:00
Battyányi Dániel
6ee6a46750 Width and height only updates to cropped version after detecting crop
As suggested by review comment
2023-09-11 23:11:38 +02:00
Battyányi Dániel
3806107315 Changed crop detection mechanism according to code review comment
Changed the crop detection to use the CropMode Fujifilm tag from the makernotes instead of an arbitrary threshold.
2023-09-11 22:58:24 +02:00
Battyányi Dániel
ea86a14dff removed unecessarily setting of raw_height and raw_width 2023-09-11 22:22:37 +02:00
Lawrence37
f93c3ddf94 Merge pull request #6838 from Lawrence37/canon-various-camconsts
Raw crop and masked areas for a few Canon cameras
2023-09-05 18:32:34 -07:00
Lawrence37
c3a97f0304 Merge pull request #6836 from Lawrence37/ilce-7m4-raw-crop
Raw crop for Sony ILCE-7M4
2023-09-05 18:30:09 -07:00
Lawrence Lee
7c73da7723 Fix Olympus E-M10MarkIV white level
Closes #6236.
2023-09-04 14:31:03 -07:00
Lawrence Lee
408b41dc72 Raw crop and masked areas for a few Canon cameras
- Fix masked areas for EOS RP 1.6x crop mode
- Masked areas for EOS M50, EOS M50m2, and EOS M100 (all the same)
- Raw crop and masked areas for EOS R 1.6x crop mode
2023-09-03 18:03:08 -07:00
Lawrence Lee
6fb8ded886 Add Sony ILCE-7M4 raw crop
Remove 10 columns of bad pixels from the right border.
2023-09-02 22:03:34 -07:00
Dániel Battyányi
554a6dc161 Added RT signifier comments 2023-08-30 23:34:36 +02:00
Dániel Battyányi
5231f3a742 Removed comments 2023-08-30 23:09:03 +02:00
Dániel Battyányi
23e2f0cca5 Fixed issue #6312
Fixed issue, where raw cropped Fuji X-Pro3 could not be loaded correctly. This would result in a Segmentation Fault.
With these changes the program should read the correct dimensions from the file's metadata, and load the image accordingly.
2023-08-30 22:17:16 +02:00
Lawrence Lee
0fdac3797a Merge branch 'dev' into browser-preview-applied-pparams 2023-08-29 22:58:51 -07:00
Beep6581
e189a1a4ec Merge pull request #6817 from ss23/clang_windows_mingw_64bit_fix
Use `_WIN32` instead of `WIN32` to detect Windows
2023-08-29 00:47:13 +02:00
Beep6581
15144e4cc2 Merge pull request #6703 from Beep6581/om5
OM Digital Solutions OM-5 camconst #6699
2023-08-28 22:51:35 +02:00
Lawrence37
ac48cc55d8 Better use of cache with inpaint opposed highight reconstruction (#6822)
* Speed up preview when inpaint opposed enabled

Only reprocess from raw if the white balance is changed. Otherwise, a
cache from later in the pipeline can be used.

* Remove unused code

* Fix refresh map bit positions

* Make WB & inpaint opposed refresh less brittle

Co-authored-by: Hombre57 <natureh.510@gmail.com>

---------

Co-authored-by: Hombre57 <natureh.510@gmail.com>
2023-08-15 07:52:38 -07:00
Stephen Shkardoon
23f2a2fc9f Use _WIN32 instead of WIN32 to detect Windows
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here.
http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
2023-08-13 17:09:49 +12:00
Lawrence Lee
7eb7fb210f Merge branch 'dev' into metadata-exiv2 2023-08-12 15:08:42 -07:00
U-PCSPECIALIST01\jdesm
269e426cc6 Another change to blendmask 2023-08-07 08:48:08 +02:00
U-PCSPECIALIST01\jdesm
8d437fec38 Change range blmask in iplocallab - thanks to hombre 2023-08-07 07:06:55 +02:00