510 Commits

Author SHA1 Message Date
Desmis
32329f306f Prepare rtengine for CH curve 2020-07-13 17:32:38 +02:00
Ingo Weyrich
d22fcb9df1 Cleanup for curves.* 2020-07-13 16:07:52 +02:00
Ingo Weyrich
bad0c0b1e7 Some cppcheck cleanups 2020-06-28 13:24:00 +02:00
Ingo Weyrich
a0eacde31a Merge branch 'dev' into cleanup_locallab_periphery 2020-06-28 12:20:54 +02:00
Ingo Weyrich
3bab9ec688 copy constructor for labimage, further cleanup for locallab periphery 2020-06-27 16:52:53 +02:00
Ingo Weyrich
f02c4e1fd1 use LUT_CLIP_OFF instead of 0 2020-06-27 14:30:58 +02:00
Ingo Weyrich
96c5eff50c Further cleanups to locallab periphery 2020-06-27 13:13:26 +02:00
Ingo Weyrich
d779a5ee2d fix segfault 2020-06-27 10:47:51 +02:00
Ingo Weyrich
6d824842af Further cleanups to locallab periphery 2020-06-26 22:25:58 +02:00
Ingo Weyrich
de787688a4 Further cleanups to locallab periphery 2020-06-26 21:49:43 +02:00
Ingo Weyrich
01e48cc809 Some first cleanups for locallab periphery 2020-06-26 21:20:26 +02:00
Desmis
1ef71095d5 merge with dev 2020-06-26 17:01:54 +02:00
Ingo Weyrich
d7c6b4b8f9 Export: Do not allocate memory for locallab if locallab is disabled 2020-06-26 12:34:54 +02:00
Desmis
20bc7af14f Change labels blend mask and default values - change range all soft guidedfilter 2020-06-26 11:19:41 +02:00
Desmis
6a03d8e325 first run that work...with bug...but save 2020-06-23 17:53:56 +02:00
Desmis
fb06a4dcfd Pass GUI parameters mask to rtengine and iplocallab.cc 2020-06-23 12:00:23 +02:00
Desmis
90dedb001f Add common mask curve to rtengine and iplocallab.cc 2020-06-23 09:17:37 +02:00
Hombre
f42548b018 Merge branch 'dev' into spot-removal-tool 2020-05-18 14:54:30 +02:00
Desmis
a806d00268 Merge with dev 2020-05-13 08:51:50 +02:00
Pandagrapher
bd3037a803 Some minor fixes in Locallab GUI 2020-05-12 18:35:33 +02:00
Desmis
fb4f64699b Use previewDeltaE information to show deltaE 2020-05-12 17:19:44 +02:00
Desmis
99fd6162f8 Clean code 2020-05-12 16:28:17 +02:00
Desmis
e25f5aa455 Rebuild wavtm with curve finerCoraser - language - various chnages to denoise 2020-05-12 09:11:16 +02:00
Pandagrapher
cca6b09768 Merge remote-tracking branch 'dev/newlocallab' into newlocallab 2020-04-20 12:54:09 +02:00
Desmis
f0e78b2a0d merge with dev 2020-04-18 07:43:44 +02:00
Pandagrapher
4ea4663e34 Merge with 'dev/newlocallab'... 2020-04-16 16:01:53 +02:00
rom9
22eee9787e
Film negative stable multipliers (#5485)
* Added new feature to calculate channel multipliers from crop area. This also saves the crop area channel medians to the processing profiles, in order to get a more consistent color balance when batch-applying the same profile to multiple pictures from the same film roll.

* Fixed wrong initialization of array, and missing check for the result of `getFilmNegativeMedians()`.
Moved `ImProcCoordinator::translateCoord()` from private member to anonymous namespace.
Fixed some whitespace and formatting issues.

* Fixed some formatting issues

* Passed `ipf` parameter as const in `translateCoord`.
Narrowed `using namespace` to single class `Coord2D`.

* Added `scaleGain` entry to thumbnail metadata file, to make `scale_mul` multipliers available in thumbnail processing phase. This simplifies multiplier calculations, so that "faking" thumbnail multipliers in the main image processing is not necessary anymore. This way, output values are immune to slight variations of multipliers between successive shots taken with in-camera AWB turned on.
Shifted multipliers so that the output channel medians are balanced when "Camera WB" is selected. This way, just computing multipliers from crop and setting "Camera WB" (which is the default) gives a pretty well balanced image as a starting point.

* New channel scaling method, based on a film base color sample instead of crop area channel medians. Channels are scaled so that the converted film base values are equal to 1/512th of the output range (65k). This giver better black levels in the output, and more consistency when batch-processing multiple negatives.
The output is now compensated for a known fixed WB value, so that the film base will appear grey when WB is set to 3500K, Green=1.
Added PPVERSION 347 to preserve backwards compatibility: when a processing profile saved by RT 5.7 is loaded (PPVERSION=346), the new fields are initialized to the special value -1, which will instruct the main processing to follow the old channel scaling behaviour. The old channel scaling multipliers will then be converted to the new film base values so that the resulting image is the same, and the fields will be overwritten as soon as the PP is saved again. This will transparently upgrade the processing profile.
When the new behaviour is used, but the film base values are still unset, they are estimated based on channel medians, excluding a 20% border around the image. This should give a better result out-of-the-box for pictures containing a large film holder.

* Code cleanup from review

* Run astyle on film neg source files

* Fixed automated build failure caused by incompatible libraries on my dev PC.

* Simplified `Thumbnail::processFilmNegative` method signature. There is no need to pass in `rmi`,`gmi`,`bmi` multipliers from the caller, i can do the same with my own internal multipliers.

* Added `FilmNegListener` class to pass estimeted film base values to the GUI after first processing. Removed old `filmBaseValues` instance variable from RawImageSource.

* Code cleanup

* Forgot to set baseValues flag in `PartialPasteDlg::applyPaste`
Fixed `filmBaseValuesLabel` not updating when reading zero baseValues. Normally not needed (the label is updated later by the listener), but when the user is browsing through pictures the listener won't fire, so the label must be updated to show values are unset.

* Overwritten channel scaling multipliers by calling `get_colorsCoeff` with `forceAutoWB=false`.
Initially, in `RawImageSource::load`, channels are auto-balanced by averaging the whole picture when computing multipliers.
This can give different multipliers for multiple shots of the same camera, which will lead to inconsistent conversions when batch-processing multiple negatives.
This commit re-sets `scale_mul`, `ref_pre_mul`, etc., in order to "undo" the auto-WB and use the normal camera multipliers.

* Found an easier way to get stable overall multipliers, removed the (horrible) on-the-fly mutation of scaling instance variables.
2020-04-13 17:20:56 +02:00
Desmis
c062d654bb merge with dev 2020-03-29 18:31:52 +02:00
Desmis
51f1198b65 Init blur by levels 2020-03-25 18:06:32 +01:00
Desmis
0ffa61748d Prepare ipwavelet and periph to TM 2020-03-22 15:31:36 +01:00
Desmis
1f4613cd3b GUI for TM wavelet 2020-03-22 10:37:21 +01:00
Desmis
e573de78b4 merge with dev 2020-03-19 13:40:11 +01:00
Ingo Weyrich
60caf17c7a Merge branch 'dev' into rawimagesource_cleanup 2020-02-29 09:35:33 +01:00
Ingo Weyrich
77be7605d8
"Auto" => "autold", #5676 2020-02-28 12:02:38 +01:00
Ingo Weyrich
f7792aa936 some cleanups 2020-02-27 21:22:34 +01:00
Ingo Weyrich
4590607ea5 simpleprocess.cc : be cppcheck clean 2020-02-27 14:54:17 +01:00
Desmis
81c6e4635d merge with dev 2020-02-24 11:05:55 +01:00
Pandagrapher
209eccba8a Add improved copy/paste or save/load for Locallab spots
Preliminary work: "nbspot" and "id" spot parameters have been removed to
simplify Locallab spots management.
2020-02-20 20:35:29 +01:00
Ingo Weyrich
f0b5ca02e7 More double promote fixes 2020-02-10 16:22:42 +01:00
Desmis
82d8844ee6 Prepare Edge Sharpness wavelet pyramid 2020-01-26 10:17:34 +01:00
Desmis
6e3fd503cc Added show modifications to sharpening 2020-01-21 09:14:39 +01:00
Desmis
ba7a61c391 merge with dev 2020-01-13 08:33:45 +01:00
Desmis
31d3b7bb4c merge with dev 2020-01-07 10:16:40 +01:00
Desmis
5823ad39f2 First dynamic wavelet compression pyramid 2020-01-03 13:41:25 +01:00
Desmis
95a2b21aa4 Improve dynamic range compression 2020-01-02 17:08:05 +01:00
Ingo Weyrich
2ce6e6d1d3 skip unnecessary transform 2020-01-02 14:35:27 +01:00
Ingo Weyrich
085c68fc29 Log tranform: fix bug in preview mode 2020-01-01 19:06:02 +01:00
Desmis
46b9aa95e2 Added mask to local contrast 2019-12-21 12:51:27 +01:00
Desmis
cf214c7a1b Save provisory work GUI 2019-12-20 18:16:10 +01:00
Desmis
8361591e0e Simplify denoise curve replace 4 sliders luminance 2019-12-20 08:52:52 +01:00