68 Commits

Author SHA1 Message Date
Lawrence Lee
0fdac3797a
Merge branch 'dev' into browser-preview-applied-pparams 2023-08-29 22:58:51 -07:00
Lawrence Lee
6787c53c9b
Show black level adjustments in file browser
File browser thumbnails for raw images start with a minimally-processed
images. These images are cached and image adjustments are applied on
top. The black level is "baked-into" the cached image. Therefore, to
reflect the black level adjustments in the thumbnail, one of two options
are required:
    1. Cache an image before the black level is applied and process the
       black level on top of this image.
    2. Recreate the base image with the new black level and cache it.
The first option yields better performance when the user changes the
black level. However, it requires other base adjustments to be applied
every time, such as the camera multipliers. The second option requires
the base image to be recreated every time the black level is changed.
This commit implements the second option. It minimizes code changes, and
therefore possible bugs. It does add a performance penalty when the
black level changes, but the black level adjustment is rarely used.
2023-07-29 17:37:13 -07:00
Lawrence Lee
0729deec4b
Merge branch 'dev' into metadata-exiv2 2023-03-22 23:01:40 -07:00
Desmis
69c1caafa1
Whitebalance - Removed GUI Itcwb from whitebalance and preferences (#6710)
* Change Preferences for observer whitebalance

* Change label white balance preferences

* Added Preferences 2 parameters Whitebalance auto correlation

* Add Preference Temperature correlation - sort and tooltip

* Change to rtengine cmakelist

* Apply patch from Lawrence37

* Small comment code

* Change defaut order prefrences wba

* Added force extra algoritm to Preferences

* Harmonize itcwb sorted

* Add fields to Preferences Itcwb

* Change settings precision Itcwb in Preferences

* Change tooltip Itcwb preferences

* First stage Itwcwb settings in main with pp3 and selction in preferences

* Second stage Itwcwb settings in main with pp3 and selction in preferences

* Third stage Itwcwb settings in main with pp3 and selction in preferences

* Add itcwb_fgreen student - green optimize

* Add Itcwb green range

* Itcwb history msg - first tooltips

* Remove force-extra because always used

* reused force-extra to use entire CIExy for sampling datas

* Removed inwanted text in console

* Set sensitive for Itcwbframe

* Various change - comment ..

* Small code review - chnage tooltips

* Remove settings itcwb_delta in Rawimagesource.cc to simplify

* Remove Itcwb Observer - put a single observer for everything - general - itcwb

* Fixed conflicts in colortemp.cc

* Various change - fixed bug - simplify

* Fixed limits for settings pp3 - chnage tooltip

* Clean unused code

* Put itcwb_findgreen in GUI

* Added checkbox 'Low sampling' to find the settings of 5.9

* Set Observer to Observer 10° - preferences default

* Missing setting Low sampling

* Show white balance multipliers

* Change default settings - Itcwb_sorted

* Move observer from preferences to WB

* Make observer selectable for camera WB

* Ensure observer checkbox is in sync with PP3

* Set default ITCWB low sampling for PP3s from <=5.9

Ensure temperature correlation white balance algorithm 1 is used when
opening edits from versions 5.9 and earlier.

* Removed unused White-balance frame in Preferences

* Comment some GUI sliders checkbox

* Removed all GUI itcwb in preferences and whitebalance

* Removed forgotten code in preferences

* Remove labels tooltips history Itcwb

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2023-03-19 07:47:58 +01:00
Thanatomanic
9fcf45dca5 Several fixes and changes made by Floessie earlier 2021-04-27 21:35:43 +02:00
Thanatomanic
ae754b2492 Merge branch 'dev' into metadata-exiv2 2021-04-27 09:59:52 +02:00
Flössie
75f44d3f2b Fix LTO and _FORTIFY_SOURCE=2 warnings (fixes #5965)
Tested with GCC 9 and 10 on AMD64.
2020-10-26 11:28:15 +01:00
Thanatomanic
8b4389ade9 Resolve exiv2 merge conflicts and merge with 2020-10-16 11:45:26 +02:00
Ingo Weyrich
b2443b0e7e more double promote fixes, still not complete 2020-01-21 00:16:27 +01:00
Ingo Weyrich
cac2eb53ef Further reduction of include dependencies 2019-10-31 20:41:08 +01:00
Flössie
aacea7046c Fix Clang warnings plus some cleanups 2019-10-31 08:56:38 +01:00
Ingo Weyrich
1acca23fe1 Further cleanup of include dependencies 2019-10-29 22:45:26 +01:00
Flössie
28f0bc14da Merge branch 'dev' into metadata-exiv2
- Rating (#5325) not yet implemented
2019-09-24 14:30:54 +02:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
Ingo Weyrich
4fedfb2b26 cppcheck: further fixes 2019-08-06 22:10:38 +02:00
Flössie
ba4de904cc Cleanups and a few fixes 2019-05-10 21:24:22 +02:00
Alberto Griggio
c360fd7e2c Use exiv2 for metadata handling 2019-05-06 09:27:44 +02:00
Flössie
1b08ac44c4 Fix potential bug in histogram matching (#5249) 2019-04-03 19:41:36 +02:00
Morgan Hardwood
d4f0a9a19b Fix crash in histogram matching #5249
Patch by Alberto
https://github.com/Beep6581/RawTherapee/issues/5249#issuecomment-477923928
2019-04-03 10:14:49 +02:00
Ingo Weyrich
28b785682a
Allow histogram matching for YI M1 Camera (160x120 thumbs) 2019-03-19 17:43:42 +01:00
heckflosse
d4d535720d Don't apply histogram matching when thumb has less than 19200 pixels 2019-03-19 15:09:18 +01:00
Ingo Weyrich
209cc16e0d
Update histmatching.cc
Allow even smaller thumbs for histogram matching. Tested on Phase One 65+ files. Works fine.
2019-03-18 21:21:56 +01:00
Ingo Weyrich
1cf1e111d5
Update histmatching.cc
Allow histogram matching also for small thumbs
2019-03-18 17:43:17 +01:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
Alberto Griggio
fd48b34cd5 curves: restored the old DCT_Spline implementation (cubic splines), and added new DCT_CatumullRom curve type 2018-12-06 14:11:49 +01:00
heckflosse
831e18ca45 Add override keyword. Thanks @Floessie 2018-11-22 16:19:16 +01:00
Alberto Griggio
53a99837e5 histmatching: avoid concavities in the upper part of the matched curve (assumed to be S-shaped)
Fixes #4979
2018-11-12 22:23:25 +01:00
Alberto Griggio
97e73457ee histmatching: use better spaced points for the generated curve 2018-08-13 14:18:59 +02:00
Alberto Griggio
0d7d1cfc8c more tweaks to catmull-rom and histogram matching after the feedback by DrSlony 2018-08-11 23:40:21 +02:00
Alberto Griggio
2bb27661a2 various tweaks to catmull-rom 2018-08-10 08:05:41 +02:00
Hombre
3a6556404a Merge branch 'dev' into testoutputprofile 2018-07-22 03:25:49 +02:00
heckflosse
3329f6ef89 Removed Stopwatch 2018-07-10 13:39:29 +02:00
heckflosse
19371b4b5d Merge branch 'dev' into histmatching-if-needed 2018-07-10 12:30:57 +02:00
Alberto Griggio
eedad21326 histmatching: use the same amount of pixels for the matching regardless of the image orientation 2018-07-10 11:05:35 +02:00
heckflosse
eeebe587ba Call Histogram matching only if necessary, #4674 2018-07-08 20:24:17 +02:00
Alberto Griggio
ee345ba376 histmatching: use fewer points in the auto-matched curve
makes editing the curve by hand much easier
2018-07-02 17:41:50 +02:00
Hombre
fb0c95969b Creation of the ICCProfileCreator 2018-06-25 00:43:11 +02:00
Hombre
fbc81028eb First batch of variable name normalisation in ICM tool, see #4478 2018-05-14 00:57:55 +02:00
Desmis
6dc36cfd18 Fixed bug Output Profile does not worl at all 2018-04-15 17:22:45 +02:00
Alberto Griggio
100da304b8 do not perform histogram matching if the embedded thumbnail is too small
Fixes #4467
2018-03-27 14:41:19 +02:00
Alberto Griggio
95a5f3d662 fixed compilation that was broken by merging 'enhanced-inspector-mode' 2018-03-27 13:46:20 +02:00
Alberto Griggio
e265d23e76 made histogram matching depend on the input profile
This improves the accuracy of the matching when using non-default profiles
2018-02-02 13:57:43 +01:00
heckflosse
7848915e58 Small ~10% speedup for histogram matching on fast decoding raw files 2018-02-01 15:32:57 +01:00
Alberto Griggio
f3b5fc791e histmatching: use the cache even when not in verbose mode
Fixes #4350 (thanks heckflosse!)
2018-02-01 13:50:41 +01:00
Alberto Griggio
7dd598d9b7 bug fixes by heckflosse 2018-01-31 21:24:56 +01:00
Alberto Griggio
74e31dff45 histmatching: dynamically adjust the skip factor according to the side of the embedded thumbnail
with large the embedded thumbnails we should skip less to improve the quality of the matching
2018-01-31 18:09:28 +01:00
Alberto Griggio
b09aeaa6ae avoid one useless copy if no cropping is required 2018-01-31 17:06:39 +01:00
Alberto Griggio
79324ed5d0 more fine-tuning of the histogram matching
make sure we do not place curve points in regions of the histogram that are
outside the dynamic range of the input images -- that would be wild guessing,
better to just leave this to the spline interpolation
2018-01-31 10:34:50 +01:00
Alberto Griggio
fdde31839d incorporated Floessie's feedback 2018-01-31 08:29:19 +01:00
Alberto Griggio
c04150be35 histmatching: slightly improved match for the shadows part of the tone curve 2018-01-30 15:27:56 +01:00