* GHS GUI first step
* GHS GUI first step
* GUI step 3
* Hide show ghsmethod
* Siril functions for ghs
* Init ghs in iplocallab
* ghs step 2
* ghs step 4
* Comment copyright Pixlnsight 2021
* Smooth highlights and tooltips
* Enabled saturation and luminance ghs mode
* First tooltip
* Ghs tooltips
* Remove wrong packstart inverssh
* Change labels and tooltips
* Disabled mask in global and other improvments
* Comment code
* appimage and windows yml ghs
* Change tooltip
* Ghsmethod hue and change tolltips
* Change tooltip
* Inverse Stretch step 1
* Inverse GHS
* GHS tooltips
* Change tooltips
* Change tooltip
* Linear black point
* Small change to blackpoint
* Change tooltip
* Clean and comment code
* forgotten GHS highlight attenuation msg in history
* Comment code with Transformation equations
* Change tooltip
* Wrong default value balck point
* Comment code iplocallab
* Ghs curve step 1
* GHS curve step 2
* Show GHS setting in a Curve Box
* Tooltip for ghs S curve
* Disabled warning in compilation simpleprocess
* Simplified code part 1
* Simplified code GHS graph part 2
* Improve black point with negatives values
* Improve BP and tooltip
* Listener enable only with GHS
* White point for GHS
* Change label and tooltip
* Improve behavior white point and black point
* Link sliders ghs_SP ghs_LP ghs_HP and change code to avoid balck screen
* hide unused button in diagonal curve GHS
* prevents the GHS representation in S from displaying artifacts if ghs-d=0
* Change tooltips
* Improvment and tooltips
* Forgotten tooltip
* Improve GUI GHS S curve - change tooltips
* Set transition gray areas in S curve GHS with values of the RT-spot
* Change label GHS
* setlogscale blackpoint and symmetry
* Set recursive reference enable by default in controlspotpanel
* Change lastlocalCurvesDir Dirghs in locallabtools and options - change labels
* Added in converttonormal ghsMode.. not sure if this is useful
* DIY to make GHS curve work without the choices
* Change RGB calculation with luminance function working profile
* 5 modes GHS method
* Label to show datas clipped Black point and White point
* Various change white point tooltips
* Bad behavior wp bp labels
* Small change to improccordinator call to ghschanged ghsbwchanged
* Set log scale ghs_D
* Hide Graduated filter if GHS enable
* Luminance Lab in ghsmethod
* Lab slope factor step 1
* Slope and Chromaticity GHS improvments
* Fixed bad sqrt line 17477 iplocallab
* Workaround linear GHS - re-enable Graduated filer GHS
* Change limits slope lab factor
* Ghs chromaticity Lab (Lch)
* Improve ghs chromaticity
* Change labels and tooltips Lab chroma
* Slope Lab to 100
* Noise and saturation RGB
* Saturation RGB standard and labels
* Change histogram and navigator panel without gamma when using working profile
* Remove gray in GHS curve
* Local contrast a minima
* Regularization stretch
* Improve Graduated Filter in all cases GHS Color and Light etc.
* Improves nlmeans to reduce noise after GHS
* Change to GF - tooltip Nlmeans
* Added oW oH tW tH etc.
* Added call GF
* tX tY for previewProps
* Comment code GF
* Improve local contrast ghs
* Change norm to norm2
* Improve GUI mode complexity and Lab GHS
* Show values BP WP in GUI
* Labgrid ghs step 1
* Labgrid for simulation GHS - step 2
* More points for Labgrid ghs
* Clean and comment code
* Fixed crash in inverse GHS white point - set to 10 points for GSH simulation
* Change to black point in inverse GHS
* Intilialize simulation with nothing if new spot
* Remove curve GHS - optimize code simulation - improve GUI
* set ghs default - fixed crash is case HP SP LP
* Fixed crash - I hope in inverse GHS
* Simplify WP and BP limits to avoid crash in inverse GHS
* Clean code with ghscurve - ghsshape
* Change tooltips
* Change to D - GUI - comment code
* Simulation with 4 more points
* Best simulation with point 0.05 and 0.95
* Clean code - change for crsah in Inverse GHS
* Show values WP and BP
* Change tooltips
* Midtones after GHS
* Modification code WP BP
* Tests changes in settings for transition and Shape detection - see Preferences
* Change order labels luma chroma hue
* Fixed bad behavior localllistener denchanged in dcrop.cc
* Save work
* Work on graduated filter
* Improve a little graduated filter SH and others...
* 3 configurations tests graduated filter SH plain image - color more sk - exposure normal
* Forgotten code ...
* Change improccordinator parameter
* Save work printf parameters GF
* New test for GF
* Hide plain image calculation GF
* Small chnages and comment code
* Change tooltip exp graduated filter
* Change tooltip exp graduated filter
* Save work
* Change GF for some tools only in Global and Fullimage - test for GF SH mode plain image
* Fixed crash and GUI part 1
* Others change GF
* Change label - allow GF plain image in SH
* Change GF with cx cy sk
* Adapt locallabtool and locallabtools2 to GF
* Clean code
* GF wavelet only in fullimage and global
* GF - Empirical correction to cx and cy in function of sk
* Change label GHS and position in GUI
* Fixed Black point bad behavior history - an oversight may be age
* Change real strength of GF - to look like GF main
* Include ksk - Skip correction in all code GF
* Passed other parameters to try
* New parameter for GF
* Change position graph-curv ghs and labels black and white point
* Change behavior and default value white point
* Save provisory work
* Save provisory work
* Curve GHS with 21 points including 0 and 1
* Two prameters added to change behavior GF - rationalize their using
* Change Black point direction
* Change range black-point for negatives values - chnage tooltips
* Change tooltips
* Various change to avoid crash and settings defaults
* Disabled showmùaskmethod - set max white point to 5
* Fixed bad behavior when change fullimage to global for mask
* Clean comment code
* Fixed - I hope - bad behavior when we go from Fullimage to Global and vice versa
* Fixed crash in output tif and show time to calculate WP and BP
* Change tooltip BP and WP
* Change tooltips BP WP
* move GF after GHS so as not to influence BP and WP
* Clean code
* Disable all mask and modifications in Global but remain active in fullimage and normal
* Change tooltip graduated filter
* Restore GF in normal mode - and increases GF strength as before
* Clean code locallabtools 1 2
* Comment in calclocalGradientParams in iplocallab for changes in Graduated F
* Change convention labels - tooltips
* Change tooltips
* improves (I hope) the readability of the tooltips
* Remove with comment change complexity in Settings
* Improve settings BP WP - improve tooltips
* Refactor GHS curve and increase resolution
Simplify how the curve parameters are passed to the drawing area.
Use up to 400 line segments to draw the curve.
* Update GHS curve tooltip
Remove statement regarding the number of points used because it is no
longer accurate.
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Change Luma with Lightness
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Update rtdata/languages/default
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
* Remove warnings in icmpanel
* Changes suggested by Lawrence37
* GHS - Hide inverse always show in some cases - improve tooltip BP WP
* Change tooltip
* Change tooltip
* Small changes
* Change tootip suggested by Lawrence37 - set midtones and LC set_sensitive in function of D
* Add tooltip as suggest by Lawrence37 for LC and midtones
* Remove tooltip on Frame LC and Midtones
* Remove all traces toottips frame LD and Midtones
* set sensitive BLP and HLP to false if stretch = 0
* Change Beep6581 to Rawtherapee in appimage.yml and Windows.yml
* Hide LC and midtones when Stretch = 0
* Clean up Generalized Hyperbolic Stretch code
Convert some ints into enum classes.
Replace new/delete with std::unique_ptr for image.
Remove unused GHS parameters in ProcParams and ParamsEdited which were
used to draw the curve.
Revert changes to the curve editors because they are not needed.
Simplify the drawing of the curve background for efficiency.
Restore the const-ness of some variables.
* Change appimage.yml and windows.yml
---------
Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
Some lens profile methods provides a way to correct distortion and CA in
a single step.
When available, applying distortion and CA correction when both enabled
in a single pass is more precise (see lensfun
ApplySubpixelGeometryDistortion doc) since it's usually how the profile
is done. Instead applying the CA correction in a step after distortion
correction could lead to a bit different (also if not always visible)
correction.
This is also required for future lens correction methods (like DNG
WarpRectilinear or corrections based on vendor metadata) that provides
only merged distortion and CA correction in a single pass.
Doing profile based CA as the really first correction in a separate steps is
probably not useful.
Additionally many lens profile (lensfun) and future one provide
functions to do them in a single step with better precision while other
just provide a single step that does both (i.e. DNG WarpRectilinear).
For the above reasons this patch removes the additional pass for CA correction.
This will also improve the perfomance due to less work.
Don't update the camera-based perspective focal length and crop factor
parameters when making other adjustments using the file browser or batch
editor.
Closes#6402
Scaling is applied at the end of all geometric transformations, so it
would be more appropriate outside of the perspective correction tool.
Such an implementation would also work better with the auto-fit feature.
If the focal length and/or crop factor for the camera-based perspective
correction tool are not edited, they will be set using the focal length
information found in the image metadata. This only applies to the editor
(batch editor and CLI still default to 24 for the focal length and 1 for
the crop factor).
Resolve minor conflict in ImProcFunctions::transformGeneral and add new
arguments for use of ImProcFunctions::needsTransform in
PerspectiveCorrection::autocompute.
This rotation is different from the Rotate tool and the post-correction
adjustment rotation because it is applied between camera shift and
camera angle. It is equivalent to correcting the camera's roll and is
the same as the rotation calculated by automatic perspective correction.
Lensfun/LCP distortion correction was applied before automatic scaling
and perspective correction in the inverse transformation. This means it
was applied after scaling and perspective in the pipeline. It should
actually come first.
