Commit Graph

4936 Commits

Author SHA1 Message Date
Lawrence37
2c51b822a3 Merge pull request #6889 from Lawrence37/wprof-crash-fix
Fix for segfault due to wprof being null
2024-01-27 21:47:55 -08:00
Lawrence37
8f1f532fe6 Merge pull request #6878 from Lawrence37/switch-image-fix
Fix for crash when moving cursor over loading raw image
2024-01-27 21:47:15 -08:00
Lawrence37
4dd7517a55 Merge pull request #6873 from 0v3rt1r3d/0v3rt1r3d/fix-a-couple-of-warnings
Fix a couple of warnings
2024-01-27 21:46:14 -08:00
Lawrence37
9b7aef5d58 Merge pull request #6865 from CarVac/dev
Fix camconst.json white levels for 1DxII
2024-01-27 21:45:40 -08:00
Lawrence37
255a0c7086 Merge pull request #6906 from Lawrence37/fix-odd-raw-crop-raw-ca
Fix for wrong colors when the demosaic border is odd (dev)
2023-12-23 11:18:31 -08:00
Lawrence37
85746a8093 Fix bad colors when demosaic border is odd
Colors are incorrect if the demosaic border is odd and raw chromatic
aberration is enabled.
2023-12-21 22:09:32 -08:00
Desmis
31bf942d92 Local adjustments - Show additional settings - link with complexity (#6899)
* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds
2023-12-17 08:37:20 +01:00
Lawrence37
1839db448d Merge pull request #6793 from Lawrence37/nr-gain
Option for disabling noise reduction gain
2023-12-16 11:11:24 -08:00
Lawrence Lee
a95a58a8a3 Fix sRGB working profile crash
The sRGB working profile cannot be found under some conditions because
the profile name is stored as a Glib::ustring and the same strings may
not be equal when using different locales. Use std::string whenever
comparing profile names.
2023-11-19 17:22:43 -08:00
U-PCSPECIALIST01\jdesm
1e7cedf3cb Ftblockdn - remove unwanted messages in console 2023-11-17 09:38:46 +01:00
Desmis
5acf1c0a7f White Balance - temperature correlation in batch mode - issue #6867 (#6877)
* Change Itcwb in simpleprocess

* Change for auto RGBgrey

* remove unnecessary code
2023-11-07 07:38:13 +01:00
Lawrence Lee
831a9bbd55 Fix crash when opening image in editor
Do not access uninitialized raw image data. The raw data is requested
when the demosaic mode is set to None and the cursor is moved over the
image in the editor. It can occur before the raw data is loaded.
2023-11-03 21:48:21 -07:00
Alexander Gruzintsev
de82b9fc7a Fix warnings: conversion to double/float, unused variables, register keyword 2023-10-30 08:18:33 +01:00
Lawrence Lee
0e835e8c00 Fix crash in noise reduction
Fix upper bound for array access while building histogram of absolute
values in mean absolute deviation (MAD) calculation.

Fixes #6871.
2023-10-29 16:20:12 -07:00
CarVac
29748d057a Update camconst.json white levels for 1DxII 2023-10-14 15:22:08 -04:00
Desmis
d276a56b10 Local adjustments - improvment Dehaze with black (#6860)
* Local Dehaze black

* Enable black

* Change threshold black - publish_pre_dev_labels ladehazeblack
2023-10-12 06:59:33 +02:00
Lawrence37
ab8de06c66 Merge branch 'dev' into nr-gain 2023-10-10 21:03:03 -07:00
Flössie
2a87c65a14 Fix UB in ProcParams::load() and the resulting Clang 15+ miscompilation
Fixes #6847.
2023-09-15 15:24:24 +02:00
Lawrence Lee
97e181bd58 Fix automatic distortion correction crash
Closes #6840.
2023-09-09 14:59:14 -07:00
Lawrence37
f93c3ddf94 Merge pull request #6838 from Lawrence37/canon-various-camconsts
Raw crop and masked areas for a few Canon cameras
2023-09-05 18:32:34 -07:00
Lawrence37
c3a97f0304 Merge pull request #6836 from Lawrence37/ilce-7m4-raw-crop
Raw crop for Sony ILCE-7M4
2023-09-05 18:30:09 -07:00
Lawrence Lee
7c73da7723 Fix Olympus E-M10MarkIV white level
Closes #6236.
2023-09-04 14:31:03 -07:00
Lawrence Lee
408b41dc72 Raw crop and masked areas for a few Canon cameras
- Fix masked areas for EOS RP 1.6x crop mode
- Masked areas for EOS M50, EOS M50m2, and EOS M100 (all the same)
- Raw crop and masked areas for EOS R 1.6x crop mode
2023-09-03 18:03:08 -07:00
Lawrence Lee
6fb8ded886 Add Sony ILCE-7M4 raw crop
Remove 10 columns of bad pixels from the right border.
2023-09-02 22:03:34 -07:00
Lawrence Lee
0fdac3797a Merge branch 'dev' into browser-preview-applied-pparams 2023-08-29 22:58:51 -07:00
Beep6581
e189a1a4ec Merge pull request #6817 from ss23/clang_windows_mingw_64bit_fix
Use `_WIN32` instead of `WIN32` to detect Windows
2023-08-29 00:47:13 +02:00
Beep6581
15144e4cc2 Merge pull request #6703 from Beep6581/om5
OM Digital Solutions OM-5 camconst #6699
2023-08-28 22:51:35 +02:00
Lawrence37
ac48cc55d8 Better use of cache with inpaint opposed highight reconstruction (#6822)
* Speed up preview when inpaint opposed enabled

Only reprocess from raw if the white balance is changed. Otherwise, a
cache from later in the pipeline can be used.

* Remove unused code

* Fix refresh map bit positions

* Make WB & inpaint opposed refresh less brittle

Co-authored-by: Hombre57 <natureh.510@gmail.com>

---------

Co-authored-by: Hombre57 <natureh.510@gmail.com>
2023-08-15 07:52:38 -07:00
Stephen Shkardoon
23f2a2fc9f Use _WIN32 instead of WIN32 to detect Windows
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here.
http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
2023-08-13 17:09:49 +12:00
Lawrence Lee
7eb7fb210f Merge branch 'dev' into metadata-exiv2 2023-08-12 15:08:42 -07:00
U-PCSPECIALIST01\jdesm
269e426cc6 Another change to blendmask 2023-08-07 08:48:08 +02:00
U-PCSPECIALIST01\jdesm
8d437fec38 Change range blmask in iplocallab - thanks to hombre 2023-08-07 07:06:55 +02:00
Lawrence37
0052f08e94 Merge pull request #6794 from Lawrence37/auto-dcp-locale-fix
Fix for Auto-matched camera profile detection when using the English (US) language
2023-08-06 14:52:08 -07:00
Lawrence37
ec24613f3b Merge pull request #6778 from Lawrence37/eos-7d-markii-raw-crop
Improved raw crop for Canon EOS 7D Mark II
2023-08-06 14:48:35 -07:00
Lawrence37
7e0f0b6636 Merge pull request #6807 from Lawrence37/ilce-7rm2-pdaf-pattern
Fix PDAF lines pattern for Sony ILCE-7RM2
2023-08-06 12:30:10 -07:00
Lawrence Lee
4faea6df7b Merge branch 'dev' into eos-7d-markii-raw-crop 2023-08-06 11:58:30 -07:00
Lawrence Lee
c5a0067eee Merge branch 'dev' into metadata-exiv2 2023-08-06 10:25:49 -07:00
Desmis
8d0333120e Research and development - WB auto -temperature correlation - tests - finding the optimum settings (#6643)
* Change estimchrom estim hue final

* Itcw observer checkbox

* 8 spectral colors

* 11 spectral colors

* 6 spectral colors

* Small change to correction green

* Fixed various bad behavior - settings itcwb_deltaspec

* 4 spectral colors green

* 3 green spectral colors

* 3 spectral colors green

* 5 spectral colors red green

* 3 spectral colors red green

* 3 spectral colrs green red

* Chnage slider choice deltaE - to size color patch

* display more info in console

* Display more info in console - comment code

* Clean - comment code

* 8 spectral colors green red

* 8 spectral colors blue

* 8 spectral colors blue

* 3 spectral colors

* 6 spectral colors

* 4 spectal colors

* 2 spectral colors

* Eliminate high Y - increse temp iteration - recenter selection inside patch

* compatibility 5.9

* Modify dislay and place selected dats in patch

* Dispaly in console hue chroma image selection

* First optimization

* optimization code - clean unused variables

* Remove sorted in chroma order - some others changes

* 5.9 compatibility

* Clean and optimize code

* Clean code - more display info in console

* More info in console - set itcwb_minsize in option

* Display patch chroma in GUI

* Change some default settings

* Minsize patch GUI

* Display GUI patch size

* Chroma patch variations

* Display in GUI min and max dats found in patch

* Some adjustments

* Remove too low datas in patch

* Various improvment - ponderate

* Clean code colortemp comment spectral datas

* Comment code - correc gren

* Comment and refine code

* Fixed bug in improcoordinator

* fixes a malfunction of AWB bias in improcoordinator

* Various improvments - clean code

* 2 improvments green and find patch

* Allows parametrind ponder and Ypurple in options

* Update autowb - filter on magenta purple

* Clean and optimize code

* Read colors in GUI

* Denoise median 5x5 image datas before Itcwb

* Change to GUI

* Replace median5x5 by 2 median3x3 - clean GUI code

* Work around to recalculate wbauto

* Remove work around - change params->wb related change

* Disabled low_sampling 5.9

* First try for compatibility Low sampling 5.9

* Re-enable WB autogrey

* Change reference image to autogrey if camera settings probably out

* Clean code aand adjust settings camera out

* Format astylert rawimagesource.cc - various small adjustments

* Small correction

* Small green correction

* Change default settings - correction to autowb bias in improccoordinator

* Save provisory work

* Save provisory work 2

* Try to find good tempitc with iterate when temptitc very different 5000K

* Change 2 default settings

* Work around awb temp bias

* Limit work around bias - small other changes

* 3 spectral colors deep blue

* 4 spectral color deep blue

* 4 color spectral yellow

* 5 spectral colors neutral red-magenta

* 5 spectral color neutral red magenta

* Change threshold tempitc

* 5.9 compatibility

* Work around bad claculation Planck's formula

* Fixed bad behavior when using blackbody spectal

* 6 spectral color - checkbutton remove 2 passes

* Fixed various bugs

* Format rawimagesource.cc

* Various improvment before to find the good selection

* First new optimization (perhaps?)

* Display GUI patc deltaE

* Various optimzation and tooltip

* Default observer 2°- Simplify GUI - improve display GUI - remove too low numbers datas

* 4 spectral colors - change 2 settings

* Change calculation threshold 2 passes

* 6 spectral colors magenta

* 13 spectral colors

* Improvment GUI display

* remove checkbutton no_purple

* 2 spectral colors - remove in GUI low sampling 5.9

* Change default setting display in console

* Change behavior when temp near stdA

* 4 spectral colors - settings Itcwb_tempstdA

* Gamut control on image histogram

* Clean code and format rawimagesource.cc

* Comment and format colortemp.cc

* Remove unused fileds from GUI - change tooltips

* Add tooltips

* Various changes

* Change settings when camera temperature is out

* improvment extra and tooltip

* Small change when using auto grey as start reference

* Remove itcwb_fgreen from GUI

* Various change - and 'unsatisfactory' test to take into account Custom

* Change second temp when < 4000 - replace automatic by automatic and refinement

* Neutralize 'Use custom tempertaure and green'

* Green refinement

* Clean code - small changes

* Other clean code

* Added forgotten itcw_green in procparams.cc

* Fixed a bug dispaly deltaE

* Change threshold settings - change code for Custom

* various change in case of using camera settings

* Change way to estimate range green

* clean code and message in console

* Clean and optimize

* Disable 2 passes if custom

* Improve GUI 2 passes

* Increase sampling and number of temperature above 9400K

* Hide AWB temperature bais and green refinement when Custom temerature ans green

* marks out the code with past time markers

* Improve time processing with spectral colors temp calculations

* Replace in console msec by nsec

* Scan temp 5.9

* Change max temp and behavior if temp > 15000k

* Refine temp near 14000K

* Increase sampling temperature 132 to 167

* Increase sampling temperature

* Set in preference choice for itcwb_custom

* White point calculated  with observer instead of table

* More on whitepoint calculation - informations

* Clean and format code with astyle colortemp.cc rawimagesource.cc improccoordinator.cc

* Small change tooltip

* Improve update auto-wb

* Remove 'use custom temperature and tin' - simplify sampling to 2 choice

* Small change to rand AWB bias - green refinement - tooltips

* slightly modify the parameters upstream of the algo - do not use camera in some cases

* Mixed initial green

* Refine init green and temp when no camera

* Refine temp and green in do not use camera settings

* Change tint threshold and various improvments (tooltips, wrong values..)

* Refinment and clean code

* Improve mode No use camera settings

* Init nocam

* Refine use no camera  settings

* Small change

* 5.9 compatibility - and format

* Refine sampling temperature  around 7000 - 8000K

* Format astylert rawimagesource colortemp

* 5.9 settings

* 5.9 settings 2

* Various change - 5.9 - format

* Improve pre and post algorithm

* Fixed correction temp > 8000K

* Fixed bad behavior Tppat.minchroma

* Change sampling choices and tooltip

* Change name wp wp2 wip to wb wb2 iwb to avoid misunderstood

* Small Change settings - limit display studgood to 0.0001

* Improvment display GUI temp

* Change default sampling

* Change ACESP0 to JDCmax

* Improve GUI abstract profile

* Allows dispaly in console xy values thanks to Reffort

* Remove bruce rgb in wp and abstract

* Change wp abstract and save itcwb with dispaly cellxy

* Change prim = 13 improccoordinator iplab2rgb

* remove display datas in console - fixed wrong display Y xyY

* Fixed ifferences in GUI maxhist minhist

* Change limits x y in function sampling

* fixed a dizziness

* Change  after algorithm rule when temp > 6000K

* Harmonize limx limy for oldsampling 5.9

* Added Cam xyz matrix to sampling - thanks to Reffort

* Display in console xyz matrix

* Forgotten instruction when mix camera and autowb grey

* Change rgbloc with Camera matrix Dcraw when no input profile

* Change rep to repref in rgbxyz

* Remove message in console

* 5.9 compat

* 5.9 compat 2

* 5.9 compat 3

* 5.9 compat 4

* 5.9 compat 5 format

* 5.9 compta 6

* Improve code

* Diasble itcwb_sampling in GUI

* Comment code

* Clean and comment code

* 5 spectral colors

* 9 spectral colors

* 2 spectral colors

* Various improvments

* 5 spectral colors

* 5 spectral colors

* First changes review lawrence37

* Second changes review Lawrence37

* 3rd changes review Lawrence37

* 4th changes review Lawrence37

* Change windows and appimage yml

* Re-enable Rtv4_Bruce in procparams.cc

* test for 5.9 compatibility

* Try to fixed crash

* Slightly improve the management of 5.9

* test for 5.9 compatibility by passing parameters via the GUI

* Forgotten parameter

* Change ref_spec limit and remove pac_start for itcwb_sampling

* Puts back the old Planck formula - the same as in dev

* Revert "test for 5.9 compatibility by passing parameters via the GUI"

This reverts commit d6b5a8feda31b93a5574cee6ebf4d3e9d58bbcfb.

* Switch to new ITCWB only when changing WB method

Prevents sudden changing of the white balance if ITCWB is selected and
the image is reopened.

* Fix spelling in comment

* Suggested change from Lawrence37 to whitebalance - small change to improcoordinator

* tempbias Set_sentive(false) if itcwb_smapling - clean whitebalance

* Another clean whitebalance.cc

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2023-08-06 13:44:48 +02:00
Jean-Christophe
00fff386c7 Merge pull request #6722 from hfiguiere/crop-leak-6721
Issue #6721 - Fix memory leak in Crop
2023-08-06 12:57:43 +02:00
Lawrence Lee
5c42a50204 Fix PDAF lines pattern for Sony ILCE-7RM2 2023-07-30 14:25:17 -07:00
Lawrence Lee
b0c53be783 Render abstract profile and white level in browser
Enable rendering of abstract profile adjustments in the file browser
thumbnail.

Fix updating of white level in the thumbnail.
2023-07-29 18:39:35 -07:00
Lawrence Lee
6787c53c9b Show black level adjustments in file browser
File browser thumbnails for raw images start with a minimally-processed
images. These images are cached and image adjustments are applied on
top. The black level is "baked-into" the cached image. Therefore, to
reflect the black level adjustments in the thumbnail, one of two options
are required:
    1. Cache an image before the black level is applied and process the
       black level on top of this image.
    2. Recreate the base image with the new black level and cache it.
The first option yields better performance when the user changes the
black level. However, it requires other base adjustments to be applied
every time, such as the camera multipliers. The second option requires
the base image to be recreated every time the black level is changed.
This commit implements the second option. It minimizes code changes, and
therefore possible bugs. It does add a performance penalty when the
black level changes, but the black level adjustment is rarely used.
2023-07-29 17:37:13 -07:00
Michael Jaschob
31bbe91760 Use std::vector Instead of Manually Managed Memory 2023-07-27 14:31:53 -06:00
Michael Jaschob
5b2811f42b Allocate on Heap, Not Stack, in gaussVertical and Friends 2023-07-22 22:20:29 -06:00
Lawrence Lee
6f50b68fa7 Consider raw border with CA avoid color shift 2023-07-16 16:17:57 -07:00
Lawrence Lee
ab2cc4ba45 Fix auto DCP detection when using US English
For systems where the locale is not English but the language in
preferences is manually set to "English (US)", the Color Management
Auto-matched camera profile option is not selectable even if a DCP
exists for the camera. This is because the Glib::ustring
casefold_collate_key() method returns a locale-dependent value. When
initializing the list of DCP files, the system locale is used. When
finding a matching DCP profile for an image, a different locale is used
because the LANG environment variable is set while initializing the
RawTherapee GUI language.
2023-07-15 18:36:26 -07:00
Lawrence Lee
473d50a0a3 Add checkbox for disabling NR gain
Option to disable noise reduction automatic gain for consistency between
photographs.
Fix automatic gain not being recalculated after changing the white level
correction.
2023-07-15 17:47:26 -07:00
Lawrence37
b68a6e9581 Merge pull request #6790 from luzpaz/typos
Fix various typos
2023-07-12 21:22:54 -07:00
luzpaz
b0ebab8e08 Fix various typos
Found via `codespell -q 3 -S ./rtdata/languages -L activ,alph,ba,bloc,bord,chang,childs,currentry,dof,dum,fo,hist,inout,invers,lonly,makro,ois,pres,preserv,portugues,rady,reall,redy,struc,tbe,thre,trough,vart,vekto`
2023-07-05 13:51:11 +00:00
Lawrence Lee
fcf22ea33a Update white level for Canon EOS R5
Drop the white level slightly to account for noise. White level
confirmed in https://github.com/Beep6581/RawTherapee/issues/6783.
2023-07-01 18:39:05 -07:00