93 Commits

Author SHA1 Message Date
Morgan Hardwood
441c320375 NR Median now works independently of lumiance details, #4208 2017-12-06 12:55:05 +01:00
Alberto Griggio
f6bd06a06c merged 'hdr_tonemap_fattal_nocache' into 'dev' 2017-11-18 17:44:34 +01:00
heckflosse
67b6aec64e Fattal: one less buffer alloc/dealloc 2017-11-09 13:06:12 +01:00
Alberto Griggio
b8ff601efa fixed silly typo in Median_Denoise, leading to segfault 2017-11-07 21:07:29 +01:00
Alberto Griggio
b1938e272c added a dedicated Median_Denoise function that applies the median filter only on dark pixels
This gives a slight performance improvement for Fattal
2017-11-07 18:00:00 +01:00
Alberto Griggio
54783f6e2f Fixed bug (uninitialized values) in ImProcFunctions::Median_Denoise
The code was not copying border pixels from medianOut to dst, leading to the
use of uninitialized values. This was not visible in RT because Median_Denoise
was always called with src == dst, so not copying the border causes no harm
2017-11-05 15:07:03 +01:00
Alberto Griggio
ceb3ebf24b Fattal: protect fftwf calls with a mutex (shared also with the denoise routine)
Initialization of the fftwMutex now happens in rtengine::init()
2017-11-05 13:34:33 +01:00
heckflosse
8de8775264 eliminate AlignedBufferMP, also eliminate some unsused functions in boxblur.h 2017-10-22 21:06:24 +02:00
heckflosse
9e812bb25b Make compilation unit rtengine/FTblockDN.cc -Wextra clean 2017-10-21 17:43:02 +02:00
heckflosse
2579e3f6ac Fix some issues reported y valgrind 2017-06-22 23:46:16 +02:00
Desmis
20472d3e69 edgepresdecomposition Ftblockdn previewimage and all files checked without change 2017-03-31 14:56:36 +02:00
Hombre
c654785ae3 Merge branch 'dev' into rt-cli 2017-03-18 18:17:45 +01:00
Flössie
97caf21b5c PIMPLed and streamlined ICCStore (#3691) 2017-03-18 11:59:14 +01:00
Flössie
d2b4fe5e54 Merge branch 'std_cpp11-dev' into dev (fixes #3635) 2017-02-21 20:37:21 +01:00
Flössie
e9b5f42a9f Sanitize ImageDimensions base class
- Make `width` and `height` private
- Drop `getW()` and `getH()`
- Clean `PreviewProps`
2017-02-14 21:23:54 +01:00
Flössie
88336cb897 Make RT build without __USE_MISC and __USE_XOPEN 2017-02-14 21:02:39 +01:00
Hombre
50165dab20 Merge branch 'master' into softproofing 2016-10-16 01:45:52 +02:00
heckflosse
e82b60cd03 Cppcheck: Fixed some issues found by Flössie during review of my changes 2016-10-04 23:50:44 +02:00
Hombre
23011fbd63 Merge branch 'master' into softproofing 2016-10-04 00:04:57 +02:00
heckflosse
f9f593d343 Cppcheck: Fix issues related to rtengine/FTblockDN.cc 2016-10-02 15:09:26 +02:00
Ingo Weyrich
c8aa1c9f49 Merge pull request #3423 from Beep6581/denoise
Merged Denoise speedups to get more tests
2016-09-09 21:58:26 +02:00
heckflosse
3ffe983140 Small code cleanups 2016-09-09 21:54:51 +02:00
heckflosse
5bb20c413e Cleaned code, also reduced base memory usage of RT by 1 MB 2016-09-09 16:04:43 +02:00
heckflosse
ef83e6b591 Removed StopWatches and corrected some bugs from latest commit 2016-09-07 23:34:06 +02:00
heckflosse
0f21a0de6c Speedups for denoise, fixes #3418 2016-09-07 16:44:16 +02:00
heckflosse
3ddb4171d2 Fix a crash in denoise 2016-09-05 10:40:28 +02:00
heckflosse
dc4bbe906b Avoid possible buffer underrun in ImProcFunctions::Mad and ImProcFunctions::MadRgb 2016-09-02 21:04:23 +02:00
Hombre
827acd35f9 Some bugfix. 2016-08-27 22:20:54 +02:00
heckflosse
2ee160dcf7 Fix OOB access in ImProcFunctions::MadRgb, fixes #3379 2016-07-10 18:35:19 +02:00
Flössie
e129510b62 Partly revert rtengine/dcraw.cc and astyle again
Also recreate `dcraw.patch` as suggested by Ingo.
2016-07-09 17:42:59 +02:00
Flössie
2e9f3fb9dc Applied clang-tidy on rtengine/FTblockDN.cc
- Applied `clang-tidy` 3.8 with these checks and `-fix`:
  google-readability-casting,modernize-redundant-void-arg,
  modernize-use-bool-literals,modernize-use-nullptr,
  modernize-use-override,readability-braces-around-statements,
  readability-container-size-empty,
  readability-inconsistent-declaration-parameter-name,
  readability-redundant-control-flow,readability-redundant-string-cstr,
  readability-redundant-string-init,readability-simplify-boolean-expr,
  readability-static-definition-in-anonymous-namespace
- Renamed last occurrences of `ULIM` to `median`
- Removed double include of `median.h` from `rtengine/rawimagesource.cc`
  (found by Ingo)
2016-07-09 12:52:59 +02:00
Flössie
7f66eb5ec4 Move common code out of switch in ImProcFunctions::Median_Denoise()
- Move suggested by @heckflosse
- Use switch/case
- astyle `FTblockDN.cc`
- Whitespace cleanups
- Apply `median()` on `ffmanager.cc`
2016-07-09 11:47:47 +02:00
Flössie
719b405076 Remove vectorized medians < 25 from ImProcFunctions::Median_Denoise()
- But keep those versions in `median.h` for consistency
- Remove stopwatch
2016-07-08 17:28:27 +02:00
Flössie
1f63ab85fa Vectorize 49 and 81 in ImProcFunctions::Median_Denoise() (#3346) 2016-06-30 18:18:13 +02:00
Flössie
e2deb16403 Fix apparent OOB access in ImProcFunctions::Median_Denoise() (#3346) 2016-06-30 18:02:19 +02:00
Flössie
406d1b7fb1 Vectorize some medians in ImProcFunctions::Median_Denoise() (#3346)
- Vectorize with Ingo's scheme
- Make loads more cache friendly
2016-06-30 17:58:02 +02:00
Flössie
5cbff43191 Finalize median.h
- Added median 13, 49, and 81
- Integrated Ingo's SSE optimization for "5x5 strong"
- Converted `MIDDLE4OF6`
- Refactored `enum mediantype`
2016-06-28 21:49:07 +02:00
Flössie
d82956bbe5 Add optimized median25 and kill old macros (#3346) 2016-06-21 20:50:42 +02:00
Flössie
2fa1ad138e Start median rework (#3346)
- Added basic algorithms to `rtengine/median.h`
- Converted first occurrences
2016-06-14 22:08:03 +02:00
DrSlony
0e0cfb9b25 Formatted all .cc and .h code in rtengine, rtexif and rtgui using astyle 2015-08-11 11:55:03 +02:00
DrSlony
effb46c3e1 Line endings 2015-08-11 11:53:44 +02:00
DrSlony
82da6f3fb6 Issue 2844: Wavelet improvements to Edge Sharpness and Denoise and Refine, also some language file fixes. 2015-07-29 19:22:25 +02:00
torger
d5ca351c20 Issue 2134: removed obsolete raw highlight preservation setting from GUI (still left in procparams for backwards compatilibility) 2015-07-10 12:00:36 +02:00