3759 Commits

Author SHA1 Message Date
Lawrence Lee
c13cc02768 Un-highlight spot removal spots after deletion 2021-06-12 11:46:54 -07:00
Lawrence Lee
a2c5fd0f91 Fix drag position after alternate button press
When a button is released and the edit state is not "dragging", reset
the drag delta to zero.

There was a problem with the spot removal spots being dragged. If a spot
is deleted while being dragged, dragging another spot will cause a jump.
2021-06-12 11:37:38 -07:00
Flössie
9d052e267d Fix "unused variable" warning on release builds 2021-06-07 15:12:09 +02:00
Bezierr
d86888e93f
Add resizing options "long edge" and "short edge" (#6263)
Introduces "long edge" and "short edge" options to resize an image. The GUI is made such that the relevant spinboxes only appear for the selected option. Unrelated values (e.g. for box-mode) are not updated.
2021-06-05 07:37:09 +02:00
Lawrence37
38ff2b5695
Merge pull request #6268 from Beep6581/perspective-ux
Perspective tool: Improve control lines user experience
2021-06-03 21:37:30 -07:00
rom9
73c505cf44 Merge remote-tracking branch 'upstream/dev' into dev 2021-06-03 20:16:58 +02:00
rom9
726f1c1f26 FilmNeg tool: used a single luminance reference when sampling white balance spot several times in sequence, to avoid luminance drift.
Fixes #6257
2021-06-03 19:57:28 +02:00
Lawrence Lee
f17eb2b504 Merge branch 'dev' into perspective-ux 2021-05-31 11:53:50 -07:00
Lawrence37
2e6e52f335
Merge pull request #6253 from Beep6581/preview-widget-fixes
On-preview widget fixes
2021-05-31 11:30:00 -07:00
Lawrence37
22f5a90cb1
Merge pull request #6222 from Beep6581/inspector-window-fixes
Inspector window fixes
2021-05-31 11:27:26 -07:00
Lawrence Lee
e7e6dd1cb5 Clean up rtgui perspective.* and controllines.*
Change size_t to std::size_t, remove void from function parameters, use
constants to represent the minimum required number of control lines, and
change const auto & to const auto.
2021-05-31 11:20:01 -07:00
Lawrence Lee
2c1e6a8ca1 Make control lines buttons react to line counts
Set the "apply" and "delete all" button sensitivity based on the number
of control lines. Add extra tooltip text to the apply button when
editing and there is not enough lines. The text explains there must be
enough vertical or horizontal control lines.
2021-05-30 18:02:29 -07:00
Lawrence Lee
3c7e20b689 Refactor rtgui/spot.cc 2021-05-30 12:05:51 -07:00
Lawrence Lee
5f88cf240e Use enums for on-preview geometry 2021-05-30 11:51:49 -07:00
Desmis
ef49d9eefd Disable masks when tool is disable 2021-05-30 07:53:19 +02:00
Desmis
6e68cab5d9 Change range primaries ICC profile creator 2021-05-25 09:05:04 +02:00
Lawrence Lee
3441854a19 Prevent making spot removal spots outside image 2021-05-23 22:01:01 -07:00
Lawrence Lee
56e634da81 Improve control lines dragging behavior
Fix control line not updating when dragging and allow dragging when
starting with the mouse cursor outside the preview image area.
2021-05-23 21:45:23 -07:00
Lawrence Lee
051d69331f Fix control line and spot removal spot highlight
Return the geometry color to normal (white) when exiting edit mode.
2021-05-23 12:10:40 -07:00
Lawrence Lee
4bc69dc30c Leave gradient widget in good state on commit
Stop highlighting the hovered or dragged geometry when disabling the
widget.
2021-05-23 12:00:30 -07:00
Ingo Weyrich
c9e58fea54 cppcheck clean rtgui/thumbnail.* 2021-05-23 14:35:59 +02:00
Lawrence Lee
3ade11c970 Leave control lines in good state on commit
When exiting perspective control line editing mode while dragging a
control line, set the geometry and control line state to the appropriate
state corresponding to when lines are not being dragged.
2021-05-22 18:17:30 -07:00
Lawrence Lee
a5de8920fb Fix crash when resetting spot removal with drag
Do not attempt to update non-existent spots immediately after resetting
the spot removal tool.
2021-05-22 17:51:54 -07:00
Lawrence Lee
76706ac276 Leave spot removal widgets in good state on commit
Set the correct geometry states if edit mode is toggled off while a spot
is being dragged.
2021-05-22 17:35:22 -07:00
Lawrence Lee
36f1300a6b Fix control line edit crash when undoing history
When perspective control line editing is active and the history entry is
changed such that edit mode is automatically disabled, there is a crash.
The history change triggers a processing parameters update and disables
editing. When editing is disabled, the perspective tool also tries to
update the processing parameters, causing a double mutex lock attempt.

This commit avoids updating parameters from the perspective tool and
uses the tweak operator (introduced with the spot removal tool) to achieve
the same effect.

Closes #6251.
2021-05-22 15:50:35 -07:00
Thanatomanic
d2f3f903f0 Add reset button to whitebalance panel (back to Camera defaults).
Fixes #5054
2021-05-22 09:07:45 +02:00
Ingo Weyrich
f1f147a826 On-Preview Editing Widgets: Crashes, #6244 2021-05-20 22:15:46 +02:00
Desmis
8c49b240f5 Fixed bad behavior abstract profile issue 6245 2021-05-20 07:28:41 +02:00
Desmis
be3579e933
ICM - Abstract profile - Added reset button (#6243)
* Added reset button

* Added black and white to reset

* Reenable tooltip Retinex

* Reset illuminant to default
2021-05-18 07:53:45 +02:00
Lawrence Lee
21020f18c2 Fix spot removal link line visual bug
The link was showing upon creating a new spot where the source and
target inner circles overlap.
2021-05-17 22:14:51 -07:00
Desmis
bd9704da80 Change default primaries slider from Adobe to ProPhoto 2021-05-17 12:56:20 +02:00
Lawrence37
d11d834045
Merge pull request #6227 from Beep6581/spot-removal-tool
Spot removal tool
2021-05-16 12:44:45 -07:00
Lawrence Lee
ca4241109a Merge branch 'dev' into spot-removal-tool 2021-05-15 22:57:06 -07:00
Desmis
35abd92209
Custom TRC Tone response curve and Illuminant - change Histogram - RGB and Lab values - for output (screen, TIF, JPG..) (#5949)
* Change TRC in the process

* Improve GUI slope

* Add tooltip output profile

* Various change to enable and tooltip

* Chnage rtthumbnail

* Small change tooltip trc

* Another small change tooltip

* Improve GUI - change default TRC BT709 - change tooltip

* Other GUI improvment

* Small changes to BT709 values

* Various change to TRC - add illuminant working profile

* Change labels tooltip TRC illuminant

* Display wp in console if wp provided

* Change tooltip

* Change max wlope

* Init trc + illum + primaries

* Add black point compensation

* Change location abstract

* Fixed bug with rtthumbnail...

* Added tooltip

* Logscale for wslope

* Change tooltip abstract

* Change labels tooltips abstract profile

* Added 6 sliders custom primaries X and Y

* Change GUI custom primaries

* Use custom primaries abstract profiles

* Tooltip with primaries red green blue

* Fixed warning gtk

* Change one tooltip

* Change range custom primaries

* Change GUI default Primaries

* Change one tooltip

* Speedup for trc

* Rendering intent for abstract profile

* Hide intent abstract

* Preserve neutral tones

* Chnage settings preserves neutral tones

* Improve GUI

* Improvment to preserv

* Clean code - speedup TRC when illuminant and primaries default

* Change label

* Change bad default value Blux

* Add forgoten illuminant when selecting primaries

* clean code

* Change labels

* improve workingtrc for LA

* Change default primaries when select default

* Added others working profile to primaries

* Change labels and GUI

* Change tooltip

* CIExy diagram displaying the primaries (interactive) and the white point (#6207)

* Ciexy diagram

* Change to Ciexy graph

* Change graph and defaut coordonates

* Various changes to graph - params

* Disable setListener(ToolPanelListener)

* Add some graduation to graph

* Clean comment code graph

* Change radius 0

* Enable sensitive graph Ciexy

* update Ciexy graph with primaries

* Remove reset button graph

* Change labels and behavior

* First step third spot green

* Second step 3rd spot green

* First try 3 primaries graph Ciexy

* Fixed bad behavior in lab grid

* Fixed another bad behavior graph

* Clean and comment code

* Change default gamma

* More accurate graph Cie xy

* Added white point to Ciexy graph

* Added tooltip Cie xy diagram

* Improvment when illuminant change

* Refine diagram CIE xy - added WP 2000K

* White point D120 + tooltip

* Change label

* Change labels

* Change tooltips

* Improve diagram CIE xy with parabolic

* Other parabolic to improve Cie xy diagram

* Small change GUI

* Added Label CIE xy - change labels

* Change behavior when none - change labels

* Improve gUI and trys to fix LGTM alerts

* CIE xy change set sensitive

* Improve tooltip primaries sliders

* Adapt tooltip to new labels

* Fixed crash and some bad behavior

* First fix bad behavior with some primaries

* Second fixed bad behavior primaries

* Third fixed bad behavior primaries

* Change white point BestRGB

* Change order rgb in history msg Ciexy

* Change tooltip

* Change tooltip

* Improve GUI primaries

* Illuminant 1500K - display in console matrix XYZ-RGB

* Improve GUI illuminant

* Change a tooltip

* Somme changes to GUI and verbose

* Test code for wprim in read

* clean code for wprims

* further cleanups, not tested

* Some cleanups and bugfixes, #5949

* Simplify `std::unique_ptr<>` dereferencing

Also some minor cleanups.

* Some changes suggested by Floessie

* Others change suggested

* Others changes suggested by Floessie

* Forgotten change in procparams.cc

* Added black and white for use with the primaries channel mixer

* Small change behavior GUI - illuminant

* Change pragma omp in iplab2rgb

* Add enums and clean up

* Remove unused code icmpanel.cc

* Fix LGTM alert, #5949

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Flössie <floessie.mail@gmail.com>
2021-05-16 06:18:25 +02:00
Lawrence Lee
1b7ddf2b31 Fix perspective and local adjustments cursor icons
Correctly override the getCursor virtual function.
2021-05-14 22:20:25 -07:00
Desmis
7040aed540
Some change issue6234 (#6238) 2021-05-15 06:40:39 +02:00
Thanatomanic
09621242f4 Fix forgotten HBox -> Box change in header 2021-05-13 13:01:41 +02:00
Desmis
eb8f121709
Add ability to export to an external editor within the same folder as the original file - issue 6195 (#6232)
* import and change the art code -thanks to Alberto

* Possible fixed for white space in folder

* Added verbose when white-space

* Replace WS only if windows and Gimp

* Fixed Windows and Gimp bug for external editor - thanks to Lawrence37

* Fix LGTM alert for reused variable name

Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
2021-05-13 12:41:22 +02:00
Thanatomanic
fa2776c732 Remove double include 2021-05-13 12:41:01 +02:00
Thanatomanic
bb623d3a02 Fix instance of deprecated HBox 2021-05-13 12:34:27 +02:00
Desmis
3cb6e88ea4 Harmonize GUI for Scope - Retinex and Dehaze 2021-05-11 13:27:04 +02:00
Lawrence Lee
77ea6d92cb Pin inspector whenever scrolling or zooming 2021-05-09 12:31:26 -07:00
Lawrence Lee
6535cb4a94 Make inspector never upscale in fit-to-window mode
When zoomed completely out, don't upscale images.
2021-05-09 12:18:06 -07:00
Lawrence Lee
9df34be6cb Hide inspector accelerator in film strip
Only show the accelerator key in the context menu when opening the menu
from the full file browser but not the film strip.
2021-05-08 12:15:58 -07:00
Lawrence Lee
36cb32b31b Make inspector window size consistent 2021-05-08 11:48:18 -07:00
Lawrence Lee
b2988ddbb3 Avoid reopening inspector window when being opened 2021-05-07 22:26:28 -07:00
Pandagrapher
1c9d1f522c Locallab - Fix bad syntax in LocallabParamsEdited vector resize 2021-05-07 18:47:14 +02:00
Lawrence Lee
9495c049c4 Fix inspector not opening full-screen at first 2021-05-06 21:39:01 -07:00
Desmis
980a16abb0
Improve ciecam16 Log encoding (#6228) 2021-05-04 13:54:12 +02:00
Desmis
f22482c204
Local adjustments - Strength control on Spot - tools - issue 6221 (#6223)
* Add strength to local contrast and wavelet

* Added strength to Color and Light

* Added strength to Denoise

* Added strength to shadows highlight Tone equalizer

* Added strength to Dynamic Range and exposure

* Added strength to Tone mapping

* Small improvment to Dynamic Range
2021-05-04 07:27:55 +02:00