Commit Graph

3664 Commits

Author SHA1 Message Date
Desmis
8c49b240f5 Fixed bad behavior abstract profile issue 6245 2021-05-20 07:28:41 +02:00
Desmis
be3579e933 ICM - Abstract profile - Added reset button (#6243)
* Added reset button

* Added black and white to reset

* Reenable tooltip Retinex

* Reset illuminant to default
2021-05-18 07:53:45 +02:00
Lawrence Lee
21020f18c2 Fix spot removal link line visual bug
The link was showing upon creating a new spot where the source and
target inner circles overlap.
2021-05-17 22:14:51 -07:00
Desmis
bd9704da80 Change default primaries slider from Adobe to ProPhoto 2021-05-17 12:56:20 +02:00
Lawrence37
d11d834045 Merge pull request #6227 from Beep6581/spot-removal-tool
Spot removal tool
2021-05-16 12:44:45 -07:00
Lawrence Lee
ca4241109a Merge branch 'dev' into spot-removal-tool 2021-05-15 22:57:06 -07:00
Desmis
35abd92209 Custom TRC Tone response curve and Illuminant - change Histogram - RGB and Lab values - for output (screen, TIF, JPG..) (#5949)
* Change TRC in the process

* Improve GUI slope

* Add tooltip output profile

* Various change to enable and tooltip

* Chnage rtthumbnail

* Small change tooltip trc

* Another small change tooltip

* Improve GUI - change default TRC BT709 - change tooltip

* Other GUI improvment

* Small changes to BT709 values

* Various change to TRC - add illuminant working profile

* Change labels tooltip TRC illuminant

* Display wp in console if wp provided

* Change tooltip

* Change max wlope

* Init trc + illum + primaries

* Add black point compensation

* Change location abstract

* Fixed bug with rtthumbnail...

* Added tooltip

* Logscale for wslope

* Change tooltip abstract

* Change labels tooltips abstract profile

* Added 6 sliders custom primaries X and Y

* Change GUI custom primaries

* Use custom primaries abstract profiles

* Tooltip with primaries red green blue

* Fixed warning gtk

* Change one tooltip

* Change range custom primaries

* Change GUI default Primaries

* Change one tooltip

* Speedup for trc

* Rendering intent for abstract profile

* Hide intent abstract

* Preserve neutral tones

* Chnage settings preserves neutral tones

* Improve GUI

* Improvment to preserv

* Clean code - speedup TRC when illuminant and primaries default

* Change label

* Change bad default value Blux

* Add forgoten illuminant when selecting primaries

* clean code

* Change labels

* improve workingtrc for LA

* Change default primaries when select default

* Added others working profile to primaries

* Change labels and GUI

* Change tooltip

* CIExy diagram displaying the primaries (interactive) and the white point (#6207)

* Ciexy diagram

* Change to Ciexy graph

* Change graph and defaut coordonates

* Various changes to graph - params

* Disable setListener(ToolPanelListener)

* Add some graduation to graph

* Clean comment code graph

* Change radius 0

* Enable sensitive graph Ciexy

* update Ciexy graph with primaries

* Remove reset button graph

* Change labels and behavior

* First step third spot green

* Second step 3rd spot green

* First try 3 primaries graph Ciexy

* Fixed bad behavior in lab grid

* Fixed another bad behavior graph

* Clean and comment code

* Change default gamma

* More accurate graph Cie xy

* Added white point to Ciexy graph

* Added tooltip Cie xy diagram

* Improvment when illuminant change

* Refine diagram CIE xy - added WP 2000K

* White point D120 + tooltip

* Change label

* Change labels

* Change tooltips

* Improve diagram CIE xy with parabolic

* Other parabolic to improve Cie xy diagram

* Small change GUI

* Added Label CIE xy - change labels

* Change behavior when none - change labels

* Improve gUI and trys to fix LGTM alerts

* CIE xy change set sensitive

* Improve tooltip primaries sliders

* Adapt tooltip to new labels

* Fixed crash and some bad behavior

* First fix bad behavior with some primaries

* Second fixed bad behavior primaries

* Third fixed bad behavior primaries

* Change white point BestRGB

* Change order rgb in history msg Ciexy

* Change tooltip

* Change tooltip

* Improve GUI primaries

* Illuminant 1500K - display in console matrix XYZ-RGB

* Improve GUI illuminant

* Change a tooltip

* Somme changes to GUI and verbose

* Test code for wprim in read

* clean code for wprims

* further cleanups, not tested

* Some cleanups and bugfixes, #5949

* Simplify `std::unique_ptr<>` dereferencing

Also some minor cleanups.

* Some changes suggested by Floessie

* Others change suggested

* Others changes suggested by Floessie

* Forgotten change in procparams.cc

* Added black and white for use with the primaries channel mixer

* Small change behavior GUI - illuminant

* Change pragma omp in iplab2rgb

* Add enums and clean up

* Remove unused code icmpanel.cc

* Fix LGTM alert, #5949

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Flössie <floessie.mail@gmail.com>
2021-05-16 06:18:25 +02:00
Lawrence Lee
1b7ddf2b31 Fix perspective and local adjustments cursor icons
Correctly override the getCursor virtual function.
2021-05-14 22:20:25 -07:00
Desmis
7040aed540 Some change issue6234 (#6238) 2021-05-15 06:40:39 +02:00
Thanatomanic
09621242f4 Fix forgotten HBox -> Box change in header 2021-05-13 13:01:41 +02:00
Desmis
eb8f121709 Add ability to export to an external editor within the same folder as the original file - issue 6195 (#6232)
* import and change the art code -thanks to Alberto

* Possible fixed for white space in folder

* Added verbose when white-space

* Replace WS only if windows and Gimp

* Fixed Windows and Gimp bug for external editor - thanks to Lawrence37

* Fix LGTM alert for reused variable name

Co-authored-by: Thanatomanic <6567747+Thanatomanic@users.noreply.github.com>
2021-05-13 12:41:22 +02:00
Thanatomanic
fa2776c732 Remove double include 2021-05-13 12:41:01 +02:00
Thanatomanic
bb623d3a02 Fix instance of deprecated HBox 2021-05-13 12:34:27 +02:00
Desmis
3cb6e88ea4 Harmonize GUI for Scope - Retinex and Dehaze 2021-05-11 13:27:04 +02:00
Pandagrapher
1c9d1f522c Locallab - Fix bad syntax in LocallabParamsEdited vector resize 2021-05-07 18:47:14 +02:00
Desmis
980a16abb0 Improve ciecam16 Log encoding (#6228) 2021-05-04 13:54:12 +02:00
Desmis
f22482c204 Local adjustments - Strength control on Spot - tools - issue 6221 (#6223)
* Add strength to local contrast and wavelet

* Added strength to Color and Light

* Added strength to Denoise

* Added strength to shadows highlight Tone equalizer

* Added strength to Dynamic Range and exposure

* Added strength to Tone mapping

* Small improvment to Dynamic Range
2021-05-04 07:27:55 +02:00
Desmis
53bb6e41bb LA other bad behavior Duplicate spot when spot outside preview 2021-04-22 07:15:28 +02:00
Desmis
f47f23a4dc LA - Duplicate full image size whole image - issue 6200 2021-04-21 10:32:51 +02:00
Desmis
128de03aed Local adjustemnts - adapt various parameters to fit labels in right tool panel issue #6153 (#6160)
* Various change to fit label in left tool panel

* Increase size left panel from 460 to 465

* Various improvment to reduce size left panel

* Others changes to reduce left panel labels

* Increase default size right panel

* Set right panel ajustable to size font

* Others small changes to mask

* Others small modifications

* change a litlle GUI - curveeditorgroup.cc - suppress curves u=in mask and reduce size right panel

* Added : to various curves label

* Others : labels curves

* Some adjustments labels sizefonts

* Change 2 forgotten length labels in denoise

* Others improvments labels

* Others labels change for retinex

* Others change labels - thanks to Wayne Sutton

* French change label length

* Change labels Wavelet levels - LA retinex - LA color and lights - and others

* Other change to mask blur

* Change box - Flowbox - thanks to Beep6581

* Adapt size box basic..advanced with size font

* Restore curveditorgroup : - change some labels and tooltips

* Remove some ':' - change and adapt labels tooltip wavelet levels

* Change flowbox for complexity under label

* Restore right panel and options to default values

* Change a label in wavelet level denoise

* Change in mask curves L(L) by L C(C) by C

* Small change labels denoise to fit in width right panel

* Others changes to GUi and labels to fit in right panel

* First change tooltips and french

* Second change tooltips

* Change tooltip mask denoise
2021-04-02 07:36:42 +02:00
Desmis
717948cf09 Local adjustments - Normalize luminance - improvment Preview TM - Retinex - Remove D.Range (#6185)
* Enable dynamic range - settings normalize luminance

* Change range DR sigma offset

* improve normalize_mean_dt with mean std before

* Save work on normalize dynamic range

* Improve normalize for TM

* Added LA retinex to normalize_mean

* Clean and optimize code

* Disabled normalize DR - improve TM and Retinex

* Clean code - first part

* Clean code - part two

* Change 2 default values Retinex

* Change order TM and Retinex in process

* remove the order number in - add tool to current spot -

* Fixed bug in TM

* Some change Retinex - default...

* optimize mean sigma

* cleanup for mean_sig

* Fix some cppcheck issues

* convert one large loop into three loops to avoid performance penalty on machines with 4-way L1 cache

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-03-28 12:55:29 +02:00
Ingo Weyrich
871d35c228 Favorites Tab: rawBayerExposure in X-Trans, fixes #6182 2021-03-24 11:05:11 +01:00
Desmis
3ad786745c LA - Move colortoning labgrid from rgb to lab - issue #6132 (#6173)
* Move colortoning labgrid from rgb to lab

* Remove unnecessary variables
2021-03-23 16:59:54 +01:00
Desmis
170df03933 LA - Simplify GUI - Dynamic range 2021-03-19 16:58:49 +01:00
Desmis
537fa73d3f Local adjustments - Log encoding - Ciecam16 ContrastJ - contrastQ - contrast threshold (#6169)
* Added contrast threshold Log encoding

* Improve contrast threshold

* Chanhe tooltip

* Change sign threshold when contrast negative

* Another change threshold with contrast Q and J
2021-03-15 07:57:25 +01:00
Desmis
227ae487d4 LA and Shadows-Highlight main - change location shadows-highlight in Lab issue 6163 (#6164)
* Change location shadows-highlight in Lab

* Suppress unused variable

* Small change in improccoordinator.cc
2021-03-13 07:17:42 +01:00
Ingo Weyrich
bb08b6bed8 Raw black points: Green2 Does not change color when click button restore value to 0, fixes #6165 2021-03-09 13:11:51 +01:00
Desmis
0170305906 Local contrast - Try to solve bug issue #6132 (#6134)
* Try to solve bug issue 6132

* Refine placement localcontrast in pipeline
2021-03-08 08:29:57 +01:00
Desmis
9b2e955dc9 LA improve behavior full image issue 6161 2021-03-08 08:00:35 +01:00
Lawrence Lee
f958074d9b Fix crash when deleting spot removal spot
Deleting a spot while hovering over one of the circles for adjusting the
radius or feathering could trigger a crash. This is because immediately
after deleting a geometry object, EditSubscriber::getCursor is given an
object ID based on old data, causing the spot tool to attempt to get
information about the deleted geometry object.

This commit fixes the issue by returning the default cursor if the
active spot is -1. It works because the active spot is set to -1 when
deleting a spot, and there is no need to use a special cursor when there
is no active spot.

A better long-term solution would be updating the geometry data before
calling EditSubscriber::getCursor.
2021-03-07 11:58:36 -08:00
Lawrence Lee
10b5f65b30 Fix spot removal enable/disable history message
The history panel was showing "HISTORY_MSG_1049".
2021-03-06 21:29:56 -08:00
Lawrence Lee
7e436a44d6 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into spot-removal-tool 2021-03-06 16:41:40 -08:00
Desmis
df9f33e44e LA - Others improvments length labels 2021-03-06 08:22:50 +01:00
Desmis
0bf7c4e56c Local adjustments - Added Guidedfilter to avoid color shift (#6149)
* Added Guidedfilter to avoid color shift

* Various improvment to avoid color shift

* Small change to mint maxt

* local adjustments avoid color shift: reduce memory usage by width * height * 8 byte if Soft Radius > 0

* Remove StopWatch

* local adjustments avoid color shift: speedup for last loop

* cleanups

* one more cleanup

* Added checkbox Munsell correction only - uniform perceptual lab

* Refine some settings

* Clean-up - other small refinement

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-03-03 18:49:55 +01:00
Pandagrapher
84751ad26f Re-allow using RT shortcut while focused on adjuster 2021-03-01 21:38:35 +01:00
Pandagrapher
d92bbf59e1 Fixes #6148, allow using decimal key on numpad 2021-03-01 21:04:08 +01:00
Stefan Wunsch
68a6e02369 Fix some cmake build system issues (#6147)
* [cmake] Switch to find_package for TIFF
- Included in cmake 3.5 and later
- Provides better configuration messages
* Add missing TIFF library to rtgui and rtexif
* Removed unnecessary quotes so that cmake sees the list as a list
* Add OpenMP to rtengine if OpenMP is enabled
2021-03-01 16:40:54 +01:00
Ingo Weyrich
02a5040a60 Undocumented search feature in exif tab can be annoying, fixes #6142 2021-02-28 17:00:37 +01:00
Thanatomanic
09441c7e54 Correctly apply Local adjustments when loading a pp3 profile 2021-02-28 11:13:21 +01:00
Desmis
b58f643d59 Local adjustments - Grain - various improvment - see issue #2460 (#6120)
* Fixed bad behavior saturation issue 6117

* Reenable scalegr for grain

* some changes to grain

* Init lagrain

* Various improvment GUI - gamma

* Change basic - normal grain
2021-02-27 08:13:44 +01:00
Thanatomanic
a6a368e682 Allow resizing of navigator window. Patch by @Lawrence37. Fixes #6052 2021-02-27 08:03:36 +01:00
Thanatomanic
1214450aaa Small fixes to Gtk::Grid::attach for compilation with gtkmm 3.22 2021-02-25 17:49:05 +01:00
Desmis
9e159deb01 Local adjustments - Blur and noise radius > 1.5 increase saturation issue #6117 (#6118)
* Fixed bad behavior saturation issue 6117

* Reenable scalegr for grain

* Add forgotten brackets
2021-02-19 13:06:34 +01:00
Thanatomanic
de15da1d59 Fix new color propagation method (#6109)
* Fixed artifacts thanks to Alberto

* Added blur to Color propagation

* Clean format code - small improvments

* color propagation: Enable old mode at blur = 0

* Improve GUI

* color propagation: smooth progress bar for blur > 0

* change label

* Some cleanups

* color propagation: small speedup for blur > 0

* color propagation: speedup for blur > 0 when region with clipped highlights is small

* Speed-up for blur=1 - clean GUI code

* color propagation: cleanups

* Harmonize events in tonecurve.cc

* tonecurve.cc : cleanup

* Highlight reconstruction: small changes to gui

* Use Gtk::Box instead of Gtk::VBox

* Change maximum number of blur levels to 4

* Suppress BENCHFUN

* Suppress bad commit locallabtools

Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-18 13:36:54 +01:00
Ingo Weyrich
d29d5e144b Update locallabtools.cc
Fix wrong fix from last commit...
2021-02-17 15:38:29 +01:00
Ingo Weyrich
036a590db1 Fix adjuster default value 2021-02-17 13:41:25 +01:00
Thanatomanic
fc031ccb5a Remove deprecated GTK3 code, fixes #6103 (#6113)
Replaces the following deprecated Gtk classes throughout the codebase by their non-deprecated counterparts. Style, HBox, VBox, HPaned, VPaned, HScrollbar, VScrollbar, VSeparator, HSeparator, Stock, Table, VScale and HScale.
2021-02-17 11:44:25 +01:00
Ingo Weyrich
a1f3edbeab delayed.h : fix cppcheck warnings 2021-02-14 17:48:37 +01:00
Desmis
9b0bbdd276 Local adjustments - Neutralize process after LA when when the user uses preview deltaE (#6099)
* Add others methods RGB process - to preview dE

* added others process to neutralize preview dE

* Added others process to neutralize preview dE

* Change scope placement for all tools
2021-02-09 07:31:54 +01:00
Desmis
6ad419f189 Local adjustments - Denoise - improvments with Non Local means issue #6087 (#6091)
* Improvment to denoise

* Initialize nlmeans - thanks to Alberto and Ingo

* Added 2 sliders max_patch and max_radius

* Added Frame Non-local means

* Improve GUI and tooltips - french

* Change dfault detail - and comment code

* Change label

* Adapt English tooltip

* Change GUI for NLmeans

* Change order GUI denoise

* Some changes to enable DCT - labels and tooltips

* French labels tooltip

* Change order combobox mode denoise - labels - tooltips

* Change tooltip Denoise based on luminance mask

* Change a tooltip

* Removes unnecessary code

* Nlmeans add gamma to preserve structure or reinforce denoise

* Change gamma tooltip

* Change tooltip Recovery denoise

* Disabled nlmeans if skip > 5

* Change tooltip - size limit spot Nlmeans 150-150

* Change gamma Nlmeans

* Supress display console

* Speedup for gammalog and igammalog, #6087

* SSE code for (i)gammalog, #6087

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-05 16:24:43 +01:00