61 Commits

Author SHA1 Message Date
Ingo Weyrich
73b336a3f1
Update FTblockDN.cc
Disable StopWatch
2019-04-18 20:43:40 +02:00
heckflosse
9ee47c29a3 Small speedup for denoise (mainly for preview mode), #5225 2019-03-17 19:45:46 +01:00
heckflosse
25625c6842 small speeduo for denoise 2019-03-16 23:35:39 +01:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
Flössie
37027e46bd Fix non-OpenMP build 2019-02-06 06:54:31 +01:00
heckflosse
71b5cc6d65 Fix coverity issues 2018-11-21 17:35:53 +01:00
heckflosse
1fa253ba63 Fix some issues reported by coverity 2018-11-16 20:48:33 +01:00
heckflosse
0983817434 SSE: Review usage of vminf, vmaxf functions, #4942 2018-11-05 15:59:41 +01:00
Flössie
77587f989e Fix Clang build (fixes #4862) 2018-10-12 20:53:12 +02:00
heckflosse
bf13654a67 Finally fix covertiy issues 185774 and 185779 / Uninitialized pointer read 2018-09-18 19:19:39 +02:00
heckflosse
5d00cb05b4 Coverity 185774, 185779 Uninitialized pointer read 2018-09-17 13:26:50 +02:00
Hombre
fbc81028eb First batch of variable name normalisation in ICM tool, see #4478 2018-05-14 00:57:55 +02:00
heckflosse
96bf06a950 Removed most of the __x86_64__ dependencies. Also removed _RT_NESTED_OPENMP 2018-01-23 16:05:31 +01:00
heckflosse
53ec11eea9 Cleanup fftw when closing RT, instead of after each time fftw is used. Speeds up fattal and luminance denoise 2018-01-17 20:39:01 +01:00
heckflosse
b32ca3ed2e Fix old bug. Result is the same as before because FFTW_MEASURE is 0 and FFTW_DESTROY_INPUT is 1 2018-01-16 18:06:27 +01:00
Flössie
b3dd5244ad Fix (currently impossible) null pointer dereference (Coverity)
Plus some `const` fixes, this time removing constness.
2018-01-01 12:30:10 +01:00
Alberto Griggio
d7fb8c9136 Avoid division by zero in RGB_denoise
Fix for #4214
2017-12-09 00:35:09 +01:00
Desmis
d668e0d745 Format ftblockdn.cc 2017-12-08 08:09:49 +01:00
Morgan Hardwood
441c320375 NR Median now works independently of lumiance details, #4208 2017-12-06 12:55:05 +01:00
Alberto Griggio
f6bd06a06c merged 'hdr_tonemap_fattal_nocache' into 'dev' 2017-11-18 17:44:34 +01:00
heckflosse
67b6aec64e Fattal: one less buffer alloc/dealloc 2017-11-09 13:06:12 +01:00
Alberto Griggio
b8ff601efa fixed silly typo in Median_Denoise, leading to segfault 2017-11-07 21:07:29 +01:00
Alberto Griggio
b1938e272c added a dedicated Median_Denoise function that applies the median filter only on dark pixels
This gives a slight performance improvement for Fattal
2017-11-07 18:00:00 +01:00
Alberto Griggio
54783f6e2f Fixed bug (uninitialized values) in ImProcFunctions::Median_Denoise
The code was not copying border pixels from medianOut to dst, leading to the
use of uninitialized values. This was not visible in RT because Median_Denoise
was always called with src == dst, so not copying the border causes no harm
2017-11-05 15:07:03 +01:00
Alberto Griggio
ceb3ebf24b Fattal: protect fftwf calls with a mutex (shared also with the denoise routine)
Initialization of the fftwMutex now happens in rtengine::init()
2017-11-05 13:34:33 +01:00
heckflosse
8de8775264 eliminate AlignedBufferMP, also eliminate some unsused functions in boxblur.h 2017-10-22 21:06:24 +02:00
heckflosse
9e812bb25b Make compilation unit rtengine/FTblockDN.cc -Wextra clean 2017-10-21 17:43:02 +02:00
heckflosse
2579e3f6ac Fix some issues reported y valgrind 2017-06-22 23:46:16 +02:00
Desmis
20472d3e69 edgepresdecomposition Ftblockdn previewimage and all files checked without change 2017-03-31 14:56:36 +02:00
Hombre
c654785ae3 Merge branch 'dev' into rt-cli 2017-03-18 18:17:45 +01:00
Flössie
97caf21b5c PIMPLed and streamlined ICCStore (#3691) 2017-03-18 11:59:14 +01:00
Flössie
d2b4fe5e54 Merge branch 'std_cpp11-dev' into dev (fixes #3635) 2017-02-21 20:37:21 +01:00
Flössie
e9b5f42a9f Sanitize ImageDimensions base class
- Make `width` and `height` private
- Drop `getW()` and `getH()`
- Clean `PreviewProps`
2017-02-14 21:23:54 +01:00
Flössie
88336cb897 Make RT build without __USE_MISC and __USE_XOPEN 2017-02-14 21:02:39 +01:00
Hombre
50165dab20 Merge branch 'master' into softproofing 2016-10-16 01:45:52 +02:00
heckflosse
e82b60cd03 Cppcheck: Fixed some issues found by Flössie during review of my changes 2016-10-04 23:50:44 +02:00
Hombre
23011fbd63 Merge branch 'master' into softproofing 2016-10-04 00:04:57 +02:00
heckflosse
f9f593d343 Cppcheck: Fix issues related to rtengine/FTblockDN.cc 2016-10-02 15:09:26 +02:00
Ingo Weyrich
c8aa1c9f49 Merge pull request #3423 from Beep6581/denoise
Merged Denoise speedups to get more tests
2016-09-09 21:58:26 +02:00
heckflosse
3ffe983140 Small code cleanups 2016-09-09 21:54:51 +02:00
heckflosse
5bb20c413e Cleaned code, also reduced base memory usage of RT by 1 MB 2016-09-09 16:04:43 +02:00
heckflosse
ef83e6b591 Removed StopWatches and corrected some bugs from latest commit 2016-09-07 23:34:06 +02:00
heckflosse
0f21a0de6c Speedups for denoise, fixes #3418 2016-09-07 16:44:16 +02:00
heckflosse
3ddb4171d2 Fix a crash in denoise 2016-09-05 10:40:28 +02:00
heckflosse
dc4bbe906b Avoid possible buffer underrun in ImProcFunctions::Mad and ImProcFunctions::MadRgb 2016-09-02 21:04:23 +02:00
Hombre
827acd35f9 Some bugfix. 2016-08-27 22:20:54 +02:00
heckflosse
2ee160dcf7 Fix OOB access in ImProcFunctions::MadRgb, fixes #3379 2016-07-10 18:35:19 +02:00
Flössie
e129510b62 Partly revert rtengine/dcraw.cc and astyle again
Also recreate `dcraw.patch` as suggested by Ingo.
2016-07-09 17:42:59 +02:00
Flössie
2e9f3fb9dc Applied clang-tidy on rtengine/FTblockDN.cc
- Applied `clang-tidy` 3.8 with these checks and `-fix`:
  google-readability-casting,modernize-redundant-void-arg,
  modernize-use-bool-literals,modernize-use-nullptr,
  modernize-use-override,readability-braces-around-statements,
  readability-container-size-empty,
  readability-inconsistent-declaration-parameter-name,
  readability-redundant-control-flow,readability-redundant-string-cstr,
  readability-redundant-string-init,readability-simplify-boolean-expr,
  readability-static-definition-in-anonymous-namespace
- Renamed last occurrences of `ULIM` to `median`
- Removed double include of `median.h` from `rtengine/rawimagesource.cc`
  (found by Ingo)
2016-07-09 12:52:59 +02:00
Flössie
7f66eb5ec4 Move common code out of switch in ImProcFunctions::Median_Denoise()
- Move suggested by @heckflosse
- Use switch/case
- astyle `FTblockDN.cc`
- Whitespace cleanups
- Apply `median()` on `ffmanager.cc`
2016-07-09 11:47:47 +02:00