59 Commits

Author SHA1 Message Date
Morgan Hardwood
e23fc17ccf Search for DateTimeOriginal if not found in standard location
The DateTimeOriginal and DateTimeDigitized Exif tags should be in the
same group - ExifIFD, but the Leica M8 stores DateTimeOriginal in the
IFD0 group. This patch by Flössie allows to find the tag.
Closes #5251
2019-03-29 09:21:47 +01:00
Flössie
86690f1ca0 Fix OOB string access (fixes #5207) 2019-03-11 21:09:57 +01:00
Floessie
17bec0a2e5
Merge pull request #5197 from Beep6581/relax-procparam-dependency
Relax dependency from `procparams.h`
2019-03-11 15:14:00 +01:00
Flössie
c2405585cf Work around strange side effects when parsing Exif (#5207) 2019-03-10 14:56:36 +01:00
Flössie
9fe6bcaab1 Merge branch 'dev' into relax-procparam-dependency 2019-03-10 12:54:04 +01:00
Flössie
d89364fcc0 Fix Exif parsing for old Canons (ported by @Beep6581, fixes #4843) 2019-03-10 11:40:05 +01:00
Morgan Hardwood
2c9dc32022 Show more meaningful lens make/model #5157
If the lens make/model from the MakerNotes is vague, and if a lens make
and model are set in Exif (LensMake, LensModel), then prefer Exif over
vague.
2019-03-09 16:17:44 +01:00
Flössie
ca3f84e94f Lens name improvements for Pentax by @Manuel-K (#5157) 2019-03-07 20:29:07 +01:00
Flössie
70475f781a Derive lens name from 0xA434 and 0xA433 if other means fail (#5157)
Implemented for
- Pentax
- Canon
- "Unknown"

Also constified `toString()` methods in `rtexif`.
2019-03-07 19:29:11 +01:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
Flössie
e39726dbf7 Return first frame in FramesData on OOB access (#4830) 2019-02-20 20:55:07 +01:00
heckflosse
58e26add76 Fallback to 'UniqueCameraModel' tag if model is 'Unknown' 2018-11-09 15:30:29 +01:00
George Hilliard
6cd50adc54 Revert "ImageData: Use terser emplace_back to add unique_ptr to vector"
This reverts commit b4813273d21f991789749d30eeb2ac437cdcc698.
2018-11-08 09:57:02 -06:00
George Hilliard
b4813273d2 ImageData: Use terser emplace_back to add unique_ptr to vector 2018-11-07 12:16:45 -06:00
George Hilliard
ec814dbf05 FramesData: Don't leak allocated frames, and remove unused functions
Valgrind report:

```
14,960 (11,544 direct, 3,416 indirect) bytes in 37 blocks are definitely lost in loss record 20,483 of 20,540
   at 0x4837DEF: operator new(unsigned long) (vg_replace_malloc.c:334)
   by 0xC06963: rtengine::FramesData::FramesData(Glib::ustring const&, std::unique_ptr<rtengine::RawMetaDataLocation, std::default_delete<rtengine::RawMetaDataLocation> >, bool) (imagedata.cc:1121)
   by 0xBD774F: rtengine::DFManager::addFileInfo(Glib::ustring const&, bool) (dfmanager.cc:380)
   by 0xBD6E90: rtengine::DFManager::init(Glib::ustring) (dfmanager.cc:303)
   by 0xC3EC5D: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:93)
   by 0x897CABD: gomp_thread_start (team.c:120)
   by 0x89B7A9C: start_thread (in /usr/lib/libpthread-2.28.so)
   by 0x8ACCB22: clone (in /usr/lib/libc-2.28.so)
```
2018-11-02 03:07:07 -05:00
Morgan Hardwood
fde0dccd6a Revised printf file format strings 2018-05-06 21:50:09 +02:00
Hombre
ec2181f7ff Fix #4532, Fix #4533 : Pentax HDR/PEF and 16/24 bits float support 2018-05-06 17:14:44 +02:00
heckflosse
4a1a10aab0 Pixel Shift: Improve motion mask and further changes 2018-04-14 01:11:01 +02:00
heckflosse
15794cc1ba First steps to extend dynamic profiles for Pixel Shift and HDR images 2018-04-05 14:41:02 +02:00
luz.paz
c3c3ceac79 Misc. typos
Found via `codespell` 
+ removed rtengine/dcraw.patch per discussion in https://github.com/Beep6581/RawTherapee/pull/4395
2018-02-14 14:07:18 -05:00
Flössie
820b6c8ae9 Remove useless call (Coverity) 2018-01-01 12:57:19 +01:00
Flössie
0b7b1d6ab3 Fix null pointer dereference (as hinted by Coverity)
Plus some `const` fixes.
2018-01-01 12:13:29 +01:00
Hombre
2c8349887b Adding PS icon to Sony's ARQ files (see #4222) 2017-12-13 02:09:15 +01:00
heckflosse
2e645debb4 Fix two issues detected by Flössie 2017-10-25 17:09:46 +02:00
heckflosse
80b23e7168 Make compilation unit rtengine/imagedata.cc -Wextra clean, #4155 2017-10-23 20:59:47 +02:00
heckflosse
8621327678 Tiff files are not shown anymore after clearing cache, fixes #4149 2017-10-16 14:59:08 +02:00
Hombre57
dfe40677e2 Fix coverity issue 2017-10-13 23:25:24 +02:00
Hombre57
2ef064f7d4 Various bugfix (see #4008) :
1. RT could crash in some circumstances with single frame image
2. UNICODE UserComment now done when already existing in raw file
3. When editing UserComment in the ExifPanel, the Value filed is now
filled with the current value
2017-10-07 00:43:45 +02:00
Hombre57
bb874bcce7 Bigfix (see #4008) :
- CIECam now gets the shot's setting of the selected frame
- 'UserComment' metadata now correctly handled
- RT prepared to handle XTrans multiframe
- SensorType now set in the cache/data files
2017-10-04 23:27:08 +02:00
Hombre57
0807510603 Bigfix: CR2 files couldn't find the metadata for display (see #4008) 2017-09-26 21:42:59 +02:00
Hombre57
17c7ec684d PixelShift detection for PEF files was broken (see #4008) 2017-09-17 23:05:34 +02:00
Hombre57
ee0bff4124 Updated frame handling with any type of hierarchy (see #4008)
Images can now be detected in nested IFDs or as root IFDs.
2017-09-16 22:30:07 +02:00
Hombre57
a056493e9a Bug fix (see #4008) 2017-08-15 16:25:56 +02:00
Hombre57
d5e4980c08 Adding Floessie's patch to use std::unique_ptr (issue #4008) 2017-08-12 19:21:29 +02:00
Hombre57
1a296b763f Correction as discussed in commit review (see also issue #4008) 2017-08-10 00:50:26 +02:00
Hombre57
f23be9345c Add multi-frame handling.
- Exif of all frames are displayed in the Editor's Exif tab (without
separator)
- isHDR and isPixelShift is added to the data files stored in cache
- In the Editor panel, the QuickInfo frame display the HDR and
PixelShift information, as well as the number of frame and bit-depth for
HDR image
- the number of frame is provided by dcraw. If not set, it is provided
by the Exif's main IFD count
- the PixelShift information (for Pentax as of now) is provided by
looking at the Exif informations
- the HDR information is provided by the Exif information of the first
frame for Pentax raw files, or by the bitspersample, sampleformat and
compression tags for other files

TODO: add icons to the thumbnails to tag HDR and PixelShift files.
2017-08-08 23:42:05 +02:00
heckflosse
eeb1135670 Fix coverity issue 2017-06-19 20:28:44 +02:00
heckflosse
a6cf24bc13 Fix some coverity issues 2017-06-12 23:57:18 +02:00
topu
f2b0efecce Show lens used on Panasonic cameras 2017-04-17 17:12:06 +02:00
Morgan Hardwood
2c9c3b2a7f Fix for fractional exposure time values, fixes #2081 2017-04-16 18:52:26 +02:00
heckflosse
cd93dab966 Fix all warnings in imagedata.cc 2017-03-30 20:33:50 +02:00
Flössie
88336cb897 Make RT build without __USE_MISC and __USE_XOPEN 2017-02-14 21:02:39 +01:00
FelixJongleur42
62451f471f issue 3598 and 2289 - util functions to determine file types by ending 2017-01-20 21:14:02 +01:00
heckflosse
59e999fbf5 Used stoi instead of atoi 2016-11-08 15:31:48 +01:00
heckflosse
b5094d9d9f Pentax: ISO > 65535 was reported as 65535 in info dialog 2016-11-08 14:06:11 +01:00
Flössie
aeaff29ac0 Apply readability-simplify-boolean-expr 2016-10-12 20:01:30 +02:00
Flössie
0731975ff0 Apply modernize-use-nullptr
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
heckflosse
b744eae46d Fix a bug reported by cppcheck and an OOB access, kudos to Floessie 2016-07-08 12:41:38 +02:00
heckflosse
721de446f4 Fix crash caused by uninitialized variables when using ciecam02 on files without exif data, fixes #3084 2016-05-09 20:00:12 +02:00
Ingo Weyrich
ad32009c53 Merge pull request #3170 from Beep6581/sonylensfix
Fix Sony LensID issue, kudos to dschlegel
2016-02-23 23:57:33 +01:00