57 Commits

Author SHA1 Message Date
Flössie
80f2b6a002 Replace raw arrays with std::array<> 2019-06-14 08:58:04 +02:00
Flössie
015cffc73a Peripheral cleanups and a fix
- Whitespace, braces, sorting
- Fixed missing filmnegative in `ProcParams::operator ==(ProcParams)`
2019-06-13 09:52:13 +02:00
rom9
9df8008949 Film negative processing: first usable version. Only supports bayer raw files, thumbnails don't work
Added performance improvements suggested by heckflosse. Lowered median sampling step from 7 to 5 since calculation is now much faster.

Added support for Fuji X-Trans raw files.

Applied SSE2 patch provided by @heckflosse, improves performance in main processing loop.

Moved film negative processing stuff in its own compilation unit.

Code cleanup: removed redundant omp directives.

Added check for dead pixels, going above threshold after inversion. ST_BAYER only for now.

Reverted leftover hack in cropwindow.cc
2019-06-08 01:40:29 +02:00
Flössie
0cbc4923bc Relax dependency from procparams.h 2019-02-28 20:44:50 +01:00
heckflosse
d51e9b9bd4 Remove obsolete MSR() in imagesource.h 2018-12-05 19:20:57 +01:00
heckflosse
831e18ca45 Add override keyword. Thanks @Floessie 2018-11-22 16:19:16 +01:00
heckflosse
1fa253ba63 Fix some issues reported by coverity 2018-11-16 20:48:33 +01:00
George Hilliard
ec814dbf05 FramesData: Don't leak allocated frames, and remove unused functions
Valgrind report:

```
14,960 (11,544 direct, 3,416 indirect) bytes in 37 blocks are definitely lost in loss record 20,483 of 20,540
   at 0x4837DEF: operator new(unsigned long) (vg_replace_malloc.c:334)
   by 0xC06963: rtengine::FramesData::FramesData(Glib::ustring const&, std::unique_ptr<rtengine::RawMetaDataLocation, std::default_delete<rtengine::RawMetaDataLocation> >, bool) (imagedata.cc:1121)
   by 0xBD774F: rtengine::DFManager::addFileInfo(Glib::ustring const&, bool) (dfmanager.cc:380)
   by 0xBD6E90: rtengine::DFManager::init(Glib::ustring) (dfmanager.cc:303)
   by 0xC3EC5D: rtengine::init(rtengine::Settings const*, Glib::ustring, Glib::ustring, bool) [clone ._omp_fn.0] (init.cc:93)
   by 0x897CABD: gomp_thread_start (team.c:120)
   by 0x89B7A9C: start_thread (in /usr/lib/libpthread-2.28.so)
   by 0x8ACCB22: clone (in /usr/lib/libc-2.28.so)
```
2018-11-02 03:07:07 -05:00
heckflosse
ac700502db Flat field: Show auto calculated clip control value in ui 2018-10-24 00:49:51 +02:00
heckflosse
5c04e6308f First steps to allow border = 0, issue #4642 2018-06-27 22:34:53 +02:00
heckflosse
f7578c1512 Dual demosaic: added DCB+VNG4, RCD+VNG4. Cleaned code. Prepared engine for semi-automatic calculation of contrast threshold 2018-06-24 17:01:15 +02:00
heckflosse
84f46eaab6 Add flat field correction for monochrome raw files 2018-03-09 14:51:28 +01:00
Alberto Griggio
e265d23e76 made histogram matching depend on the input profile
This improves the accuracy of the matching when using non-default profiles
2018-02-02 13:57:43 +01:00
Alberto Griggio
bb56d73cc8 started working on proof-of-concept histogram matching 2018-01-17 01:12:13 +01:00
Flössie
3b6cc19ae9 Fix some Coverity warnings 2018-01-12 18:20:21 +01:00
Flössie
ce2be7ad87 Fix pass-by-value (Coverity) 2018-01-01 12:48:35 +01:00
Flössie
1054083661 Fix pass-by-value (Coverity) 2018-01-01 12:43:51 +01:00
heckflosse
d5ceb850f3 Make compilation unit rtengine/rawimagesource.cc -Wextra clean, #4155 2017-10-22 13:43:28 +02:00
Hombre57
dfe40677e2 Fix coverity issue 2017-10-13 23:25:24 +02:00
Hombre57
86dac147c6 Adding icons on thumbnails and solving a bug in cacheimagedata.cc
See issue #4008.
The bug in cacheimagedata.cc was preventing correct cached thumbnail
loading, asking for a full processing at each loading of the directory.
2017-08-13 18:13:39 +02:00
Hombre57
1a296b763f Correction as discussed in commit review (see also issue #4008) 2017-08-10 00:50:26 +02:00
Hombre57
f23be9345c Add multi-frame handling.
- Exif of all frames are displayed in the Editor's Exif tab (without
separator)
- isHDR and isPixelShift is added to the data files stored in cache
- In the Editor panel, the QuickInfo frame display the HDR and
PixelShift information, as well as the number of frame and bit-depth for
HDR image
- the number of frame is provided by dcraw. If not set, it is provided
by the Exif's main IFD count
- the PixelShift information (for Pentax as of now) is provided by
looking at the Exif informations
- the HDR information is provided by the Exif information of the first
frame for Pentax raw files, or by the bitspersample, sampleformat and
compression tags for other files

TODO: add icons to the thumbnails to tag HDR and PixelShift files.
2017-08-08 23:42:05 +02:00
heckflosse
8aff354df9 Fix some coverity and cppcheck issues 2017-06-18 18:40:40 +02:00
heckflosse
2a444e260a Fix some coverity issues. Pixel Shift: calculate per frame brightness factors only once after preprocessing 2017-06-17 14:43:48 +02:00
heckflosse
6e55f6bab5 Fixed a lot of issues reported by cppcheck 1.78 2017-04-08 22:41:46 +02:00
heckflosse
9bb5164cce allow translation of demosaic methods; hide Sub-Image selector for files with onyl 1 raw file; ... 2017-03-22 14:13:51 +01:00
heckflosse
d570459f1e Fixed bug in last commit when image was rotated 2017-02-05 19:03:34 +01:00
heckflosse
812bf40d17 Show raw values in navigator when demosaic 'none' is used 2017-02-05 16:06:57 +01:00
heckflosse
89901f4b36 reworked pixelshift code and temporary removed Fuji S5 dual frame support 2016-11-03 00:01:47 +01:00
Hombre
d8593469ee Adding 'Image Number' to the Bayer Raw tool 2016-11-02 02:06:40 +01:00
Flössie
0bbc84b2af Merge branch 'master' into clang-tidy 2016-10-18 17:48:50 +02:00
heckflosse
3625643392 Cppcheck: Fixed bug from last commit. Also added some new fixes 2016-10-13 17:37:08 +02:00
heckflosse
e98bd47487 Cppcheck: Fix some warnings 2016-10-12 19:04:06 +02:00
Flössie
0731975ff0 Apply modernize-use-nullptr
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
heckflosse
58e560b88e Added further speedups and astyles the changed files 2016-06-30 19:48:44 +02:00
Floessie
2abd641c06 Refactor DCPProfile::DCPProfile()
- Rename members
- Styling
- C++11

Still to come:
- All the rest of DCPProfile
2016-06-05 21:30:51 +02:00
Floessie
a520c93775 Add Ingo's patch for #3304 2016-06-04 21:07:41 +02:00
heckflosse
8e3c9bfdaf Fix broken dcp tonecurve and lookup table 2016-06-04 12:15:06 +02:00
Beep6581
10f4bf3109 Merged master into rgbcurvesspeedup. 2016-06-02 22:33:34 +02:00
heckflosse
5c14573be7 cleaned code a bit, also added a small speedup 2016-05-08 23:16:23 +02:00
Desmis
b449e0827b Init new process gain with curve 2016-02-11 18:21:56 +01:00
Desmis
f74e4b0dd2 Fixed numerous bug and add Preview for mask and transmission 2015-11-13 08:45:24 +01:00
Desmis
44490e81ae Add mask method 2015-11-12 08:58:07 +01:00
Desmis
731ccb3ef5 Add 2 methods for magenta highlight 2015-10-05 15:19:36 +02:00
Desmis
aa42f7394c Highlight magenta!! 2015-09-28 12:35:43 +02:00
heckflosse
c59fca2d6a Retinex: Fixed crash in queue and race conditions in histogram 2015-09-14 14:49:43 +02:00
Desmis
270367c592 Display histogram L in Histogram equalizer 2015-09-14 13:14:28 +02:00
heckflosse
bc841d9808 Retinex, only demosaic when enabled/disabled or Colorspace changes 2015-09-13 00:39:55 +02:00
Morgan Hardwood
5aa6f7861a Dehaze tool renamed to Retinex, GUI fixed, defaults changed 2015-09-11 21:04:29 +02:00
Desmis
528d85b1f9 Dehaz enhancement HSL GUI bugs partialpaste... 2015-09-09 20:01:27 +02:00