Flössie
0cbc4923bc
Relax dependency from procparams.h
2019-02-28 20:44:50 +01:00
Flössie
37027e46bd
Fix non-OpenMP build
2019-02-06 06:54:31 +01:00
Alberto Griggio
dbb9fcd2b1
Lens corrections: apply CA correction after distortion, and not before
2018-04-11 11:03:07 +02:00
Alberto Griggio
19281eedd1
merge branch 'lensprofile-ca-correction' into 'dev'
2017-11-14 22:53:27 +01:00
heckflosse
bd9592cb1f
Fix two warnings when using gcc < 7
2017-11-12 13:42:25 +01:00
Ingo Weyrich
5946a00511
Merge pull request #4176 from Beep6581/extraclean
...
get rt cleaner when built using -Wextra #4155
2017-11-11 18:06:00 +01:00
Alberto Griggio
2006a1755b
fixed regression in ImProcFunctions::transformGeneral introduced by recent refactorings
2017-10-31 10:49:40 +01:00
Alberto Griggio
770479f643
removed unused parameters from transformLCPCAOnly
2017-10-31 09:38:27 +01:00
Alberto Griggio
dfff9812bf
improved profile-based CA correction in preview
...
also cleaned up the code
2017-10-31 00:51:01 +01:00
Alberto Griggio
5a05b04e09
profile-based CA correction applied during 1:1 preview
2017-10-29 21:41:19 +01:00
Alberto Griggio
a29287eaa0
started working on enabling full support for CA correction with a lens profile
2017-10-26 22:51:03 +02:00
Alberto Griggio
1c86c3c44d
Disable LCP CA correction if LCP distortion is enabled
...
This was the old behaviour before lensfun integration. In order to enable both CA and distortion correction from the LCP, more work is needed.
(temporary) fix for #4159
2017-10-26 15:02:55 +02:00
heckflosse
9a17962f4b
Make compilation unit rtengine/iptransform.cc -Wextra clean, #4155
2017-10-25 16:53:17 +02:00
Hombre57
8cef3c5e2f
Merge branch 'dev' into multiframe-handling
2017-09-17 15:04:29 +02:00
Flössie
fb06a75c81
Fix clang warnings on new lensfun code ( fixes #4086 )
2017-09-17 11:06:11 +02:00
Hombre57
0905294bda
Merge branch 'dev' into multiframe-handling, with some merge bugfix
2017-09-17 01:15:51 +02:00
heckflosse
818200522a
Fix some inconsistencies in Profiled Lens Correction gui
2017-09-15 20:11:49 +02:00
Flössie
05b97f5c50
Fix some new Coverity warnings
2017-09-13 19:58:48 +02:00
Alberto Griggio
c2960caab5
some (minor) code cleanup
2017-09-13 15:06:47 +02:00
Flössie
f2853d8742
Some little cleanups to rtlensfun.*
...
- Sanitize `std::unique_ptr<>` handling
- Use `NonCopyable`
- Employ `explicit operator bool()`
- Correct use of `std::vector::emplace_back()`
- Cleanup includes
- Streamline implementation order
2017-09-12 20:58:20 +02:00
Alberto Griggio
4dc0e20ae0
merge with lcp-vignetting-issue4062
2017-09-11 17:22:01 +02:00
Alberto Griggio
e4ba4d19f5
made lensfun-based correction compatible with auto fill mode
2017-09-10 22:02:43 +02:00
Flössie
d442f7a85b
LCP cleanup ( #4062 )
...
- Removed `using namespace`
- Use real `Cache`
- Use `std::shared_ptr<LCPProfile>`
- Moved `LCPPersModel` to .cc
More could be done...
2017-09-09 20:19:11 +02:00
Alberto Griggio
f3ae370ea7
fixed bug in passing image dimensions to the lensfun correction engine
2017-09-07 16:53:53 +02:00
Alberto Griggio
940577ce45
handle coarse rotation in lensfun distortion correction
2017-09-07 09:57:37 +02:00
Alberto Griggio
dde94bc6d3
added basic integration of lensfun
...
so far only distortion correction, and no GUI yet
2017-09-07 00:53:03 +02:00
Alberto Griggio
b4d3caf9c6
changed signature of ImProcFunctions::transform to take as input an ImageMetaData pointer
2017-09-06 00:15:41 +02:00
Alberto Griggio
2c257d2215
started refactoring ImProcFunctions::transform in preparation for lensfun integration
2017-09-03 20:48:49 +02:00
Alberto Griggio
0ecb02afdd
Merge pull request #3916 from Beep6581/lcp-distortion-alt-match
...
Lcp distortion alt match
2017-06-26 23:37:14 +02:00
heckflosse
c4f27b2c13
Fix some coverity issues
2017-06-14 17:02:33 +02:00
Alberto Griggio
b39529f7c0
LCP: new experimental logic for finding the correct distortion coefficients
2017-06-05 14:21:52 +02:00
Ingo Weyrich
3ff2519302
Merge pull request #3816 from Beep6581/cppcheck3
...
Merged to get more tests. Additional fixes will follow.
2017-04-09 23:58:07 +02:00
heckflosse
6e55f6bab5
Fixed a lot of issues reported by cppcheck 1.78
2017-04-08 22:41:46 +02:00
Alberto Griggio
871c75e494
Correctly apply LCP "distortion" correction for Fisheye lenses
...
Note: as discussed e.g. at http://lensfun.sourceforge.net/manual/corrections.html , this is really a combination of distortion correction and change of projection (from fisheye to rectilinear), but "distortion correction" is how the Adobe camera model calls it, and this is how it appears in the RT gui
2017-04-08 10:13:53 +02:00
Desmis
bdcc4ab37e
clean iptransform ipresize ipvibrance
2017-03-31 12:57:07 +02:00
Alberto Griggio
4bf70b72e8
fixed zooming and rendering of the preview window when a LCP profile with distortion correction is active
...
fixes #3765
2017-03-18 17:14:45 +01:00
Flössie
d2b4fe5e54
Merge branch 'std_cpp11-dev' into dev ( fixes #3635 )
2017-02-21 20:37:21 +01:00
Flössie
e9b5f42a9f
Sanitize ImageDimensions
base class
...
- Make `width` and `height` private
- Drop `getW()` and `getH()`
- Clean `PreviewProps`
2017-02-14 21:23:54 +01:00
Flössie
88336cb897
Make RT build without __USE_MISC
and __USE_XOPEN
2017-02-14 21:02:39 +01:00
Ingo Weyrich
2145f559ae
Merge pull request #3477 from Beep6581/speedup_gradient_vignette
...
Speedup Vignette and Graduated Filter
2016-12-19 00:36:42 +01:00
heckflosse
db2c01af02
Further small speedup for vignette and gradient
2016-12-13 15:13:03 +01:00
Flössie
495c0938f4
Fix Clang warnings and build failure on OSX 10.12
...
Kudos to Partha over at pixls.us for finding and fixing!
2016-11-06 17:09:27 +01:00
heckflosse
2c7325b2fd
Removed StopWatch
2016-10-22 18:11:14 +02:00
heckflosse
09b319fe0b
Speedup for Vignette and Graduated Filter
2016-10-22 00:21:01 +02:00
Flössie
0731975ff0
Apply modernize-use-nullptr
...
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
heckflosse
8e4c4be6d6
Allow lcp distortion correction for lenses without focal length information (e.g. lenses without chip)
2016-04-12 13:38:27 +02:00
DrSlony
0e0cfb9b25
Formatted all .cc and .h code in rtengine, rtexif and rtgui using astyle
2015-08-11 11:55:03 +02:00
torger
d5ca351c20
Issue 2134: removed obsolete raw highlight preservation setting from GUI (still left in procparams for backwards compatilibility)
2015-07-10 12:00:36 +02:00