Commit Graph

4902 Commits

Author SHA1 Message Date
Lawrence Lee
7eb7fb210f Merge branch 'dev' into metadata-exiv2 2023-08-12 15:08:42 -07:00
U-PCSPECIALIST01\jdesm
269e426cc6 Another change to blendmask 2023-08-07 08:48:08 +02:00
U-PCSPECIALIST01\jdesm
8d437fec38 Change range blmask in iplocallab - thanks to hombre 2023-08-07 07:06:55 +02:00
Lawrence37
0052f08e94 Merge pull request #6794 from Lawrence37/auto-dcp-locale-fix
Fix for Auto-matched camera profile detection when using the English (US) language
2023-08-06 14:52:08 -07:00
Lawrence37
ec24613f3b Merge pull request #6778 from Lawrence37/eos-7d-markii-raw-crop
Improved raw crop for Canon EOS 7D Mark II
2023-08-06 14:48:35 -07:00
Lawrence37
7e0f0b6636 Merge pull request #6807 from Lawrence37/ilce-7rm2-pdaf-pattern
Fix PDAF lines pattern for Sony ILCE-7RM2
2023-08-06 12:30:10 -07:00
Lawrence Lee
4faea6df7b Merge branch 'dev' into eos-7d-markii-raw-crop 2023-08-06 11:58:30 -07:00
Lawrence Lee
c5a0067eee Merge branch 'dev' into metadata-exiv2 2023-08-06 10:25:49 -07:00
Desmis
8d0333120e Research and development - WB auto -temperature correlation - tests - finding the optimum settings (#6643)
* Change estimchrom estim hue final

* Itcw observer checkbox

* 8 spectral colors

* 11 spectral colors

* 6 spectral colors

* Small change to correction green

* Fixed various bad behavior - settings itcwb_deltaspec

* 4 spectral colors green

* 3 green spectral colors

* 3 spectral colors green

* 5 spectral colors red green

* 3 spectral colors red green

* 3 spectral colrs green red

* Chnage slider choice deltaE - to size color patch

* display more info in console

* Display more info in console - comment code

* Clean - comment code

* 8 spectral colors green red

* 8 spectral colors blue

* 8 spectral colors blue

* 3 spectral colors

* 6 spectral colors

* 4 spectal colors

* 2 spectral colors

* Eliminate high Y - increse temp iteration - recenter selection inside patch

* compatibility 5.9

* Modify dislay and place selected dats in patch

* Dispaly in console hue chroma image selection

* First optimization

* optimization code - clean unused variables

* Remove sorted in chroma order - some others changes

* 5.9 compatibility

* Clean and optimize code

* Clean code - more display info in console

* More info in console - set itcwb_minsize in option

* Display patch chroma in GUI

* Change some default settings

* Minsize patch GUI

* Display GUI patch size

* Chroma patch variations

* Display in GUI min and max dats found in patch

* Some adjustments

* Remove too low datas in patch

* Various improvment - ponderate

* Clean code colortemp comment spectral datas

* Comment code - correc gren

* Comment and refine code

* Fixed bug in improcoordinator

* fixes a malfunction of AWB bias in improcoordinator

* Various improvments - clean code

* 2 improvments green and find patch

* Allows parametrind ponder and Ypurple in options

* Update autowb - filter on magenta purple

* Clean and optimize code

* Read colors in GUI

* Denoise median 5x5 image datas before Itcwb

* Change to GUI

* Replace median5x5 by 2 median3x3 - clean GUI code

* Work around to recalculate wbauto

* Remove work around - change params->wb related change

* Disabled low_sampling 5.9

* First try for compatibility Low sampling 5.9

* Re-enable WB autogrey

* Change reference image to autogrey if camera settings probably out

* Clean code aand adjust settings camera out

* Format astylert rawimagesource.cc - various small adjustments

* Small correction

* Small green correction

* Change default settings - correction to autowb bias in improccoordinator

* Save provisory work

* Save provisory work 2

* Try to find good tempitc with iterate when temptitc very different 5000K

* Change 2 default settings

* Work around awb temp bias

* Limit work around bias - small other changes

* 3 spectral colors deep blue

* 4 spectral color deep blue

* 4 color spectral yellow

* 5 spectral colors neutral red-magenta

* 5 spectral color neutral red magenta

* Change threshold tempitc

* 5.9 compatibility

* Work around bad claculation Planck's formula

* Fixed bad behavior when using blackbody spectal

* 6 spectral color - checkbutton remove 2 passes

* Fixed various bugs

* Format rawimagesource.cc

* Various improvment before to find the good selection

* First new optimization (perhaps?)

* Display GUI patc deltaE

* Various optimzation and tooltip

* Default observer 2°- Simplify GUI - improve display GUI - remove too low numbers datas

* 4 spectral colors - change 2 settings

* Change calculation threshold 2 passes

* 6 spectral colors magenta

* 13 spectral colors

* Improvment GUI display

* remove checkbutton no_purple

* 2 spectral colors - remove in GUI low sampling 5.9

* Change default setting display in console

* Change behavior when temp near stdA

* 4 spectral colors - settings Itcwb_tempstdA

* Gamut control on image histogram

* Clean code and format rawimagesource.cc

* Comment and format colortemp.cc

* Remove unused fileds from GUI - change tooltips

* Add tooltips

* Various changes

* Change settings when camera temperature is out

* improvment extra and tooltip

* Small change when using auto grey as start reference

* Remove itcwb_fgreen from GUI

* Various change - and 'unsatisfactory' test to take into account Custom

* Change second temp when < 4000 - replace automatic by automatic and refinement

* Neutralize 'Use custom tempertaure and green'

* Green refinement

* Clean code - small changes

* Other clean code

* Added forgotten itcw_green in procparams.cc

* Fixed a bug dispaly deltaE

* Change threshold settings - change code for Custom

* various change in case of using camera settings

* Change way to estimate range green

* clean code and message in console

* Clean and optimize

* Disable 2 passes if custom

* Improve GUI 2 passes

* Increase sampling and number of temperature above 9400K

* Hide AWB temperature bais and green refinement when Custom temerature ans green

* marks out the code with past time markers

* Improve time processing with spectral colors temp calculations

* Replace in console msec by nsec

* Scan temp 5.9

* Change max temp and behavior if temp > 15000k

* Refine temp near 14000K

* Increase sampling temperature 132 to 167

* Increase sampling temperature

* Set in preference choice for itcwb_custom

* White point calculated  with observer instead of table

* More on whitepoint calculation - informations

* Clean and format code with astyle colortemp.cc rawimagesource.cc improccoordinator.cc

* Small change tooltip

* Improve update auto-wb

* Remove 'use custom temperature and tin' - simplify sampling to 2 choice

* Small change to rand AWB bias - green refinement - tooltips

* slightly modify the parameters upstream of the algo - do not use camera in some cases

* Mixed initial green

* Refine init green and temp when no camera

* Refine temp and green in do not use camera settings

* Change tint threshold and various improvments (tooltips, wrong values..)

* Refinment and clean code

* Improve mode No use camera settings

* Init nocam

* Refine use no camera  settings

* Small change

* 5.9 compatibility - and format

* Refine sampling temperature  around 7000 - 8000K

* Format astylert rawimagesource colortemp

* 5.9 settings

* 5.9 settings 2

* Various change - 5.9 - format

* Improve pre and post algorithm

* Fixed correction temp > 8000K

* Fixed bad behavior Tppat.minchroma

* Change sampling choices and tooltip

* Change name wp wp2 wip to wb wb2 iwb to avoid misunderstood

* Small Change settings - limit display studgood to 0.0001

* Improvment display GUI temp

* Change default sampling

* Change ACESP0 to JDCmax

* Improve GUI abstract profile

* Allows dispaly in console xy values thanks to Reffort

* Remove bruce rgb in wp and abstract

* Change wp abstract and save itcwb with dispaly cellxy

* Change prim = 13 improccoordinator iplab2rgb

* remove display datas in console - fixed wrong display Y xyY

* Fixed ifferences in GUI maxhist minhist

* Change limits x y in function sampling

* fixed a dizziness

* Change  after algorithm rule when temp > 6000K

* Harmonize limx limy for oldsampling 5.9

* Added Cam xyz matrix to sampling - thanks to Reffort

* Display in console xyz matrix

* Forgotten instruction when mix camera and autowb grey

* Change rgbloc with Camera matrix Dcraw when no input profile

* Change rep to repref in rgbxyz

* Remove message in console

* 5.9 compat

* 5.9 compat 2

* 5.9 compat 3

* 5.9 compat 4

* 5.9 compat 5 format

* 5.9 compta 6

* Improve code

* Diasble itcwb_sampling in GUI

* Comment code

* Clean and comment code

* 5 spectral colors

* 9 spectral colors

* 2 spectral colors

* Various improvments

* 5 spectral colors

* 5 spectral colors

* First changes review lawrence37

* Second changes review Lawrence37

* 3rd changes review Lawrence37

* 4th changes review Lawrence37

* Change windows and appimage yml

* Re-enable Rtv4_Bruce in procparams.cc

* test for 5.9 compatibility

* Try to fixed crash

* Slightly improve the management of 5.9

* test for 5.9 compatibility by passing parameters via the GUI

* Forgotten parameter

* Change ref_spec limit and remove pac_start for itcwb_sampling

* Puts back the old Planck formula - the same as in dev

* Revert "test for 5.9 compatibility by passing parameters via the GUI"

This reverts commit d6b5a8feda31b93a5574cee6ebf4d3e9d58bbcfb.

* Switch to new ITCWB only when changing WB method

Prevents sudden changing of the white balance if ITCWB is selected and
the image is reopened.

* Fix spelling in comment

* Suggested change from Lawrence37 to whitebalance - small change to improcoordinator

* tempbias Set_sentive(false) if itcwb_smapling - clean whitebalance

* Another clean whitebalance.cc

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2023-08-06 13:44:48 +02:00
Jean-Christophe
00fff386c7 Merge pull request #6722 from hfiguiere/crop-leak-6721
Issue #6721 - Fix memory leak in Crop
2023-08-06 12:57:43 +02:00
Lawrence Lee
5c42a50204 Fix PDAF lines pattern for Sony ILCE-7RM2 2023-07-30 14:25:17 -07:00
Michael Jaschob
31bbe91760 Use std::vector Instead of Manually Managed Memory 2023-07-27 14:31:53 -06:00
Michael Jaschob
5b2811f42b Allocate on Heap, Not Stack, in gaussVertical and Friends 2023-07-22 22:20:29 -06:00
Lawrence Lee
6f50b68fa7 Consider raw border with CA avoid color shift 2023-07-16 16:17:57 -07:00
Lawrence Lee
ab2cc4ba45 Fix auto DCP detection when using US English
For systems where the locale is not English but the language in
preferences is manually set to "English (US)", the Color Management
Auto-matched camera profile option is not selectable even if a DCP
exists for the camera. This is because the Glib::ustring
casefold_collate_key() method returns a locale-dependent value. When
initializing the list of DCP files, the system locale is used. When
finding a matching DCP profile for an image, a different locale is used
because the LANG environment variable is set while initializing the
RawTherapee GUI language.
2023-07-15 18:36:26 -07:00
Lawrence37
b68a6e9581 Merge pull request #6790 from luzpaz/typos
Fix various typos
2023-07-12 21:22:54 -07:00
luzpaz
b0ebab8e08 Fix various typos
Found via `codespell -q 3 -S ./rtdata/languages -L activ,alph,ba,bloc,bord,chang,childs,currentry,dof,dum,fo,hist,inout,invers,lonly,makro,ois,pres,preserv,portugues,rady,reall,redy,struc,tbe,thre,trough,vart,vekto`
2023-07-05 13:51:11 +00:00
Lawrence Lee
fcf22ea33a Update white level for Canon EOS R5
Drop the white level slightly to account for noise. White level
confirmed in https://github.com/Beep6581/RawTherapee/issues/6783.
2023-07-01 18:39:05 -07:00
Lawrence37
1d9225dfc3 Merge pull request #6774 from Lawrence37/hsv-equalizer-pipette-crash
Fix for HSV equalizer pipette crash
2023-06-30 22:24:43 -07:00
Lawrence37
9ca2217603 Merge pull request #6766 from Lawrence37/lab-curve-histogram-scale-fix
Fix for L*a*b* curves histogram scaling and pipette values
2023-06-30 22:24:27 -07:00
Lawrence37
f490e9c607 Merge pull request #6765 from Lawrence37/pipette-lab-fix
Fix L*a*b* values in the lockable color picker and navigator
2023-06-30 22:24:07 -07:00
Desmis
0404a47fb7 LA Color and Light - Merge file - Screen : improve behavior (#6779)
* Change merge secreen in LA color and light

* Remove warning in console
2023-06-25 08:02:53 +02:00
Lawrence37
c6028d0364 Merge pull request #6768 from Lawrence37/eos-r8-raw-crop
Camconst entry for Canon EOS R8
2023-06-24 16:26:28 -07:00
Lawrence Lee
27f247e8db Crop row of bad pixels for Canon EOS 7D Mark II 2023-06-20 22:25:10 -07:00
Lawrence Lee
1ea0ef8af1 Fix HSV equalizer pipette crash
Check if pipette buffer is valid before filling it in the RGB process.
2023-06-17 22:07:46 -07:00
Lawrence37
b0714e7c00 Merge pull request #6691 from elliptic-shiho/fix-jpeg-exif-buffer-size
Fix the buffer-size computation flow of exif marker of JPEG
2023-06-13 20:53:51 -07:00
Lawrence37
0a3a314d82 Merge pull request #6687 from matei-georged/georgem_6630_fix_pdaf_crash_nikonz50
PDAF lines filter crashes with RAWs from Nikon Z 50
2023-06-13 20:50:59 -07:00
Lawrence37
ae188f6338 Merge pull request #6709 from hfiguiere/dcraw-6708
Issue #6708 - fix overlapping buffer strcpy
2023-06-13 20:49:27 -07:00
Lawrence37
bca2d05f95 Merge pull request #6645 from Entropy512/user_icc
iccstore: Allow loading profiles from user-writable configuration directory
2023-06-13 20:48:56 -07:00
Lawrence37
c07a6e8901 Merge pull request #6641 from Lawrence37/tone-equalizer
Global tone equalizer
2023-06-09 21:15:58 -07:00
Desmis
be2d5ce11f Local adjustments - denoise improvments (#6705)
* Init improvment LA denoise

* First display luma chroma residual noise

* Clean code denoise iplocallab.cc

* Change windows.yml with old version january 2023

* Clean code - change calculation denoise - GUI

* Improve labels tooltip denoise

* Clean code

* Change tooltip

* Set auto denoise - main - chroma auto to 50%  when LA denoise is used

* Change GUI denoise with expanders

* Change labels

* Change reference remianing noise in percentage

* Change tooltip and labels

* Change values in preview remaining noise

* Clean comment code - chnage tooltips

* Change windows.yml and appimage.yml publish_pre_dev labels

* Update windows.yml

* Restore windows.yml

* Restore windows.yml and clean code

* Revert change Noise Reduction link with Local denoise

* Revert all changes on Noise-reduction linked with Local adjustments
2023-06-05 06:40:57 +02:00
Lawrence Lee
376d680b16 Add basic camconst entry for Canon EOS R8
The camera seems to have the same characteristics as the Canon EOS R6m2.
The raw crops for the R6m2 are derived from standard and CRAW images for
full-frame and 1.6 crop. The raw crops for the R8 are from standard and
CRAW images for full-frame only, but for both standard and Dual Pixel.
The Dual Pixel R8 images require 10 pixels cropped from the right side
instead of 6. Thus, the full-frame crop needs adjustment.
2023-06-04 16:32:41 -07:00
Lawrence Lee
24f0bff0ab Fix L*a*b* curves histogram and pipette scaling
Use correct horizontal scale for chroma histogram.
Fix pipette values for chroma, a*, and b*.
2023-05-29 15:49:58 -07:00
Lawrence Lee
8accebe416 Fix incorrect sampled L*a*b* values
Use LCMS to convert values back into L*a*b*. The pipette buffer has the
output or working profile applied with LCMS. Performing the inverse
operation fixes the incorrect values shown in the navigator, histogram
indicator bars, and lockable color pickers.
2023-05-28 18:15:27 -07:00
Lawrence37
6a11c59b79 Merge pull request #6758 from Lawrence37/sony-zv-1-camconst
Sony ZV-1 color matrix and black level
2023-05-27 15:24:25 -07:00
Lawrence37
77853893a9 Merge pull request #6739 from SimonSegerblomRex/fix-6682
dcraw.cc: Fix bug for tiff_ifd.new_sub_file_type
2023-05-27 15:23:02 -07:00
Hubert Figuière
a1bbc93538 Fix missing explicit include (#6704)
* Fix missing explicit include

- Also avoid rtgui include

* Fix more missing explicit include
2023-05-21 15:25:42 -07:00
Lawrence Lee
68ae17a640 Add PDAF pattern for Sony ZV-1 2023-05-14 12:14:33 -07:00
Lawrence Lee
572a75f02a Fix lens model reading for Sony ILMEs and ZV-E10
Use lens model from the EXIF group for these cameras.
2023-05-14 11:06:23 -07:00
Lawrence Lee
bcf9b86dcf Add Sony ZV-1 color matrix and black level 2023-05-13 17:36:22 -07:00
Lawrence Lee
0ac49e4d9a Support Exiv2 >= v0.28.0
The various Datum classes no longer have the toLong method and must be
replaced with toInt64.
ErrorCode is an enum class instead of an enum.
Error classes are reduced to Exiv2::Error.
2023-05-13 16:43:47 -07:00
Lawrence Lee
8c98925f3d Get lens name from EXIF group for ILCE/NEX cameras
Fix incorrect lens name read in certain cases from Sony cameras (see
https://discuss.pixls.us/t/call-for-testing-rawtherapee-metadata-handling-with-exiv2-includes-cr3-support/36240/87).
2023-05-12 22:44:04 -07:00
Lawrence37
677aaf2ec7 Merge pull request #6753 from Lawrence37/eos-r6m2-raw-crop
Canon EOS R6 Mark II raw crop
2023-04-29 14:18:47 -07:00
Lawrence Lee
25082b6fc0 Add Canon EOS R6 Mark II color matrix 2023-04-28 21:56:27 -07:00
Lawrence Lee
91a07a2ac5 Add raw crop for Canon EOS R6 Mark II 2023-04-27 21:11:58 -07:00
Lawrence Lee
61b05f8504 Fix crash with Fujifilm sports finder mode
Handle heights and widths larger than raw heights and widths. Add
camconst raw crop for certain Fujifilm cameras with sports finder mode
on.
2023-04-22 21:32:08 -07:00
Simon Segerblom Rex
3ea40d893e dcraw.cc: Fix bug for tiff_ifd.new_sub_file_type
This was regressed by bd118a4a40.
2023-04-16 08:02:46 +02:00
Lawrence Lee
1eb58255ce Merge branch 'dev' into tone-equalizer 2023-04-15 16:58:52 -07:00
Lawrence Lee
9893e02aab Move tone equalizer after exposure
Place it between the shadows curve (black and shadow compression) and
DCP tone curve and look table. Moving it after exposure makes it
possible to easily adjust the exposure to the ball-park range before
applying the tone equalizer. Keeping it before the tone curves allows it
to affect the image before clipping occurs.
2023-04-15 16:53:58 -07:00
Lawrence Lee
c4245b5106 Merge branch 'dev' into metadata-exiv2 2023-04-09 17:10:54 -07:00