12554 Commits

Author SHA1 Message Date
Lawrence Lee
a57cbcfdb4
Fix macOS ARM build
Add permission to upload artifacts to release tags.
2025-02-01 15:27:30 -08:00
Lawrence37
cd3b2c31e8
Merge pull request #7296 from Lawrence37/workflow-permissions
Fix for artifact uploading from GitHub Actions
2025-02-01 14:29:01 -08:00
Lawrence Lee
7ad0c95594
Fix workflow ability to upload artifacts
Add content write permission to AppImage, macOS, and Windows workflows.
2025-02-01 12:38:50 -08:00
Lawrence37
fa4d0e1f24
Merge pull request #7265 from Lawrence37/info-font-size
Quick info font size
2025-02-01 11:44:32 -08:00
Lawrence37
831f7bea46
Merge pull request #7281 from Lawrence37/sony-lens-identification
Sony lens identification improvement
2025-02-01 11:43:32 -08:00
Lawrence37
049ff6e6d8
Merge pull request #7274 from RawTherapee/fixbug-blur-2
Fix for Blur/Grain & Denoise in global mode
2025-02-01 11:42:27 -08:00
Lawrence Lee
1885f5d489
Improve proc params clear when XMP sync enabled
Always check the rank and color label in the XMP if XMP sync is enabled
when clearing the processing parameters. Allows the pp3 to be deleted
whenever possible, even if the rank or color label has been edited.
2025-01-20 12:53:07 -08:00
Lawrence Lee
367041e2e6
Fix processing params clear when XMP sync enabled
Fix caching of XMP when clearing processing parameters so that it knows
if the pp3 can be deleted without affecting the rank and color labels.
2025-01-20 12:49:36 -08:00
U-PCSPECIALIST01\jdesm
1d56072be4
Fixed pb step 1 2025-01-19 15:29:33 -08:00
Lawrence Lee
d3dca005eb
Merge branch 'dev' into clear-pp3-bug-fix 2025-01-19 12:50:55 -08:00
Lawrence37
5041aa2de4
CodeQL workflow fix (#7290)
The ubuntu-latest runner is now using Ubuntu 24.04. Package libhwy0 has
been renamed to libhwy1t64. Since libhwy-dev is required and dev
packages depend on the runtime library, libhwy1t64 does not need to be
explicitly installed.

Update libjxl and its dependencies in CodeQL workflow.
2025-01-19 12:47:37 -08:00
Desmis
a578423378
Abstract Profile - Contrast enhancement -- Selective Editing Cam16 and JzCzHz - improvments (#7111)
* Init levels trc GUI

* Levels TRC

* Complete with gamma based attenuation

* Limit RGB channel Slope with checkbox

* Improve GUI and code channel TRC

* Change default values - compexity levels RGB channels

* Relative gamma mode RGB channel TRC

* Change label and ponderation rolloff

* Change rolloff level

* Threshold attenuation

* Threshold attenuation 2 part

* GUI Link R G B

* Linked RGB with Green slope - RGB channels

* Set Freeman TM functions with ImProcFunctions

* First GUI Abstract profile highlight attenuation

* GUI AP part 2

* Restore olg GUI AP

* Expander AP primaries adn illuminant

* Disable RGB channel TRC

* Expander contrast AP

* Slider attenuation response

* Save work GUI local contrast

* Save GUI part 2 AP curve

* Local contrast GUI Abstract Profile

* Move Abstract profile in toolpanel and ICMpanel

* rtengine variable contrast

* Variable contrast 2

* Variable contrast engine 3

* Variable contrast engine 4

* Variable contrast engine

* Detail levels pyramid

* Engine residual contrast

* Residual contrast

* Change settings detail levels

* Expander refinement - new tooltips - low resid contrast

* Change contrast profile and labels

* Remove warning message GUI Gtk

* Gamutcontrol code - disabled

* Improve with calceffect

* Other improvement variable contrast

* Offset variable contrast

* Range offset - comment code

* Parametric inva fot lut

* Clean cmakelist.txt

* Change contrast profiles

* Comment code ipwavelet

* Added orthogonal Daubechies scaling D20

* Change strenght curve - tooltip Daubechies

* Forgotten changes

* Comment code

* Move variable in process - take into account highlight attenuation

* Display label maximum preview and preset selection

* Remove console message

* harmonize levels wavelets iplocallab

* Tooltips contrast enhancement

* Change tooltip Contrast profile

* Chnage tooltip Contrast

* Message warning preview size

* Change gamma TRC values in GUI

* Remove itanium architecture support for windows as PR 7105

* Change windows.yml and appimage.yml

* Windows.yml apseimprov

* Clean and comment ipwavelet

* Clean comment icmpanel.cc

* Harmonize local contrast wavelet Selective editing with Abstract profile

* Harmonize with AP - offset

* vanishing moment D20 - Selective editing wavelet

* Offset only in advanced mode

* GUI expander contrast enable and pyrwavtrc

* Clean and comment code

* merge with dev

* Prepare sigmoid based

* Contrast sigmoid GUI

* Skew sigmoid GUI

* Sigmoid tone mapper in iplocallab

* Change GUI settings

* White-point and black-point auto

* Change EvDCP to ALLNORAW as others events DCP

* Change default skew

* Change settings - enable scale Yb

* Display white point - advanced mode

* Improve GUI

* Clean unused variable

* new sigmoid Q in cam16

* Change tooltips and default sigmoid Q settings

* Sigmoid Jz

* Clean code Jz and sigmoid

* Harmonize Sigmoid Q and Sigmoid RGB

* Harmonize Sigmoid Jz

* Clean code

* Improve labels wit cd/m2

* Slope base Q methode first

* GUI slope based Q

* Change default settings and tooltips

* Change tooltips

* Clean code - change default setting

* Change default local contrast & wavelet to wavelet & basic mode

* Fixed bad assignation slopesmoq

* Improve sigmoid and slope based Q - GUI for Log encoding Color appearance

* Remove wrong change

* various small improvments

* Allows black and white AP and SDA in basic mode

* Change  the writing of wGamma and wSlope - attenuates the effect of the first 2 AP contrast profiles

* Clean code wgamma wslope

* Set curve Cam16 in basic mode

* Change position curve in GUI cam16

* Enable tonecurve1 in colorappearance & lighting in standard mode

* Fixed bug scale yb scene - ciecam curve - change default contrast enhancement

* not reset curve shape ciecam in strandard

* Change label Tone mapping operators and tooltips

* Change some labels and tooltips - Appearance - Mask and Mofifications - Recovery Based On Luminance Mask

* Forgotten changes

* Clean locallabtools2.cc

* Maxlevel wavelet minimum to 5

* Reset mask and modifications in SE wavelet and all tools in Global

* Show modified areas SE wavelet

* Tooltip show wavelets decomposition

* Fixed another bad behavior in Global - changes also in color & light for merge file

* Change behavior fullimage - global as in PR GHS

* Disable all mask and modifications in Global but remain active in fullimage and normal

* Set expander expanded = true

* Chane contrast enhancement coef

* Replace VBox trcWavVBox by ToolParamBlock trcWavFBox

* Forgotten code in icmpanel read pedited opacityShapeWLI - hope solve batch mode

* Change RGB Slope behavior with link

* No access to last level contrast enhancement

* Move Abstract Profile tooltip to title

The tooltip was popping up when the cursor was over almost any part of
the tool which was inconvenient. Now, the tooltip only appears when
hovering over the title.

* Improve Color Management expanders behavior

By default, collapse Abstract Profile and leave it's sub-expanders
expanded.

Keep the expanded state of all the sub-expanders during the editing
session.

Fix the right-click behavior. The clicked expander should be expanded
and all siblings, if any, should be collapsed.

* Fix RGB slope tone mapping RGB linkage

Synchronize the red, green, and blue values before updating the preview
to avoid using incorrect values to generate the preview.

* Fix SE CAM tone mapping slider defocus

Avoid unnecessarily hiding then showing the adjusters in tone mapping so
that focus is not lost while adjusting the adjusters.

* Delete history kslopesmo - remove IcmOpacityCurveWL

* change the tooltips as suggested by Lawrence

* Review L37 - change strengthjz strengthlc - MIDDLE_GREY MIDDLE_GREYjz - artifacts ciecam

* Change name Tone map freeman functions

* Remove gamutcont - rename localcont - change allocation memory wdspot

* Clean procparams

* remove sigmoidsenscie - logcieq

* Added * to three labels 'sigmoid' - change tooltip which shows the incompatibility with 5.11

* Forgotten correction suggested by Lawrence

* Compatibility 5.11 log encoding - sigmoid part 1

* Compatibility 5.11 part 2

* Compatibility 5.11 - step 3

* Compatibility 5.11 - step 4

* Compatibility 5.11 step xx

* Compatibility 5.11 - combobox operators Q and J

* Compatibility 5.11 Cam16 GUI first part

* Improve GUI Cam16 sigmoid compatibility

* Compatibility 5.11 Jz - sigmoid - step 1

* Compatibility 5.11 Jz gui step 2

* Compatibility 5.11 Jz GUI step x

* Compatibility 5.11 Jz - history - etc.

* Various change labels - history ...

* Improve GUI - hide show 5.11 5.12

* Jz 5.11 in iplocallab - step 1

* Compatibility 5.11 iplocallab cam16 step 1

* Improve GUI hide show 511 512

* Solved - I hope - GUI problem with tone mapper Q and J 5.11 and 5.12

* Compatibility 5.11 iplocallab Cam16 step 2

* Improve GUI compatibility 5.11 labels tooltips

* Small improvments GUI - labels - history...

* Fixed typo in paramsedited.cc clcurve issue 7283

* Change tooltips method 5.12 - 5.11 for cam16 and Jz  brightness Q or J

* Clean and refine code

* Various change dafult language  and CAM16 CAM02 replace by Cam16 Cam02

* Change modeQJ method for 5.11 in function ppversion

* Change labels as suggested by Wayne PR 7111

* Others changes suggested for label

* Change tooltips as suggested in PR

* Use unique pointer instead of manual management

* Update rtdata/languages/default

Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>

* Change all Cam16 references to CAM16

* Change convention uppercase and lowercase in frame - checkbox

* Improve tooltips for Tone Mapping Operators

* Another change CIECAM and uppercase lowercase in checkbox

* Remove appimage and windows yml

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2025-01-19 07:52:32 +01:00
Lawrence Lee
187a0318d3
Fix pp3 deletion when clearing processing params
Fix comparison of original vs. current rank. The rank value can be -1,
which should be interpreted as 0. This allows proper assessment if the
rank has been changed. The pp3 is deleted if and only if the rank, color
label, and trash status are unchanged. pp3s were not getting deleted
because of the mismatch between the original rank (-1) and current rank
(0).

Also consider the rank and color label in the metadata and XMP sidecars.
If the rank and color label have not been edited in the current session
and the current values match the ones in the metadata and XMP sidecars,
the pp3 can be deleted.
2025-01-18 18:01:30 -08:00
Lawrence37
70a4309bd5
Merge pull request #7264 from Lawrence37/demosaiced-float-dng
Demosaiced floating point DNGs
2025-01-16 22:20:53 -08:00
Lawrence37
d6059979d5
Merge pull request #7259 from Lawrence37/raw-dehaze-bad-pixels
Raw dehaze negative values fix
2025-01-16 22:20:40 -08:00
Lawrence Lee
79d402c820
Improve lens identification for Sony ARWs
Let Exiv2 get the lens name if the lens spec is present. Otherwise, use
the lens ID.
2025-01-11 12:21:20 -08:00
Lawrence37
ccce1530b4
Merge pull request #7245 from Lawrence37/camconst-separation
Separation of camconst files
2025-01-01 15:57:37 -08:00
Daniel Gao
4969fdd989 Clean up framing compiler warnings
* Remove unused variables/dead code
* Add missing `.children = {}`
* Remove relative includes
2024-12-27 18:37:11 -05:00
Lawrence37
98752a2433
Merge pull request #7257 from Beep6581/fix-warnings-5.12
Compiler warning fixes
2024-12-26 22:26:11 -08:00
Lawrence37
ed7f2d0690
Merge pull request #7255 from digitalcarp/cleanup-includes
Get rid of relative include paths
2024-12-26 22:25:58 -08:00
Lawrence37
3c21dca522
Merge pull request #7253 from digitalcarp/framing
Add Framing Tool
2024-12-18 22:16:28 -08:00
Lawrence Lee
efb8870877
Reject bad pixels with raw de-haze
Do not consider pixels lower than the black level.
2024-12-14 15:29:23 -08:00
Lawrence37
9fbdc25245
Merge pull request #7258 from Lawrence37/raw-dehaze-crash-fix
Multi-frame image crash fix
2024-12-14 12:46:48 -08:00
Lawrence37
31e90afe22
Merge pull request #7254 from Lawrence37/ilce-7m3-black-level
Sony ILCE-7M3 (and other Sony cameras) black level
2024-12-14 12:46:01 -08:00
Lawrence37
f2fe3bffe5
Merge pull request #7249 from Lawrence37/canon-r8-masked-area-fix
Canon R8 electronic shutter black level fix
2024-12-14 12:44:55 -08:00
Lawrence37
598ec01b3b
Merge pull request #7269 from Benitoite/patch-45
macOS CI: upgrades x86_64 runner to macOS 13
2024-12-14 11:46:11 -08:00
Richard E Barber
e6e3d95bb4
macOS CI: upgrades x86_64 runner to macOS 13 2024-12-13 07:05:26 -08:00
Lawrence Lee
5fe1520c65
Set font size of quick info display
Use the main font size set in preferences.
2024-12-08 17:17:41 -08:00
Lawrence Lee
fd445d00a6
Support demosaiced floating point DNGs with LibRaw 2024-12-08 14:34:56 -08:00
Daniel Gao
f8cde10662 Fix missing min frame border
* Previously only considered min border if the current border is smaller
* Need to consider as long as min size is enabled
2024-12-06 22:16:27 -05:00
Daniel Gao
a54aacca3f Switch framing tool events to use event mapper
* Removed hard coded events from ProcEventCode and RefreshMap
* Change HISTORY_MSG_* to HISTORY_MSG_FRAMING_*
2024-11-30 15:03:14 -05:00
Daniel Gao
d3962c7e56 Fix framing tool issues
* Print messages only in verbose mode
* Linearize 8-bit values to 16-bit values properly
* Fix memory leak
2024-11-30 14:31:18 -05:00
Daniel Gao
f983da5d16 Fix bugs in framing tool sizing
* Rework uniform relative size calculations
* Fix minimum size requirements not being respected
* Fix typo in framing tool keylib value
* Drive-by code formatting changes
2024-11-30 13:55:52 -05:00
Lawrence37
b0117b7a60
Merge pull request #7246 from Lawrence37/offset-time-default
Include offset times in default EXIF tags
2024-11-24 16:13:23 -08:00
Lawrence37
082d9ff4e8
Merge pull request #7242 from Lawrence37/batch-exif-reset-fix
Fix for all EXIF data getting selected
2024-11-24 16:12:55 -08:00
Lawrence37
9774355960
Merge pull request #7240 from Beep6581/se-exposure-cbdl-dehaze-crash-fix
Fix for crash with Haze Removal, CBDL, and Selective Editing Exposure
2024-11-24 16:12:34 -08:00
Lawrence37
74adad2c8c
Merge pull request #7239 from Beep6581/channel-mixer-deactivated-fix
Fix for channel mixer deactivation
2024-11-24 16:11:52 -08:00
Lawrence37
98136d3738
Merge pull request #7235 from Lawrence37/fftw-blur-radius-fix
FFTW blur radius fix
2024-11-24 16:10:38 -08:00
Lawrence37
df5f1b31f7
Merge pull request #7231 from Beep6581/ukrainian
Ukrainian translation
2024-11-24 16:06:52 -08:00
Lawrence37
7d0ce2fbee
Merge pull request #7224 from Lawrence37/rank-reset-fix
Fix for rank, color label, and trash status reset
2024-11-24 16:06:34 -08:00
Lawrence Lee
2a6b79fb0c
Fix crash when opening multi-frame images
Fix source of raw data when calculating raw minimum values for raw
de-haze.
2024-11-24 12:04:54 -08:00
Lawrence37
3e8d581194
Merge pull request #7178 from Pandagrapher/patch_editwidgets
Allow using more than 255 Edit Widgets for locallab
2024-11-23 12:44:07 -08:00
Pandagrapher
77fefe90b3 Fix for review remarks 2024-11-23 18:07:13 +01:00
Lawrence Lee
2a91962c48
Fix usage of deprecated Exiv2 function
Exiv2::enableBMFF() is deprecated as of v0.28.3. Only the CMake flag
EXIV2_ENABLE_BMFF is required to enable BMFF support.
2024-11-19 23:35:07 -08:00
Lawrence Lee
29a344aef1
Fix some more compiler warnings 2024-11-18 23:42:33 -08:00
Daniel Gao
45bde1c999 Add uniform relative sizing method to framing tool 2024-11-18 15:33:55 -05:00
Daniel Gao
bbb3efd81d Fix resize scale adjustment with framing 2024-11-18 15:33:55 -05:00
Daniel Gao
57ef07f3f6 Improve framing tool usability
* Rename "Resize" to "Resize & Framing" from discoverability
* Add ColorPreview class for displaying a solid color
* Add border color preview
2024-11-18 15:33:55 -05:00
Daniel Gao
2458ba4a29 Fix missing FramingParams equality check in ProcParams 2024-11-18 15:33:55 -05:00
Daniel Gao
4358c2d7a6 Fix computation errors in framing tool
* Compute image aspect ratio if required instead of leaving at 0
* Fix divide by zero error in computing framed size
* Compute resize scale based on original crop
* Reword "Current" aspect ratio to "As Image"
2024-11-18 15:33:55 -05:00