2139 Commits

Author SHA1 Message Date
rom9
536bbf95aa Added comments to clarify the difference between default exponents in procparams and default ratios in the GUI sliders. 2019-06-28 22:17:28 +02:00
rom9
4e09fd4f21 Changed master exponent default from 2.0 to 1.5; it was too large for high-contrast negatives. Set all sliders as log-scale, centered at 1.0, so that reasonable values can be fine-tuned more easily. 2019-06-28 21:29:06 +02:00
heckflosse
4eb7240a41 change granularity of raw black point adjusters from 0.1 to 1 2019-06-27 22:39:36 +02:00
rom9
63a6e1b79c Changed GUI behaviour so that the first slider sets the reference exponent (green channel), and the other two sliders set the ratio of the red/blue exponent to the reference one. This should be more intuitive, and less confusing when clicking on the reset-to-default slider button. Now the first slider sets the general contrast, while the other two affect the color.
Lowered exponent slider max value from 6 to 4 (it was too large to be useful). New sliders are log-scale.
2019-06-26 02:00:34 +02:00
heckflosse
66c9cd6177 Don't scan for darframes/flatfields/cluts if folder is not set, #2238 2019-06-24 19:52:17 +02:00
rom9
2fde6e562a The "dual-spot" exponents calculation feature now honors the master (green) exponent set by the user, and adjusts red and blue based on the ratios between the new, "guessed" exponents.
This way, if the user has chosen a different master exponent than the default, using the feature just alters the color characteristic of the conversion, while keeping the same contrast level.
2019-06-23 22:21:24 +02:00
rom9
8c6458daff Removed "lock channels" CheckButton, it wasn't very useful. Keeping the "(lead)" note on the green channel label, to give a hint that this slider controls the other two as well. 2019-06-21 20:51:50 +02:00
Eric Jiang
789edc5bd3 Apply code-cleanup patch from @Floessie
See https://github.com/Beep6581/RawTherapee/pull/5325
2019-06-18 13:02:10 -07:00
rom9
7c0275ca1a Updated copyright notice in new source files 2019-06-18 13:52:58 +02:00
rom9
8de581ac39 Removed old debugging stuff from rtgui/filmnegative.cc 2019-06-17 21:46:50 +02:00
Flössie
b687ca2643 Merge branch 'rom9-filmnegative' into filmnegative-cleanup 2019-06-17 08:57:14 +02:00
Flössie
54cc02eea9 Filmenegative core cleanup 2019-06-17 08:03:46 +02:00
rom9
d01f78864c Locked red and blue exponents by default in the GUI, added CheckButton to unlock them. 2019-06-14 22:14:24 +02:00
Flössie
80f2b6a002 Replace raw arrays with std::array<> 2019-06-14 08:58:04 +02:00
Flössie
015cffc73a Peripheral cleanups and a fix
- Whitespace, braces, sorting
- Fixed missing filmnegative in `ProcParams::operator ==(ProcParams)`
2019-06-13 09:52:13 +02:00
rom9
8d0755eddc Raised default master exponent from 1.0 to 2.0, to get a reasonable contrast right from the start. 2019-06-11 22:50:36 +02:00
rom9
5ddc4a3e0e Added missing checkbox for film negative feature in partial apply / partial paste dialogs. 2019-06-11 22:13:16 +02:00
rom9
2bbf8bd864 Changed events action from ALL to FIRST , this way the histogram is updated after enabling/disabling or moving the adjusters. 2019-06-11 20:26:13 +02:00
rom9
223ae8abce Bugfix: exponent adjusters were not following the master (green) slider after exponents auto-calc via dual spot picking; updated redRatio/blueRatio after calculation. 2019-06-11 00:19:18 +02:00
rom9
b95bdb1aea Linked red and blue exponent adjuster to the green adjuster, in order to maintain the ratio between exponents if the user moves the green adjuster (master).
Switched back to vector sort for median calculations: the results of the histogram search function diverge more and more from the simple median calculation as the exponents increase.
At 2.0 the test picture is already impossible to WB as the multipliers are too far off (2.78226e+08 histo vs 9.7927e+11 sort), and the normal WB sliders can't compensate for those huge factors.
2019-06-10 22:05:54 +02:00
rom9
9df8008949 Film negative processing: first usable version. Only supports bayer raw files, thumbnails don't work
Added performance improvements suggested by heckflosse. Lowered median sampling step from 7 to 5 since calculation is now much faster.

Added support for Fuji X-Trans raw files.

Applied SSE2 patch provided by @heckflosse, improves performance in main processing loop.

Moved film negative processing stuff in its own compilation unit.

Code cleanup: removed redundant omp directives.

Added check for dead pixels, going above threshold after inversion. ST_BAYER only for now.

Reverted leftover hack in cropwindow.cc
2019-06-08 01:40:29 +02:00
Ingo Weyrich
4ff41f7a2c
Merge pull request #5343 from Beep6581/thumbcache
Change thumbnail cache eviction strategy
2019-06-04 17:54:12 +02:00
heckflosse
df65774667 Fix calculation of reserve 2019-06-04 17:52:39 +02:00
luz.paz
cc60ea2248 Fix source comment and misc. typos
Found via `codespell -q 3 -I ../rawtherapy-whitelist.txt -S ./rtdata/languages -L hist,fo,reall,bloc,alph`
2019-06-03 17:38:50 -04:00
Flössie
f9c44f2e47 Some minor cleanups and optimizations 2019-06-03 09:19:46 +02:00
heckflosse
25fdf2114e Change thumbnail cache eviction strategy 2019-06-01 16:56:10 +02:00
Morgan Hardwood
853b198b1e Clarify what is being deleted in Trash, fixes #5337
The message shown when deleting items in trash was ambiguous.
2019-05-24 16:46:51 +02:00
heckflosse
b2936d185d Keyboard shortcut should reveal tool's current tab (original or favorites), fixes #5333 2019-05-21 16:24:14 +02:00
heckflosse
dfd9bdf977 Fix some leaks in editorpanel, fixes #5328 2019-05-20 00:21:48 +02:00
heckflosse
40aa7d2034 Fix memory leak in preferences dialog 2019-05-19 13:20:34 +02:00
Eric Jiang
820024972a Use rating from EXIF/XMP where available 2019-05-18 15:22:00 -07:00
heckflosse
159e1784f4 Memory leak in RefreshMapper, fixes #5323 2019-05-18 18:44:06 +02:00
lewiatan
7512093c20 support rating tag from EXIF/XMP- fixes 2019-05-16 17:05:01 -07:00
lewiatan
105517c561 support rating tag from EXIF/XMP 2019-05-16 17:04:07 -07:00
Ingo Weyrich
d05b6c14ba
Merge pull request #5320 from Beep6581/adjuster_review
review adjuster class
2019-05-15 10:26:24 +02:00
heckflosse
efe9ff5ae3 Don't show 1:1 icon on raw tools when using demosaic for < 1:1 view == as in pp3 2019-05-14 22:53:22 +02:00
heckflosse
caeb171e0e Applied changes suggested by @Floessie, #5320 2019-05-14 22:08:02 +02:00
heckflosse
6d1b1c7691 Remove StopWatch 2019-05-14 13:01:58 +02:00
Ingo Weyrich
975cdceef5
Merge pull request #5321 from Beep6581/clut_scan_speedup
Clut scan speedup
2019-05-14 12:33:14 +02:00
heckflosse
357cf3a89e Reduce memory allocations/deallocations and string copies when loading language files 2019-05-14 00:23:10 +02:00
heckflosse
141e9f632f Scan clut folder: Don't check for unused profile 2019-05-13 23:12:40 +02:00
heckflosse
ea2e9dd274 Scan clut folder: check for .png first because most of cluts are png 2019-05-13 23:04:14 +02:00
heckflosse
1be40beafa Scan clut folder: use std::set<std::string> instead of std::set<Glib::ustring> 2019-05-13 22:54:00 +02:00
heckflosse
de3d667ed7 review adjuster class: reduce memory allocations/deallocations, also small speedup for adjuster creation 2019-05-13 15:15:37 +02:00
heckflosse
bd2ee13e7b revert commit 6e364e4, fixes #5308 2019-04-25 21:09:35 +02:00
heckflosse
6e364e4c80 First doubleclick on an image after starting rt does not open the image. Patch provided by @Pandagrapher, fixes #5294 2019-04-22 21:18:44 +02:00
Hombre57
7d33fc40cd Merge branch 'icon-size-fix' into dev 2019-04-15 22:35:04 +02:00
Morgan Hardwood
2e2d981dac Excluding libatomic needed by Clang/FreeBSD, #3636 2019-04-15 12:08:37 +02:00
Morgan Hardwood
fb4c5e1ce2 Merge branch 'm-bugfix' into dev 2019-04-15 11:40:37 +02:00
Hombre57
feb122553e Minor bugfix 2019-04-14 17:19:48 +02:00