82 Commits

Author SHA1 Message Date
Flössie
b08fb04dae Convert almost all IdleRegister::add() calls to add(std::function<>) 2019-01-01 15:53:39 +01:00
Flössie
5af3f64a9d Merge branch 'dev' into review-idle_register-calls 2018-12-31 14:58:26 +01:00
heckflosse
190772af5e Fix some issues found by cppcheck 2018-11-22 18:40:09 +01:00
Flössie
5906329485 Review IdleRegister (#4892)
This turns `IdleRegister::add()` into a template function to make the
provided function pointers type safe. It also adds a `delete_data`
parameter to manage the provided data pointer even in `destroy()`.
2018-10-28 13:12:01 +01:00
Flössie
2125f42116 Turn almost all Listeners into abstract interfaces 2018-10-09 20:32:40 +02:00
Morgan Hardwood
522495f4eb Icon cleanup #4469 #3547
Rebased in new branch to cleanup commit history.
2018-07-13 18:13:35 +02:00
Flössie
05505803ae C'tor init for (ToneCurve|Retinex|LCurve|ColorToning)Params 2017-11-18 19:07:23 +01:00
heckflosse
0e01162318 Fixes #3969, Retinex tool does not remember the status of its settings subtool 2017-07-14 00:02:53 +02:00
heckflosse
f98ef980d9 remove unused retinex.gain and retinex.baselog 2017-07-09 21:37:39 +02:00
heckflosse
5f97800e69 Reduce number of leakes ui handles per editor instance, #3937 2017-06-29 19:09:40 +02:00
Desmis
772a4a60db Small changes to Retinex GUI 2017-04-26 16:34:42 +02:00
heckflosse
92a46e9a3d Merge branch 'idle_harder' into dev 2017-04-09 02:18:09 +02:00
Alberto Griggio
6fe04e3990 fixed warnings in rtgui 2017-04-01 15:55:39 +02:00
Flössie
f114b1151f Merge branch 'dev' into idle_harder 2017-03-30 21:44:31 +02:00
heckflosse
45a66e980f Fix some uninitialized variables found by valgrind; also fixes #3786 2017-03-28 14:01:19 +02:00
Flössie
91b44dbd08 Replace all g_idle_adds with IdleRegister (#3767) 2017-03-26 22:03:33 +02:00
Morgan Hardwood
20d44b6693 Post-merge fix to retinex.cc 2017-01-22 18:54:41 +01:00
Morgan Hardwood
15e0875df2 Merge branch 'master' into gtk3 2017-01-22 18:32:54 +01:00
Hombre
3f62b14703 Small bugfix in rtgui/retinex.cc, no issue 2017-01-22 18:06:32 +01:00
Hombre
75138356f1 Updated French strings + bugfix in rtgui/retinex.cc (no issue) 2017-01-21 02:26:58 +01:00
Hombre
c90b701999 Backporting patch from issue #3446
This commit change the way that the Curve buttons and Accompanying
object expands, and fix the alignment of the WB's buttons.
2016-12-25 23:55:45 +01:00
Hombre
c7be386c3a Solving issue #3531, assign classes to Gtk::Window and MyWidget
- Curve editor buttons are set to expand by default, but they are set to
shrink as soon as an accompagnying widget is set to expand
- White Balance's method button now has a centered ellipse ("...")
- White Balance's buttons are now aligned on their right
- A "withScrollbar" class is added to MyExpander if the ToolPanel's
vertical scrollbar is visible. This can let you add padding space for
the scrollbar (see #MyExpander.withScrollbar in RT default theme)
- A "maximized" and "fullscreen" class is added to the RTWindow whenever
it change state ; BEWARE: if you maximize the window then make it
fullscreen, Gtk says that the window is in a "maximized & fullscreen"
state, which mean that both class can be added at the same time to the
window.

One Gtk oddity (at least on Windows) is that you can make your window
fullscreen and still drag it around by its header bar... That's not very
practical to click on the unfullscreen button if in Single Editor mode
with vertical Tab.

I also managed to see the window in a Inconified + Maximized state. This
part of Gtk doesn't seem very robust, on Windows at least.
2016-12-20 01:58:37 +01:00
Hombre57
f3f317e5bd Issue #3446: Updated Gtk3.18 theme
Harcoded style has been reintroduced for Gtk < 3.20 only ; a cleanup
will have to be done once Gtk3.18 support will be dropped.
2016-12-06 01:33:03 +01:00
Hombre
965cadb52e New batch of update for issue 3446
This commit include :
- cleanup rtgui/retinex.cc file (constructor only) and switched to
Gtk::Grid (the new standard) instead of Gtk::Box. This however doesn't
solve the issue of the Transmission curves in the Retinex tool, with
wrong resize of the Frame when folding/unfolding the curves.
- better alignment of the Histogram panel now with 4px of padding on the
left and right side
- Threshold selector now use the Scale's Trough style to draw its box
and sliders
- Curve's background are darker and restricted to the curve diagram
- Diagonal and Flat curves has been converted to Gtk::Grid as well
- A special color is now used for unsensitive Threshold selector and
Sclaes widgets
- Gap around the main Window has been removed on windows to circumvent a
bug in Gtk3, but the window can now only be maximized (usual use case)
or resized vertically by the top border only.
- Buttons at the bottom of the Editor panel has now the same height
2016-11-01 20:39:41 +01:00
Hombre
e4e474ca8a Merge branch 'gtk3' into gtk3-bugfix 2016-10-28 23:48:22 +02:00
heckflosse
b16ef8d1f5 Merge master into gtk3 2016-10-28 17:59:47 +02:00
Hombre
b2af94ac74 More bugfix to the Gtk3 RawTherapee theme, see issue #3446 2016-10-22 02:13:50 +02:00
Flössie
0731975ff0 Apply modernize-use-nullptr
Setup:
- `mkdir tidy; cd tidy`
- `cmake .. -DCMAKE_BUILD_TYPE=debug -DPROC_TARGET_NUMBER=1 -DCACHE_NAME_SUFFIX=4 -DBINDIR=. -DDATADIR=. -DBUILD_BUNDLE=ON -DWITH_LTO=OFF -DOPTION_OMP=OFF -DCMAKE_EXPORT_COMPILE_COMMANDS=ON`
- `cd ..`
- `find -name '*.cc' -exec clang-tidy-3.8 -header-filter=.* -p=tidy -fix-errors -checks=modernize-use-nullptr {} \;`
2016-10-12 17:48:40 +02:00
Morgan Hardwood
0dbea030cb Merge branch 'master' into gtk3-merge-master-b8eb349 2016-10-10 23:07:41 +02:00
heckflosse
566d4c9822 Cppcheck: Fixed most issued in rtgui/* 2016-10-04 23:28:19 +02:00
Beep6581
e737365597 Merge branch 'master' into gtk3 2016-05-22 13:13:04 +02:00
Desmis
a742e3a7ba merge master into retinexgain 2016-05-01 08:53:52 +02:00
Beep6581
6daa86be2e Merged master ffd40 into gtk3 9bfca 2016-03-11 18:37:47 +01:00
Beep6581
ffd403140d Regenerated translation files. 2016-03-11 18:29:10 +01:00
Hombre
830c58877f Reintroduce some set_border_width to circumvent some Gtk bugs.
Also fix a bug that let you grab the first and last point of the
diagonal curve more easily now, when they are at their left/right
extremum.
2016-02-29 22:08:05 +01:00
Hombre
3577d87862 Removed set_border_width from the code, padding and margin values still
to be set in CSS file
2016-02-23 21:36:00 +01:00
Beep6581
e8cfea9fb5 Merged master into gtk3 2016-02-14 19:37:14 +01:00
Desmis
ba5161d446 change default Tansmission curve 2016-02-12 13:36:32 +01:00
Desmis
a21deef3de GUI improvment and re-introduce scale 2016-02-12 12:51:46 +01:00
Desmis
b449e0827b Init new process gain with curve 2016-02-11 18:21:56 +01:00
Desmis
fea35baf69 Try to solved iplab2rgb ipwavelet partialpasted retinex 2016-02-01 10:55:34 +01:00
Hombre
978e9f67d6 Merge branch gtk3-gui-touchup-and-bugfix into gtk3 2016-01-30 20:13:36 +01:00
Desmis
2880cfbbda Fixed display Transmission in Retinex 2016-01-26 11:23:37 +01:00
Desmis
481fdab32c Fixed display Transmission in Retinex 2016-01-26 10:58:48 +01:00
Desmis
fa70b1be57 Fixed forgot a label in viewmethod Retinex 2016-01-25 08:17:19 +01:00
Beep6581
8c67765341 Merged master 55fc921 into gtk3 676a444 2016-01-24 17:39:34 +01:00
Beep6581
d282bba429 Merge master into newretinex and fixed some merge conflicts 2016-01-22 13:23:29 +01:00
Desmis
c50a4bb7a9 Simplify interface Process and Mask 2016-01-17 18:46:48 +01:00
Desmis
2d77d783e0 Fixed various bug issue 2969 2016-01-17 10:06:22 +01:00
Hombre
93d01f3a82 GUI bugfix (histogram) + touchup
- Fix the Histogram background and grid lines
- Add 1 pixel of empty space between in the Histogram panel
- Add a light grey color border for Gtk::DrawingArea oject, for those
using the render_frame method
- In the Toolbox, make the nested MyExpander and Gtk::Frame lighter, and
adjust the Gtk::DrawingArea background color accordingly
- All added class to the MyCurve has been removed, so that the
Gtk::Drawing object's style is used
- The Retinex Settings' expander is now level 2 for GUI consistency
2016-01-17 04:45:01 +01:00