Commit Graph

251 Commits

Author SHA1 Message Date
Lawrence Lee
1a3fce8c56 Remove benchmarking 2025-05-18 22:27:08 -07:00
Desmis
a578423378 Abstract Profile - Contrast enhancement -- Selective Editing Cam16 and JzCzHz - improvments (#7111)
* Init levels trc GUI

* Levels TRC

* Complete with gamma based attenuation

* Limit RGB channel Slope with checkbox

* Improve GUI and code channel TRC

* Change default values - compexity levels RGB channels

* Relative gamma mode RGB channel TRC

* Change label and ponderation rolloff

* Change rolloff level

* Threshold attenuation

* Threshold attenuation 2 part

* GUI Link R G B

* Linked RGB with Green slope - RGB channels

* Set Freeman TM functions with ImProcFunctions

* First GUI Abstract profile highlight attenuation

* GUI AP part 2

* Restore olg GUI AP

* Expander AP primaries adn illuminant

* Disable RGB channel TRC

* Expander contrast AP

* Slider attenuation response

* Save work GUI local contrast

* Save GUI part 2 AP curve

* Local contrast GUI Abstract Profile

* Move Abstract profile in toolpanel and ICMpanel

* rtengine variable contrast

* Variable contrast 2

* Variable contrast engine 3

* Variable contrast engine 4

* Variable contrast engine

* Detail levels pyramid

* Engine residual contrast

* Residual contrast

* Change settings detail levels

* Expander refinement - new tooltips - low resid contrast

* Change contrast profile and labels

* Remove warning message GUI Gtk

* Gamutcontrol code - disabled

* Improve with calceffect

* Other improvement variable contrast

* Offset variable contrast

* Range offset - comment code

* Parametric inva fot lut

* Clean cmakelist.txt

* Change contrast profiles

* Comment code ipwavelet

* Added orthogonal Daubechies scaling D20

* Change strenght curve - tooltip Daubechies

* Forgotten changes

* Comment code

* Move variable in process - take into account highlight attenuation

* Display label maximum preview and preset selection

* Remove console message

* harmonize levels wavelets iplocallab

* Tooltips contrast enhancement

* Change tooltip Contrast profile

* Chnage tooltip Contrast

* Message warning preview size

* Change gamma TRC values in GUI

* Remove itanium architecture support for windows as PR 7105

* Change windows.yml and appimage.yml

* Windows.yml apseimprov

* Clean and comment ipwavelet

* Clean comment icmpanel.cc

* Harmonize local contrast wavelet Selective editing with Abstract profile

* Harmonize with AP - offset

* vanishing moment D20 - Selective editing wavelet

* Offset only in advanced mode

* GUI expander contrast enable and pyrwavtrc

* Clean and comment code

* merge with dev

* Prepare sigmoid based

* Contrast sigmoid GUI

* Skew sigmoid GUI

* Sigmoid tone mapper in iplocallab

* Change GUI settings

* White-point and black-point auto

* Change EvDCP to ALLNORAW as others events DCP

* Change default skew

* Change settings - enable scale Yb

* Display white point - advanced mode

* Improve GUI

* Clean unused variable

* new sigmoid Q in cam16

* Change tooltips and default sigmoid Q settings

* Sigmoid Jz

* Clean code Jz and sigmoid

* Harmonize Sigmoid Q and Sigmoid RGB

* Harmonize Sigmoid Jz

* Clean code

* Improve labels wit cd/m2

* Slope base Q methode first

* GUI slope based Q

* Change default settings and tooltips

* Change tooltips

* Clean code - change default setting

* Change default local contrast & wavelet to wavelet & basic mode

* Fixed bad assignation slopesmoq

* Improve sigmoid and slope based Q - GUI for Log encoding Color appearance

* Remove wrong change

* various small improvments

* Allows black and white AP and SDA in basic mode

* Change  the writing of wGamma and wSlope - attenuates the effect of the first 2 AP contrast profiles

* Clean code wgamma wslope

* Set curve Cam16 in basic mode

* Change position curve in GUI cam16

* Enable tonecurve1 in colorappearance & lighting in standard mode

* Fixed bug scale yb scene - ciecam curve - change default contrast enhancement

* not reset curve shape ciecam in strandard

* Change label Tone mapping operators and tooltips

* Change some labels and tooltips - Appearance - Mask and Mofifications - Recovery Based On Luminance Mask

* Forgotten changes

* Clean locallabtools2.cc

* Maxlevel wavelet minimum to 5

* Reset mask and modifications in SE wavelet and all tools in Global

* Show modified areas SE wavelet

* Tooltip show wavelets decomposition

* Fixed another bad behavior in Global - changes also in color & light for merge file

* Change behavior fullimage - global as in PR GHS

* Disable all mask and modifications in Global but remain active in fullimage and normal

* Set expander expanded = true

* Chane contrast enhancement coef

* Replace VBox trcWavVBox by ToolParamBlock trcWavFBox

* Forgotten code in icmpanel read pedited opacityShapeWLI - hope solve batch mode

* Change RGB Slope behavior with link

* No access to last level contrast enhancement

* Move Abstract Profile tooltip to title

The tooltip was popping up when the cursor was over almost any part of
the tool which was inconvenient. Now, the tooltip only appears when
hovering over the title.

* Improve Color Management expanders behavior

By default, collapse Abstract Profile and leave it's sub-expanders
expanded.

Keep the expanded state of all the sub-expanders during the editing
session.

Fix the right-click behavior. The clicked expander should be expanded
and all siblings, if any, should be collapsed.

* Fix RGB slope tone mapping RGB linkage

Synchronize the red, green, and blue values before updating the preview
to avoid using incorrect values to generate the preview.

* Fix SE CAM tone mapping slider defocus

Avoid unnecessarily hiding then showing the adjusters in tone mapping so
that focus is not lost while adjusting the adjusters.

* Delete history kslopesmo - remove IcmOpacityCurveWL

* change the tooltips as suggested by Lawrence

* Review L37 - change strengthjz strengthlc - MIDDLE_GREY MIDDLE_GREYjz - artifacts ciecam

* Change name Tone map freeman functions

* Remove gamutcont - rename localcont - change allocation memory wdspot

* Clean procparams

* remove sigmoidsenscie - logcieq

* Added * to three labels 'sigmoid' - change tooltip which shows the incompatibility with 5.11

* Forgotten correction suggested by Lawrence

* Compatibility 5.11 log encoding - sigmoid part 1

* Compatibility 5.11 part 2

* Compatibility 5.11 - step 3

* Compatibility 5.11 - step 4

* Compatibility 5.11 step xx

* Compatibility 5.11 - combobox operators Q and J

* Compatibility 5.11 Cam16 GUI first part

* Improve GUI Cam16 sigmoid compatibility

* Compatibility 5.11 Jz - sigmoid - step 1

* Compatibility 5.11 Jz gui step 2

* Compatibility 5.11 Jz GUI step x

* Compatibility 5.11 Jz - history - etc.

* Various change labels - history ...

* Improve GUI - hide show 5.11 5.12

* Jz 5.11 in iplocallab - step 1

* Compatibility 5.11 iplocallab cam16 step 1

* Improve GUI hide show 511 512

* Solved - I hope - GUI problem with tone mapper Q and J 5.11 and 5.12

* Compatibility 5.11 iplocallab Cam16 step 2

* Improve GUI compatibility 5.11 labels tooltips

* Small improvments GUI - labels - history...

* Fixed typo in paramsedited.cc clcurve issue 7283

* Change tooltips method 5.12 - 5.11 for cam16 and Jz  brightness Q or J

* Clean and refine code

* Various change dafult language  and CAM16 CAM02 replace by Cam16 Cam02

* Change modeQJ method for 5.11 in function ppversion

* Change labels as suggested by Wayne PR 7111

* Others changes suggested for label

* Change tooltips as suggested in PR

* Use unique pointer instead of manual management

* Update rtdata/languages/default

Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>

* Change all Cam16 references to CAM16

* Change convention uppercase and lowercase in frame - checkbox

* Improve tooltips for Tone Mapping Operators

* Another change CIECAM and uppercase lowercase in checkbox

* Remove appimage and windows yml

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2025-01-19 07:52:32 +01:00
Lawrence37
98752a2433 Merge pull request #7257 from Beep6581/fix-warnings-5.12
Compiler warning fixes
2024-12-26 22:26:11 -08:00
Lawrence Lee
721d664136 Fix compiler warnings 2024-11-17 22:11:57 -08:00
Daniel Gao
711f274403 Get rid of relative include paths
* Use target_include_directories to specify include paths
* Specify project root (parent of rtgui and rtengine) as include path
* Replace relative includes with normal includes
2024-11-16 17:20:02 -05:00
Desmis
ac185128d3 Wavelet denoise limit window size to avoid crash issue 7146 (#7169)
* Wavelet denoise limit window

* Change limit minimum windows to 128
2024-08-11 07:18:36 +02:00
Desmis
1adf2bbac3 Wavelet selection levels issue 7069 (#7070)
* Fixed wavelet selective luminance

* Enable PR appimage.yml windows.yml

* disabled appimage.yml and windows.yml
2024-05-12 08:40:32 +02:00
luzpaz
b0ebab8e08 Fix various typos
Found via `codespell -q 3 -S ./rtdata/languages -L activ,alph,ba,bloc,bord,chang,childs,currentry,dof,dum,fo,hist,inout,invers,lonly,makro,ois,pres,preserv,portugues,rady,reall,redy,struc,tbe,thre,trough,vart,vekto`
2023-07-05 13:51:11 +00:00
luzpaz
4d1d5d4539 Fix various typos (#6569)
* Fix various typos

* Fix previous commit + add follow-up grammatical fixes
2022-08-30 15:17:43 +02:00
Lawrence37
0a55428205 Clean up missing language keys (#6556)
* Clean up some unused code

* Use grid for abstract profile primaries

* Remove blank line from default
2022-08-24 20:23:09 +02:00
luzpaz
65db39b9f8 Fix various typos (#6529) 2022-08-18 16:49:26 +02:00
Desmis
9b837e59b3 Fixes crash in ipwavelet, improve behavior mask when one spot with many tools and mask (#6478) 2022-05-14 05:41:11 +02:00
Desmis
31e178a4dd Change loop limit for cp.mulC ipwavlet.cc 2021-06-19 18:36:20 +02:00
Desmis
c01166441c Wavelet levels - and denoise - crash in some cases - issue 6264 (#6265)
* Change order levwav for denoise

* Intialize to zero multipliers contrast if not used

* Forgotten commit

* Clean code
2021-05-29 11:39:06 +02:00
Desmis
e98288ab31 Wavelet levels - enable Toning in some cases 2021-03-30 16:49:25 +02:00
Desmis
c0e67b64c8 Fixed crash wavelet edge sharpness in some cases 2021-03-18 09:40:34 +01:00
Ingo Weyrich
045bc1cd9a Cleanup and removed stopwatch, #6143 2021-02-28 14:16:20 +01:00
Ingo Weyrich
1f9a8b69a2 Clarify expression by adding parentheses, #6143 2021-02-28 11:14:56 +01:00
Ingo Weyrich
966cbfe276 speedup for a loop in wavelet code , #6143 2021-02-28 10:40:59 +01:00
Ingo Weyrich
7a4ad241a2 Merge pull request #6138 from Beep6581/issue_6137
Speedup for wavelets/final touchup/local contrast
2021-02-27 17:18:52 +01:00
Ingo Weyrich
84d463fbb9 Segfault in wavelet/denoise, fixes #6140 2021-02-26 17:18:45 +01:00
Ingo Weyrich
4f880b346a add a cppcheck-suppress 2021-02-26 14:19:52 +01:00
Ingo Weyrich
fb72b6c626 Keep original code, Optimizer will catch that 2021-02-26 13:47:08 +01:00
Ingo Weyrich
d3c536b0d8 Fix clang build 2021-02-26 13:01:02 +01:00
Ingo Weyrich
d7327e8b05 left original code in comments 2021-02-26 12:41:23 +01:00
Ingo Weyrich
10e0ab4eaa Speedup final touchup local contrast 2021-02-25 23:10:37 +01:00
Ingo Weyrich
9ba266c21f added some stopwatches 2021-02-25 22:44:50 +01:00
Ingo Weyrich
f727477710 Make some more files cppcheck clean (#6133)
* Make some more files cppcheck clean

* revert change of dcrop.cc from last commit

* Replace calculation: y = pow(x, 1/ (2.f * 2.f)) by y = sqrt(sqrt(x))

* Revert "Replace calculation: y = pow(x, 1/ (2.f * 2.f)) by y = sqrt(sqrt(x))"

This reverts commit d639c67249f1723fa9f9e55e0442afcb862eba91.
2021-02-24 22:39:23 +01:00
Desmis
79545293d6 Review ipwavelet denoise enable 2020-11-30 08:44:15 +01:00
Desmis
784be4a5e8 Suppress warning 2020-10-27 10:57:15 +01:00
Desmis
85bd064454 Fixed enable denoise wavelet level - enable denoise chroma 2020-10-27 09:55:04 +01:00
Desmis
344735bb8b Change call edge to Ftblockdn 2020-10-12 11:13:32 +02:00
Desmis
8e9e397130 Fixed crash by changing level with preview size 2020-10-12 08:35:09 +02:00
Desmis
0511458502 Fixed crash when preview too small for denoise 2020-10-11 18:38:01 +02:00
Desmis
17940b3103 Two others crash fixed in wavelet when enable with none 2020-10-11 16:12:24 +02:00
Desmis
8e92c13b28 Fixed crash issue 5945 2020-10-11 12:41:19 +02:00
Desmis
5fd640f977 Change GUI to disable denoise if level sup to 7 (#5942) 2020-10-09 16:53:03 +02:00
Desmis
075011cc78 Fixed bad behavior structure mask - suppress warning BENCHFUN ipwavelet (#5920)
* Change tooltip settings

* Change colo and light tooltip

* Change mask color and light tooltip

* Others change to tooltip mask

* Another change to tooltip color and light

* Change all mask in locallabtolls.cc

* Change all masks in locallabtools2.cc

* Change tooltip shape detection

* Fixed bad behavior structure mask

* Suppress BENCHFUN in ipwavelet.cc
2020-09-28 18:11:45 +02:00
Desmis
bc3cd93e70 Added directional contrast to final touchup alone 2020-09-25 17:59:32 +02:00
Desmis
e3568e86d4 Add Final touchup to enable wavelet decomposition 2020-09-25 17:30:42 +02:00
Desmis
c65a27ce19 Wavelet levels - Fixed crash in rare cases in flat areas 2020-09-02 18:21:02 +02:00
Desmis
467bac3dea Wavelet levels: denoise and guided filter with hue curve and local contrast (#5894)
* First wavelet denoise

* Gui for wavel denoise

* First version local contrast and denoise

* Second version local contrast and denoise

* second version GUI equalizer

* enable equalizer local contrast denoise 1234

* change local contrast curve defaut

* disable local contrast when curve 1

* denmethod in advanced - standard

* Simulate slider denoise with curve

* Some various chnages

* Chnage reference local contrast

* GUI part reference local contrast

* Enable reference noise mix denoise for local contrast denoise

* Improvment to reference local contrast denoise

* Display comment in console

* Best format string in console

* Change agressive denoise limit to 50 - added tooltip

* Added method quality denoise - change madL in ftblockdn

* Change equalizer 1234 settings - added high level local contrast

* added high levels local contrast curve

* Fixed sigma local contrast

* clean format code

* Some improvments

* normalize level slider high level threshold

* change ordonate curve high level contrast

* Fixed bad level for curve high levels - simplify GUI standard

* several changes - guidefilter final - new double slider threshold

* save provisory work

* save GUI work GF threshold

* save provisory work

* Fixed some bad behavior GUI

* save GUI Hue GF

* Curve Hue for GF

* OMP for hue GF

* addes noisevarhue and fixed some bug

* save GUI equalizer hue

* enable equalizer hue

* Fixed bad behavior GUI in advanced mode

* change some default values

* Others change default values

* Change in progressivity slider threshold local contrast

* simplifie algorithm and GUI

* Added tooltip and chnage some labels

* Change labels and tooltip wavelet denoise

* added level 5 denoise

* Change typo in label guided theshold

* Various changes labels tooltip

* Change minimum wavelet level

* Added level 5 to denoise

* Change slider sigm for a double slider sigm03 sigm45

* small delay for double slider sigm

* Fixed wrong values sigm

* Hide level56 in standard complexity

* Improve in standard complexity

* Various improvment levels 14

* interaction 56 14 - advanced complexity
2020-08-30 08:16:31 +02:00
Desmis
130fbb8eb2 Local complexity - Add 'Basic' to 'Standard'(Normal) and 'Advanced'(Expert) (#5858)
* Mode simple to color and light

* Exposure complex

* Vibrance and SH complex

* Soft and Blur complex

* Common mask complex

* Sharp Retinex complex

* Localcontrast complex

* Change label tooltip complex

* Change labels and tooltip

* Change tooltip french

* Change default value scope TM

* Some forgotten hide..with basic in inverse mode

* Another hide in basic and inverse

* Change some type in labels

* Change typo contrast

* Refine some labels tootips

* Change after review Ingo - thanks

* Improve history behaviour when changing local adjustments complexity mode

* Added normal to original retinex - basic to dehaze

* Fixed bad behavior normal expert Color and Light

* Improve edge sharpness

* Another improvment edge sharpness

* various improvement

* locallab: speedup and reduced memory usage for wavcontrast4()

* remove file

* French labels complexity

* calckoe(): cleanup, speedup and bugfix for 3x3 gaussian kernels

* calckoe(): cleanup for 3x3 gaussian kernels

* calckoe(): fill koeli[] with zeroes if level <= 1 && tloww >= 75.f

* GUI part fixes and cleanup

* Fix in Locallab Settings panel

Additionnal minor fix in Preferences windows

* Change default mode complexity in preferences - basic

* Change complexity in option

* Improve gui when lauch first image

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
Co-authored-by: Pandagrapher <pierre.cab@gmail.com>
2020-08-10 13:18:21 +02:00
Desmis
e0d3353d72 Wavelet levels - choice complexity standard - advanced (#5869)
* Added in option edghi edglo limrad

* Hide choice edgesharpness slider curve

* First normal expert

* Second normal expert

* Changes in normal expert contrast chroma residual

* Change label complexity wavelet

* French + hide sigmafin standard

* Added tooltip complexty wavelet
2020-08-02 15:52:01 +02:00
Desmis
6b749bcbff Wavecrash - fixed crash in wavelet specially when using "edge sharpening" (#5854)
* Add epsil to all log calculation

* add another epsil to log

* Another eps value in koeli calculation

* Avoid negative L values after reconstruct

* Suppress all changes except negatives values reconstruct
2020-07-20 06:40:18 +02:00
Ingo Weyrich
f03a19ebf1 Cleanup and speedup for a loop in wavelet denoise 2020-07-08 13:28:27 +02:00
Ingo Weyrich
d65e00b3df Wavelet Blur levels chroma: use LUT for pyramid, reduce memory usage, speedup 2020-07-07 13:10:16 +02:00
Ingo Weyrich
e269b38d1e Wavelet Blur levels: use LUT for pyramid, reduce memory usage, speedup 2020-07-06 15:25:04 +02:00
luz.paz
a41aa73124 Fix various typos
Found via  codespell v2.0.dev0  
```
codespell -q 3 -I ../rawtherapy-whitelist.txt -S ./rtdata/languages -L bord,hist,fo,reall,bloc,alph,dof,thre,makro,chang,currentry,portugues,vektor,ue
```
2020-06-18 14:53:04 -04:00
Ingo Weyrich
f23c2e9de0 locallab: speedup for wavcontrast4 and clarimerge 2020-06-16 15:35:42 +02:00