Commit Graph

11651 Commits

Author SHA1 Message Date
Adam Reichold
fae40a137a A few more minor fixes geared towards lgtm.com alerts (#6127)
* Remove unfilled formatting placeholders in KLT parser.
* Fix presumably unintentionally missing reference on PlanatPtr and ChunkyPtr call operators.
* Fix catching pointer and make use-after-free of workimg easier to spot.
Make sure all of our thrown exceptions derive from std::exception and then catch
by reference instead of by pointer.
* Fix mismatch between array form new and non-array form delete.
* Simplify memory management of embedded color profiles by unifying allocation to use operator new.
2021-03-17 08:37:19 +01:00
Desmis
537fa73d3f Local adjustments - Log encoding - Ciecam16 ContrastJ - contrastQ - contrast threshold (#6169)
* Added contrast threshold Log encoding

* Improve contrast threshold

* Chanhe tooltip

* Change sign threshold when contrast negative

* Another change threshold with contrast Q and J
2021-03-15 07:57:25 +01:00
Morgan Hardwood
2c47005b1d Chinese (Simplified) locale updated
Updated by syyrmb, closes #6168
2021-03-15 02:42:52 +01:00
Beep6581
f75090c513 Merge pull request #6158 from stwunsch/fix-cmake-abspath
[cmake] Use absolute path to cmake in UpdateInfo
2021-03-15 00:04:11 +01:00
Desmis
227ae487d4 LA and Shadows-Highlight main - change location shadows-highlight in Lab issue 6163 (#6164)
* Change location shadows-highlight in Lab

* Suppress unused variable

* Small change in improccoordinator.cc
2021-03-13 07:17:42 +01:00
Ingo Weyrich
bb08b6bed8 Raw black points: Green2 Does not change color when click button restore value to 0, fixes #6165 2021-03-09 13:11:51 +01:00
Desmis
0170305906 Local contrast - Try to solve bug issue #6132 (#6134)
* Try to solve bug issue 6132

* Refine placement localcontrast in pipeline
2021-03-08 08:29:57 +01:00
Desmis
9b2e955dc9 LA improve behavior full image issue 6161 2021-03-08 08:00:35 +01:00
Lawrence Lee
f958074d9b Fix crash when deleting spot removal spot
Deleting a spot while hovering over one of the circles for adjusting the
radius or feathering could trigger a crash. This is because immediately
after deleting a geometry object, EditSubscriber::getCursor is given an
object ID based on old data, causing the spot tool to attempt to get
information about the deleted geometry object.

This commit fixes the issue by returning the default cursor if the
active spot is -1. It works because the active spot is set to -1 when
deleting a spot, and there is no need to use a special cursor when there
is no active spot.

A better long-term solution would be updating the geometry data before
calling EditSubscriber::getCursor.
2021-03-07 11:58:36 -08:00
Desmis
dda9b8ed6b LA settings - change label background color 2021-03-07 16:39:23 +01:00
Lawrence Lee
10b5f65b30 Fix spot removal enable/disable history message
The history panel was showing "HISTORY_MSG_1049".
2021-03-06 21:29:56 -08:00
Lawrence Lee
7e436a44d6 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into spot-removal-tool 2021-03-06 16:41:40 -08:00
Stefan Wunsch
47b1804034 [cmake] Enable mcpu=native for all Arm processors (#6156) 2021-03-06 12:37:44 +01:00
Stefan Wunsch
4cb6fa2dcb [cmake] Use absolute path to cmake in UpdateInfo
- Recommended for usage of cmake from custom commands
- Enables building with Xcode using the project generated with 'cmake -GXcode ..'
2021-03-06 11:46:23 +01:00
Desmis
df9f33e44e LA - Others improvments length labels 2021-03-06 08:22:50 +01:00
Desmis
31641f9481 LA others change length labels english and french 2021-03-05 08:58:11 +01:00
Desmis
4583176d1b LA french - adjust label length 2021-03-05 08:38:32 +01:00
Desmis
c448860b6a LA change size label Shadows/highlights and Tone Equalizer 2021-03-05 08:02:25 +01:00
Desmis
0bf7c4e56c Local adjustments - Added Guidedfilter to avoid color shift (#6149)
* Added Guidedfilter to avoid color shift

* Various improvment to avoid color shift

* Small change to mint maxt

* local adjustments avoid color shift: reduce memory usage by width * height * 8 byte if Soft Radius > 0

* Remove StopWatch

* local adjustments avoid color shift: speedup for last loop

* cleanups

* one more cleanup

* Added checkbox Munsell correction only - uniform perceptual lab

* Refine some settings

* Clean-up - other small refinement

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-03-03 18:49:55 +01:00
Stefan Wunsch
02b86239db [cmake] Enable native compilation on Apple M1 (#6152) 2021-03-03 18:35:19 +01:00
Pandagrapher
84751ad26f Re-allow using RT shortcut while focused on adjuster 2021-03-01 21:38:35 +01:00
Pandagrapher
d92bbf59e1 Fixes #6148, allow using decimal key on numpad 2021-03-01 21:04:08 +01:00
Ingo Weyrich
2366cb4935 raw crop for Leica SL2-S 2021-03-01 18:30:40 +01:00
Stefan Wunsch
68a6e02369 Fix some cmake build system issues (#6147)
* [cmake] Switch to find_package for TIFF
- Included in cmake 3.5 and later
- Provides better configuration messages
* Add missing TIFF library to rtgui and rtexif
* Removed unnecessary quotes so that cmake sees the list as a list
* Add OpenMP to rtengine if OpenMP is enabled
2021-03-01 16:40:54 +01:00
Ingo Weyrich
cf21bd87d5 Merge pull request #6145 from Beep6581/issue_6143
speedup for a loop in wavelet code, fixes #6143
2021-03-01 16:28:29 +01:00
Ingo Weyrich
02a5040a60 Undocumented search feature in exif tab can be annoying, fixes #6142 2021-02-28 17:00:37 +01:00
Ingo Weyrich
045bc1cd9a Cleanup and removed stopwatch, #6143 2021-02-28 14:16:20 +01:00
Desmis
d8515da4dd LA - Disable default avoid color shift - change needHH to true 2021-02-28 13:38:20 +01:00
Ingo Weyrich
1f9a8b69a2 Clarify expression by adding parentheses, #6143 2021-02-28 11:14:56 +01:00
Thanatomanic
09441c7e54 Correctly apply Local adjustments when loading a pp3 profile 2021-02-28 11:13:21 +01:00
Ingo Weyrich
966cbfe276 speedup for a loop in wavelet code , #6143 2021-02-28 10:40:59 +01:00
Ingo Weyrich
7a4ad241a2 Merge pull request #6138 from Beep6581/issue_6137
Speedup for wavelets/final touchup/local contrast
2021-02-27 17:18:52 +01:00
Desmis
b58f643d59 Local adjustments - Grain - various improvment - see issue #2460 (#6120)
* Fixed bad behavior saturation issue 6117

* Reenable scalegr for grain

* some changes to grain

* Init lagrain

* Various improvment GUI - gamma

* Change basic - normal grain
2021-02-27 08:13:44 +01:00
Thanatomanic
a6a368e682 Allow resizing of navigator window. Patch by @Lawrence37. Fixes #6052 2021-02-27 08:03:36 +01:00
Thanatomanic
8d32d59b33 Basic color support for Canon EOS 2000D in camconst.json
Fixes #5495, but improvement possible
2021-02-27 07:49:57 +01:00
Ingo Weyrich
bb12519eec Merge pull request #6141 from Beep6581/issue_6140
Segfault in wavelet/denoise, fixes #6140
2021-02-26 18:14:12 +01:00
Ingo Weyrich
84d463fbb9 Segfault in wavelet/denoise, fixes #6140 2021-02-26 17:18:45 +01:00
Ingo Weyrich
4f880b346a add a cppcheck-suppress 2021-02-26 14:19:52 +01:00
Ingo Weyrich
fb72b6c626 Keep original code, Optimizer will catch that 2021-02-26 13:47:08 +01:00
Ingo Weyrich
d3c536b0d8 Fix clang build 2021-02-26 13:01:02 +01:00
Ingo Weyrich
d7327e8b05 left original code in comments 2021-02-26 12:41:23 +01:00
Ingo Weyrich
10e0ab4eaa Speedup final touchup local contrast 2021-02-25 23:10:37 +01:00
Ingo Weyrich
9ba266c21f added some stopwatches 2021-02-25 22:44:50 +01:00
Thanatomanic
1214450aaa Small fixes to Gtk::Grid::attach for compilation with gtkmm 3.22 2021-02-25 17:49:05 +01:00
Thanatomanic
6f9f81b057 Merge pull request #6135 from luzpaz/typos
Fix various source comment typos
2021-02-25 16:27:53 +01:00
luz paz
fe795b419c Fix various source comment typos
Found via `codespell -q 3 -S ./rtdata/languages -L ba,bord,childs,hist,fo,reall,bloc,alph,dof,inout,thre,makro,chang,currentry,preserv,portugues,struc,trough,vektor,`
2021-02-25 09:49:27 -05:00
Ingo Weyrich
f727477710 Make some more files cppcheck clean (#6133)
* Make some more files cppcheck clean

* revert change of dcrop.cc from last commit

* Replace calculation: y = pow(x, 1/ (2.f * 2.f)) by y = sqrt(sqrt(x))

* Revert "Replace calculation: y = pow(x, 1/ (2.f * 2.f)) by y = sqrt(sqrt(x))"

This reverts commit d639c67249f1723fa9f9e55e0442afcb862eba91.
2021-02-24 22:39:23 +01:00
Ingo Weyrich
7a2463a81a make improcfun.cc cppcheck and -Wextra clean (#6128)
* make improcfun.cc cppcheck clean

* improcfun.cc: add -Wdouble-promotion to stay clean about this warning in future, because we are clean about it atm

* improcfun.cc: some cleanups, now this file is -Wextra clean. Let's keep it clean...

* improcfun.cc : Fix LGTM alert
2021-02-23 23:06:51 +01:00
Thanatomanic
0694eb1d3d Update .clang-format to prevent unwanted sorting of includes 2021-02-23 17:38:52 +01:00
Adam Reichold
a349559e40 Merge pull request #6126 from adamreichold/fix-signed-unsigned-comparison-warning
Fix GCC warning about comparing signed and unsigned integers.
2021-02-22 20:53:32 +01:00