Commit Graph

1148 Commits

Author SHA1 Message Date
Alberto Griggio
b25bac8c53 improved performance of Fattal in dcrop
Now only Fattal works on the full image, the rest of the pipeline (including denoising) always operates only on the visible crop
2017-11-17 15:27:56 +01:00
Alberto Griggio
619b3e9c63 fixed off-by-one error leading to segfault 2017-11-16 17:35:21 +01:00
Alberto Griggio
2cdc5fc69a move Fattal before transform 2017-11-11 16:18:38 +01:00
heckflosse
67b6aec64e Fattal: one less buffer alloc/dealloc 2017-11-09 13:06:12 +01:00
Alberto Griggio
b0ebcc30eb Fattal: reduced number of temporary buffers needed 2017-11-08 21:49:50 +01:00
heckflosse
cb735125a2 Removed two stopwatches 2017-11-08 19:09:06 +01:00
heckflosse
2ff9ca0145 lot of small speedups for fattal 2017-11-08 19:01:52 +01:00
Alberto Griggio
75405404a9 Fattal: speed up FFT computation by rescaling the images to FFTW-friendly dimensions 2017-11-08 18:07:03 +01:00
Alberto Griggio
b8ff601efa fixed silly typo in Median_Denoise, leading to segfault 2017-11-07 21:07:29 +01:00
Alberto Griggio
b1938e272c added a dedicated Median_Denoise function that applies the median filter only on dark pixels
This gives a slight performance improvement for Fattal
2017-11-07 18:00:00 +01:00
Alberto Griggio
4d010f8dec do use a temporary image for Fattal in dcrop when it is needed
Because, sometimes it is needed indeed...
2017-11-07 10:31:03 +01:00
Alberto Griggio
6e17e38136 no need to use a temporary image for Fattal in dcrop 2017-11-06 23:00:52 +01:00
Alberto Griggio
d37f82498b Fattal: fixed typo in assertion, and added one more assertion 2017-11-06 22:48:40 +01:00
heckflosse
11f756239b Added comment to findMaxMinPercentile, interpolated minLum and maxLum. Removed some stop watches 2017-11-06 20:53:36 +01:00
heckflosse
d810de4445 Double speed for rescale_bilinear 2017-11-06 19:08:30 +01:00
heckflosse
356d495252 Merge branch 'hdr_tonemap_fattal' of https://github.com/Beep6581/RawTherapee into hdr_tonemap_fattal 2017-11-06 01:12:37 +01:00
heckflosse
ab061283a6 fattal, about 100x speedup for findMaxMinPercentile() 2017-11-06 01:12:15 +01:00
Alberto Griggio
1a2b7d2cde Fattal: extract luminance using the current working space matrix, not the sRGB one
Doesn't seem to make any practical difference though...
2017-11-05 21:32:06 +01:00
heckflosse
facb37be91 Speedup for exp-loop 2017-11-05 16:47:22 +01:00
heckflosse
1e0c5bfb5e solved merge conflict 2017-11-05 16:29:59 +01:00
heckflosse
59043cc978 Speedup for log-loop in tmo_fattal02 2017-11-05 16:25:13 +01:00
Alberto Griggio
d187c2e20b Fattal: raised threshold on black pixels clipping to avoid pixel artifacts 2017-11-05 16:05:50 +01:00
Alberto Griggio
d7136fc668 Fattal: apply a median filter on luminance on the deep shadows, to avoid boosting noise
Now preview matches output also for noisy images
2017-11-05 15:09:22 +01:00
Alberto Griggio
54783f6e2f Fixed bug (uninitialized values) in ImProcFunctions::Median_Denoise
The code was not copying border pixels from medianOut to dst, leading to the
use of uninitialized values. This was not visible in RT because Median_Denoise
was always called with src == dst, so not copying the border causes no harm
2017-11-05 15:07:03 +01:00
Alberto Griggio
ceb3ebf24b Fattal: protect fftwf calls with a mutex (shared also with the denoise routine)
Initialization of the fftwMutex now happens in rtengine::init()
2017-11-05 13:34:33 +01:00
Hombre
0a9f382967 Refactored name for Fattal / Alpha & Beta + updated ranges (see #4168)
Ranges for Threshold and Amount is now -100 / +100 integer. Effective
range should be modified in ImProcFunctions::ToneMapFattal02 if ever.
2017-11-04 23:09:58 +01:00
Alberto Griggio
9db14cc521 Fattal: added sanity check for the values of alpha and beta 2017-11-04 21:10:26 +01:00
Alberto Griggio
f6faccc759 moved Fattal earlier in the pipeline (before rgbProc, right after distortion/perspective/ca) 2017-11-04 18:16:51 +01:00
Alberto Griggio
c9615d440d trying out some hacks to make Fattal results less dependent on the size of the input image 2017-11-03 22:10:10 +01:00
Alberto Griggio
d418b9d01d various fixes to Fattal, and moved it later in the pipeline 2017-11-03 14:58:27 +01:00
Alberto Griggio
77b4ad497b Integrated "Fattal02" tone-mapping operator from Luminance HDR 2017-11-02 22:34:49 +01:00
Alberto Griggio
dd6e411c13 lensfun: improved logic for handling fixed-lens cameras
Fixes #4161
2017-10-31 09:02:37 +01:00
Morgan Hardwood
a2a70bffdf Added alternative camera make name XIAOYI == YI TECHNOLOGY to fix magenta highlights, closes #4164 2017-10-30 13:12:26 +01:00
Alberto Griggio
1c86c3c44d Disable LCP CA correction if LCP distortion is enabled
This was the old behaviour before lensfun integration. In order to enable both CA and distortion correction from the LCP, more work is needed.

(temporary) fix for #4159
2017-10-26 15:02:55 +02:00
Alberto Griggio
6f3d5688d8 Fixed bug in finding lensfun lens when maker name consists of multiple words 2017-10-19 16:03:33 +02:00
heckflosse
8621327678 Tiff files are not shown anymore after clearing cache, fixes #4149 2017-10-16 14:59:08 +02:00
Hombre57
dfe40677e2 Fix coverity issue 2017-10-13 23:25:24 +02:00
Hombre57
02463995af Merge branch 'dev' into multiframe-handling 2017-10-13 22:51:42 +02:00
heckflosse
e6f57b1978 Use std::string instead of Glib::ustring for key of map in camconst, #4140 2017-10-13 21:34:55 +02:00
heckflosse
93f6bf89b9 Multithreaded init phase, #4140 2017-10-13 20:59:49 +02:00
Hombre57
dcd2922167 Let users select RGB Input ICC profiles for output profiles
as requested there
https://discuss.pixls.us/t/rawtherapee-restriction-on-user-chosen-output-profile/5301
(no issue)
2017-10-10 23:03:57 +02:00
heckflosse
f38b271d74 fix heap-buffer-overflow in wavelet, Detected by AddressSanitizer. #4127 2017-10-10 15:44:27 +02:00
Alberto Griggio
1fdc2d7b49 dcraw: do not use CameraCalibration matrices when loading DNG files
This is to make sure that DNG-converted and original raw files are processed in the same way

Fixes #4129
2017-10-09 09:46:00 +02:00
heckflosse
d84a3fd40a Improve start time of rawtherapee when Dark-frames and Flat-fileds directories are set at default (windows), fixes #4103 2017-10-08 17:27:39 +02:00
heckflosse
2f32afa841 Raw CA correction created an artifact, fixes #4116 2017-10-08 15:36:31 +02:00
Hombre57
2ef064f7d4 Various bugfix (see #4008) :
1. RT could crash in some circumstances with single frame image
2. UNICODE UserComment now done when already existing in raw file
3. When editing UserComment in the ExifPanel, the Value filed is now
filled with the current value
2017-10-07 00:43:45 +02:00
Hombre57
180912df0f Merge branch 'dev' into multiframe-handling 2017-10-04 23:34:28 +02:00
Hombre57
bb874bcce7 Bigfix (see #4008) :
- CIECam now gets the shot's setting of the selected frame
- 'UserComment' metadata now correctly handled
- RT prepared to handle XTrans multiframe
- SensorType now set in the cache/data files
2017-10-04 23:27:08 +02:00
Morgan Hardwood
2f19546c72 astyled rtengine/improcfun.cc 2017-09-30 15:45:17 +02:00
Desmis
dbe1fb3fa6 Suppress compilation warning in improcfun.cc due to sumQ 2017-09-29 08:31:06 +02:00