3511 Commits

Author SHA1 Message Date
Thanatomanic
687217a6af Brighten the diagonal line in curves, tone down the gridlines. Fixes #5687. 2020-04-23 10:10:42 +02:00
Pandagrapher
2c7adc1f7a Updates in RT-spot panel GUI
- Adjusters "transitweak_" and "thresh_" are now present in all modes
- Modification of maximum value of "transitweak_" adjuster
2020-04-22 21:27:27 +02:00
Desmis
de04f63fc8 Harmonize show frame - box in wavelet 2020-04-21 17:28:23 +02:00
Desmis
07e6d07d46 Added GUI sigmaed to edge sharpness wavelet 2020-04-21 13:23:49 +02:00
Desmis
f2d867bef1 Added slider sigmabl - disactivated blurcbdl 2020-04-21 10:32:38 +02:00
Desmis
bef184aa95 GUI part - adde sigma to Wavelet Range Compression 2020-04-20 18:09:39 +02:00
Pandagrapher
a126a728d0 Fix issues in Locallab Exposure GUI according to Complexity mode
Another fixes:
- Merge problems in default language file
- Remove useless "printf"
2020-04-20 14:24:30 +02:00
Pandagrapher
cca6b09768 Merge remote-tracking branch 'dev/newlocallab' into newlocallab 2020-04-20 12:54:09 +02:00
Pandagrapher
7197d2c736 Defines default visibility of Locallab tool expanders
Also fixes an issue where Blur, Noise & Denoise mask curves weren't
available for all complexity mode
2020-04-20 12:45:01 +02:00
Pandagrapher
dd4eb44971 Merge Locallab tool "Denoise" into Locallab tool "Blur & Noise" 2020-04-19 15:19:48 +02:00
Pandagrapher
99b4a056c8 Fixes several cases where mask visibility wasn't resetted
- When a tool was removed with mask visibility active
- When an active mask visibility combobox was hidden due to other GUI
action
2020-04-18 12:30:05 +02:00
Pandagrapher
8e534877c2 Fix issue where clipboard RT-spots weren't paste with fill mode active 2020-04-18 11:36:01 +02:00
Desmis
2b8ee075a7 chnage ppversion 2020-04-18 07:49:18 +02:00
Desmis
f0e78b2a0d merge with dev 2020-04-18 07:43:44 +02:00
Pandagrapher
9d468bc6ee Avoid a case where no spot is selected using Ctrl+click on treeview 2020-04-17 17:00:04 +02:00
Pandagrapher
9013700382 Fixes several issues in Locallab GUI
- Log Encoding cannot be added to RT-spot
- RT crashes when "duplicate" or "delete" button is used without RT-spot
2020-04-17 11:48:10 +02:00
Pandagrapher
78ce750145 Fix error in 'updateExposureGUI3' function 2020-04-16 16:29:46 +02:00
Pandagrapher
4ea4663e34 Merge with 'dev/newlocallab'... 2020-04-16 16:01:53 +02:00
Desmis
a70691caf1 Enabled Toning excluded colors - to test 2020-04-16 10:57:52 +02:00
Desmis
a481b18e94 Save provisory work on toning 2020-04-15 15:37:13 +02:00
Desmis
b0f73d7cd3 Wavelet - added damper to directionnal contrast 2020-04-15 08:48:18 +02:00
Desmis
feb2c7c77f Improve GUI final Touchup 2020-04-14 16:20:15 +02:00
Desmis
ad207e003c Wavelet Improve Chroma with link contrast levels 2020-04-14 13:08:02 +02:00
Desmis
62fd0a0401 Wavelet - Add colored left bar to toning curve 2020-04-14 10:18:10 +02:00
Desmis
2c3c658171 Wavelet - added meanab sigmaab damper to chroma -Fixed bug in toning 2020-04-14 08:36:51 +02:00
Desmis
6db96ed88e merge with dev 2020-04-13 18:00:27 +02:00
Desmis
25513c85bc Improve toning with meanab sigmaab and damper 2020-04-13 17:52:56 +02:00
rom9
22eee9787e
Film negative stable multipliers (#5485)
* Added new feature to calculate channel multipliers from crop area. This also saves the crop area channel medians to the processing profiles, in order to get a more consistent color balance when batch-applying the same profile to multiple pictures from the same film roll.

* Fixed wrong initialization of array, and missing check for the result of `getFilmNegativeMedians()`.
Moved `ImProcCoordinator::translateCoord()` from private member to anonymous namespace.
Fixed some whitespace and formatting issues.

* Fixed some formatting issues

* Passed `ipf` parameter as const in `translateCoord`.
Narrowed `using namespace` to single class `Coord2D`.

* Added `scaleGain` entry to thumbnail metadata file, to make `scale_mul` multipliers available in thumbnail processing phase. This simplifies multiplier calculations, so that "faking" thumbnail multipliers in the main image processing is not necessary anymore. This way, output values are immune to slight variations of multipliers between successive shots taken with in-camera AWB turned on.
Shifted multipliers so that the output channel medians are balanced when "Camera WB" is selected. This way, just computing multipliers from crop and setting "Camera WB" (which is the default) gives a pretty well balanced image as a starting point.

* New channel scaling method, based on a film base color sample instead of crop area channel medians. Channels are scaled so that the converted film base values are equal to 1/512th of the output range (65k). This giver better black levels in the output, and more consistency when batch-processing multiple negatives.
The output is now compensated for a known fixed WB value, so that the film base will appear grey when WB is set to 3500K, Green=1.
Added PPVERSION 347 to preserve backwards compatibility: when a processing profile saved by RT 5.7 is loaded (PPVERSION=346), the new fields are initialized to the special value -1, which will instruct the main processing to follow the old channel scaling behaviour. The old channel scaling multipliers will then be converted to the new film base values so that the resulting image is the same, and the fields will be overwritten as soon as the PP is saved again. This will transparently upgrade the processing profile.
When the new behaviour is used, but the film base values are still unset, they are estimated based on channel medians, excluding a 20% border around the image. This should give a better result out-of-the-box for pictures containing a large film holder.

* Code cleanup from review

* Run astyle on film neg source files

* Fixed automated build failure caused by incompatible libraries on my dev PC.

* Simplified `Thumbnail::processFilmNegative` method signature. There is no need to pass in `rmi`,`gmi`,`bmi` multipliers from the caller, i can do the same with my own internal multipliers.

* Added `FilmNegListener` class to pass estimeted film base values to the GUI after first processing. Removed old `filmBaseValues` instance variable from RawImageSource.

* Code cleanup

* Forgot to set baseValues flag in `PartialPasteDlg::applyPaste`
Fixed `filmBaseValuesLabel` not updating when reading zero baseValues. Normally not needed (the label is updated later by the listener), but when the user is browsing through pictures the listener won't fire, so the label must be updated to show values are unset.

* Overwritten channel scaling multipliers by calling `get_colorsCoeff` with `forceAutoWB=false`.
Initially, in `RawImageSource::load`, channels are auto-balanced by averaging the whole picture when computing multipliers.
This can give different multipliers for multiple shots of the same camera, which will lead to inconsistent conversions when batch-processing multiple negatives.
This commit re-sets `scale_mul`, `ref_pre_mul`, etc., in order to "undo" the auto-WB and use the normal camera multipliers.

* Found an easier way to get stable overall multipliers, removed the (horrible) on-the-fly mutation of scaling instance variables.
2020-04-13 17:20:56 +02:00
Desmis
10ed56e740 merge with dev 2020-04-13 13:12:08 +02:00
Desmis
cb36e0130e merge with dev 2020-04-13 12:26:45 +02:00
Thanatomanic
9cc744b1f6 Reset all options in crop. Fixes #5138 and #5045 2020-04-13 11:40:28 +02:00
Desmis
71da91c85f Wavelet levels - Added Damper to local contrast final 2020-04-13 09:04:38 +02:00
Desmis
60bb7b520b Wavelet - Fixed crash when blur residual high and zoom high 2020-04-12 14:08:06 +02:00
Desmis
1df6bfcab5 merge with dev 2020-04-08 09:14:29 +02:00
Desmis
abba1bf360 Improve enabled blur level and wavelet decomp level 2020-04-07 10:16:08 +02:00
Desmis
31355ca70e Added equalizer denoise luminance 2020-04-06 09:37:37 +02:00
Desmis
753cf61ae6 merge with dev 2020-04-05 15:51:12 +02:00
Desmis
93284afafd merge with dev 2020-04-05 14:34:56 +02:00
Flössie
15db8cdb57 Guard accesses to Crop::crop_ratios (#5701) 2020-04-05 11:26:47 +02:00
Desmis
2d52fbdcef Improve wavelet levels with denoise chroma 2020-04-05 10:28:45 +02:00
Desmis
7d8e0abd2f Clean code and change default values 2020-04-04 15:37:22 +02:00
Desmis
fb23a3c8ef Merge with dev 2020-04-04 07:13:04 +02:00
Desmis
bf9089ba61 merge with dev 2020-04-03 07:47:32 +02:00
Desmis
ac0d54ef3e Display pyramid mea[] 2020-04-03 07:37:16 +02:00
Flössie
8886402e93 Fix Clang-10 warnings 2020-04-02 13:23:57 +02:00
Desmis
61c6b19533 GUI for wavelt denoise chroma 2020-04-02 12:32:29 +02:00
Desmis
29596bb457 change reset value slider bluwav to 1 2020-04-01 10:16:24 +02:00
Desmis
428bd617c9 merge with dev 2020-03-31 16:46:01 +02:00
Desmis
b8749f708c Added effect to edge sharpness 2020-03-31 14:24:17 +02:00
Desmis
5102c82c11 Improve blur with effect 2020-03-31 10:04:16 +02:00