34 Commits

Author SHA1 Message Date
Simone Gotti
b98fa42857 lens profile: report availability of distortion and vignetting
Beside CA, report also distortion and vignetting availability. Rename
is${CORRECTION}Available methods to has${CORRECTION}.
2024-07-08 10:29:43 +02:00
Simone Gotti
dc0e23c82c iptransform: apply distortion and CA correction in a single pass
Some lens profile methods provides a way to correct distortion and CA in
a single step.

When available, applying distortion and CA correction when both enabled
in a single pass is more precise (see lensfun
ApplySubpixelGeometryDistortion doc) since it's usually how the profile
is done. Instead applying the CA correction in a step after distortion
correction could lead to a bit different (also if not always visible)
correction.

This is also required for future lens correction methods (like DNG
WarpRectilinear or corrections based on vendor metadata) that provides
only merged distortion and CA correction in a single pass.
2024-07-08 09:40:36 +02:00
Lawrence Lee
72de3f21c7 Remove misleading comments 2020-06-25 10:39:21 -07:00
Lawrence Lee
8a970f95bc Merge from branch 'dev' 2020-05-04 11:49:34 -07:00
Ingo Weyrich
b4c0bb3acb More double promote fixes 2020-02-10 20:06:43 +01:00
Lawrence
b266cb7ca3 Remove scale parameter from distortion correction
Scale is no longer useful in LensCorrection::correctDistortion. Remove
the scale parameter from the functions.
2020-01-02 18:33:35 -08:00
Ingo Weyrich
a2b0167339 Fix broken non OMP build 2019-12-02 19:46:00 +01:00
Ingo Weyrich
f95acfe74e Multithread lensfun vignetting correction 2019-12-02 17:32:13 +01:00
Ingo Weyrich
d731e172c2 Further reduction of include dependencies 2019-11-01 16:15:59 +01:00
Ingo Weyrich
068847eb5a Further cleanup of include dependencies 2019-10-29 21:06:27 +01:00
Ingo Weyrich
20726d5bfe Forward declare Imagefloat 2019-10-28 20:01:16 +01:00
Morgan Hardwood
60b2196bce Updated gnu.org links to use HTTPS 2019-09-10 12:34:57 +02:00
heckflosse
190772af5e Fix some issues found by cppcheck 2018-11-22 18:40:09 +01:00
heckflosse
831e18ca45 Add override keyword. Thanks @Floessie 2018-11-22 16:19:16 +01:00
heckflosse
1cdd814e1b Fix coverity issues 2018-11-20 14:42:39 +01:00
Alberto Griggio
5a05b04e09 profile-based CA correction applied during 1:1 preview 2017-10-29 21:41:19 +01:00
Alberto Griggio
4dc0e20ae0 merge with lcp-vignetting-issue4062 2017-09-11 17:22:01 +02:00
Alberto Griggio
e4ba4d19f5 made lensfun-based correction compatible with auto fill mode 2017-09-10 22:02:43 +02:00
Flössie
d442f7a85b LCP cleanup (#4062)
- Removed `using namespace`
- Use real `Cache`
- Use `std::shared_ptr<LCPProfile>`
- Moved `LCPPersModel` to .cc

More could be done...
2017-09-09 20:19:11 +02:00
Alberto Griggio
dde94bc6d3 added basic integration of lensfun
so far only distortion correction, and no GUI yet
2017-09-07 00:53:03 +02:00
Alberto Griggio
5656d16e64 LCP: filter out bad vignetting correction entries
Candidate fix for regression #4062
2017-09-06 15:27:54 +02:00
Alberto Griggio
2edd677d1a Fixed various memory leaks as reported by AddressSanitizer 2017-06-07 10:36:28 +02:00
Alberto Griggio
871c75e494 Correctly apply LCP "distortion" correction for Fisheye lenses
Note: as discussed e.g. at http://lensfun.sourceforge.net/manual/corrections.html, this is really a combination of distortion correction and change of projection (from fisheye to rectilinear), but "distortion correction" is how the Adobe camera model calls it, and this is how it appears in the RT gui
2017-04-08 10:13:53 +02:00
Alberto Griggio
633af0bb6c fix buffering issue in the LCP profile parser (issue #3788) 2017-04-06 17:57:00 +02:00
heckflosse
7d9e5765ba Removed unused function and stopwatch 2017-02-22 14:50:10 +01:00
heckflosse
8e205afeed Revert "Further cleanup and astyled lcp.*"
This reverts commit 1348ea06e4975d26b50f9e723ae61f87916dcf17.
2017-02-22 14:43:41 +01:00
heckflosse
1348ea06e4 Further cleanup and astyled lcp.* 2017-02-22 01:53:22 +01:00
Flössie
99309aa4ac Preliminary cleanup for LCPModelCommon 2017-02-21 21:10:33 +01:00
heckflosse
87a280f8ca Additional speedup for lcp vignette correction 2017-02-21 19:11:54 +01:00
heckflosse
94129861f5 Speedup for lcp vignetting correction 2017-02-19 20:36:45 +01:00
heckflosse
e82b60cd03 Cppcheck: Fixed some issues found by Flössie during review of my changes 2016-10-04 23:50:44 +02:00
heckflosse
3552fd4161 Cppcheck: Fix issues related to explicit constructors 2016-10-03 00:54:02 +02:00
DrSlony
0e0cfb9b25 Formatted all .cc and .h code in rtengine, rtexif and rtgui using astyle 2015-08-11 11:55:03 +02:00
torger
d5ca351c20 Issue 2134: removed obsolete raw highlight preservation setting from GUI (still left in procparams for backwards compatilibility) 2015-07-10 12:00:36 +02:00