Commit Graph

3636 Commits

Author SHA1 Message Date
Thanatomanic
bb623d3a02 Fix instance of deprecated HBox 2021-05-13 12:34:27 +02:00
Lawrence Lee
f958074d9b Fix crash when deleting spot removal spot
Deleting a spot while hovering over one of the circles for adjusting the
radius or feathering could trigger a crash. This is because immediately
after deleting a geometry object, EditSubscriber::getCursor is given an
object ID based on old data, causing the spot tool to attempt to get
information about the deleted geometry object.

This commit fixes the issue by returning the default cursor if the
active spot is -1. It works because the active spot is set to -1 when
deleting a spot, and there is no need to use a special cursor when there
is no active spot.

A better long-term solution would be updating the geometry data before
calling EditSubscriber::getCursor.
2021-03-07 11:58:36 -08:00
Lawrence Lee
10b5f65b30 Fix spot removal enable/disable history message
The history panel was showing "HISTORY_MSG_1049".
2021-03-06 21:29:56 -08:00
Lawrence Lee
7e436a44d6 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into spot-removal-tool 2021-03-06 16:41:40 -08:00
Desmis
df9f33e44e LA - Others improvments length labels 2021-03-06 08:22:50 +01:00
Desmis
0bf7c4e56c Local adjustments - Added Guidedfilter to avoid color shift (#6149)
* Added Guidedfilter to avoid color shift

* Various improvment to avoid color shift

* Small change to mint maxt

* local adjustments avoid color shift: reduce memory usage by width * height * 8 byte if Soft Radius > 0

* Remove StopWatch

* local adjustments avoid color shift: speedup for last loop

* cleanups

* one more cleanup

* Added checkbox Munsell correction only - uniform perceptual lab

* Refine some settings

* Clean-up - other small refinement

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-03-03 18:49:55 +01:00
Pandagrapher
84751ad26f Re-allow using RT shortcut while focused on adjuster 2021-03-01 21:38:35 +01:00
Pandagrapher
d92bbf59e1 Fixes #6148, allow using decimal key on numpad 2021-03-01 21:04:08 +01:00
Stefan Wunsch
68a6e02369 Fix some cmake build system issues (#6147)
* [cmake] Switch to find_package for TIFF
- Included in cmake 3.5 and later
- Provides better configuration messages
* Add missing TIFF library to rtgui and rtexif
* Removed unnecessary quotes so that cmake sees the list as a list
* Add OpenMP to rtengine if OpenMP is enabled
2021-03-01 16:40:54 +01:00
Ingo Weyrich
02a5040a60 Undocumented search feature in exif tab can be annoying, fixes #6142 2021-02-28 17:00:37 +01:00
Thanatomanic
09441c7e54 Correctly apply Local adjustments when loading a pp3 profile 2021-02-28 11:13:21 +01:00
Desmis
b58f643d59 Local adjustments - Grain - various improvment - see issue #2460 (#6120)
* Fixed bad behavior saturation issue 6117

* Reenable scalegr for grain

* some changes to grain

* Init lagrain

* Various improvment GUI - gamma

* Change basic - normal grain
2021-02-27 08:13:44 +01:00
Thanatomanic
a6a368e682 Allow resizing of navigator window. Patch by @Lawrence37. Fixes #6052 2021-02-27 08:03:36 +01:00
Thanatomanic
1214450aaa Small fixes to Gtk::Grid::attach for compilation with gtkmm 3.22 2021-02-25 17:49:05 +01:00
Desmis
9e159deb01 Local adjustments - Blur and noise radius > 1.5 increase saturation issue #6117 (#6118)
* Fixed bad behavior saturation issue 6117

* Reenable scalegr for grain

* Add forgotten brackets
2021-02-19 13:06:34 +01:00
Thanatomanic
de15da1d59 Fix new color propagation method (#6109)
* Fixed artifacts thanks to Alberto

* Added blur to Color propagation

* Clean format code - small improvments

* color propagation: Enable old mode at blur = 0

* Improve GUI

* color propagation: smooth progress bar for blur > 0

* change label

* Some cleanups

* color propagation: small speedup for blur > 0

* color propagation: speedup for blur > 0 when region with clipped highlights is small

* Speed-up for blur=1 - clean GUI code

* color propagation: cleanups

* Harmonize events in tonecurve.cc

* tonecurve.cc : cleanup

* Highlight reconstruction: small changes to gui

* Use Gtk::Box instead of Gtk::VBox

* Change maximum number of blur levels to 4

* Suppress BENCHFUN

* Suppress bad commit locallabtools

Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-18 13:36:54 +01:00
Ingo Weyrich
d29d5e144b Update locallabtools.cc
Fix wrong fix from last commit...
2021-02-17 15:38:29 +01:00
Ingo Weyrich
036a590db1 Fix adjuster default value 2021-02-17 13:41:25 +01:00
Thanatomanic
fc031ccb5a Remove deprecated GTK3 code, fixes #6103 (#6113)
Replaces the following deprecated Gtk classes throughout the codebase by their non-deprecated counterparts. Style, HBox, VBox, HPaned, VPaned, HScrollbar, VScrollbar, VSeparator, HSeparator, Stock, Table, VScale and HScale.
2021-02-17 11:44:25 +01:00
Ingo Weyrich
a1f3edbeab delayed.h : fix cppcheck warnings 2021-02-14 17:48:37 +01:00
Desmis
9b0bbdd276 Local adjustments - Neutralize process after LA when when the user uses preview deltaE (#6099)
* Add others methods RGB process - to preview dE

* added others process to neutralize preview dE

* Added others process to neutralize preview dE

* Change scope placement for all tools
2021-02-09 07:31:54 +01:00
Desmis
6ad419f189 Local adjustments - Denoise - improvments with Non Local means issue #6087 (#6091)
* Improvment to denoise

* Initialize nlmeans - thanks to Alberto and Ingo

* Added 2 sliders max_patch and max_radius

* Added Frame Non-local means

* Improve GUI and tooltips - french

* Change dfault detail - and comment code

* Change label

* Adapt English tooltip

* Change GUI for NLmeans

* Change order GUI denoise

* Some changes to enable DCT - labels and tooltips

* French labels tooltip

* Change order combobox mode denoise - labels - tooltips

* Change tooltip Denoise based on luminance mask

* Change a tooltip

* Removes unnecessary code

* Nlmeans add gamma to preserve structure or reinforce denoise

* Change gamma tooltip

* Change tooltip Recovery denoise

* Disabled nlmeans if skip > 5

* Change tooltip - size limit spot Nlmeans 150-150

* Change gamma Nlmeans

* Supress display console

* Speedup for gammalog and igammalog, #6087

* SSE code for (i)gammalog, #6087

Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-05 16:24:43 +01:00
Pandagrapher
1640dfcea9 Avoid resetting spot shape when switching from Normal to Excluded spot 2021-02-03 18:45:52 +01:00
Desmis
6b1e5d6181 Ciecam - Take into account issue #6022 choice between classic - symmetric - mixed - for cat02/16 (#6079)
* Change mode cat02-16 auto

* Change tooltip
2021-01-30 07:35:07 +01:00
Lawrence Lee
78209d3c96 Fix color label with default profile bug
Prevent the color label, rating, and trash status from being reset when
resetting a photo to the default processing profile.

Closes #5936.
2021-01-24 18:10:02 -08:00
Desmis
999eb30f5f LA Denoise - change reparition basic standard advanced 2021-01-24 08:06:46 +01:00
Desmis
cbb7735fae Change 2 labels show modified areas 2021-01-17 17:21:53 +01:00
Desmis
2ea7b02f2a Local adjustments - GUI 'full image' - allows you to use the local adjustment tools on the whole image (#6063)
* Init Full image auto mode

* Add tooltip for full image

* Change tootip

* Added tooltip to Full image

* Slighly change tooltip
2021-01-17 08:51:37 +01:00
Desmis
ea6bb8fcf7 Local adjustments - Retinex - Last Recovery based on luminance mask (#6062)
* LA Retinex GUI for Recovery based on luminance mask

* LA Retinex Enable Recovery based on luminance mask
2021-01-15 12:29:46 +01:00
Desmis
58feb50b33 Local adjustments - CBDL Luminance - Recovery based on luminance mask (#6060)
* LA CBDL GUI for Recovery based on luminance mask

* Improve tooltips
2021-01-14 14:21:01 +01:00
Desmis
5e95b2e5e2 Local adjustments - Tone Mapping - Recovery based on luminance mask (#6059)
* LA TM GUI for Recovery based on luminance mask

* LA TM enable Recovery based on luminance mask
2021-01-14 07:41:25 +01:00
Desmis
13bd5c0681 LA denoise - Improve Recovery based on luminance mask with chominance slider (#6058) 2021-01-13 12:28:09 +01:00
Desmis
8037457a8d Local adjustment - local contrast - wavelet - Recovery based on luminance mask (#6057)
* LA GUI Lc and Wavelet - recovery based on luminance mask

* Enable LA Lc wavelet Recovery based on luminance mask
2021-01-12 15:14:56 +01:00
Desmis
0ba18ab687 Local adjustments - Vibrance and Warm Cool - Recovery based on luminance mask (#6055)
* GUI for Vibrance Recovery based on luminance mask

* Enable LA Vibrance Recovery based on luminance mask
2021-01-12 06:58:21 +01:00
Desmis
291c866b53 LA log encoding - forgotten enable mask in standard 2021-01-10 18:26:20 +01:00
Desmis
036257859d Local adjustments - denoise - Change curve denoise and default settings (#6051)
* Change parameters curve LA denoise

* Change enable denoise and default curve

* Change default curve level denoise

* Change default reset and enable
2021-01-08 17:17:44 +01:00
Desmis
efb601c028 Local adjustments - Shadows highlights - Recovery based on luminance mask (#6050)
* LA GUI for recovery using luminance mask

* LA Shadows Highlights Enable Recovery based on luminance mask
2021-01-08 13:17:28 +01:00
Desmis
e8da58ad24 Some GUI improvment Ciecam 2021-01-07 10:09:28 +01:00
Desmis
66908b6c5a Improve GUI Ciecam - disable setDelay and throwOnButtonRelease 2021-01-05 09:12:30 +01:00
Desmis
5df1478320 Local adjustments - Dynamic range and exposure - Recovery based on luminance mask (#6046)
* GUI for recovery mask - Log encoding

* Enable recovery Log encoding with luminance mask

* GUI for exposure

* Improve code with maskrecov

* Enable recovery based on luminance mask for Dynalic Range and exposure

* Change tooltips

* Change boxblur
2021-01-05 07:50:22 +01:00
Desmis
b8d5a3d9fb Local adjustments - Log encoding - Recovery based on mask luminance (#6038)
* GUI for recovery mask - Log encoding

* Enable recovery Log encoding with luminance mask
2021-01-01 12:05:33 +01:00
Desmis
d118801561 LA denoise recovery gray (#6037) 2020-12-30 10:12:32 +01:00
Desmis
bad08bfe1d Local adjustments - Color and light - Recovery based on luminance mask (#6035)
* Init GUI color mask recovery

* Enable recovery Color and Light with mask

* Disabled invmaskd in color and light

* Hide decay in standard - added tooltips

* Change tooltips

* Change normal to simple for all defaults mask
2020-12-29 10:27:57 +01:00
Thanatomanic
d2cd5f21c9 GUI changes: more distinct on/off modules, various CSS and GUI tweaks for further future modifications
Collection of CSS and GUI improvements, cleanup of main CSS theme, introduction of highlight for enabled module. 

Primary change is the modification of the module titles to better distinguish modules that are on or off. The text of a disabled module is now less bright, the corresponding icon is a slightly smaller version of the power icon. When activating the module, the text turns brighter and the icon slightly bigger and also brighter. Thanks to @TechXavAL for the icon work.

Secondary changes are related to the margins around several GUI elements, padding within elements and some accompanying borders. These changes hopefully make it easier to distinguish the various (sometimes crowded) GUI elements of modules. The panels have gotten a slightly 'outset' look.

Nested panels have a changed look where deeper nesting increases the background brightness slightly, instead of darkening it (old behaviour). This  is done without a strong decrease in contrast.

The old theme is available as a legacy option. Due to hardcoded GUI changes needed for the new theme, the legacy version is not a 100% exact replicate. The @TooWaBoo theme's may also be slightly affected.
2020-12-27 15:31:39 +01:00
Desmis
94f54b6443 Local adjustments - Denoise and Guided Filter - Recovery based on luminance mask (#6032)
* Slider recovery threshold guidedfilter

* Enable GuidedFilter recovery based on mask

* Enable inverse GF recovery

* Small changes GUI

* Recovery GUI denoise LA

* Enable recovery denoise with mask luminance

* Fixed bad compilation error

* Fixed bad behavior GUI expert - basic

* Another fixed bad behavior GUI

* First changes and verifications algo and GUI

* Others GUI modifications

* Fixed bug compilation and reset and clean code

* Some changes in algo - new tooltip

* Added calcdif to denoise - prepare GUI - change some tooltips

* Change tooltips

* Change some settings

* Small Change settings default curve denoise
2020-12-27 08:14:51 +01:00
Desmis
36cd2bc8ba Local adjustment denoise - added Laplacian to detail threshold DCT (#6027)
* Comment code

* Change GUI place edge detection

* added usemask in reset

* Added sk gaussian blur edge DCT

* Improve Laplacian threshold detail DCT
2020-12-19 07:46:12 +01:00
Desmis
183b20110b Change default values DCT denoise LA 2020-12-16 20:13:00 +01:00
Desmis
977fd771e6 Reset button for LA denoise 2020-12-16 13:53:11 +01:00
Desmis
a4ab8f9fba Display status enable mask for denoise 2020-12-16 12:39:20 +01:00
Desmis
10cc600277 Improvment selection GUI mask denoise 2020-12-16 07:54:47 +01:00