396 Commits

Author SHA1 Message Date
Thanatomanic
de15da1d59
Fix new color propagation method (#6109)
* Fixed artifacts thanks to Alberto

* Added blur to Color propagation

* Clean format code - small improvments

* color propagation: Enable old mode at blur = 0

* Improve GUI

* color propagation: smooth progress bar for blur > 0

* change label

* Some cleanups

* color propagation: small speedup for blur > 0

* color propagation: speedup for blur > 0 when region with clipped highlights is small

* Speed-up for blur=1 - clean GUI code

* color propagation: cleanups

* Harmonize events in tonecurve.cc

* tonecurve.cc : cleanup

* Highlight reconstruction: small changes to gui

* Use Gtk::Box instead of Gtk::VBox

* Change maximum number of blur levels to 4

* Suppress BENCHFUN

* Suppress bad commit locallabtools

Co-authored-by: Desmis <jdesmis@gmail.com>
Co-authored-by: Ingo Weyrich <heckflosse67@gmx.de>
2021-02-18 13:36:54 +01:00
Ingo Weyrich
7a0d2dddc9 Fix flat field correction for multiframe raw files 2021-01-31 14:09:41 +01:00
rom9
e635030650
FilmNegative: non-raw file support and better accuracy (#5798)
* Added support for non-raw files to the film negative tool. The tool is now under the "Color" tab. Moved the entire filmneg code downstream, right after input profile conversion.
Usage changes a bit: White Balance must be set to the _backlight_ color temperature. Added two more sliders to color-balance the picture after negative inversion. Legacy inversion method kept for compatibility with processing profiles saved by RT v5.7 or 5.8 (only if Film Negative was enabled). Should be removed in a future version.
There is still an issue with DCP profiles that need the look table to be active to work properly. Using a simple matrix input profile (or just camera standard) is recommended for now.

* The user can now choose to perform inversion before or after input colorspace conversion.
Seamless backwards compatibility with previous processing profiles; upgrading from a previous version now gives an (almost) identical output as before.
Generalised the concept of film base values: the processing profile now contains a pair of RGB triplets, "reference input" and "reference output", which makes it much more straightforward to compute the output multipliers.

* Added support for `RGB` data type to putToKeyFile, removed the now unused `RGB::toVector()` method. Some cleanup.

* Spot balance picker now stays active indefinitely. Can be disabled by right-clicking, too.

* Removed film negative from `filterRawRefresh` condition, since the new version does not require raw rendering anymore.

* The Output Level slider is now exponential, so it should feel more familiar to use (similar to the exposure compensation slider).

* Removed old `RedBase`, `GreenBase`, `BlueBase` keys from the PP3 file after params upgrade. Keys are only kept if the file only undergoes batch edit (hence no params upgrade was done).

* Made the balance sliders exponential and centered at zero. Now they should be a bit smoother and possibly more user-friendly.

* Changed adjusters' step to more useful values, they were too fine-grained and hard to adjust using the +/- spinbutton.
Increased max ratio value from 3 to 5, as i found an old negative needing a very high blue channel exponent.

* Added an initial processing profile for film negative inversion, to be provided as a bundled profile.

* Removed Output Level and balance sliders when in batch mode: since the effect of these sliders is dependent on the reference input values, those values needed to be copied as well. And, touching any of the sliders needed to flag all three as dirty. All this felt more confusing than useful.
It should be sufficient (and clearer) to copy/paste the params, and then fine-tune the balance on individual pictures when needed.

* Set bayer demosaic method to RCD in the bundled "Film Negative" processing profile. RCD seems to play a bit better with Capture Sharpening in the presence of film grain, compared to Amaze.
This will favor new users starting with all-defaults settings, hence having Capture Sharpening enabled by default.

* Removed incorrect "contrast" term from the "Reference exponent" label. This parameter adjusts the image _gamma_, not its contrast.
2020-11-21 13:29:47 +01:00
Ingo Weyrich
b1690fd489 Merge branch 'dev' into bayer_bilinear 2020-08-14 12:55:55 +02:00
Ingo Weyrich
6caf33a589 Some fixes suggested by @Floessie 2020-07-16 11:35:41 +02:00
Ingo Weyrich
d22fcb9df1 Cleanup for curves.* 2020-07-13 16:07:52 +02:00
Ingo Weyrich
98378892f5 Merge branch 'dev' into bayer_bilinear 2020-06-22 15:15:46 +02:00
Thanatomanic
421f868921
Merge pull request #5804 from luzpaz/typos
Fix various typos
2020-06-19 18:05:17 +02:00
Ingo Weyrich
e89a3041fa fix black level computation for applying flat-field correction, taken from ART, thanks @agriggio 2020-06-19 17:07:49 +02:00
luz.paz
a41aa73124 Fix various typos
Found via  codespell v2.0.dev0  
```
codespell -q 3 -I ../rawtherapy-whitelist.txt -S ./rtdata/languages -L bord,hist,fo,reall,bloc,alph,dof,thre,makro,chang,currentry,portugues,vektor,ue
```
2020-06-18 14:53:04 -04:00
Ingo Weyrich
43d5de7bac iplocallab.cc: further cleanups; also removed some debug code 2020-06-11 18:32:27 +02:00
Ingo Weyrich
bf30ca6c05 dual_demosaic: added Amaze+bilinear and Vng4+biliner, also made a small speedup, #5748 2020-05-24 19:28:56 +02:00
Ingo Weyrich
3ee5f0473a Merge branch 'dev' into bayer_bilinear 2020-05-24 14:14:05 +02:00
rom9
f0720ff34c
Avoid overwriting c_black from inside ::preprocess when re-computing multipliers according to selected preprocess WB mode. Fixes #5765. 2020-05-20 08:29:19 +02:00
rom9
6590e6d98b Merge branch 'dev' into preprocess_wb 2020-05-13 19:47:09 +02:00
Ingo Weyrich
acc2b3d308 Add RCD+Bilinear demosaic for Bayer sensors, #5748 2020-05-10 12:16:48 +02:00
Desmis
fe17a7add2 Improve comment code algorithm Itcwb 2020-03-18 09:37:34 +01:00
Desmis
a45823995a Itcwb increases precision in color sampling 5 instead of 9 - option itcwb_precis 2020-03-18 09:00:26 +01:00
Desmis
8a972bef9e Itcwb - Use standard observer 10 by default - create option itcwb_stdobserver10 2020-03-16 17:58:35 +01:00
rom9
fb023e7ba8 Removed channel compensation adjusters 2020-03-15 17:01:40 +01:00
Ingo Weyrich
b2165aedd9 camconst.cc/h : code review 2020-03-08 14:12:23 +01:00
Desmis
8875cc8df4 Change number of green reference from 118 to 134 2020-03-06 16:04:31 +01:00
Desmis
961bf3e5fd Change range geen in autowb 2020-03-06 15:15:22 +01:00
Desmis
9773f1bd98 Improve results when chroma is very low 2020-03-06 10:41:58 +01:00
Desmis
f6c5bf0a0b Change didide getrgbloc 10 to 9 - suppress 3 spectral datas 2020-03-06 08:53:39 +01:00
Desmis
e63320eec9 Added new spectral datas near neutral 2020-03-05 13:36:37 +01:00
Desmis
e3b5a59748 First improvment to histxyY 158 to 192 2020-03-05 10:41:22 +01:00
Ingo Weyrich
cc4de2e804 Fixed some typos in comments 2020-03-03 15:06:49 +01:00
rom9
50becdef31 Merge branch 'dev' into preprocess_wb 2020-03-02 20:54:48 +01:00
Desmis
6d31fe48a7 Comment code Itcwb 2020-03-02 08:51:11 +01:00
Ingo Weyrich
c92c0c0c8a disabled BENCHFUN 2020-03-01 12:44:15 +01:00
Ingo Weyrich
f85b2cc5bc small correction 2020-03-01 12:22:15 +01:00
Ingo Weyrich
d0034c880b further cleanups and speedups for ItcWB/getrgbloc 2020-03-01 11:50:58 +01:00
Desmis
95b238ca5d Added Ingo to copyright Itcwb 2020-03-01 08:37:51 +01:00
Ingo Weyrich
cee41b9786 restore speed when not using auto itc wb and improve speed when using it 2020-02-29 21:04:09 +01:00
Ingo Weyrich
0a23e85868 Further cleanups 2020-02-29 19:44:20 +01:00
Ingo Weyrich
6029b29d89 fix copy/paste bug 2020-02-29 14:59:26 +01:00
Ingo Weyrich
be765768ff further cleanups 2020-02-29 14:19:06 +01:00
Ingo Weyrich
be5e447f53 Itcwb : cleanup and speedup, #5676 2020-02-29 13:16:42 +01:00
Ingo Weyrich
96ab9863dd fix segfault in ItcWB. #5676 2020-02-29 10:37:32 +01:00
Ingo Weyrich
60caf17c7a Merge branch 'dev' into rawimagesource_cleanup 2020-02-29 09:35:33 +01:00
Ingo Weyrich
28cff72eb0 rawimagesource.cc : cleanup, also speedup and bugfix for ItcWB, #5676, #5675 2020-02-28 20:18:45 +01:00
Desmis
ae0586719a Enabled bencfun for Itcwb 2020-02-28 08:33:12 +01:00
Ingo Weyrich
f7792aa936 some cleanups 2020-02-27 21:22:34 +01:00
Ingo Weyrich
ad271a87eb clang errors: variable-sized object initialization, fixes #5667 2020-02-25 17:02:00 +01:00
Desmis
eeb24af8f0 Suppress message in console except verbose 2020-02-25 12:48:23 +01:00
rom9
d4fc4dc083 Added new "Preprocess WB" parameter in the Raw toolpanel, just below "Raw White Points" tool. Allows to choose between "Camera" and "Auto" (average-based) raw channel multipliers, and to apply custom compesation factors.
Fixes #5616
2020-02-24 21:00:51 +01:00
Desmis
92fc0e307f merge with dev 2020-02-24 11:09:20 +01:00
Ingo Weyrich
f0b5ca02e7 More double promote fixes 2020-02-10 16:22:42 +01:00
Ingo Weyrich
b627adea3a Merge branch 'dev' into fix-double-promotion 2020-02-09 16:45:20 +01:00