liz/rawTherapee
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11,920 Commits 1 Branch 0 Tags
e4087e2fa2f4b0bcee08e1aa903df1a3201c86d2
Commit Graph

3983 Commits

Author SHA1 Message Date
Desmis
e4087e2fa2 White balance auto temperature correlation - improve behavior with non raw files (#6903) 
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
 2024-02-01 07:48:07 +01:00
Lawrence37
ba065dc13f Merge pull request #6920 from sgilbertson/issue-6915-queue-template-improvements 
Queue template improvements
 2024-01-28 11:43:07 -08:00
Lawrence37
4dd7517a55 Merge pull request #6873 from 0v3rt1r3d/0v3rt1r3d/fix-a-couple-of-warnings 
Fix a couple of warnings
 2024-01-27 21:46:14 -08:00
Scott Gilbertson
11a0a0b697 Fixes per pull request comments: fix %p-1 missing slash, use static_cast, fix int/unsigned mismatches 2024-01-16 07:54:12 -05:00
Scott Gilbertson
6cbc448f63 Handle Samba-style UNC prefix '//' in %p and %P queue output template specifiers 2024-01-15 17:13:40 -05:00
Scott Gilbertson
1df9b4869e Make %p and %P queue output template specifiers limit invalid range rather than treating that as an error. 
For example in a 4-element path "first 5 elements" and "last 5 elements" now return all four elements.
 2024-01-15 16:39:38 -05:00
Scott Gilbertson
a39e6779e4 Fix: If %p or %P queue template term includes start of file path, prepend the leading /, \ or \\ from the file path 2024-01-15 15:27:09 -05:00
Scott Gilbertson
343b5ecc68 Left-justify the queue destination preview label and allow it to scroll horizontally 2024-01-15 14:40:56 -05:00
Scott Gilbertson
b3bbaa6421 Code formatting: move ampersands next to types 2024-01-10 18:55:52 -05:00
Scott Gilbertson
9e310b7454 Minor changes per feedback in issue #6915 (mostly code formatting) 2024-01-10 18:47:14 -05:00
Scott Gilbertson
c918de3178 Reversed %p and %P processing cases for location templates, which were opposite to what the help says. 2024-01-07 11:49:19 -05:00
Scott Gilbertson
0127b68bdb Minor comment clarification 2024-01-07 11:14:52 -05:00
Scott Gilbertson
df41028468 On Windows, use backslashes in template-generated paths 
(but continue to accept either / or \ in input strings, on any platform)
Also deleted an unused helper function.
 2024-01-07 11:10:05 -05:00
Scott Gilbertson
f92e07e5cf Make destination path preview label selectable, so its contents can be copied to the clipboard 2024-01-07 10:52:01 -05:00
Scott Gilbertson
0f66d43272 Update destination preview whenever the save format changes. 2024-01-07 10:09:45 -05:00
Scott Gilbertson
21c53823ee Reimplemented %p template specifier to use new method, added %P specifier 
The %P specifier includes directories from the start of the file path,
whereas the original %p specifier includes them from the end. In both
cases N is from the last directory in the path, and -N is from the
first directory in the path (N=1..9).
 2024-01-06 18:21:59 -05:00
Scott Gilbertson
b8d3f90ca0 Reimplement template %dN specifier, making %d-N count from start of path, not end 
Also made %pN selectively skip the next character only if it's a slash or backslash,
so for example %p2/a, %p2\a and %p2a produce the same result.
 2024-01-06 18:01:56 -05:00
Scott Gilbertson
587e0c6782 Simplified BatchQueue::updateDestinationPathPreview after noticing that calcAutoFileNameBase handles all cases 2024-01-06 16:32:14 -05:00
Scott Gilbertson
380d964077 Add destination path preview label to batch queue panel. 
Label initially says "Destination path for the first selected image appears here"
so the feature is discoverable. Select a file and it shows the destination path
that would be used if it is the first file to be processed and the file does
not already exist. Label is updated as the template is edited, so you can see the
effect of the edits. If "Save to folder" is selected, the previewed path uses
that folder.
 2024-01-06 16:00:19 -05:00
Desmis
31bf942d92 Local adjustments - Show additional settings - link with complexity (#6899) 
* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds
 2023-12-17 08:37:20 +01:00
Lawrence37
1839db448d Merge pull request #6793 from Lawrence37/nr-gain 
Option for disabling noise reduction gain
 2023-12-16 11:11:24 -08:00
Desmis
32aca270ec LA exposure hide show sliders when expcomp different from zero (#6892) 2023-12-02 08:24:42 +01:00
Lawrence Lee
330f99832e Fix WB method reset when not using English 
Use the GUI label for "Camera" instead of hard-coding it.
 2023-11-26 16:25:06 -08:00
Alexander Gruzintsev
de82b9fc7a Fix warnings: conversion to double/float, unused variables, register keyword 2023-10-30 08:18:33 +01:00
Desmis
d276a56b10 Local adjustments - improvment Dehaze with black (#6860) 
* Local Dehaze black

* Enable black

* Change threshold black - publish_pre_dev_labels ladehazeblack
 2023-10-12 06:59:33 +02:00
Lawrence37
dac3dcf664 Merge pull request #6854 from Lawrence37/color-toning-layers-fix 
Fix hidden layers in the Color Toning tool
 2023-10-10 21:05:33 -07:00
Lawrence37
ab8de06c66 Merge branch 'dev' into nr-gain 2023-10-10 21:03:03 -07:00
Lawrence Lee
a35b320f1a Fix color toning layers being hidden 
Request resizing of tool widgets after being attached to the tool panel.
 2023-09-17 15:27:19 -07:00
Lawrence37
7ebbac25ca Format code 2023-09-10 14:29:17 -07:00
Lawrence Lee
730704f3b2 Fix startup crash in debug build 
Do not throw error when trying to get mutex lock.
 2023-09-09 16:02:41 -07:00
Lawrence Lee
0fdac3797a Merge branch 'dev' into browser-preview-applied-pparams 2023-08-29 22:58:51 -07:00
Beep6581
e189a1a4ec Merge pull request #6817 from ss23/clang_windows_mingw_64bit_fix 
Use `_WIN32` instead of `WIN32` to detect Windows
 2023-08-29 00:47:13 +02:00
Morgan Hardwood
5f6ca0afab More visible curve crosshair cursor 
Fixes #6741

The mouse cursor when hovering over a curve was sometimes impossible to
see on a high resolution screen due to the almost identical colors of
the cursor relative to the curve background.
 2023-08-29 00:32:56 +02:00
Morgan Hardwood
322c124e6b Merge branch 'switched-rating-shortcuts' of github.com:Eemilp/RawTherapee into Eemilp-switched-rating-shortcuts 2023-08-29 00:01:50 +02:00
Beep6581
0a13b85d1d Merge pull request #6798 from LoKolbasz/film_negative_pick_size 
Adjustable picker size in Film Negative tool
 2023-08-28 21:58:55 +02:00
Beep6581
3a15743620 Merge pull request #6829 from Lawrence37/profiled-lens-correction-batch-unchanged-bugfix 
Show "unchanged" in batch profiled lens correction
 2023-08-28 21:51:16 +02:00
Richard E Barber
7a5931135e handle libatomic in cmake module 
cmake/modules/findATOMIC.cmake detects libatomic flags. see #6821
 2023-08-28 09:43:09 -07:00
Lawrence Lee
e6a2654241 Show "unchanged" in batch profiled lens correction 2023-08-27 16:32:30 -07:00
Dániel Battyányi
75541d6281 Changes to get the full spot width where needed 2023-08-20 13:59:42 +02:00
Dániel Battyányi
6b6200314f Member functions changed to const 
The following member functions and methods of SpotPicker changed to const:
- get_active()
- get_spot_half_width()
- selecterSetup()
- spotButtonTemplate().
 2023-08-20 13:38:24 +02:00
Dániel Battyányi
af22f4195d Removed empty destructor 2023-08-20 13:29:49 +02:00
Battyányi Dániel
6715e89696 Merge branch 'dev' into film_negative_pick_size 2023-08-19 19:44:29 +02:00
Lawrence37
a56c11570f Merge pull request #6814 from Lawrence37/multi-editor-tabs-external-editor-bugfix 
External editor button: synchronize in multiple editors layout
 2023-08-18 21:03:18 -07:00
Dániel Battyányi
3d5810f088 Applied requested changes from review comments 2023-08-19 00:17:10 +02:00
Lawrence37
ac48cc55d8 Better use of cache with inpaint opposed highight reconstruction (#6822) 
* Speed up preview when inpaint opposed enabled

Only reprocess from raw if the white balance is changed. Otherwise, a
cache from later in the pipeline can be used.

* Remove unused code

* Fix refresh map bit positions

* Make WB & inpaint opposed refresh less brittle

Co-authored-by: Hombre57 <natureh.510@gmail.com>

---------

Co-authored-by: Hombre57 <natureh.510@gmail.com>
 2023-08-15 07:52:38 -07:00
Stephen Shkardoon
23f2a2fc9f Use _WIN32 instead of WIN32 to detect Windows 
`WIN32` is not defined when building a 64-bit executable on Windows with Clang. `_WIN32` is the more appropriate option here.
http://web.archive.org/web/20191012035921/http://nadeausoftware.com/articles/2012/01/c_c_tip_how_use_compiler_predefined_macros_detect_operating_system contains a handy table/matrix of the options and why this is best.
 2023-08-13 17:09:49 +12:00
Lawrence37
9ae8c79c3a Merge pull request #6755 from Lawrence37/lensfun-db-preferences 
Edit Lensfun database directory from preferences
 2023-08-12 17:43:50 -07:00
Lawrence Lee
db4bfd8695 Add tooltips for LCP & Lensfun dir in preferences 2023-08-12 15:39:59 -07:00
Lawrence Lee
7eb7fb210f Merge branch 'dev' into metadata-exiv2 2023-08-12 15:08:42 -07:00
Lawrence37
bd94fbd6b6 Merge pull request #6808 from Lawrence37/places-ux 
Show favorite places at the top of the list
 2023-08-08 19:17:29 -07:00