Commit Graph

5176 Commits

Author SHA1 Message Date
Lawrence37
42817bffa4 Defringe tool banding & desaturation fix (#6934)
* Fix defringe banding & desaturation race condition

Use a copy of the image instead of the image itself for the source data.
Affects Defringe, Color Appearance & Lighting Hot/bad pixel filter, and
Contrast by Detail Levels Reduce artifacts.

* Fix CodeQL warning

Fix multiplication overflow.
2024-02-04 15:41:32 -08:00
Lawrence37
2f7c2e973c Fix rotation of images with odd number of rows (#6926)
* Fix line in middle of 180 degree rotated image

For images with an odd number of rows, a 180 degree rotation resulted in
one row of un-rotated pixels because it was effectively rotated twice.

* Replace verbose swap with std::swap
2024-02-04 15:40:38 -08:00
Lawrence37
0d0834cbe7 Dynamic Range Compression Improvement (5.10) (#6943)
* Improve Dynamic Range Compression - for some images with very high DR

* Clean code

* Improve TM fattal with saturation control in LA

* Saturation control fattal in LA

* Re-order paramsedit

* Change history_msg_tmo_satur with saturation

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-04 15:38:04 -08:00
Alexander Brock
e9bdda8727 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into defish 2024-02-04 18:01:33 +01:00
Desmis
5349f7a860 Improve Dynamic Range Compression - for some images with very high DR - Main and LA (#6931)
* Improve Dynamic Range Compression - for some images with very high DR

* Clean code

* Improve TM fattal with saturation control in LA

* Saturation control fattal in LA

* Re-order paramsedit

* Change history_msg_tmo_satur with saturation
2024-02-02 07:42:34 +01:00
Lawrence37
f06e756c20 AWB non-raw file fixes (for 5.10) (#6940)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: U-PCSPECIALIST01\jdesm <jdesmis@gmail.com>
2024-02-01 22:41:56 -08:00
Desmis
e4087e2fa2 White balance auto temperature correlation - improve behavior with non raw files (#6903)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2024-02-01 07:48:07 +01:00
Lawrence37
2c51b822a3 Merge pull request #6889 from Lawrence37/wprof-crash-fix
Fix for segfault due to wprof being null
2024-01-27 21:47:55 -08:00
Lawrence37
8f1f532fe6 Merge pull request #6878 from Lawrence37/switch-image-fix
Fix for crash when moving cursor over loading raw image
2024-01-27 21:47:15 -08:00
Lawrence37
4dd7517a55 Merge pull request #6873 from 0v3rt1r3d/0v3rt1r3d/fix-a-couple-of-warnings
Fix a couple of warnings
2024-01-27 21:46:14 -08:00
Lawrence37
9b7aef5d58 Merge pull request #6865 from CarVac/dev
Fix camconst.json white levels for 1DxII
2024-01-27 21:45:40 -08:00
Lawrence37
13bf7a1f0a Merge pull request #6857 from Lawrence37/camconst-from-art
Update camconst.json from ART
2024-01-27 15:52:54 -08:00
Lawrence37
7eb2aedbc1 Merge pull request #6927 from Lawrence37/panasonic-dc-g100-white-levels
Panasonic DC-G100 white levels
2024-01-25 21:04:19 -08:00
Lawrence37
5ffa0632f2 Merge pull request #6885 from Lawrence37/asan-mem-leak
Fixes for memory leaks and memcpy overlap found by AddressSanitizer
2024-01-25 21:02:50 -08:00
Lawrence37
ddcaa7a81c Merge pull request #6881 from Lawrence37/lensfun-vignette-fix
Fix focus distance from metadata
2024-01-25 21:01:17 -08:00
Lawrence Lee
2bc7cea5a1 Add white levels for Panasonic DC-G100
Reduce white levels for ISOs 1600-4000 due to noise with LENR on.
2024-01-14 12:58:05 -08:00
Alexander Brock
bbc8d0d4c7 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into defish 2024-01-14 20:30:32 +01:00
Lawrence Lee
67da8a9634 Implement Hasselblad flat-field and levels 2024-01-11 22:35:26 -08:00
Lawrence Lee
2b6789b4ac Fix Hasselblad model name when using LibRaw
The model, rather than the normalized model, gives the name that matches
those given by dcraw for Hasselblad cameras. This is important for
matching the model name in camconst.json.
2024-01-11 22:32:09 -08:00
Lawrence Lee
d13badbbe0 Implement DNG bad pixels constant for LibRaw
Works if the FixBadPixelsConstant is zero, as implemented for dcraw.
Other constant values may be implemented in the future.
2024-01-06 21:40:00 -08:00
Lawrence Lee
d96809ecab Copy missing camera constants from dcraw to LibRaw
Update white level for Fujifilm HS20EXR/HS22EXR and add constants for
Panasonic DMC-TZ82.
2024-01-06 21:40:00 -08:00
Lawrence Lee
ab21f77b95 Implement Sony Pixel Shift for LibRaw 2024-01-06 21:39:59 -08:00
Lawrence Lee
88f9978e1f Merge commit 'de5f92937857cccc45080c59c6236561416e5ece' into libraw-copylib
Upgrade LibRaw to 0.21.2.
2023-12-31 14:05:48 -08:00
Lawrence Lee
ebf5b422be Use proper include for LibRaw
The include directory for LibRaw is properly set by CMake so
    `#include <libraw/libraw.h>`
will work for both the internal and system versions.
2023-12-31 12:33:01 -08:00
Lawrence Lee
e599f71bf2 Remove unused rawimage functions
Prevent accidental use of these functions that will not supply the
correct data when using LibRaw.
2023-12-31 12:03:16 -08:00
Lawrence Lee
dca44bb89a Fix crash loading multi-frame RAFs with LibRaw
Set the frame number when reading image metadata.
2023-12-31 12:00:45 -08:00
Lawrence37
255a0c7086 Merge pull request #6906 from Lawrence37/fix-odd-raw-crop-raw-ca
Fix for wrong colors when the demosaic border is odd (dev)
2023-12-23 11:18:31 -08:00
Lawrence37
d0e36ee509 Merge pull request #6904 from Lawrence37/fix-odd-raw-crop-raw-ca
Fix for wrong colors when the demosaic border is odd
2023-12-23 11:14:37 -08:00
Lawrence37
85746a8093 Fix bad colors when demosaic border is odd
Colors are incorrect if the demosaic border is odd and raw chromatic
aberration is enabled.
2023-12-21 22:09:32 -08:00
Alexander Brock
1286fbacd6 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into defish 2023-12-18 17:44:24 +01:00
Lawrence Lee
2b7889b645 Add option to disable LibRaw in preferences 2023-12-17 16:00:30 -08:00
Lawrence Lee
f296991419 Implement DNG gain map for LibRaw 2023-12-17 16:00:30 -08:00
Desmis
31bf942d92 Local adjustments - Show additional settings - link with complexity (#6899)
* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds
2023-12-17 08:37:20 +01:00
Lawrence37
1839db448d Merge pull request #6793 from Lawrence37/nr-gain
Option for disabling noise reduction gain
2023-12-16 11:11:24 -08:00
Lawrence Lee
badbb9fbe2 Add checkbox for disabling NR gain
Option to disable noise reduction automatic gain for consistency between
photographs.
Fix automatic gain not being recalculated after changing the white level
correction.
2023-12-16 11:10:11 -08:00
U-PCSPECIALIST01\jdesm
339fdd9f04 Ftblockdn - remove unwanted messages in console 2023-12-12 22:15:09 -08:00
Desmis
f6aa9b86cb White Balance - temperature correlation in batch mode - issue #6867 (#6877)
* Change Itcwb in simpleprocess

* Change for auto RGBgrey

* remove unnecessary code
2023-12-12 22:15:08 -08:00
Lawrence Lee
d5ba3cf232 Fix crash in noise reduction
Fix upper bound for array access while building histogram of absolute
values in mean absolute deviation (MAD) calculation.

Fixes #6871.
2023-12-12 22:15:07 -08:00
Lawrence Lee
20d3311931 Add decoding through LibRaw
Decode raw files with LibRaw and fall back to dcraw if LibRaw is unable
to read the file.
2023-12-01 21:15:13 -08:00
Lawrence Lee
a95a58a8a3 Fix sRGB working profile crash
The sRGB working profile cannot be found under some conditions because
the profile name is stored as a Glib::ustring and the same strings may
not be equal when using different locales. Use std::string whenever
comparing profile names.
2023-11-19 17:22:43 -08:00
Alexander Brock
5cbf9bc560 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into defish 2023-11-20 00:06:25 +01:00
U-PCSPECIALIST01\jdesm
1e7cedf3cb Ftblockdn - remove unwanted messages in console 2023-11-17 09:38:46 +01:00
Lawrence Lee
3f5c3988e5 Merge commit '638ecc4cde79b0296f2e04f683ca4cb881c28f36' as 'rtengine/libraw' 2023-11-12 11:49:00 -08:00
Lawrence Lee
c5bb1f093e Fix issues found by AddressSanitizer
Fix memcpy overlap in TIFF reader.
Fix memory leaks of SpotRows in control spot panel.
Fix memory leaks of SpotRows in locallab.
Fix memory leak of Glib::ThreadPool in file browser entry.
Fix memory leak of Glib::ThreadPool in thumbnail image updater.
2023-11-11 16:56:34 -08:00
Lawrence Lee
f25659307c Calculate focus distance for Nikon Z cameras 2023-11-11 14:57:24 -08:00
Alberto Griggio
e5d389e271 metadata: fixed focus distance computation
A wrong focus distance calculation was affecting lensfun vignetting correction
2023-11-09 21:22:37 -08:00
Desmis
5acf1c0a7f White Balance - temperature correlation in batch mode - issue #6867 (#6877)
* Change Itcwb in simpleprocess

* Change for auto RGBgrey

* remove unnecessary code
2023-11-07 07:38:13 +01:00
Lawrence Lee
831a9bbd55 Fix crash when opening image in editor
Do not access uninitialized raw image data. The raw data is requested
when the demosaic mode is set to None and the cursor is moved over the
image in the editor. It can occur before the raw data is loaded.
2023-11-03 21:48:21 -07:00
Alexander Brock
10ff073b62 Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into defish 2023-10-30 15:17:20 +01:00
Alexander Gruzintsev
de82b9fc7a Fix warnings: conversion to double/float, unused variables, register keyword 2023-10-30 08:18:33 +01:00