Commit Graph

4176 Commits

Author SHA1 Message Date
Lawrence Lee
8accebe416 Fix incorrect sampled L*a*b* values
Use LCMS to convert values back into L*a*b*. The pipette buffer has the
output or working profile applied with LCMS. Performing the inverse
operation fixes the incorrect values shown in the navigator, histogram
indicator bars, and lockable color pickers.
2023-05-28 18:15:27 -07:00
Hubert Figuière
a1bbc93538 Fix missing explicit include (#6704)
* Fix missing explicit include

- Also avoid rtgui include

* Fix more missing explicit include
2023-05-21 15:25:42 -07:00
Lawrence Lee
c557b320c2 Refresh cached image data if sidecar is changed 2023-05-14 18:18:27 -07:00
Alexander Brock
e1a3fe0656 Change default scale to 1 2023-05-02 00:49:37 +02:00
Pandagrapher
3120aea7dd Improves cursor hotspot location management 2023-05-01 11:18:07 +02:00
Lawrence Lee
45a3b36b3a Fix file chooser entry not updating
Save file name while it is typed in the text entry.

Add placeholder text for Lensfun database directory to indicate
automatic detection if left blank.
2023-04-30 12:30:46 -07:00
Lawrence Lee
f5dba61243 Allow Lensfun DB dir editing from preferences
Also refactor the file chooser button widget to share code with the file
chooser entry. Use our own folder icon instead of the system one.
2023-04-29 18:43:38 -07:00
Pandagrapher
f7c25b18af Merge with 'Beep6581/dev' 2023-04-29 11:24:55 +02:00
Pandagrapher
23be310029 Fixes issues following merge with 'dev'
- External Editor: App icon not correctly managed in RTImage
- Favorite preferences: Fixes widget sizes
- Other fix: With some versions of Glib/Glibmm library on MacOS, Glib::KeyFile "load_from_file" function does not raise a Glib::Error but another exception. This causes crash opening preferences panel due to missing dynamic profiles configuration
2023-04-29 11:06:58 +02:00
Alexander Brock
2ad61ba4bb Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into defish 2023-04-28 10:24:13 +02:00
Lawrence Lee
1f8e2aaf55 Merge branch 'dev' into metadata-exiv2 2023-04-19 21:14:54 -07:00
Lawrence Lee
1eb58255ce Merge branch 'dev' into tone-equalizer 2023-04-15 16:58:52 -07:00
Lawrence Lee
c4245b5106 Merge branch 'dev' into metadata-exiv2 2023-04-09 17:10:54 -07:00
Lawrence Lee
186995acf4 Improve code quality for external editor settings 2023-04-09 13:52:09 -07:00
Lawrence Lee
19f12f3182 Allow native commands as external editors
If an editor is marked as a native command, it is launched using the
older method (native for Windows or Glib otherwise). Non-native commands
are launched with Gio. When reading preferences containing the old style
external editor settings, all commands are marked as native to avoid
breaking them.

Fix bug where the send to editor button shows the wrong editor. The bug
happens when the other editor option is selected while the user edits
the external editors in preferences. When saved, the button shows the
first option is selected instead of the other editor option (the last
entry).
2023-04-08 18:16:23 -07:00
Lawrence37
f018d1fec0 Merge pull request #6536 from Bezierr/ha-profilepath-dev
Relative pathnames to .dcp and .lcp files in .pp3 for interchangeability between Windows and Linux
2023-04-03 18:38:58 -07:00
Alexander Brock
79bef50a8e Merge branch 'dev' of https://github.com/Beep6581/RawTherapee into defish 2023-03-29 13:20:28 +02:00
Lawrence Lee
0729deec4b Merge branch 'dev' into metadata-exiv2 2023-03-22 23:01:40 -07:00
Alexander Brock
f9e2e934df Move de-fish to distortion 2023-03-22 00:19:26 +01:00
Desmis
5481a8bbe1 Ciecam - Fixed issue #6713 and add some batch functions (#6717)
* Try to solve issue 6713 ans add some batch functions

* Missing setAddMode tempout
2023-03-20 07:38:48 +01:00
Desmis
69c1caafa1 Whitebalance - Removed GUI Itcwb from whitebalance and preferences (#6710)
* Change Preferences for observer whitebalance

* Change label white balance preferences

* Added Preferences 2 parameters Whitebalance auto correlation

* Add Preference Temperature correlation - sort and tooltip

* Change to rtengine cmakelist

* Apply patch from Lawrence37

* Small comment code

* Change defaut order prefrences wba

* Added force extra algoritm to Preferences

* Harmonize itcwb sorted

* Add fields to Preferences Itcwb

* Change settings precision Itcwb in Preferences

* Change tooltip Itcwb preferences

* First stage Itwcwb settings in main with pp3 and selction in preferences

* Second stage Itwcwb settings in main with pp3 and selction in preferences

* Third stage Itwcwb settings in main with pp3 and selction in preferences

* Add itcwb_fgreen student - green optimize

* Add Itcwb green range

* Itcwb history msg - first tooltips

* Remove force-extra because always used

* reused force-extra to use entire CIExy for sampling datas

* Removed inwanted text in console

* Set sensitive for Itcwbframe

* Various change - comment ..

* Small code review - chnage tooltips

* Remove settings itcwb_delta in Rawimagesource.cc to simplify

* Remove Itcwb Observer - put a single observer for everything - general - itcwb

* Fixed conflicts in colortemp.cc

* Various change - fixed bug - simplify

* Fixed limits for settings pp3 - chnage tooltip

* Clean unused code

* Put itcwb_findgreen in GUI

* Added checkbox 'Low sampling' to find the settings of 5.9

* Set Observer to Observer 10° - preferences default

* Missing setting Low sampling

* Show white balance multipliers

* Change default settings - Itcwb_sorted

* Move observer from preferences to WB

* Make observer selectable for camera WB

* Ensure observer checkbox is in sync with PP3

* Set default ITCWB low sampling for PP3s from <=5.9

Ensure temperature correlation white balance algorithm 1 is used when
opening edits from versions 5.9 and earlier.

* Removed unused White-balance frame in Preferences

* Comment some GUI sliders checkbox

* Removed all GUI itcwb in preferences and whitebalance

* Removed forgotten code in preferences

* Remove labels tooltips history Itcwb

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2023-03-19 07:47:58 +01:00
Lawrence Lee
20e78068cd Merge branch 'dev' into metadata-exiv2 2023-03-17 22:16:17 -07:00
Pandagrapher
2338b8f366 Merge with "Beep6581/dev" 2 2023-03-11 11:03:19 +01:00
Pandagrapher
c28d5aab97 Merge with "Beep6581/dev" 2023-03-11 11:02:29 +01:00
Flössie
8f6d4f31c5 Consistently use Gtk::manage() in SaveFormatPanel 2023-03-02 09:17:01 +01:00
Flössie
a07c38f405 Support for saving TIFFs as BigTIFF (#6690) 2023-03-01 12:47:55 +01:00
abrock
37cc311a46 Remove ipers_rotate_left/right in constructor call of adjuster for camera_scale
Co-authored-by: Lawrence37 <45837045+Lawrence37@users.noreply.github.com>
2023-02-25 21:25:17 +01:00
Alexander Brock
e0b72af60e Style fix 2023-02-22 13:52:46 +01:00
Alexander Brock
2e66dc11a2 Style changes as requested 2023-02-22 10:52:42 +01:00
Alexander Brock
2a92257438 Add HISTORY_MSG_PERSP_CAM_SCALE to default language file 2023-02-19 23:40:58 +01:00
Alexander Brock
66698d515c Change detection of scale factor 2023-02-19 20:11:34 +01:00
Alexander Brock
0089520277 Add appendBehavList(mi, M("TP_PERSPECTIVE_CAMERA_DEFISH"), ADDSET_PERSP_CAM_DEFISH, false); hoping it would fix the label issue, it doesn't. 2023-02-18 00:51:48 +01:00
Alexander Brock
6c43f10c30 Fix bug: Defish checkbox value wasn't correctly loaded 2023-02-18 00:50:25 +01:00
Lawrence Lee
e3c7fd42e9 Merge branch 'dev' into metadata-exiv2 2023-02-15 22:28:18 -08:00
Lawrence Lee
cac76c18c0 Re-introduce UTF-8 validation for EXIF panel 2023-02-12 17:47:07 -08:00
Alexander Brock
f023a90170 Add camera_defish to PerspCorrection::read/write 2023-02-11 23:51:32 +01:00
Alexander Brock
fb90908cbd Add GUI elements for defish and scale in perspective tool. Doesn't work very good yet. 2023-02-11 20:31:08 +01:00
Desmis
e5d46032ff Add "Inpaint opposed" to Highlight reconstruction and improved Itcwb (#6635)
* Essai HL

* Try Inpaint opposed

* Code improvment

* Add file

* Improvment to process inpaint opposed  and color propagation

* Clean code

* Change Blend to Coloropp in Profile pp3

* Enable BENCHFUN hilite_recon

* Clean rtengine cmakelist

* Comment unused code

* Neutralise unused code

* Change bad Exposure in Pop2Lab.pp3

* Try to fix bug when Inpaint Opposed is used and White balance disabled

* Changes to refreshmap

* Change to improccoordinator M_RETINEX

* Clean unused commented code

* Force Inpaint-opposed in rawimagesouce if wb change

* Suppressed message in console

* Change events and limits to 1 the number of calls to inpaint-opposed

* Comment code

* Add gain theshold to inpaint opposed

* fixed typo in procparams.cc

* Change in option.cc itcwb_sort to true

* Change itcw sorted in options and rawimagesource.cc

* Change sampling read datas Itcwb

* Allow or not purple in WB itcwb

* Added option icwb.nopurple to bypass settings

* Added code comment Itcwb

* optimize Itcwb between green and student

* Formated code used by Itcwb with Astylert.bat

* Change color_match - thanks to Lawrence37

* Remove wrong text
2023-02-09 07:14:20 +01:00
Lawrence Lee
12ef477a6d Fix merge issues
Adapt tone equalizer to favorites tab changes.
2023-02-06 21:44:57 -08:00
Lawrence Lee
f236a7edb7 Merge branch 'dev' into tone-equalizer 2023-02-05 18:39:23 -08:00
Lawrence Lee
3833c6e634 Merge branch 'dev' into metadata-exiv2 2023-02-05 12:29:58 -08:00
Lawrence Lee
2982f02328 Merge branch 'dev' into favorites-gui 2023-02-03 21:58:34 -08:00
Desmis
9a245c1acb Avoid Color shift - Gamut and Munsell Review in RT - branch Munsellgamut (#6673)
* Fixed numerous problems with gamut and Munsell in Local adjustments

* change gamut-munsell in lab adjustmnts - gamut in ciecam

* Improve XYZ colorimetry and tooltip

* Change event - format code - change labels tooltips

* Removed avoid_ and avoidmun_

* Removed avoidcolorshift in labcurve

* Push change proposed by Lawrence37 - compatibility with old pp3
2023-01-31 12:32:31 +01:00
Lawrence37
ef7676826e Merge pull request #6661 from Beep6581/external-editor-fixes
External editor fixes for Windows
2023-01-26 21:37:14 -08:00
Desmis
7afdfc1e2b Abstract profile - Gamut improvment (#6665)
* Gamut control when the chosen primaries are different from working profile

* Gamut control abstract

* Gamut label and history

* Change to Wx Wz

* Fixed crash if y primaries are set to zero

* Fomated with Astylert ImProcFunctions::workingtrc and Color::primaries_to_xyz

* Fixed black becomes green wit gamt abstract profile

* Harmonize types in color.cc

* Try to fix Multiplication result converted to larger type
2023-01-24 14:29:50 +01:00
Lawrence Lee
22edf5f069 Add radio indicator to external editor selector
Make it easier to see that the selector is for changing the current
editor and not for immediately sending the image to the clicked-on
editor.
2023-01-15 15:10:54 -08:00
Lawrence Lee
194ef397a6 Fix external editor file chooser filter (Windows)
Look for files with the MIME type "application/x-msdownload", which are
Windows executable files. The Gio function for determining if a file is
executable does not work for Windows.
2023-01-08 22:17:21 -08:00
Lawrence Lee
5468e74e57 Fall back to custom external editor launcher 2023-01-08 17:20:42 -08:00
Desmis
21afbaf90b CIECAM - Changes such as symmetric works and temperature output makes sense - issue #6656 (#6658)
* changes such as symmetric works and temperature output makes sense

* Comment code

* other Comment code and small change

* Change tint in tooltip temperature

* Improve GUI for tempout and greenout
2023-01-06 06:43:21 +01:00
Desmis
95cede9a1a Color Appearance and lighting : Remove cat02preset and all dependencies issue 5664 (#6585)
* Remove cat02preset and all dependencies issue 5664

* Normalize cmakelist
2023-01-03 07:44:46 +01:00