Commit Graph

5026 Commits

Author SHA1 Message Date
Desmis
e4087e2fa2 White balance auto temperature correlation - improve behavior with non raw files (#6903)
* Improve Itcwb with non-raw files

* Change pre-dev builds wbrefinement

* Change template in pre-dev

* Improvment improccordinator.cc

* Forgotten observer convert

* Reenable wbauto autogrey as 5.8

* Remove wrong code

* Missing getrgbloc references

* Fixed bug due to bias in queu with temperaure correlation issue 6911

* Simpleprocess queue compatibility tif-jpg

* Preserve AWB edits from 5.9

In 5.9 for non-raw files,
   1. RGB grey uses the unit multipliers with temperature bias applied.
   2. Temperature correlation uses the equivalent of temperature 5000,
      green 1, and red/blue equalizer 1.

* Refactor temperature correlation AWB code

* Fix inaccurate RGB grey WB preview after using ITC

The RGB grey automatic white balance algorithm caches the multipliers.
Temperature correlation automatic white balance also caches results to
the same location, but never uses it. This causes the RGB grey method to
produce incorrect results in the editor. Removing the temperature
correlation cache fixes the issue and does not have side-effects.

---------

Co-authored-by: Lawrence Lee <45837045+Lawrence37@users.noreply.github.com>
2024-02-01 07:48:07 +01:00
Lawrence37
2c51b822a3 Merge pull request #6889 from Lawrence37/wprof-crash-fix
Fix for segfault due to wprof being null
2024-01-27 21:47:55 -08:00
Lawrence37
8f1f532fe6 Merge pull request #6878 from Lawrence37/switch-image-fix
Fix for crash when moving cursor over loading raw image
2024-01-27 21:47:15 -08:00
Lawrence37
4dd7517a55 Merge pull request #6873 from 0v3rt1r3d/0v3rt1r3d/fix-a-couple-of-warnings
Fix a couple of warnings
2024-01-27 21:46:14 -08:00
Lawrence37
9b7aef5d58 Merge pull request #6865 from CarVac/dev
Fix camconst.json white levels for 1DxII
2024-01-27 21:45:40 -08:00
Lawrence37
13bf7a1f0a Merge pull request #6857 from Lawrence37/camconst-from-art
Update camconst.json from ART
2024-01-27 15:52:54 -08:00
Lawrence37
7eb2aedbc1 Merge pull request #6927 from Lawrence37/panasonic-dc-g100-white-levels
Panasonic DC-G100 white levels
2024-01-25 21:04:19 -08:00
Lawrence37
5ffa0632f2 Merge pull request #6885 from Lawrence37/asan-mem-leak
Fixes for memory leaks and memcpy overlap found by AddressSanitizer
2024-01-25 21:02:50 -08:00
Lawrence37
ddcaa7a81c Merge pull request #6881 from Lawrence37/lensfun-vignette-fix
Fix focus distance from metadata
2024-01-25 21:01:17 -08:00
Lawrence Lee
2bc7cea5a1 Add white levels for Panasonic DC-G100
Reduce white levels for ISOs 1600-4000 due to noise with LENR on.
2024-01-14 12:58:05 -08:00
Lawrence37
255a0c7086 Merge pull request #6906 from Lawrence37/fix-odd-raw-crop-raw-ca
Fix for wrong colors when the demosaic border is odd (dev)
2023-12-23 11:18:31 -08:00
Lawrence37
d0e36ee509 Merge pull request #6904 from Lawrence37/fix-odd-raw-crop-raw-ca
Fix for wrong colors when the demosaic border is odd
2023-12-23 11:14:37 -08:00
Lawrence37
85746a8093 Fix bad colors when demosaic border is odd
Colors are incorrect if the demosaic border is odd and raw chromatic
aberration is enabled.
2023-12-21 22:09:32 -08:00
Desmis
31bf942d92 Local adjustments - Show additional settings - link with complexity (#6899)
* Change hishow -additional seeting - with complexity

* Modify windows.yml and appimage.yml

* Fixed bug in duplicate spot

* Remove pre-dev builds
2023-12-17 08:37:20 +01:00
Lawrence37
1839db448d Merge pull request #6793 from Lawrence37/nr-gain
Option for disabling noise reduction gain
2023-12-16 11:11:24 -08:00
Lawrence Lee
badbb9fbe2 Add checkbox for disabling NR gain
Option to disable noise reduction automatic gain for consistency between
photographs.
Fix automatic gain not being recalculated after changing the white level
correction.
2023-12-16 11:10:11 -08:00
U-PCSPECIALIST01\jdesm
339fdd9f04 Ftblockdn - remove unwanted messages in console 2023-12-12 22:15:09 -08:00
Desmis
f6aa9b86cb White Balance - temperature correlation in batch mode - issue #6867 (#6877)
* Change Itcwb in simpleprocess

* Change for auto RGBgrey

* remove unnecessary code
2023-12-12 22:15:08 -08:00
Lawrence Lee
d5ba3cf232 Fix crash in noise reduction
Fix upper bound for array access while building histogram of absolute
values in mean absolute deviation (MAD) calculation.

Fixes #6871.
2023-12-12 22:15:07 -08:00
Lawrence Lee
a95a58a8a3 Fix sRGB working profile crash
The sRGB working profile cannot be found under some conditions because
the profile name is stored as a Glib::ustring and the same strings may
not be equal when using different locales. Use std::string whenever
comparing profile names.
2023-11-19 17:22:43 -08:00
U-PCSPECIALIST01\jdesm
1e7cedf3cb Ftblockdn - remove unwanted messages in console 2023-11-17 09:38:46 +01:00
Lawrence Lee
c5bb1f093e Fix issues found by AddressSanitizer
Fix memcpy overlap in TIFF reader.
Fix memory leaks of SpotRows in control spot panel.
Fix memory leaks of SpotRows in locallab.
Fix memory leak of Glib::ThreadPool in file browser entry.
Fix memory leak of Glib::ThreadPool in thumbnail image updater.
2023-11-11 16:56:34 -08:00
Lawrence Lee
f25659307c Calculate focus distance for Nikon Z cameras 2023-11-11 14:57:24 -08:00
Alberto Griggio
e5d389e271 metadata: fixed focus distance computation
A wrong focus distance calculation was affecting lensfun vignetting correction
2023-11-09 21:22:37 -08:00
Desmis
5acf1c0a7f White Balance - temperature correlation in batch mode - issue #6867 (#6877)
* Change Itcwb in simpleprocess

* Change for auto RGBgrey

* remove unnecessary code
2023-11-07 07:38:13 +01:00
Lawrence Lee
831a9bbd55 Fix crash when opening image in editor
Do not access uninitialized raw image data. The raw data is requested
when the demosaic mode is set to None and the cursor is moved over the
image in the editor. It can occur before the raw data is loaded.
2023-11-03 21:48:21 -07:00
Alexander Gruzintsev
de82b9fc7a Fix warnings: conversion to double/float, unused variables, register keyword 2023-10-30 08:18:33 +01:00
Lawrence Lee
0e835e8c00 Fix crash in noise reduction
Fix upper bound for array access while building histogram of absolute
values in mean absolute deviation (MAD) calculation.

Fixes #6871.
2023-10-29 16:20:12 -07:00
Pandagrapher
3eb73fb225 Merge with 'Beep6581/dev' 2023-10-20 13:16:03 +02:00
Lawrence Lee
1efa06e887 Fix Lensfun camera mismatch
Work around a Lensfun bug that finds the wrong camera when given an
exact name of certain cameras.
2023-10-14 21:18:04 -07:00
CarVac
29748d057a Update camconst.json white levels for 1DxII 2023-10-14 15:22:08 -04:00
Pandagrapher
488a157476 Fixing review comments 2023-10-13 11:12:37 +02:00
Desmis
d276a56b10 Local adjustments - improvment Dehaze with black (#6860)
* Local Dehaze black

* Enable black

* Change threshold black - publish_pre_dev_labels ladehazeblack
2023-10-12 06:59:33 +02:00
Lawrence37
ab8de06c66 Merge branch 'dev' into nr-gain 2023-10-10 21:03:03 -07:00
Lawrence Lee
1ecbd73a4a Update camconst.json from ART
Add color matrix for Canon EOS Rebel SL3 (250D / Kiss X10).
Add masked areas for Canon EOS M6 Mark II and 90D.
Include Canon PowerShot G9 X for values for G5 X and G7 X Mark II.
Add black level for LEICA D-LUX 7.
Include PANASONIC DC-GX880 for values for DC-GF10.
2023-09-24 16:37:29 -07:00
Pandagrapher
0c2d7c1382 Merge with 'Beep6581/dev' 2023-09-22 20:36:03 +02:00
Flössie
dcbc0327a1 Fix UB in ProcParams::load() and the resulting Clang 15+ miscompilation
Fixes #6847.
2023-09-17 15:14:11 -07:00
Lawrence Lee
dab9a3f57e Fix automatic distortion correction crash
Closes #6840.
2023-09-17 15:14:03 -07:00
Flössie
2a87c65a14 Fix UB in ProcParams::load() and the resulting Clang 15+ miscompilation
Fixes #6847.
2023-09-15 15:24:24 +02:00
Battyányi Dániel
d0b34a3234 Fixed crop mode checking
Me make dumb mistake in prev. commit sry.
2023-09-12 18:19:51 +02:00
Battyányi Dániel
1a0b7f4562 Replaced casting with != 2023-09-12 14:01:35 +02:00
Battyányi Dániel
b4daf36349 CropMode changed from "plain enum" to "enum class" 2023-09-12 10:39:50 +02:00
Battyányi Dániel
0fe4c18752 Semantic changes 2023-09-12 10:33:04 +02:00
Battyányi Dániel
f09612453a Metadata no longer overwrites camconsts
Added suggested changes to camconst and removed the camconst.json overwriting part as per the review comment
2023-09-12 00:07:43 +02:00
Battyányi Dániel
ab6d5b190c Tags in numerical order inside parse_fuji()
As suggested by review comment
2023-09-11 23:18:57 +02:00
Battyányi Dániel
6ee6a46750 Width and height only updates to cropped version after detecting crop
As suggested by review comment
2023-09-11 23:11:38 +02:00
Battyányi Dániel
3806107315 Changed crop detection mechanism according to code review comment
Changed the crop detection to use the CropMode Fujifilm tag from the makernotes instead of an arbitrary threshold.
2023-09-11 22:58:24 +02:00
Battyányi Dániel
ea86a14dff removed unecessarily setting of raw_height and raw_width 2023-09-11 22:22:37 +02:00
Lawrence Lee
97e181bd58 Fix automatic distortion correction crash
Closes #6840.
2023-09-09 14:59:14 -07:00
Pandagrapher
735958fc0d Merge with 'Beep6581/dev' 2023-09-08 17:58:50 +02:00