17 Commits

Author SHA1 Message Date
Lawrence Lee
f958074d9b Fix crash when deleting spot removal spot
Deleting a spot while hovering over one of the circles for adjusting the
radius or feathering could trigger a crash. This is because immediately
after deleting a geometry object, EditSubscriber::getCursor is given an
object ID based on old data, causing the spot tool to attempt to get
information about the deleted geometry object.

This commit fixes the issue by returning the default cursor if the
active spot is -1. It works because the active spot is set to -1 when
deleting a spot, and there is no need to use a special cursor when there
is no active spot.

A better long-term solution would be updating the geometry data before
calling EditSubscriber::getCursor.
2021-03-07 11:58:36 -08:00
Lawrence Lee
10b5f65b30 Fix spot removal enable/disable history message
The history panel was showing "HISTORY_MSG_1049".
2021-03-06 21:29:56 -08:00
Hombre57
8b60ea4794 Bugfix in SpotRemoval tool GUI (Batch Editor) + Partial Paste handling 2019-12-17 21:46:18 +01:00
Hombre
1935820884 Fix crash in Spot Removal tool when deleting a Spot entry 2019-09-14 23:03:19 +02:00
Hombre
82e7caa635 Spot removal : differentiating source/dest, betted cursor handling
+ some code cleanup from floessie (see issue #2239)
2019-09-01 02:08:48 +02:00
Hombre
0d19cd40a6 Adding documentation of Spot Removal in a tooltip
(see issue #2239)
2019-08-16 02:46:55 +02:00
Hombre
68e26fb648 More bugfix for issue #2239 2019-08-15 20:23:29 +02:00
Hombre
a46b85f226 Fix crash reported in #2239 + suppress warning from header files
Crash reported here
https://github.com/Beep6581/RawTherapee/issues/2239#issuecomment-521585237
2019-08-15 19:01:30 +02:00
Hombre
4d4f54cbc2 Spot-Removal (#2239): Adding recusivity and border handling
Warning: Debug builds will be slow due to the amount of debug output (no problem for Release builds). Code cleanup will be done when after testing phase.
2019-08-14 15:52:22 +02:00
Hombre
0db64d49a2 Introducing TweakOperator, for better tool's special mode handling 2019-08-06 02:04:48 +02:00
Hombre
7d310e688c Adding a new spot adjust editing mode in rtengine / preview window 2019-08-04 16:07:35 +02:00
Hombre
5b136d664d Merge branch 'dev' into spot-removal-tool 2019-03-25 22:35:17 +01:00
Hombre
e0c04955e3 Fix build crash (see #5232), but this branch is still not usable 2019-03-19 22:29:10 +01:00
Hombre
698492e21c Merge branch 'dev' into spot-removal-tool 2019-03-18 22:35:11 +01:00
Hombre57
81932ba2d6 Some files 'astylized' + slight cleanup 2017-08-22 00:15:56 +02:00
Hombre
3eeeb151ec Merge branch 'master' into spot-removal-tool 2016-12-28 01:57:46 +01:00
Hombre
56dafcf8c1 Spot Removal tool
It is not working yet, but the GUI is (almost) done.
See issue #2239.
2016-04-23 00:46:01 +02:00