liz/wikijs-fork
liz/wikijs-fork
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove excess div wrappers (#4528)

Browse Source 
* Removing superfluous div wrapping

It seems like standalone text is already wrapped in paragraph elements, so this code seems superfluous. Additionally, it adds div wrappers at every line break as described in #4524

* Fix for newlines and returns

This change skips newlines and returns to focus on unbounded text only.

* misc: fix indentation

* misc: fix indentation (2)

Co-authored-by: Nicolas Giard <github@ngpixel.com>
This commit is contained in:
broxen 2021-10-09 11:09:54 -07:00 committed by GitHub
parent 525f758151
commit 12aef93cd6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/modules/rendering/html-core/renderer.js
View File

@ -234,11 +234,11 @@ module.exports = {
}) })
// -------------------------------- // --------------------------------
// Wrap root text nodes // Wrap non-empty root text nodes
// -------------------------------- // --------------------------------
$('body').contents().toArray().forEach(item => { $('body').contents().toArray().forEach(item => {
if (item && item.type === 'text' && item.parent.name === 'body') { if (item && item.type === 'text' && item.parent.name === 'body' && item.data !== `\n` && item.data !== `\r`) {
$(item).wrap('<div></div>') $(item).wrap('<div></div>')
} }
}) })