liz/wikijs-fork
liz/wikijs-fork
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: prevent empty page content

Browse Source
This commit is contained in:
Nick 2019-08-26 23:19:39 -04:00
parent 518602b0d4
commit 1d8f1f50e1
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/helpers/error.js
View File

@ -125,6 +125,10 @@ module.exports = {
message: 'Cannot create this page because an entry already exists at the same path.', message: 'Cannot create this page because an entry already exists at the same path.',
code: 6002 code: 6002
}), }),
PageEmptyContent: CustomError('PageEmptyContent', {
message: 'Page content cannot be empty.',
code: 6004
}),
PageNotFound: CustomError('PageNotFound', { PageNotFound: CustomError('PageNotFound', {
message: 'This page does not exist.', message: 'This page does not exist.',
code: 6003 code: 6003

9
server/models/pages.js
View File

@ -182,6 +182,10 @@ module.exports = class Page extends Model {
throw new WIKI.Error.PageDuplicateCreate() throw new WIKI.Error.PageDuplicateCreate()
} }
if (!opts.content || _.trim(opts.content).length < 1) {
throw new WIKI.Error.PageEmptyContent()
}
await WIKI.models.pages.query().insert({ await WIKI.models.pages.query().insert({
authorId: opts.authorId, authorId: opts.authorId,
content: opts.content, content: opts.content,
@ -230,6 +234,11 @@ module.exports = class Page extends Model {
if (!ogPage) { if (!ogPage) {
throw new Error('Invalid Page Id') throw new Error('Invalid Page Id')
} }
if (!opts.content || _.trim(opts.content).length < 1) {
throw new WIKI.Error.PageEmptyContent()
}
await WIKI.models.pageHistory.addVersion({ await WIKI.models.pageHistory.addVersion({
...ogPage, ...ogPage,
isPublished: ogPage.isPublished === true || ogPage.isPublished === 1, isPublished: ogPage.isPublished === true || ogPage.isPublished === 1,