liz/wikijs-fork
liz/wikijs-fork
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(auth): SAML authnContext parameter should be an array (#5290)

Browse Source 
* saml auth: `authnContext` must be a list now

This fixes

    this.options.authnContext.forEach is not a function

when trying to login via SAML on wiki-js 2.5.281.

Reason for that is that `authnContext` must be a list now which is
apparently a breaking change that was missed while upgrading
passport-saml[1].

Resolves #5289

[1] https://github.com/node-saml/passport-saml/pull/615

* fix(auth): split authnContext for SAML authenticaiton module

Co-authored-by: Nicolas Giard <github@ngpixel.com>
This commit is contained in:
Maximilian Bosch 2022-05-15 03:17:17 +02:00 committed by GitHub
parent 9b40d60261
commit b345375477
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/modules/authentication/saml/authentication.js
View File

@ -21,7 +21,7 @@ module.exports = {
wantAssertionsSigned: conf.wantAssertionsSigned, wantAssertionsSigned: conf.wantAssertionsSigned,
acceptedClockSkewMs: _.toSafeInteger(conf.acceptedClockSkewMs), acceptedClockSkewMs: _.toSafeInteger(conf.acceptedClockSkewMs),
disableRequestedAuthnContext: conf.disableRequestedAuthnContext, disableRequestedAuthnContext: conf.disableRequestedAuthnContext,
authnContext: conf.authnContext, authnContext: _.split(conf.authnContext, '|'),
racComparison: conf.racComparison, racComparison: conf.racComparison,
forceAuthn: conf.forceAuthn, forceAuthn: conf.forceAuthn,
passive: conf.passive, passive: conf.passive,