liz/PluralKit
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly tag request logs in metrics

Browse Source
This commit is contained in:
Ske
2020-08-27 16:26:37 +02:00
parent e556cc71fa
commit e27826955e
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
PluralKit.Bot/Tracing/DiscordRequestObserver.cs
View File

@@ -56,6 +56,9 @@ namespace PluralKit.Bot
if (response.RequestMessage.RequestUri.Host != "discord.com")
return;
var routePath = NormalizeRoutePath(response.RequestMessage.RequestUri.LocalPath.Replace("/api/v7", ""));
var route = $"{response.RequestMessage.Method} {routePath}";
using (LogContext.PushProperty("Elastic", "yes?"))
{
if ((int) response.StatusCode >= 400 && (int) response.StatusCode < 500)
@@ -64,8 +67,6 @@ namespace PluralKit.Bot
LogContext.PushProperty("ResponseBody", content);
}
var routePath = NormalizeRoutePath(response.RequestMessage.RequestUri.LocalPath.Replace("/api/v7", ""));
var route = $"{response.RequestMessage.Method} {routePath}";
LogContext.PushProperty("RequestUrlRoute", route);
_logger.Information(
@@ -77,8 +78,11 @@ namespace PluralKit.Bot
activity.Duration.TotalMilliseconds);
}
var timer = _metrics.Provider.Timer.Instance(BotMetrics.DiscordApiRequests);
timer.Record(activity.Duration.Ticks / 10, TimeUnit.Microseconds, ((int) response.StatusCode).ToString());
var timer = _metrics.Provider.Timer.Instance(BotMetrics.DiscordApiRequests, new MetricTags(
new[] {"endpoint", "status_code"},
new[] {route, ((int) response.StatusCode).ToString()}
));
timer.Record(activity.Duration.Ticks / 10, TimeUnit.Microseconds);
}
public void OnNext(KeyValuePair<string, object> value)